summaryrefslogtreecommitdiffstats
path: root/basctl
Commit message (Collapse)AuthorAgeFilesLines
* Fix typosAndrea Gelmini2018-01-161-1/+1
| | | | | | | Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a Reviewed-on: https://gerrit.libreoffice.org/47855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2018-01-151-1/+1
| | | | | | | Change-Id: I51c97356c9c2939f2d94d6388c829a179ca00daa Reviewed-on: https://gerrit.libreoffice.org/47853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* More loplugin:cstylecast: basctlStephan Bergmann2018-01-1213-36/+36
| | | | | | | | auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I3bddf4b08e064dead05eae87619db2232744d7f8
* convert (a>b?a:b) to std::max(a,b)Noel Grandin2018-01-111-1/+1
| | | | | | | | | | with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Resolves: tdf#114766 gtk3 solar mutex assertCaolán McNamara2018-01-081-6/+8
| | | | | | | | | | | | | | | | since commit 33de587e95dddfc8e3c89b84f90b3d1bca823dae Date: Tue Mar 17 12:56:54 2015 +0530 tdf#88230: cleanup solar mutex yielding Use SolarMutexReleaser, instead. Change-Id: Ied2c78f95592c87b7908d14e9ab6c78e62f987e7 Reviewed-on: https://gerrit.libreoffice.org/47590 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* lokdialog: Allow language switching in SfxModule(s).Jan Holesovsky2018-01-052-5/+3
| | | | | | | Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b Reviewed-on: https://gerrit.libreoffice.org/47385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* remove SfxUsrAnyItem typedefNoel Grandin2018-01-044-6/+6
| | | | | | | | | | and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made by leaving the most popular one behind Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f Reviewed-on: https://gerrit.libreoffice.org/47313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Translate German commentJohnny_M2018-01-031-1/+1
| | | | | | | Change-Id: Id65ccfe3b2394c8c30d3531316b70b511e34e366 Reviewed-on: https://gerrit.libreoffice.org/47131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:passstuffbyref more return improvementsNoel Grandin2018-01-031-2/+2
| | | | | | | | | slightly less restrictive check when calling functions Change-Id: I35e268ac611797b1daa83777cda02288a635aa32 Reviewed-on: https://gerrit.libreoffice.org/47259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:passstuffbyref improved return in variousNoel Grandin2017-12-293-6/+6
| | | | | | | Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560 Reviewed-on: https://gerrit.libreoffice.org/47173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall fix functionsNoel Grandin2017-12-113-3/+3
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#63154 removed some solar.h referencesekuiitr2017-12-111-1/+0
| | | | | | | | Change-Id: Ib3672f84acc54d5838ab7ccf02d368968aa8b5af Reviewed-on: https://gerrit.libreoffice.org/46029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* loplugin:countusersofdefaultparams in basctl..basegfxNoel Grandin2017-12-073-3/+3
| | | | | | | Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241 Reviewed-on: https://gerrit.libreoffice.org/45957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall fix non-virtual methodsNoel Grandin2017-12-052-11/+11
| | | | | | | | | first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryparen check for (f1()).f2Noel Grandin2017-11-271-3/+3
| | | | | | | Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:simplifybool for negation of comparison operatorNoel Grandin2017-11-231-1/+1
| | | | | | | Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop duplicate methodCaolán McNamara2017-11-221-1/+1
| | | | | | | Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* coverity warningsCaolán McNamara2017-11-211-1/+2
| | | | | | | | Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1 Reviewed-on: https://gerrit.libreoffice.org/45023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* renameModuleOrDialog: add missing check for valid Referencetagezi2017-11-201-1/+1
| | | | | | | Change-Id: I2cf33a4fae4db45b854e77e31e166afa0281a054 Reviewed-on: https://gerrit.libreoffice.org/44956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#108872 Also remove VBA module info on module removaltagezi2017-11-201-0/+3
| | | | | | | | | | | | | If this information is left, then css.container.ElementExistException is thrown on following creation of a module with the same name in XVBAModuleInfo::insertModuleInfo called from ScriptDocument::Impl::createModule (see commit 2be139d76bdb66e77719613d802dc0047c284456) Change-Id: I6750819ce36c112c146d7800a6bab4cc207e0062 Reviewed-on: https://gerrit.libreoffice.org/44940 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* Fix typosAndrea Gelmini2017-11-201-1/+1
| | | | | | | Change-Id: Ib138f971c4efcc67c68c901c9f08b4d1d95cdde2 Reviewed-on: https://gerrit.libreoffice.org/44933 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* silence some coverity warningsCaolán McNamara2017-11-182-2/+2
| | | | | | | | Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Translate German debug stringsJohnny_M2017-11-141-1/+1
| | | | | | | Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555 Reviewed-on: https://gerrit.libreoffice.org/44627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
* loplugin:finalclasses in basctlNoel Grandin2017-11-1010-38/+17
| | | | | | | Change-Id: I5974cf3df434ebfff1e3748ddd291e2a21cbb0de Reviewed-on: https://gerrit.libreoffice.org/44536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams in various(1)Noel Grandin2017-11-042-4/+4
| | | | | | | Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b Reviewed-on: https://gerrit.libreoffice.org/44261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in basic,basctlNoel Grandin2017-11-016-9/+8
| | | | | | | Change-Id: If918c42d4b82d78c07786cfa47c74d0dfb7493d6 Reviewed-on: https://gerrit.libreoffice.org/44131 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: make MapMode constructor explicitMichael Stahl2017-10-266-16/+16
| | | | | | | Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
* new loplugin:dodgyswitchNoel Grandin2017-10-251-1/+1
| | | | | | | | | | | | | | | | and fix bug in ScriptDocument::getTitle which has been there since commit e304ba66f4aba5cc55612508b5738a1ed26a7904 Date: Thu Mar 15 14:59:30 2007 +0000 INTEGRATION: CWS basmgr02 (1.1.2); FILE ADDED plugin is off by default since it uses expensive parentStmt() calls Change-Id: Id0f16baec48e0381e0083594d7e59b58b023da2f Reviewed-on: https://gerrit.libreoffice.org/43750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: basctlStephan Bergmann2017-10-2313-27/+27
| | | | Change-Id: Id7d19b16505aa42877c456e2ac270157077a9365
* Resolves: tdf#113252 missing tabs in basic library organizerCaolán McNamara2017-10-201-0/+7
| | | | | | | Like SfxTabDialog, as in interim measure throw away the TabPage if its not suitable for reuse Change-Id: If8247ea37dfca42e690716a8b687677e0f73c9a8
* turn implicit container explicit in buildable notebooksCaolán McNamara2017-10-171-4/+28
| | | | | | | | | | | as in interim measure for SfxTabDialogs we throw away the TabPage if its not suitable for reuse Change-Id: Ic5776ca3d2a8cb6bf41f33df01b211f81c62a842 Reviewed-on: https://gerrit.libreoffice.org/43134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#113052 needs mpUIBuilder to load breaklistmenuJan-Marek Glogowski2017-10-111-3/+3
| | | | | | | The mpUIBuilder object is also used in the else branch, so move the creation in the outer scope. Change-Id: I18211bbe3c6f85cdd7697225159a98ad672a4ce2
* Use erase-remove idiomJulien Nabet2017-10-101-1/+1
| | | | | | | Change-Id: Ib62b7fd36d6390bf58d98a8213e444109d81aa16 Reviewed-on: https://gerrit.libreoffice.org/43302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* basctl: consistently use "" and <> in include directivesMike Kaganski2017-10-1046-159/+159
| | | | | | | Change-Id: I1796836fb0d53bd07d621af9cfc03becc969d420 Reviewed-on: https://gerrit.libreoffice.org/43299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* add << operator for css::uno::ExceptionNoel Grandin2017-10-041-1/+1
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* new loplugin:blockblockNoel Grandin2017-10-031-45/+43
| | | | | | | Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* throw more useful uno::Exception'sNoel Grandin2017-10-011-1/+1
| | | | | | | | | | | | if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Rename GetSelectEntryData -> GetSelectedEntryDataSamuel Mehrbrodt2017-09-251-1/+1
| | | | | | | Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173 Reviewed-on: https://gerrit.libreoffice.org/42285 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Rename GetSelectEntryCount -> GetSelectedEntryCountSamuel Mehrbrodt2017-09-252-3/+3
| | | | | | | Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25 Reviewed-on: https://gerrit.libreoffice.org/42284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Fresh run of bin/update_pch.shMike Kaganski2017-09-221-20/+44
| | | | | | | Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:flatten in basctl..configmgrNoel Grandin2017-09-211-32/+30
| | | | | | | Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d Reviewed-on: https://gerrit.libreoffice.org/42577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt2017-09-214-7/+7
| | | | | | | Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt2017-09-212-11/+11
| | | | | | | Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* clang-tidy modernize-use-equals-default in basctlJochen Nitschke2017-09-214-43/+0
| | | | | | | | | | | to find unneeded explicit defined or default able copy assignments and copy constructors. Remove the default destructor if it's not needed. Change-Id: I8c53a8622a53398889397132ec1f464e996ac49d Reviewed-on: https://gerrit.libreoffice.org/42525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#112381 Macro Organizer: Move Run, Close, Help buttons to the bottomSabin Frandes2017-09-201-202/+226
| | | | | | | Change-Id: Id08ce71bcd060121630c3a9194f8cfe663ca5822 Reviewed-on: https://gerrit.libreoffice.org/42331 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* clang-tidy modernize-use-emplace in b*Noel Grandin2017-09-081-4/+4
| | | | | | | Change-Id: I51e0369ba2e1fe0b7c934531f71d3bda95ba09ec Reviewed-on: https://gerrit.libreoffice.org/42109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryparen include c++ castsNoel Grandin2017-09-041-1/+1
| | | | | | | Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* set parent for import macro lib dialogCaolán McNamara2017-09-021-1/+3
| | | | | | | | Change-Id: I8c2174a6acee7aed8dca6d4674538f42cfe28ae6 Reviewed-on: https://gerrit.libreoffice.org/41810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* set parent dialog for file dialogCaolán McNamara2017-09-021-1/+1
| | | | | | | | Change-Id: I943d50e46cdd61a52c26297b21045423886deda6 Reviewed-on: https://gerrit.libreoffice.org/41809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* move to FileDialogHelperCaolán McNamara2017-09-011-2/+4
| | | | | | | | Change-Id: I90579f0994f573743327999da2382351a5eb0d3e Reviewed-on: https://gerrit.libreoffice.org/41793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-09-01 05:21:32 +0000