summaryrefslogtreecommitdiffstats
path: root/basctl
Commit message (Collapse)AuthorAgeFilesLines
* convert InsertOperation to scoped enumNoel Grandin2017-02-101-2/+2
| | | | | | and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
* Add missing #includesStephan Bergmann2017-02-065-1/+5
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* loplugin:unusedenumconstants in basctlNoel Grandin2017-02-063-15/+14
| | | | | | | | | drop UNKNOWN constant and convert to scoped enum Change-Id: Iffeb27193cd0df47c781f2b84144d6f85a6b49e0 Reviewed-on: https://gerrit.libreoffice.org/33888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* .uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky2017-02-051-1/+1
| | | | | | | | ... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
* new loplugin:unusedenumconstantsNoel Grandin2017-02-031-1/+0
| | | | | | | | | | These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* makeAny->Any in basctl..chart2Noel Grandin2017-02-0310-25/+25
| | | | | | | Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61 Reviewed-on: https://gerrit.libreoffice.org/33867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert method names in tools::SvRef to be more like our other..Noel Grandin2017-02-023-24/+24
| | | | | | | | | | | reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Convert RID_POPUP_TABBAR to xmlMaxim Monastirsky2017-02-0113-152/+68
| | | | Change-Id: Ic4587b8e244c52089692908fe0d10e363b5ed4fb
* convert RID_POPUP_BRKPROPS menu to .uiCaolán McNamara2017-01-308-77/+74
| | | | Change-Id: I2f55f4959249ac45de4a852089256a33e0f24d91
* Just pass in OUString directlyStephan Bergmann2017-01-272-5/+4
| | | | Change-Id: Iba5289abf96b15e833cb85e96d4e60b2285271be
* Remove dynamic exception specificationsStephan Bergmann2017-01-2623-208/+185
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor: basctl..codemakerNoel Grandin2017-01-242-2/+0
| | | | | | | Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c Reviewed-on: https://gerrit.libreoffice.org/33452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Change all Idle* LINKs to be Timer*Jan-Marek Glogowski2017-01-235-7/+7
| | | | | | | | | | | | | | | | | | | | | Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
* New loplugin:dynexcspec: Add @throws documentation, basctlStephan Bergmann2017-01-193-0/+15
| | | | Change-Id: I34a1b868176f26c1bab841547b97bca56113e47e
* missed a conversion hereCaolán McNamara2017-01-191-1/+1
| | | | Change-Id: I7c422c9700b960248450181c950394f72504e7ea
* Change Idle to be a Timer subclassJan-Marek Glogowski2017-01-171-1/+1
| | | | | | | Drops a lot of duplicated code, as Idle is just a convenience class for instant, mostly low priority timers. Change-Id: I847592e92e86d15ab1cab168bf0e667322e48048
* Refactor Scheduler to add Task classJan-Marek Glogowski2017-01-172-2/+2
| | | | | | | | Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
* b*, c*: load BitmapEx resources instead of Image onesCaolán McNamara2017-01-167-55/+64
| | | | Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
* tdf#104830, need an own termination listener for lib objectsMarkus Mohrhard2017-01-101-1/+1
| | | | | | | | | | | | | | | | | The destruction of the SwDLL object happens already through the normal termination listener but the other termination listeners might still depend on it. Also the outstanding events might need the SwDLL instance to be still around. This makes the destruction of the instance explicit and at a time when it should be safe. We should use the same code for calc, impress, math and base as well. Change-Id: I50b8f30426f5a4a54e362e748fe962839abca73e Reviewed-on: https://gerrit.libreoffice.org/32856 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Clean up a usage of OUStringBufferStephan Bergmann2017-01-061-5/+4
| | | | Change-Id: I05205763502fb20e056cc80f50a37b93232e5743
* Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann2017-01-051-2/+2
| | | | Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
* tdf#105069, store the VBA module info for new modules as wellMarkus Mohrhard2017-01-051-0/+10
| | | | | | | | | | This was never a problem until we started to export the VBA stream instead of just writing back the imported stream. Change-Id: I4e20e717bebd3dc649efcf1b9c18b6e5053303d9 Reviewed-on: https://gerrit.libreoffice.org/32741 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#105005 Breakpoint has wrong image in BASIC IDERegina Henschel2017-01-021-4/+4
| | | | | | | | | | Breakpoint, inactive breakpoint, step marker and error marker have got wrong images in 96d0506fceb8064c5ae156dfaf12d5b45623c557 Change-Id: I7c03595dfa41e03b5b4a23d36c514a6c782281a3 Reviewed-on: https://gerrit.libreoffice.org/32590 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* convert VclButtonsType to scoped enumNoel Grandin2016-12-211-1/+1
| | | | | | | Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
* make IOS hack a DISABLE_DYNLOADING hack and extend for basctl+starmathCaolán McNamara2016-12-191-0/+10
| | | | | | | Change-Id: I07057dec477051ddc96600f467ffbb0c8bd1da5f Reviewed-on: https://gerrit.libreoffice.org/32144 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix iOS (and --disable-scripting in general?) buildTor Lillqvist2016-12-151-2/+2
| | | | Change-Id: I93b26283f7faa937a528c2e4806b3407348ed8b1
* unwind RID_IMGLST_LAYOUT imagelistCaolán McNamara2016-12-124-22/+26
| | | | Change-Id: I17146905c93162977effe9179c844ba691320d35
* convert SFX_HINT to scoped enumNoel Grandin2016-12-082-19/+15
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert VCLEVENT constants to scoped enumNoel Grandin2016-12-071-11/+11
| | | | | | | Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryoverrideStephan Bergmann2016-12-061-5/+0
| | | | Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
* convert DecodeMechanism to scoped enumNoel Grandin2016-12-052-9/+9
| | | | Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
* convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin2016-12-051-3/+3
| | | | Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
* tdf#93592 Make it possible to add default language resource to dialogeditorNiklas Johansson2016-12-021-13/+6
| | | | | | | | | | | | | | | | | During the conversion of uno services a few lines where removed that probably should not have been removed. This caused the dialog editor to crash if you tried to add a new language resource to a document fdo#93077. The fix for that bug fixed the crash but also made it imposible to add a language resource to a dialog that isn't previously translated. With this patch the functionality should be back on track, adding/removing language resources without problems at least as far as my testing goes. Change-Id: Ie6e083837894a219bf8e9c75dec6bf7652d51615 Reviewed-on: https://gerrit.libreoffice.org/30462 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#96717: The macro name desired by the user is now took into account.Pierre Lepage2016-11-291-1/+4
| | | | | | | Change-Id: I3949ffed6dcf85e01bc5fc24a27a04265e54fe44 Reviewed-on: https://gerrit.libreoffice.org/30592 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2016-11-293-10/+7
| | | | | | | | | | | | | | Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: rename Window::Notify to EventNotifyMichael Stahl2016-11-243-4/+3
| | | | | | | | | There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
* vcl makes no use of menu Get/Set DefaultItemCaolán McNamara2016-11-241-2/+0
| | | | | | | this is exposed through uno however, so move it into VCLXMenu to continue to support it doing nothing of great value there Change-Id: I6888e61cbec85faa2d1fcca8731ab42023e594c6
* use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin2016-11-242-2/+2
| | | | Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
* convert SbDEBUG constants to o3tl::typed_flagsNoel Grandin2016-11-247-18/+19
| | | | Change-Id: Ifcada5684bacae46ec90c5ce3e58980860fee29f
* loplugin:unnecessaryoverride (dtors) in basctlStephan Bergmann2016-11-231-4/+0
| | | | Change-Id: Ib2754450cd7caa2675b872c8c9f3d41cec950770
* No use of <svx/Palette.hxx> hereTor Lillqvist2016-11-221-1/+0
| | | | Change-Id: I619f07d52d303bdd386383daa359b4dbeb0c70a6
* convert inventorId to scoped enumNoel Grandin2016-11-215-10/+5
| | | | | | | | | | SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add missing deps on ui filesDavid Tardon2016-11-211-0/+4
| | | | Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
* gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud2016-11-201-1/+1
| | | | | | | | | | | | | | | this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
* Fix typosSamuel Mehrbrodt2016-11-151-1/+1
| | | | | | | Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#68118: Pass current document frame to SvxScriptSelectorDialogMike Kaganski2016-11-144-9/+27
| | | | | | | | | | | | ... through MacroChooser Without this, current document's macros library is unavailable in "Assign" dialog Change-Id: I83baa3b98858260eab61e8f4fefde3f9979c6d83 Reviewed-on: https://gerrit.libreoffice.org/30600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* coverity#703927 Unchecked return valueCaolán McNamara2016-11-141-2/+2
| | | | | | | | | | | make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:expandablemethods in avmedia..canvasNoel Grandin2016-11-114-16/+2
| | | | | | | Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54 Reviewed-on: https://gerrit.libreoffice.org/30753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-119-22/+22
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* 'make screenshot' use-after-free fixesStephan Bergmann2016-11-101-2/+2
| | | | Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
generated by cgit (git 2.34.1) at 2024-10-17 16:26:38 +0000