summaryrefslogtreecommitdiffstats
path: root/basctl/source
Commit message (Collapse)AuthorAgeFilesLines
* Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara2020-02-111-1/+1
| | | | | | | | | | | | xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88395 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Fix macro disabling in Basic IDESamuel Mehrbrodt2019-11-131-1/+3
| | | | | | | | | | | | | | After 8d69ca60f3c8f53699986f924291a2acda5694a1 macros were always disabled as ScriptDocument::allowMacros always returned false when called from non-document context. Change-Id: Ibef4c7d561f4ee01cd44f5327e4ab948282bb07d Reviewed-on: https://gerrit.libreoffice.org/82444 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 6a40737e1feb2e8d1992c46ee6c0e5cf30bab025) Reviewed-on: https://gerrit.libreoffice.org/82489 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Always check whether macro execution is allowedSamuel Mehrbrodt2019-11-081-8/+6
| | | | | | | | | | | | | | | No only when this executing from a document. Setting 'DisableMacrosExecution' had no effect on the macro editor, macros could still be executed there. Change-Id: I400ed25050173d2ce1fb612aebd2dbcb73720a73 Reviewed-on: https://gerrit.libreoffice.org/82229 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 8d69ca60f3c8f53699986f924291a2acda5694a1) Reviewed-on: https://gerrit.libreoffice.org/82251 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* search dialog is weldedCaolán McNamara2019-06-211-2/+2
| | | | | | | | Change-Id: I51fa749266efed733aeff9d2e22d7d5f628468c1 Reviewed-on: https://gerrit.libreoffice.org/74514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* remove some unused includesCaolán McNamara2019-06-153-2/+5
| | | | | | | | Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* remove some unneeded includesCaolán McNamara2019-06-135-7/+6
| | | | | | | | | | Change-Id: I4722cc32e79cb9bd3708a66be127e097fdb84aed Reviewed-on: https://gerrit.libreoffice.org/73838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit acf941677f92debe62900232231b81c3c03ccf51) Reviewed-on: https://gerrit.libreoffice.org/73939 Tested-by: Jenkins
* weld OrganizeDialogCaolán McNamara2019-06-139-1182/+762
| | | | | | | | Change-Id: I976edb0b49c8439d1723be4544b10a5375b8e1d3 Reviewed-on: https://gerrit.libreoffice.org/73900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop unneeded includesCaolán McNamara2019-05-311-0/+1
| | | | | | | | Change-Id: Ie0f52bb1d6866075d0b664bfc3ddc47c02e4f81b Reviewed-on: https://gerrit.libreoffice.org/73169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* New loplugin:dataStephan Bergmann2019-05-221-1/+1
| | | | | | | | | | ...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin2019-05-132-10/+10
| | | | | | | | | | | By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#62699 Drop pass-through header file include/svx/svdattr.hxxGabor Kelemen2019-05-105-0/+6
| | | | | | | Change-Id: I04289589196ac69b31f75989d9252c79d03c890f Reviewed-on: https://gerrit.libreoffice.org/71633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin2019-05-081-3/+2
| | | | | | | | | | | | Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* implement std::hash for css::uno::Reference and rtl::ReferenceNoel Grandin2019-04-301-3/+1
| | | | | | | | | | | | | | | | The declaration in BarChart.cxx is particularly suspicious, because it was using a < for the KeyEqual template parameter. Been there since: commit b2c3233e5f267b5d244d722a94424a3b224b3314 Date: Thu Dec 21 20:08:33 2017 +0900 chart2: suspend/resume setting rects dirty for 3D shapes comphelper::OInterfaceCompare is no longer necessary Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975 Reviewed-on: https://gerrit.libreoffice.org/71537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Resolves: tdf#124704 need to state the area the tooltip is forCaolán McNamara2019-04-281-7/+12
| | | | | | | | | | to make it work under gtk3 Change-Id: I4c895181af233a16292ce16b194f0a60994446fb Reviewed-on: https://gerrit.libreoffice.org/71478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#124984 organize basic macro new added module doesn't show upCaolán McNamara2019-04-273-5/+8
| | | | | | | | Change-Id: I422131ab203eba62ed5cf6fb2e19e23325b43f6e Reviewed-on: https://gerrit.libreoffice.org/71433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#123043 make type character detection unicode-awareTomoyuki Kubota2019-04-231-4/+4
| | | | | | | Change-Id: I98886a7d13a43cc3202d45f96ceb5062f76f0784 Reviewed-on: https://gerrit.libreoffice.org/71013 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* optimise find/insert patternNoel Grandin2019-04-191-2/+1
| | | | | | | | | | if we're doing a find/insert on a set or a map, it is better to just do a conditional insert/emplace operation than triggering two lookups. Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d Reviewed-on: https://gerrit.libreoffice.org/70937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* improve loplugin simplifyconstructNoel Grandin2019-04-152-3/+3
| | | | | | | | | | to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:sequentialassign in accessiblity..canvasNoel Grandin2019-04-122-8/+4
| | | | | | | Change-Id: I984717138ac85c1af5fc363fda06f5c2b5497965 Reviewed-on: https://gerrit.libreoffice.org/70641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen2019-04-0812-0/+21
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* improve combining in hash functionsNoel Grandin2019-04-081-1/+5
| | | | | | | | | | | | specifically, use boost::hash_combine to combine values in hash functions, except for a couple of places where I use the small-prime-number strategy popular in the Java world, to avoid including boost in header files that are widely shared. Change-Id: I0e184c9ec8803bf09fc6e84fe20131b203e1652a Reviewed-on: https://gerrit.libreoffice.org/70384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* weld OTableSubscriptionPageCaolán McNamara2019-04-062-4/+4
| | | | | | | | Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typoAndrea Gelmini2019-04-031-1/+1
| | | | | | | Change-Id: I8f5828e0e9887aaee928e4ff794bd21399fa5abc Reviewed-on: https://gerrit.libreoffice.org/70171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* drop some unneeded includesCaolán McNamara2019-04-021-1/+1
| | | | | | | | Change-Id: I78b9682968acea7564554fb589d2759b6c8e67d0 Reviewed-on: https://gerrit.libreoffice.org/70126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop unnecessary includesCaolán McNamara2019-04-011-4/+1
| | | | | | | | Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen2019-04-012-0/+3
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen2019-03-291-0/+1
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen2019-03-283-0/+3
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Remove unused using declarations in directories [a-d]*Gabor Kelemen2019-03-271-1/+0
| | | | | | | | | | Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen2019-03-2519-0/+27
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Fix typoAndrea Gelmini2019-03-211-1/+1
| | | | | | | Change-Id: I5e585dfe96e650da40c0311928e681619ba40bca Reviewed-on: https://gerrit.libreoffice.org/69494 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#120703 PVS: remove redundant static castsMike Kaganski2019-03-171-2/+1
| | | | | | | | | | V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I6d1523e71b3e06be1cf41abaabb44e49fe11cd8e Reviewed-on: https://gerrit.libreoffice.org/69369 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Simplify containers iterations in basctl, basegfx, basic, bridgesArkadiy Illarionov2019-03-163-45/+15
| | | | | | | | | Use range-based loop or replace with STL functions Change-Id: I8594740103bdc2091c2d03d4b92bbe8393f5378c Reviewed-on: https://gerrit.libreoffice.org/69223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clarify that set_visible(true/false) is just show/hideCaolán McNamara2019-03-161-6/+6
| | | | | | | | | | ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves tdf#122707 - Replace listbox for print range by radio buttonsheiko tietze2019-03-141-3/+11
| | | | | | | | | | | | Some changes to the ui file (GtkGrid, alignment, radio buttons), setChoiceRadiosControlOpt() instead of *list Labels adjusted accordingly Patch partially reverts I62bd9affc9e065d7afcc60296a72eae4612b0ddd Change-Id: Ia06b8f2513d98fbdb1971477cf7b7127595d338c Reviewed-on: https://gerrit.libreoffice.org/68846 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
* i#119731 Hyperlink Control on dialog EditorShubham Goyal2019-03-117-7/+29
| | | | | | | Change-Id: I34132931eba103aec5f9622be9c3bf2dd4de237d Reviewed-on: https://gerrit.libreoffice.org/69001 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* weld SvxMenuConfigPage/SvxToolbarConfigPageCaolán McNamara2019-03-113-13/+13
| | | | | | | | Change-Id: I166ac6c0be8461ea38db711796d1e14fc5b78998 Reviewed-on: https://gerrit.libreoffice.org/68889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#53524 Create UNO grid control- dialog editorShubham Goyal2019-03-087-7/+31
| | | | | | | | | The commit is based on the patch in https://bz.apache.org/ooo/show_bug.cgi?id=120066. Change-Id: Ia4ad536331954679940104adf5d6178228c90854 Reviewed-on: https://gerrit.libreoffice.org/68814 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#42949 Fix IWYU warnings in include/basic/*Gabor Kelemen2019-03-076-0/+6
| | | | | | | | | | Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9dd7984affc4343f148c66077feaac19176adf51 Reviewed-on: https://gerrit.libreoffice.org/68769 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* log nice exception messages whereever possibleNoel Grandin2019-03-071-2/+3
| | | | | | | Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* simplify UNO getTypes methodsNoel Grandin2019-03-041-7/+4
| | | | | | | Change-Id: Ia8b07edec54527fb4904536fabb03a18e8452550 Reviewed-on: https://gerrit.libreoffice.org/68659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2019-02-252-21/+0
| | | | | | | Change-Id: I085394e0f4b780dc5b376d5ac0e9d761434e3ead Reviewed-on: https://gerrit.libreoffice.org/68301 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields in variousNoel Grandin2019-02-252-6/+0
| | | | | | | Change-Id: I31d0e6c3559af2e322fb474b97f3bbf4d5064831 Reviewed-on: https://gerrit.libreoffice.org/68280 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* weld ChineseDictionaryDialogCaolán McNamara2019-02-193-5/+3
| | | | | | | | | | and ChineseTranslationDialog Change-Id: I3b754c405c8379fc0c5fa94437cc0464a1dea999 Reviewed-on: https://gerrit.libreoffice.org/67991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Pointer is pointlessNoel Grandin2019-02-131-1/+2
| | | | | | | | | since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* merge together as get_checkbox_column_widthCaolán McNamara2019-02-121-1/+1
| | | | | | | | Change-Id: I183d2d94ab60c128b136674ef40eeb30057b281c Reviewed-on: https://gerrit.libreoffice.org/67714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#120703 PVS: remove redundant static castsMike Kaganski2019-02-121-1/+1
| | | | | | | | | | V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* new loplugin writeonlyvarsNoel Grandin2019-02-111-3/+1
| | | | | | | | | | largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:indentation in basctl..bridgesNoel Grandin2019-02-083-21/+21
| | | | | | | Change-Id: Ie4e27466c4258c6f774a3ebb82ec3a88c28fd753 Reviewed-on: https://gerrit.libreoffice.org/67525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* weld ManageLanguageDialogCaolán McNamara2019-02-073-72/+62
| | | | | | | | Change-Id: I70cabe6c028cdfae06d0f677979937f18249917a Reviewed-on: https://gerrit.libreoffice.org/67513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-09-03 21:40:53 +0000