summaryrefslogtreecommitdiffstats
path: root/avmedia/source
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:unusedfields in avmedia..comphelperNoel Grandin2018-05-222-3/+1
| | | | | | | Change-Id: I74f125103b67c506d9bb67537e4c4cd3f8f871da Reviewed-on: https://gerrit.libreoffice.org/54641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in MediaWindowImplNoel Grandin2018-05-142-10/+8
| | | | | | | Change-Id: I45c9e33578f23ed368b4bff92a72b37e3c98e8e3 Reviewed-on: https://gerrit.libreoffice.org/54176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in MediaFloaterNoel Grandin2018-05-141-5/+3
| | | | | | | Change-Id: Ibdf838b630fdd63f549b59f69ee05c2030326fa5 Reviewed-on: https://gerrit.libreoffice.org/54175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Clarify checking o_pbLink directly, versus missing dereferencingStephan Bergmann2018-04-171-4/+4
| | | | | | | | | | | | | But given 18ab7abaa9426cd27092125637fdf5fb849b4a04 "MediaWindow::executeMediaURLDialog: add link button" documents that parameter as "if not 0, this is an 'insert' dialog", it looks plausible that all these places indeed want to check the pointer-to-bool for non-nullness, rather than checking the dereferenced bool. Change-Id: Ifbd5e4b711bee97f3ba0b6aab556f533574d21c6 Reviewed-on: https://gerrit.libreoffice.org/52992 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
* remove some unused comphelper includesJochen Nitschke2018-04-151-1/+0
| | | | | | | | | and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Revert "long->sal_Int32 in tools/gen.hxx"Stephan Bergmann2018-04-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 8bc951daf79decbd8a599a409c6d33c5456710e0. As discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-April/079955.html> "long->sal_Int32 in tools/gen.hxx", that commit caused lots of problems with signed integer overflow, and the original plan was to redo it to consistently use sal_Int64 instead of sal_Int32. <https://gerrit.libreoffice.org/#/c/52471/> "sal_Int32->sal_Int64 in tools/gen.hxx" tried that. However, it failed miserably on Windows, causing odd failures like not writing out Pictures/*.svm streams out into .odp during CppunitTest_sd_export_ooxml2. So the next best approach is to just revert the original commit, at least for now. Includes revert of follow-up 8c50aff2175e85c54957d98ce32af40a3a87e168 "Fix Library_vclplug_qt5". Change-Id: Ia8bf34272d1ed38aac00e5d07a9d13fb03f439ae Reviewed-on: https://gerrit.libreoffice.org/52532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* weld linkeditdialogCaolán McNamara2018-04-062-3/+3
| | | | | | | | | | which enables changing FileDialogHelper over to welded Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c Reviewed-on: https://gerrit.libreoffice.org/52388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#42949 Remove unnecessary localization headers from avmediaGabor Kelemen2018-04-042-2/+0
| | | | | | | | | | | Found by searching for the header names and the localization function: git grep -e \<mediamisc.hxx\> -e \<strings.hrc\> avmedia | xargs grep -c AvmResId | grep :0$ | grep -v /pch Change-Id: I7e136a8c1c676fe75e200175345cf1b118de5e41 Reviewed-on: https://gerrit.libreoffice.org/52351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* long->sal_Int32 in tools/gen.hxxNoel Grandin2018-04-031-1/+1
| | | | | | | | | which triggered a lot of changes in sw/ Change-Id: Ia2aa22ea3f76463a85ea077a411246fcfed00bf6 Reviewed-on: https://gerrit.libreoffice.org/48806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused processfactory.hxx includesJochen Nitschke2018-04-012-2/+0
| | | | | | | | | and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* weld native message dialogsCaolán McNamara2018-02-222-9/+8
| | | | | | | | | | | | | | | | just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Bin unused functionTor Lillqvist2018-02-222-19/+0
| | | | Change-Id: I38e9f2e21fdb7cfeb379278e9300e6451c8b970d
* Revert "loplugin:changetoolsgen in avmedia..basic" and reapply pluginNoel Grandin2018-02-161-21/+21
| | | | | | | | | | | | | because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 1adb1a320a7e9832a41545bde13fd59d27ce7954. Change-Id: I52924b35008c8e4b44c8a6b6657cc3a1ac513886 Reviewed-on: https://gerrit.libreoffice.org/49848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:changetoolsgen in avmedia..basicNoel Grandin2018-02-132-9/+9
| | | | | | | Change-Id: I4e355ae27b9fad1cc6e8f8f408dbd9e93d7256d7 Reviewed-on: https://gerrit.libreoffice.org/49603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move Bitmap::SetToData to BitmapToolsNoel Grandin2018-02-071-3/+2
| | | | | | | Change-Id: I0fc62d29d2044c2aa8af3742d4aeb9d782793713 Reviewed-on: https://gerrit.libreoffice.org/49280 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* avmedia: move BitmapWriteAccess inside BitmapNoel Grandin2018-02-021-18/+1
| | | | | | | | | part of a larger project to hide BitmapWriteAccess inside Bitmap Change-Id: Ia46c12b3297107892a6236633c11ca9ada6edbd4 Reviewed-on: https://gerrit.libreoffice.org/49106 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* avmedia: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski2018-01-313-21/+1
| | | | | | | Change-Id: I6274d563f9bb4f1f173d0d5d25239e5617ee064c Reviewed-on: https://gerrit.libreoffice.org/48946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* ofz: speed up bitmap image fuzzingCaolán McNamara2018-01-311-3/+4
| | | | | | | | Change-Id: I73c9ee7aef7062e3cb025c6ae0f3bb6a91485330 Reviewed-on: https://gerrit.libreoffice.org/48983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Remove stdlib.h from sal/config.hStephan Bergmann2018-01-251-0/+3
| | | | | | | | | | | This reverts 5da3337c007e0572028283d70bad43e9a29d45c1 "readded include stdlib.h, because of missing NULL definition in many headers, #100000, #101685", which is no longer relevant. Change-Id: I544ed9a7afbf7b611bc481b8d50acca3193d93de Reviewed-on: https://gerrit.libreoffice.org/48131 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* More loplugin:cstylecast on WindowsStephan Bergmann2018-01-231-4/+4
| | | | | | | | | | | | Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* More loplugin:cstylecast on macOSStephan Bergmann2018-01-201-2/+2
| | | | | | | | | | | | Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Iff4877e8a42804c952c48c13332caf0a83c92870 Reviewed-on: https://gerrit.libreoffice.org/48216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:redundantcast (after loplugin:cstylecast, macOS)Stephan Bergmann2018-01-191-1/+1
| | | | | | | Change-Id: Ife73b464b39c1556f4549226d835d6c8f2b50c1a Reviewed-on: https://gerrit.libreoffice.org/48191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedmethods also check for functions returning boolNoel Grandin2018-01-192-20/+3
| | | | | | | | | we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin:emptyifNoel Grandin2018-01-191-12/+0
| | | | | | | Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* More loplugin:cstylecast: avmediaStephan Bergmann2018-01-151-1/+1
| | | | Change-Id: If76a59af4164f08a79334035c904d5e920115d43
* More loplugin:cstylecast: avmediaStephan Bergmann2018-01-122-5/+5
| | | | | | | | auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Id1ad7f5c7beeea0c749a2ed48dedd03c50945b80
* Fix template parameter ambiguityStephan Bergmann2018-01-111-1/+1
| | | | Change-Id: I52f0134b599ee950e5c9e47a6374e44415a800af
* convert (a>b?a:b) to std::max(a,b)Noel Grandin2018-01-111-1/+1
| | | | | | | | | | with something like: git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2' Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413 Reviewed-on: https://gerrit.libreoffice.org/47602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky2017-12-222-39/+1
| | | | | | | | | | | | | | This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:unusedmethodsNoel Grandin2017-12-194-26/+0
| | | | | | | Change-Id: I3ffd9142fed98e4df75c2c28f8a025be3e8eb803 Reviewed-on: https://gerrit.libreoffice.org/46687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfieldsNoel Grandin2017-12-193-6/+4
| | | | | | | Change-Id: I84a7bcb891548416f0e1f1b20059f9b20c890d4c Reviewed-on: https://gerrit.libreoffice.org/46686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryvirtualNoel Grandin2017-12-183-3/+3
| | | | | | | Change-Id: Icf42fdd40a2cf6cda82254f81a7e389c7bac8558 Reviewed-on: https://gerrit.libreoffice.org/46683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall (clang-cl)Stephan Bergmann2017-12-151-2/+2
| | | | | | | Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:salcall (macOS)Stephan Bergmann2017-12-153-6/+6
| | | | | | | Change-Id: I297ac09358ce948acae9b73e8ed605964520c73b Reviewed-on: https://gerrit.libreoffice.org/46437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:salcall fix functionsNoel Grandin2017-12-113-5/+5
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcallStephan Bergmann2017-12-062-4/+4
| | | | Change-Id: Icf9309addd971c5d98d4057dba6619c4eef9ea6d
* tdf#113380: if the player doesn't exist,...Xisco Fauli2017-12-042-2/+2
| | | | | | | | | | | | | ... use the same size as VLC does. See: https://opengrok.libreoffice.org/xref/core/avmedia/source/vlc/vlcplayer.cxx#167 Change-Id: Ib878ded6c8aacf3a04227ab9efaa59b388f8ff51 Reviewed-on: https://gerrit.libreoffice.org/43827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:singlevalfieldsNoel Grandin2017-12-042-11/+9
| | | | | | | Change-Id: I521d2efa641f3a14c48561e2e0f6d687e5807d93 Reviewed-on: https://gerrit.libreoffice.org/45662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann2017-11-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | ...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedmethodsNoel Grandin2017-11-101-1/+0
| | | | | | | Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454 Reviewed-on: https://gerrit.libreoffice.org/44553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:finalclasses in accessibilityNoel Grandin2017-11-101-2/+2
| | | | | | | Change-Id: I9d8bc018dfe8bd8668d28daccd85ea5770fe31b0 Reviewed-on: https://gerrit.libreoffice.org/44537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* related: tdf#103884 remove gltf/collada featureThorsten Behrens2017-10-3014-1566/+0
| | | | | | | Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* loplugin:includeform: avmediaStephan Bergmann2017-10-2317-35/+35
| | | | Change-Id: I32b9617ffd78ec65a6af0fb7fb1c09f5f8cdde4e
* tdf#87808 Add missing tooltips to Media Playback toolbarGabor Kelemen2017-10-201-0/+2
| | | | | | | | | For the Position and the Volume sliders Change-Id: Ie7eee332b05e9a6cfc8165cf7b7b59695c58b458 Reviewed-on: https://gerrit.libreoffice.org/43571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* Move vlc/wrapper include files to common include directoryStephan Bergmann2017-10-1914-37/+37
| | | | | | | | | | ...that are inclued from both vlc and vlc/wrapper. Change done in preparation of loplugin:inlcudeform. Change-Id: Ic7dc08b93d8a33b21dc64dfc0bfbe3952039f05b Reviewed-on: https://gerrit.libreoffice.org/43556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* iOS, dummy SoundHandler_get_implementationjan Iversen2017-10-101-0/+6
| | | | | | | | | Since it is not easy to remove the avmedia component, adding a dummy SoundHandler_get_implementation solves the link errors With this commit LibreOfficeLight links, but without the prelinked lib Change-Id: Ib18773d784346573f3c1fb21dc4446d92bd27748
* avmedia: consistently use "" and <> in include directivesMike Kaganski2017-10-0924-41/+41
| | | | | | | Change-Id: Ic8d0dee5b0af986214dd5967400651903b84422b Reviewed-on: https://gerrit.libreoffice.org/43269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2017-10-052-2/+4
| | | | | | | | | | | | | | | | Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* add << operator for css::uno::ExceptionNoel Grandin2017-10-042-3/+2
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski2017-10-032-2/+7
| | | | | | | Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-30 13:40:23 +0000