summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* BinaryDataContainer swap out implementation.private/mmeeks/binarydatacacheMichael Meeks2023-05-013-18/+113
| | | | | | | | | | | | | We can easily accumulate a large number of in-memory graphic objects, and swapping these as well as the un-compressed images can become important. Despite the shared pImpl, we retained the reference counting on the underling vector to keep this immutable while we hand out a MemoryStream reference to it. Change-Id: Ib7ca45afb8499460b1852461f7c11afca3f3cdfa Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
* BinaryDataContainer: account for in-memory size of un-compressed image.Michael Meeks2023-04-274-0/+13
| | | | | Change-Id: Ia86d4dda706959bb58e941e65f2b2f7fffa8dc3d Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
* sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 4Miklos Vajna2023-04-273-1/+44
| | | | | | | | | | | | | | | | | | | | | | | | | Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed the crash and parts 2-3 already improved the layout partially, towards avoiding a layout loop. The top problem now seems to be that page breaks before floating tables are ignored, which leads to a layout situation that loops. This problem was hidden before, since page breaks were not ignored. Fix the problem at DOCX import time: if there is a "break before" on the table, then transfer that to the anchor paragraph, which gives the correct layout, and also side-steps the above described layout loop. We should probably never call SwTextFrame::JoinFrame() when creating the initial layout for a document, that part is still unfixed, but that looks like a pre-existing problem. Change-Id: I1e2ecdbf0a3d4e2477cd4768a9b4a35a155e815b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151082 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
* fix bug in json_writerJaume Pujantell2023-04-271-1/+5
| | | | | | | | | | Ruler stores null-terminated strings in fixed length char arrays, so when creating a JSON a string might end earlier that it's size sugsests. Change-Id: Icdcaf35f9ce54c24dcd36368dc49bb688a2a65ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150542 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
* Fix typoAndrea Gelmini2023-04-271-1/+1
| | | | | | | Change-Id: I8ae43a371b925773e02e23631f18b74fd7bf366f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151092 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#154818 - Find bar: remember and reuse last search stringAndreas Heinisch2023-04-271-2/+5
| | | | | | | | | | If there exists no last search string in the view options and there exists a search history, preselect the last search item. Change-Id: Ic6056e02eaf6c0ee7e266e47ba961dff11e9f9da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151072 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
* Update git submodulesSeth Chaiklin2023-04-271-0/+0
| | | | | | | | | | | | | * Update helpcontent2 from branch 'master' to a53384ca39c4423a4562583373eaaabc20e6763e - tdf#154717 improve notes about number format; simplify "refer to" also move "Chapter" format to correspond to position in UI. Change-Id: Idf76a27c42dc8fa1ba9ee36f80faf2ef36769b51 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150512 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* add @since for COMPACT_LAYOUTDennis Francis2023-04-271-0/+2
| | | | | | | Change-Id: I4b7f918e846ea1d220b9df2be5bc0b39d1f22f7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151086 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
* Avoid temporary OUString creationMike Kaganski2023-04-271-1/+1
| | | | | | | Change-Id: I1cebcc2cbd36ed83d4898e222929c872f46c08d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151028 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Revert "introduce sw::SpzFrameFormat ..."Stephan Bergmann2023-04-2765-279/+318
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 09cdcb5f37bb4e42da7b28db6e757b9f2affed14. It broke at least CppunitTest_sw_uiwriter3 (<https://ci.libreoffice.org//job/lo_ubsan/2756/>), > /sw/source/core/undo/rolbck.cxx:938:46: runtime error: downcast of address 0x61300041fd00 which does not point to an object of type 'SwFlyFrameFormat' > 0x61300041fd00: note: object is of type 'SwDrawFrameFormat' > 00 00 00 00 70 83 cf 09 25 7f 00 00 00 83 47 00 30 61 00 00 40 e5 43 00 30 61 00 00 80 66 5d 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwDrawFrameFormat' > #0 0x7f24fca9c5b9 in SwHistoryChangeFlyAnchor::SetInDoc(SwDoc*, bool) /sw/source/core/undo/rolbck.cxx:938:46 > #1 0x7f24fca880f3 in SwHistory::Rollback(SwDoc*, unsigned short) /sw/source/core/undo/rolbck.cxx:1208:15 > #2 0x7f24fcb47832 in SwUndoDelete::UndoImpl(sw::UndoRedoContext&) /sw/source/core/undo/undel.cxx:1031:33 > #3 0x7f24fcb703c2 in SwUndo::UndoWithContext(SfxUndoContext&) /sw/source/core/undo/undobj.cxx:225:5 > #4 0x7f2543b8b57c in SfxUndoManager::ImplUndo(SfxUndoContext*) /svl/source/undo/undo.cxx:712:22 > #5 0x7f2543b8c4f8 in SfxUndoManager::UndoWithContext(SfxUndoContext&) /svl/source/undo/undo.cxx:664:12 > #6 0x7f24fca6a074 in sw::UndoManager::impl_DoUndoRedo(sw::UndoManager::UndoOrRedoType, unsigned long) /sw/source/core/undo/docundo.cxx:696:32 > #7 0x7f24fca6b38f in sw::UndoManager::UndoWithOffset(unsigned long) /sw/source/core/undo/docundo.cxx:731:16 > #8 0x7f24fa830b18 in SwEditShell::Undo(unsigned short, unsigned short) /sw/source/core/edit/edundo.cxx:141:57 > #9 0x7f250088f448 in SwWrtShell::Do(SwWrtShell::DoType, unsigned short, unsigned short) /sw/source/uibase/wrtsh/wrtundo.cxx:45:26 > #10 0x7f24ff7f16e2 in SwBaseShell::ExecUndo(SfxRequest&) /sw/source/uibase/shells/basesh.cxx:651:27 > #11 0x7f24ff7eea14 in SfxStubSwBaseShellExecUndo(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:2203:1 > #12 0x7f2523fbc059 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9 > #13 0x7f2523fd1ced in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9 > #14 0x7f2523f61333 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1060:22 > #15 0x7f252437496b in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:688:53 > #16 0x7f2524377211 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:266:16 > #17 0x7f24cad28dd6 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:163:30 > #18 0x7f24cad27cb2 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:120:16 > #19 0x7f24cad29684 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx > #20 0x7f24e91d386d in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:94:33 > #21 0x7f25319b2012 in testTdf132321::TestBody() /sw/qa/extras/uiwriter/uiwriter3.cxx:982:5 Change-Id: Ibeb181bc38cd6f88df76403cca8a15b45090633f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151027 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* sc: pivot table compact layoutDennis Francis2023-04-2739-91/+989
| | | | | | | | | | | | | | | | | | | This implements compact layout for pivot tables. In ooxml each row field can have a compact layout setting. Support for any such "mixed" layout of tabular/outline/compact per field is also implemented. This also implements expand/collpse toggle buttons to field labels to make pivot tables with compact layout more usable. Such buttons are also available if other layouts are used. Conflicts: sc/qa/unit/pivottable_filters_test.cxx sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/checklistmenu.hxx Change-Id: Ieaa1f3bd282ebdec804d0b45a0af7b3d95a2027f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151057 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
* Extend tiled rendering test to account for dark modeParis Oplopoios2023-04-273-3/+27
| | | | | | | | | | Made testGetViewRenderState test for change from light mode to dark mode Change-Id: Ia02e7a462e595671492405733f25c0bbb3c24080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151046 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOleImgMiklos Vajna2023-04-271-42/+52
| | | | | | | | | | Set the filter options explicitly, rather than inferring it from the test name. Change-Id: I5726642d932a495ff2158d3a0ed9c242a5c13278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151073 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#136749 no need to use maMutex in SwAccessibleMapNoel Grandin2023-04-272-363/+319
| | | | | | | | | | | we already need to be running under the SolarMutex, so just use that. Shaves some 5% off time here. Change-Id: Ife13f44d2e52171638bebcee946f5a1f07248cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#38194 Use a hashed string HSL color approachJim Raykowski2023-04-271-31/+11
| | | | | | | | | | | for style name color creation New magic for style name color creation. Change-Id: Ia6eec2dcf04fc2c3c38276bf6eaed73598505947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151079 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Bin the unused paintTileToCGContext special thing for iOSTor Lillqvist2023-04-273-117/+25
| | | | | | | | | It was used by "LibreOfficeLight" which died years ago. Change-Id: I71a1315448baa4f1ec7a22b20cb3dd39c88cda78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151066 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Remove wrong "toolti-text" in notebookbar.uiRafael Lima2023-04-271-6/+0
| | | | | | | | | | | | | | | | This patch removes wrong "toolti-text" entries in Calc's notebookbar.ui file. Besides being wrong (the correct would be "tooltip-text"), these entries do not make sense since tooltips are not supported in this manner by the Tabbed UI. Moreover, "toolti-textp" is not used in any of the notebookbar files. Change-Id: I2f862cfe53a8de5fa1566fec7cc00c14d1bcc505 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151022 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#151958 Disable binary search on sorted cache for current releasesEike Rathke2023-04-271-3/+15
| | | | | | | | | | | Temporary measure until the actual cause is fixed. The by string query of binary search on sorted cache is broken for mixed types like here the numeric date cells and text cells. Change-Id: Icfe0b0c30987fcefdd6ed11066ea9113f3b4dabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151074 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
* Update git submodulesOlivier Hallot2023-04-261-0/+0
| | | | | | | | | | | * Update helpcontent2 from branch 'master' to 6a79a8d4a5ca9e76f0811ddc8fcf8d79b21728ac - Refactor page - no content change Change-Id: I0f97c79e69234b52147c0812066f50f952705bd9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151077 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Simplify aCurNode.children construction in sw/WriterInspectorTextPanel.cxxJulien Nabet2023-04-261-12/+7
| | | | | | | Change-Id: Ide294aadc8a0c0df1fa6ba24bae044a2592677f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151075 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Update git submodulesChristian Lohmaier2023-04-261-0/+0
| | | | | | | | | | * Update translations from branch 'master' to bd22a155b84999d3a2e75cca0e1c735993971064 - update translations for master and force-fix errors using pocheck Change-Id: I8c546190ea25d29f985750ecb2461a126f0815ff
* pptx export: fix export of vertical table textSarper Akdemir2023-04-262-4/+4
| | | | | | | | | | | | | | | The mapping (implemented in 77655fc3dca05d4bb2366e67ccea228e3886bfe2) used on export and the accompanying roundtrip test was incorrect. This patch fixes both. Rotation value of - 9000 maps to vert270 - 27000 maps to vert Change-Id: I9a9f889a2bff0241e62ee685492034eec6d0cccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150955 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
* tdf#136749 std::map -> unordered_mapNoel Grandin2023-04-261-3/+3
| | | | | | | | | | considerably faster when looking up pointers, shaves 10% of time off here Change-Id: I521f8d557a30e4f430caab6b0701ad8da65f99f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sw floattable: DOCX import: m_bConvertedTable is now unusedMiklos Vajna2023-04-263-9/+0
| | | | | | | | | | | | | This was added in commit 659c0227a50d298780d72902314e03df8824bc06 (tdf#107889 DOCX import: consider page breaks for multi-page floattables, 2017-05-16), but is no longer used since commit c50bf5a5daaae3d40f89ea0784a75a8a571c208d (sw floattable: remove no longer needed DOCX import heuristics, 2023-04-12). Change-Id: Ieba43e1175ab59c29c0555299facb8fc0e865acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151067 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
* Typo UNO_NAME_EDIT_PARA_TAPSTOPS->UNO_NAME_EDIT_PARA_TABSTOPSJulien Nabet2023-04-262-2/+2
| | | | | | | Change-Id: I515557adc9363858ebda5230e8428e2b58d06d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151068 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Update git submodulesOlivier Hallot2023-04-261-0/+0
| | | | | | | | | | | | | | * Update helpcontent2 from branch 'master' to 77b1a5a7118478c2b3a86fd43cfc68e336ac913c - tdf#153547 Fix typo + Reference to comment #2 + Refactor of whole file Change-Id: I1c167c9ca1a0cf8e6d3f10ecb9da02eac9060ba3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151071 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Disable WiX-based MSI generation for the momentThorsten Behrens2023-04-261-1/+0
| | | | | | | | | | Right now, CI builders have no WiX toolset installed, breaking all daily builds (since commit 9aee0383c3ebc3f267c99e19764728ba09c12d3a) Change-Id: I92ba2590c5afa711d3079edc070fd904b01de6f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150823 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* cid#1401342 Uncaught exceptionCaolán McNamara2023-04-262-0/+7
| | | | | | | Change-Id: I50a2a4b1763749ae6117e38c982808b514e876d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151037 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* upgrade to more recent fuzzing dicts and use some additional onesCaolán McNamara2023-04-269-8/+21
| | | | | | | | | that look a good fit for the formats we're already fuzzing Change-Id: Ie635d17d829858c0cb10f71ea936f8dc131db811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151052 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* add a svg fuzzerCaolán McNamara2023-04-265-0/+98
| | | | | | | Change-Id: I9662d91d2761b4f160858897f19f31f474dccbed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151051 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* assume IFrame script/macro support isn't neededCaolán McNamara2023-04-262-11/+5
| | | | | | | | | seems undocumented at least Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* use skia's svg seed corpusCaolán McNamara2023-04-261-0/+1
| | | | | | | Change-Id: Iee1e7a6bbc3e50b3e882465aafea4c9b0650dcbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* expose parsing svgs for testingCaolán McNamara2023-04-266-0/+26
| | | | | | | Change-Id: I4d59aa9a684bd3e05fca473d6c7567cd8258b242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* tdf#151624 Fix Insert Formula tool in the Tabbed UIRafael Lima2023-04-264-4/+16
| | | | | | | | | | | | | As reported in the ticket the Insert Formula tool was misaligned in the Tabbed UI since the removal of the Emoji tool. This patch fixes that by making the tool use all the available vertical space. Change-Id: I26d36ba4fc6f38e80d8ab46bfdf88c08fbf2fd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150701 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
* Resolves tdf#153852 - Make sort dialog resizableHeiko Tietze2023-04-263-2/+16
| | | | | | | Change-Id: Ie0db5c713bf16443962245900655736aeddce532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151042 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
* tdf#108757 speed up PDF generationNoel Grandin2023-04-262-6/+7
| | | | | | | | | | std::list->std::vector reduces output time by 10% because we search the m_aChildren often and vector is better at that Change-Id: I4d0d5f6248a9c36aa0085cb22315ad6e2f53738e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#108757 avoid some OUString construction on a hot pathNoel Grandin2023-04-261-5/+5
| | | | | | | Change-Id: I468bc9fac024dd9fa33286382264e2b84617481b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 3Miklos Vajna2023-04-263-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Converting the bugdoc to PDF crashed Writer layout since commit ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable: import floating tables as split flys by default, 2023-04-12). Part 1 already fixed the crash, but a layout loop remains. The current problem is that we could have a document of 3 pages where the last page had no anchor for the fly frame, so it took the anchor from the previous page, but this lead to negative frame heights and at the end an empty 3rd page. To fix the problem: 1) Make sure SwTextFrame::FormatAdjust() doesn't break the invariant that only the last frame of a floattable anchor has text content. 2) Make sure SwTextFrame::AdjustFollow_() doesn't join a frame that still hosts non-last split flys. With this, we have exactly 3 anchor frames (in a flow frame chain) for the 3 pages and the 3rd page looks correct. The original document still needs more work to fix the layout loop, though. Change-Id: I2fc9c4728fdf191ac5b5b435a10d553a699bae75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151048 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
* Bin leftover dead codeTor Lillqvist2023-04-261-20/+0
| | | | | | | Change-Id: Ie0583d52b01bba92e6fc41f0fee3fd4732f1d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151054 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Fix typoAndrea Gelmini2023-04-261-1/+1
| | | | | | | Change-Id: I05e089a8d04d2b5527cf466510b182eeac355836 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151044 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2023-04-261-1/+1
| | | | | | | Change-Id: I13e43e0cd7f3f3e31b581c5b3cec12f5c0634cdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151043 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* update creditsChristian Lohmaier2023-04-261-1857/+1896
| | | | Change-Id: I934d635e0d241b9884017e4a22ba99e9d1459783
* Revert "workaround compile failures in libxml, with clang-17"Noel Grandin2023-04-261-1/+1
| | | | | | | | | | | This reverts commit 4a828dde104551c1c3d935ed8b43ebc546fa77c3. Reason for revert: Caolan merged a better fix with aa87fe2562e7a55a18a1c757a49babfe74377bcd Change-Id: I3ae713555fc62782675dbc48ad51a36ff41bfcf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scaleTibor Nagy2023-04-263-0/+70
| | | | | | | | | | | | This is a follow up to commit 3f614f431475e1bf3bb3bbeac59b0681309628b7 (tdf#95295: don't add duplicate conditional formats) The above commit clearly describes how this fix works. Change-Id: I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150899 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
* jsdialog: enable themedialog.ui and themecoloreditdialog.uiTomaž Vajngerl2023-04-261-0/+2
| | | | | | | Change-Id: Ie6c6af3e3a98548cad8b5bfb067382a03296b278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151033 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Related: tdf#155017 Stop after the first pop in case the shell was not on stackMike Kaganski2023-04-261-0/+7
| | | | | | | | | | | | | | | | After commit 271f17a6022c64cbbe9befbc66a9eaaa0567d569 (tdf#155017: make sure that the correct shell is popped from SfxDispatcher, 2023-04-26). This restores the previous logic for a hypothetical case of a pop without POP_UNTIL scheduled for a shell, which was not on the stack (so that it wasn't removed in the code added in the commit mentioned above); I haven't a reproducer, but it definitely can happen, given how things work here. So I try to avoid breaking it even further :-) Change-Id: Ied0a1406881fbefe3cf069f816c50da03a41dcd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151034 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* use our existing zipfuzzer_seed_corpusCaolán McNamara2023-04-261-1/+2
| | | | | | | Change-Id: Ib0ea6ad80ff24d3b405051c22b4cdcc461ae2018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* tdf#152246 Fix RTL content control field positionHossein2023-04-261-3/+11
| | | | | | | | | | | | | | | | | | | With this patch, the horizonal position of the content control fields are corrected. Previously, they were calculated just like the fields in the LTR paragraphs. To implement this, I've used the GetTextFrame()->SwitchLTRtoRTL method. The remaining issue is that The exported fileds in the PDF are still LTR themselves. For example, the combo box will still be LTR. It should be pointed that handling vertical text is still an issue that should be addressed later. If you rotate the paragraph with content control field, the output does not obey, which is incorrect. Change-Id: I927d14f9ca90434b4397dcf175dbb9531dda0c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150515 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#138093 DOCX import: fix broken date selector control in tableCzeber László Ádám2023-04-263-1/+58
| | | | | | | | | | | | | | | | | | | | | | In tables, first character of the text value of the date selector control left outside of the control during the import, resulting broken date selector, e.g. 2[023] instead of [2023]. (Clicking on the broken control, according to the year *023*, the selector listed the lowest possible value, year 1900, and selecting that, the result became 2[1900].) Note: the fix works well with nested tables, too, so likely the condition with tables is obsolete. Perhaps regression from commit b36ef83ea59eeaca239e58b95aa0b1acdcb99efc "tdf126701: MSForms: Fix import of date field at the end of the paragraph." and commit 68e1be4ccbb90ee9a788962219a88312c4ffbea2 "MSForms: Rework text-based date form field's representation". Change-Id: Ib217a3a06522bfe7b3b0fbc884f98504f628fc59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
* tdf#155006 don't show "InsertObjectFloatingFrame" by default in menus and ↵Caolán McNamara2023-04-2634-269/+23
| | | | | | | | | | | | | | | | | | | | | | | | | toolbars still exists, just isn't presented by default. help describes this as "Inserts a floating frame into the current document. Floating frames are used in HTML documents to display the contents of another file." and "Changes the properties of the selected floating frame. Floating frames work best when they contain an html document, and when they are inserted in another html document." This is basically support for html IFrames and is a fairly obscure thing for an ordinary document. Change-Id: Iec8ff591393e4ee4ed8791094e1f15a225808c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150707 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Caolán McNamara <caolanm@redhat.com>