summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Don't unselect an existing selection on (long) press on iOS and Androidprivate/tml/cp-6-4-28-1Tor Lillqvist2021-03-111-3/+12
| | | | | | | | | | | | | | | | | A (long) press, also known as a long tap, in Collabora Online (as used to bring up a context menu), shows up in core as a click of the right mouse button. We don't want that to cause an existing selection to be unselected. This fixes https://github.com/CollaboraOnline/online/issues/1323 Why this problem happened only in presentation documents I have no idea. Change-Id: Iebbf71e75dcea7c39a92fd8d5dd07c368d92f163 Signed-off-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112261 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Bump version to 6.4-28cp-6.4-28Andras Timar2021-03-031-1/+1
| | | | Change-Id: I7a31392b4b079fce2815975f789d3238c75a0462
* lok: disable macro executionHenry Castro2021-03-031-1/+1
| | | | | | | Change-Id: I97a1fd7992d6be57e54c186045e62c3402b99375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111752 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* LOK: added missing PixelInvalidate method for currency listPranam Lashkari2021-03-034-0/+44
| | | | | | | | | | | | | when docking window is displayed in popup mode, there are two windows created docking window and floating window, to make the this window work correctly with LOK, we have to invalidate the floating window to update floating window, as well as docking window. Change-Id: Ia1b4220646664aa0666a24e34fc14bf41421f9e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111762 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* [cp] fix packaging of pyuno-debuginfoAndras Timar2021-03-031-3/+5
| | | | Change-Id: I9c14835fdbfd660bd3a88f8a9bf96f3b85991d6a
* Handle floating-point return values correctly on iOSTor Lillqvist2021-03-031-13/+11
| | | | | | | | | | | | | | | | | | The code did not work at all. The contents of register d0 that we tried to access in MapReturn() was not what the called function had stored there. Probably the clobber list in the __asm__ statement is wrong? Anyway, simpler to fix it by explicitly storing d0, too, into a variable after the call, like we do for x0 and x1, and then pass that variable, too, to MapReturn(). Fixes https://github.com/CollaboraOnline/online/issues/1519 . Change-Id: Id05c8c57209eb9ade4d67035830b2dec601bc046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111826 Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* tdf#137121 add popup menu to style items used in styles preview windowJim Raykowski2021-03-032-9/+43
| | | | | | | | | | Change-Id: Ib9bd6584416b24301d3d302165d12c89bcd1e178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109838 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111659 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* tdf#133473 Change SDRATTR_SHADOWSIZEX flag.Gülşah Köse2021-03-034-2/+20
| | | | | | | | | | | | | SDRATTR_SHADOWSIZEX holds a percentage value. So we shouldn't use METRIC_ITEM. Change-Id: I9f1a20d5871f60d2899ef7d525f4cf837b0a9088 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111311 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111566 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* Prevent the unnecessary lclCropGraphic call.Gülşah Köse2021-03-031-9/+10
| | | | | | | | | | | | | In case text::GraphicCrop aGraphCrop( 0, 0, 0, 0 ) we don't need to call lclCropGraphic. Change-Id: I9960900f9b5c5b770824c76ffeb9ec9b51cbaef3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111401 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111565 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#128213 Add unit test for text camera z rotation.Gülşah Köse2021-03-032-0/+17
| | | | | | | | | | Change-Id: I50dab62ba1013d4ae17684edde620f9c94c5ec47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111028 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111563 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#134210 Better testing for cropping bitmap of custom shape.Gülşah Köse2021-03-033-18/+12
| | | | | | | | | | Change-Id: I592e2e99306a4aa27dce17e8b8d75e4bb2262cab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110723 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110966 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#137406 removed Apply to Master button in Slide Master modeGokce Kuler2021-03-031-0/+7
| | | | | | | | | Change-Id: Ic19c38a5e6e561cae45cd0a40cfe56d7002efe9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110835 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111562 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Bump package version to 6.4-27cp-6.4-27Andras Timar2021-02-271-1/+1
| | | | Change-Id: I4af6fb548cf08d815eb645fade043ac0b88a1483
* lok: mark calc document as modified when adjusting split-panes (2)Andras Timar2021-02-271-0/+2
| | | | | | | Change-Id: I91231770ebf02218ae0380ddf76a8664dc6e5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111651 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* lok: mark calc document as modified when adjusting split-panes.Michael Meeks2021-02-271-0/+2
| | | | | | | Change-Id: I592ee4dc4317f27fae24141b2052475ef26e9fc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111599 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
* tdf#132368 svx: empty the interop grab-bag on ending text editMiklos Vajna2021-02-273-0/+75
| | | | | | | | | | | | | | | | | | | | | | | | | Regression from commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 (PPTX export: save SmartArt as diagram instead of group of shapes, 2019-03-13), the idea of interop grab-bag was to carry additional information around as long as the object is not changed. However, actual clearing of the grab-bag was never implemented, do this when editing shape text. An alternative would be to do this in SdrObject::SetChanged(), but Writer sets the layer of SdrObjects during layout (when the import filter is already finished and undo is enabled), so that would mean loss of the smartart metadata for DOCX. (cherry picked from commit a01ae07740e5c311fcc37f2ac2e2a0a2a1935920) Conflicts: svx/qa/unit/svdraw.cxx Change-Id: I9ab205b4ef84169f4b5a16b86fe9a152e3370a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111596 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* sw: fix incorrect loop condition in SwTransferable::isComplex()Miklos Vajna2021-02-272-1/+29
| | | | | | | | | | | | | We're not consuming hints in that loop, so we want to end when the iteration ended, not when the list of hints is empty. Conflicts: sw/qa/uibase/dochdl/dochdl.cxx Change-Id: I2cb735c03c3551f7b0be8b314183780eedff9ecf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111558 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Revert "Revert "sw lok: simplify SwTransferable::isComplex()""Andras Timar2021-02-271-23/+25
| | | | | | | This reverts commit fec6ada35de1592bd0d5314e7385fe90bb732dcf. Reason: We have a fix now. Change-Id: Ic2023e1c83ade89205d6ead83d97c222371f1fe2
* Bump package version to 6.4-26cp-6.4-26Andras Timar2021-02-251-1/+1
| | | | Change-Id: I31f5c2ff8db94419fa9c2597a78289c69aeeec8d
* avoid LOK text selection update when reference cell is in different tabPranam Lashkari2021-02-253-6/+12
| | | | | | | Change-Id: I511b9c5a27f97b6e14e9a844179c27a96997abe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111346 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* show reference range specific to only selected calc sheetPranam Lashkari2021-02-251-1/+4
| | | | | | | | | | | Problem: when switching tab in online reference range would not change according to tabs this would show incorrect reference range Change-Id: I07e072a74b2925a25b7a4a50ce0c238308d99ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111408 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* Fix non-valid json generation on NotifyOtherViewsmert2021-02-251-3/+9
| | | | | | | Change-Id: I82aa0aefcd1de14b4c1bb2bbe3f087b60d691beb Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111299 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Revert "sw lok: simplify SwTransferable::isComplex()"Andras Timar2021-02-251-25/+23
| | | | | | | This reverts commit 70bc089fe9bec46ef4ca0417518ee06302c65f4c. Reason: it crashes even more often than before Change-Id: I6ebc540a5ac041d1645862af51c89608dcba43ca
* Bump version to 6.4-25cp-6.4-25Andras Timar2021-02-241-1/+1
| | | | Change-Id: I42c97abf75f2fd06b3d128f50a9e33a9a2fbf09d
* tools: json: fix missing escaped charsHenry Castro2021-02-241-0/+21
| | | | | | | | | | | | | | When client side tries to show the "Macro Security Warning" message dialog, it fails to parse the JSON objects Change-Id: Id73c291ddd9cf739d63d69f06094eacb7b43a2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108287 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 6002ff0354c95c3dffbf4f933833695f3f47b73b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111418 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* lok: fix treeview action "select"Henry Castro2021-02-231-4/+7
| | | | | | | | | | | | Unfortunately the Macros dialog has a treeview control that fill on demand and the position is absolute and it has a side effect to deselect the item since the relative entry position is nullptr. Change-Id: Ie442f6d634437a293cde65da0764d3f433a70155 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110963 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* jsdialog: fix missing update for "treeview" action "select"Henry Castro2021-02-231-0/+1
| | | | | | | | | | When Treeview control selects an item, the state of the control has changed and it should update the new changes to the client side. Change-Id: I27d6a215148fcef260799d76ffe209460f38c559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111355 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* sw lok: simplify SwTransferable::isComplex()Miklos Vajna2021-02-231-23/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 169a87563a3940299811d874b4df0ad13591771c (LOK: Implement getSelectionType, 2019-06-24) implemented detecting complex selections by copying the selection to a new SwDoc, which probably had two benefits: first, the created SwPaM instance didn't touch the document; second, this means no bounds has to be set when scanning nodes: the entire document is the selection. Later commit 7fe30d1cb00c576469d6cbe5606268a9cdf35bd3 (LOK: detect Graphics in isComplex for Writer, 2019-06-25) got rid of the SwPaM (which would register itself into text nodes), so now it's possible to not touch the document, even if we work on the original document. Instead, solve the partial scanning by iterating over the list of selections. This is meant to be faster, and also less likely to crash in case some internal document model invariant is broken. No testcase, testComplexSelection in CppunitTest_desktop_lib already covers thie behavior. (cherry picked from commit 7a8dc25defee31edbb75a2f8c35f92ee2d3f3a83) Conflicts: sw/source/uibase/dochdl/swdtflvr.cxx Change-Id: Ia528c06a48defd06c5e34ed7d61621e5ce10bb06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111385 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* lok: add batch mode option to load the documentHenry Castro2021-02-223-0/+11
| | | | | | | | | | | | | | | | | When the LibreOffice Kit is active by default is set to headless mode, with the flag "DialogCancelMode::Silent", according to the documentation it should close the dialog, but it was changed for dialog tunneling. However the dialog tunneling is being deprecated, and in order to not produce any regression, it will be used temporary a new state "DialogCancelMode::LOKSilent", to disable any dialog interactivity. Change-Id: I3b6cce38c37f75dc1b24dda352f6caec19438ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111087 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* Bump version to 6.4-24cp-6.4-24Andras Timar2021-02-221-1/+1
| | | | Change-Id: If4c58cd09eb58927e7a25b16dc8f47f4f6bb24c0
* filter: svg: js engine: misplaced text: improving text field handlingMarco Cecchetti2021-02-222-48/+83
| | | | | | | Change-Id: I8b5f9a39b3cd3fcfdae0d088eae0a875cf9404ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111065 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* filter: svg: export: renaming class attributes related to TextShapeMarco Cecchetti2021-02-224-9/+11
| | | | | | | | | | TextShape => SVGTextShape com.sun.star.drawing.TextShape => TextShape Change-Id: I4bbb465e0f65aa328527ac3022c0b68546fb5db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111224 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* filter: svg: unit test for placeholder localeMarco Cecchetti2021-02-221-0/+58
| | | | | | | | | | We set the language to it-IT and check that the exported placeholder text is still <number> instead of <numero> Change-Id: I7ec7e25e53075da38cb87d81e9f8268b37121bfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111115 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* fix variable name in SAL_INFOAndras Timar2021-02-211-1/+1
| | | | | | | Change-Id: Ie6da9b1677e60b4e9dfe507e1571cc68610a6cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111187 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* online: fixed freeze pane not writing correct data on file savePranam Lashkari2021-02-181-0/+6
| | | | | | | | | | | | | | problem: when we save the file after setting freeze panes in online, opening same file in Desktop libreoffice will show incorrect view, each freeze view would start from A1 this patch ensures that we write correct starting cell pos for each freeze view Change-Id: Ic8ccd5fb5cbedf2ea4f0e9376f0cfdd530e32d6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111131 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
* try to use a different timestamp serviceAndras Timar2021-02-184-4/+4
| | | | Change-Id: I0fdbe2871d74836d530a69532bf22c17f642c922
* Better fix for tdf#125824: switch page only for the current view.Tamás Zolnai2021-02-172-2/+6
| | | | | | | | | | | | | | | | | | | | | | | First workaround was avoiding undoing: 9dca7c2fac5c6b83a6910aa61b1a2a316f36d948 Second workaround was forcing all views to exit text editing: e6c7a018a0cfee395ce2886d41c908a2447ef5cc Instead of these solutions, we allow to continue text editing in other views. What we do is avoiding jumping to the object location in all views while undoing. In theory, the two views / windows should be able to edit the document's different parts independently. So one view should not jump to the location where the other view edits something / does an undo. It works both with multi-window and Collabora Online's collaborative editing. Change-Id: I7ffe29bf175b8f855fe3e92b3d7e11ca6bcd3f5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111073 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* filter: svg: text field: placeholder localization issueMarco Cecchetti2021-02-172-1/+16
| | | | | | | | | | | | | The text content for a placeholder is localized, so in case a French locale is used, the placeholder for a PageNumber text field is <numéro> instead of <number>. Change-Id: If1d31fee98d044775995b5b80567296f78d2a6c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110944 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
* On aarch64 platform deb package platform string should be arm64 actuallyAndras Timar2021-02-171-0/+1
| | | | Change-Id: I0b4b04e4a6f5c474b3961e5223128e0c835b8c44
* tdf#139511 Correct calculation of minimum row height during resize.Gülşah Köse2021-02-171-1/+1
| | | | | | | | | | | Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit b6d53ce5359d4f41b9fece475339cdf63c5817e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110930 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#134210 Handle greyscale effect on bitmap filled custom shapes.Gülşah Köse2021-02-173-0/+35
| | | | | | | | | | Change-Id: Ia4a0828dad80e32cc0c7fe12227ffca717d62e03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110572 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110965 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#134210 Import crop position of bitmap filled shape.Gülşah Köse2021-02-175-31/+121
| | | | | | | | | | Change-Id: I6a62d68cd0f57e53934851a2f53dae05bf7d3730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110262 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110964 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Avoid crash in online on a document with commentsAron Budea2021-02-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Crashed on a specific doc with the following backtrace: Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault. 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 71 const SwPostItField* GetPostItField() const { return mpField; } 0 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField() const (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 1 0x00007f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&) (this=0x557e1d985a10, rJsonWriter=...) at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337 2 0x00007f4823216534 in getPostIts(LibreOfficeKitDocument*) (pThis=0x557e1d93c890) at /.../libreoffice/desktop/source/lib/init.cxx:3425 ... Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110917 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update git submodulesAndras Timar2021-02-151-0/+0
| | | | | | | | * Update translations from branch 'distro/collabora/cp-6.4' to 0c8c6b0d6280466e025e5b5bcfb4d2db1399c871 - Translation update Change-Id: I394b633d4357e0e1661f70c457cbde1a15882a1a
* svx: fix import of multiple paragraphs into title shapesMiklos Vajna2021-02-152-12/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Title shapes try hard to have a single paragraph only, the Impress UI inserts linebreaks instead of paragraphs breaks in sd::FuText::KeyInput(), ever since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b (initial import, 2000-09-18). This matches the PowerPoint behavior. This is most visible when the paragraph has a bullet associated with it. Interestingly you can still put multiple paragraphs into title shapes using paste special -> plain text. In that case, it was inconsistent that we exported these multiple paragraphs to ODP, but merged them to a single paragraph on import since commit 0a783c1a041e2b74b7bf238d11ee2c303f6708f4 (#100190# don't allow more then one paragraph on title text objects, 2002-06-25). This results in loosing your bullets on save + open, both in the ODP and PPTX cases, since removeActionLock() on the XShape triggers this tweak. Also, PowerPoint does not do this merging on import. So fix the problem by removing the import-time tweak but leave the UI unchanged. (cherry picked from commit 043690eff82d5798774452a8364e1566b866a320) Conflicts: svx/source/unodraw/unoshtxt.cxx Change-Id: I6796f83c40e83f65cfb0f6c7e66069c3e08c1e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110935 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* tdf#130629 Don't add object insert undo twiceJim Raykowski2021-02-121-0/+5
| | | | | | | | | | | | | | | Change-Id: I074afd4397b6fc4631bd00655de56b8a154d7dff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105955 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 5110cca39cc55c8977b81f7b09873e626144b29b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105995 (cherry picked from commit 46d6effe3373a39938bde57b43dc45c4a30ce33f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110834 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* tdf#134210 Apply mirror property to custom cropped graphic.Gülşah Köse2021-02-115-4/+54
| | | | | | | | | | Change-Id: I5bf2ba8fa432af8b6a560cc60c18bef799834fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110039 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110663 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Don't shrink row height when deleting cell contents interactively eitherTor Lillqvist2021-02-114-7/+11
| | | | | | | | | | | | Follow-up to e763e13873adfe3c6abfa4c2dfd3ac3847e2d494. Such shrinking of row height, typically by a few silly pixels, just causes unnecessary invalidation thrash in a collaborative editing context. Change-Id: I5651ce994ba4bf82c83d7d4ef1bb8ed5bab0a66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110697 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Revert "on SelMouseButtonDown check if window pointer is not null"Caolán McNamara2021-02-111-1/+1
| | | | | | | | | | | | | | | | | because there is no pWin for the cases where an EditEngine is hosted in a native widget, e.g. comment in a sidebar in writer or format header/footer in calc's format page, header/footer, edit... and with change applied clicking doesn't move the cursor This reverts commit 0a2fa32f8756b3c99975df6d98736a8e9abb625a. Change-Id: Ie1da24d22b6d298f0c074f7bf187c5d891b78368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110648 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins (cherry picked from commit 2d154d55db925dfa20358faa0302d4d942496aee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110677 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* LOK: form field button: split SendLOKMessage() method.Tamás Zolnai2021-02-103-45/+44
| | | | | | | | | | Hiding form fiel button can be static. We don't need to know which fieldmark has the actual button. Change-Id: I3f7d52c0f11c7dfbb0b4f50bc0c7c0302f50d815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110711 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>