summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Flatpak: Upgrade to 21.08 runtime, disable SkiaStephan Bergmann2021-09-072-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For whatever reason, building Skia against the 21.08 SDK would fail with > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘void {anonymous}::colrv1_draw_paint(SkCanvas*, const FT_Color*, FT_Face, FT_COLR_Paint)’: > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:668:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’? > 668 | case FT_COLR_PAINTFORMAT_TRANSFORMED: { > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | FT_COLR_PAINTFORMAT_TRANSFORM > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:669:60: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’? > 669 | SkMatrix transform = ToSkMatrix(colrv1_paint.u.transformed.affine); > | ^~~~~~~~~~~ > | transform > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘bool {anonymous}::colrv1_traverse_paint(SkCanvas*, const FT_Color*, FT_Face, FT_OpaquePaint)’: > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:763:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’? > 763 | case FT_COLR_PAINTFORMAT_TRANSFORMED: > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | FT_COLR_PAINTFORMAT_TRANSFORM > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:768:74: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’? > 768 | colrv1_traverse_paint(canvas, palette, face, paint.u.transformed.paint); > | ^~~~~~~~~~~ > | transform > make[1]: *** [/run/build/libreoffice/solenv/gbuild/LinkTarget.mk:347: /run/build/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.o] Error 1 But including Skia in the Linux flatpak isn't too useful anyway (and just happened to be on by default): First, it is disabled by default on Linux, cf. UseSkia in officecfg/registry/data/org/openoffice/Office/Common.xcu. And second, on Linux it can only be enabled for SAL_USE_VCLPLUGIN=gen, but not for the gtk3 plugin that the flatpak normally uses, cf. OfaViewTabPage::UpdateSkiaStatus in cui/source/options/optgdlg.cxx. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121705 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4) Conflicts: solenv/flatpak-manifest.in Change-Id: Ifdc9c23676280caf19db0e9f09df15aaa21eef5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 92c55f7840267fdbe775897c913c5fc369286368) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121757 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Revert "tdf#142214: autocomplete: do not search across empty blocks"Ilmari Lauhakangas2021-09-063-73/+11
| | | | | | | | | | | | | | | | | | | This reverts commit ca2ec443893731093970914feb750b31ea13e47f. Breaks user experience. Removed ScTiledRenderingTest::testAutoInputStringBlock as well. Change-Id: Id03bc645d78c29c0aa588b2133fc1cb96f3cceb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121640 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> (cherry picked from commit 223f3a6fac43580114bca86abb34d7cf3219f4bc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121570 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#144289 invert / disable default OpenGL supportJan-Marek Glogowski2021-09-067-5/+8
| | | | | | | | | | | | | | | | | | | ... and as a result drop setting a default in SalSvpInstance. This is also more consistent: now you must explicitly implement CreateOpenGLContext() and set "m_bSupportsOpenGL = true". Change-Id: I591580bf134907213b8308e0843c278d2f470ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 50238bddf0e95169007cb90479cca86849a19007) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121635 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 824433168363b7e969c9adca6b636e016a66edb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121567 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
* Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown()Eike Rathke2021-09-033-7/+37
| | | | | | | | | | | | | | | | | | | | | | | | | Calling SvNumberformat::GetThousandDivisorPrecision() for a "AA "General format resulted in 3000 as that was implemented for tdf#106253 without taking into account that ImpSvNumberformatInfo::nThousand may be abused under some conditions, which here is having FLAG_STANDARD_IN_FORMAT = 1000 as nThousand, multiplied by 3 gives 3000. Subtracted from the 0 precision gave -3000 decimals for which of course the new rounding produced 0 where it previously simply ignored the decimals and returned the original value. Change-Id: I66afaf1e2d8b2654d9f7cc8cfb66389357fb742d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121447 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 71b003a12f8afdff42a25786ad0a12ddd6609d59) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121460 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#144105 crash after closing edit address block dialogCaolán McNamara2021-09-021-0/+1
| | | | | | | | | | | | | | use RemoveView to call RemoveDragAndDropListeners before shutdown to avoid RemoveDragAndDropListeners getting called during dtor and calling EditViewCallbacks::GetDropTarget on the destroyed host widget controller Change-Id: I63841b893d37d45cc44a0ffbaa534cf87c407615 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121278 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* update creditsXisco Fauli2021-09-011-2074/+2152
| | | | | Change-Id: I8fc0e8085dd647f3677554084a0de139a71e4367 (cherry picked from commit 2cfcc8d7c988631333998a78b4b40cb17b025fe7)
* tdf#144183: restore 'erase' that was accidentally droppedMike Kaganski2021-08-311-0/+1
| | | | | | | | | | | | | | | | | | | ... in d47ac2ebdb495b025eb26e17cbbe2509797c31f0 Change-Id: Ic4946b72a0ef599428af5b806754bda5f0906990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121282 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 638acd81979f24262c29dc12e0289d7fc38fcd8b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bcc8fa6c0e5bcb6ca0da74a02427cf07e2abd0e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121285 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Update git submodulesChristian Lohmaier2021-08-301-0/+0
| | | | | | | | | | | | * Update translations from branch 'libreoffice-7-2-1' to 3febaabc4aa8344193ac0a8f9213b6012124ca36 - update translations for 7-2/master and force-fix errors using pocheck Change-Id: I76dedce86c4402c3a3cbb4ad01c3cfaba8732f43 (cherry picked from commit 02e3dd80f5b066ff95b1769ad2a5c9651337a509) (cherry picked from commit a1920d052f3979cf66c7f7a836793ff6511d50aa)
* Sync flatpak-manifest.in with FlathubStephan Bergmann2021-08-301-0/+6
| | | | | | | | | | | | | | | | | | | | ...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/2add5864d55a5cbe376da8a342549a8dbf46387b> "Merge pull request #158 from flathub/extensions: Add an org.libreoffice.LibreOffice.BundledExtension extension point" Change-Id: I1a1515e8ece2d8aec83abb6c8775f784083573a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 65940d00f1b7788b6b4241bf33a10073993181db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121054 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 168a6cd06703936a8f021adaa82cf015eb90c2b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121062 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#144084 if not initialized default to FILEOPEN_SIMPLECaolán McNamara2021-08-262-2/+23
| | | | | | | | | | | | | | | | | | | | | | which is a problem since... commit 43335776cfc18cdc7addf33250cffc886d384186 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue May 11 17:21:47 2021 +0100 gtk[3|4] don't create File Dialog with buttons that need to be removed just create it without the offending buttons in the first place where we create without buttons because its hard, especially since gtk4, to remove unwanted buttons. Change-Id: Ib0337c412fa7e8210d3b1bf3261174c4ffac0a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121056 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* bump product version to 7.2.1.1.0+Xisco Fauli2021-08-261-1/+1
| | | | Change-Id: I7c1f469389f22e903a5a59bf1d530b3125c1125b
* Branch libreoffice-7-2-1Xisco Fauli2021-08-264-1/+1
| | | | | | | | | | This is 'libreoffice-7-2-1' - the stable branch for the 7.2.1 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.2.x release, please use the 'libreoffice-7-2' branch. If you want to build something cool, unstable, and risky, use master.
* tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape exportMike Kaganski2021-08-265-7/+94
| | | | | | | | | | | | | | | | | | This allows to export editengine columns to ODS. Alternatively, we could re-introduce chaining text attributes in XMLShapeExport ctor, which was commented out in commit d5b1e4827f8e6e0661563ec856cd80d926ba7b58 without explanation; but that would affect export from other modules as well (e.g., SdXMLExport::setSourceDocument sets up respective chaining in sd), so to be on the safe side, I do it only for ScXMLShapeExport. Change-Id: Iafee77b2b57e95031cfe1bbd2d43d7361a3e8469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120958 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit cfa931784082d38bb6b98058c5acccbaf9870710) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120989 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#144089: Revert "tdf#137737 i18n search: don't expand start/end with ↵Xisco Fauli2021-08-263-34/+2
| | | | | | | | | | | | | | | | | regex ^ or $" This reverts commit a511bffd67a9cebfdc878766581ac08c79d7ff51. Reason for revert: See https://gerrit.libreoffice.org/c/core/+/120981 Change-Id: If8a445448976a9963f76623d3d968b8d5e3d74dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120990 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121048 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
* tdf#143567: Distinguish bitmap vs. pattern fill styleKatarina Behrens2021-08-261-7/+3
| | | | | | | | | | | | | | | | | | | By the time fill style state change (SID_ATTR_FILL_STYLE) happens, the actual bitmap fill may or may not be known. If it is not known, it is impossible to tell whether it is a regular bitmap or a pattern. That's why this toolbar sometimes incorrectly reports bitmap fill instead of pattern one To solve the problem, we adjust fill style listbox selection only later, by the time we know for sure the fill IS a pattern Change-Id: I0aa95c49601d77dca29ab54ad4c056a76a90e049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120687 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 1b06e7e9e8c467de3450077fe8b90be6b7f73e4b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120991 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#142394 return to using CAIRO_OPERATOR_SOURCE in drawBitmapCaolán McNamara2021-08-261-0/+5
| | | | | | | | | | | | | | | | | | | | | since commit cd09fc9451897e6efedbf9f5e1d5b9bd96e65cb5 Date: Mon Mar 22 19:06:15 2021 +0100 do not enable mbSupportsBitmap32 for headless (tdf#141171) turned back off the mbSupportsBitmap32 support experiemented with in commit 86ea64f216819696cd86d1926aff0a138ace2baf Date: Fri Feb 15 13:14:32 2019 +0100 Support for native 32bit Bitmap in VCL and SVP (cairo) backend Change-Id: I818c3f11d0334278a65a0e45b61141327669121d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120727 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
* openssl: upgrade to release 1.1.1lMichael Stahl2021-08-261-2/+2
| | | | | | | | | | | | Fixes CVE-2021-3712, CVE-2021-3711 (not obvious if any of them affect LO) Change-Id: I98652348977a5a3c728f1d4fdf7293b76a93b630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121026 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 5c391f4346e86bd5d7528fbb42a3af64f98a03d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120986 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-4/+1
| | | | | | | | | | Change-Id: Icc09937594ddc97706a63bd11afe062a854ae8ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6097ea726dcc087694a600cf823761097e3ba13e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120978 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#128612: Support applying pattern fill from toolbarKatarina Behrens2021-08-252-26/+142
| | | | | | | | | | | | | | | | | List available pattern fills and add 'pattern' case to state and execute functions This is likely not perfect and there's still boatloads of code duplication that should be cleaned up eventually, but hey, it fixes the bug Change-Id: I3381a4271bb32a63c048cbecb0b54ebabe12ef51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119229 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit c1a8ff837e3e369561150c0022c6ab02aab27c2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120241 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#127978 - Don't URL encode filename for navigator's tooltip (D&D)Andreas Heinisch2021-08-251-1/+3
| | | | | | | | | | Change-Id: I3a5d6404755698be81818c4636fcc505992e1a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120936 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit a558be2393cf05a4ccf8b4af546207e69669eba2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120982 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-1/+1
| | | | | | | | | | | Change-Id: I69b76dd2aed35fe2038e61eef343ee8d84f053f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6f790c8b31360463670439e6857ea64f418ddfbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120972 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves tdf#143633 - Image size wrong after disabling relative image widthHeiko Tietze2021-08-251-0/+28
| | | | | | | | | | | | Adjustments added back, missing from 3cbecf3d0d9d68de286589e153ee31f8f709be03 Change-Id: Ia2f64fbf0792bd0916052c01e79b37d8820f8b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120940 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit dd5039ceea319ebfc72a3e032753b22538add12e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120983 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#141097 Revert "Veto process exit while an OLE client is connected"Michael Warner2021-08-255-89/+1
| | | | | | | | | | | | | | | | | | | | | | This reverts changes that were made to prevent process exit when an OLE client is connected. These commits had the side effect of preventing the use case of creating a document via OLE, and then allowing the user to view/edit and ultimately quit from the GUI. Revert "More hacks for quit requests from an OLE Automation client" This reverts commit 05e03911cd1f8a355b6410d3997cffc2c794a1e9. Revert "Veto process exit while an OLE client is connected" This reverts commit 89f883bd90a50587868a57397b6350ed9559a20f. Change-Id: I29a1e42a830815bc8d1ff0056c22d86b8f98cc1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118596 (cherry picked from commit 080e4550257a90597c241f83fd766b99c83ba6e8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120877 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#143959 sdext.pdfimport: fix font name with subtagKevin Suo2021-08-251-0/+9
| | | | | | | | | | | | | as returned by the font descriptor when reading the font file. Change-Id: I376b887e6356e765f669b41c43776f78f94c3623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120815 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120896 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-4/+5
| | | | | | | | | | Change-Id: I364368cf4f5cb68c03bbff81f42002f56e3e44af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4556dd0f9d154c9b71b009f6dcf9f3e54d9a4d85) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120976 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-4/+4
| | | | | | | | | | Change-Id: Iaecbdaa7a7ad61f8c657b0aa04fd30ee27699b72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8351081be79d0b9d61aae2a6eb328a11e2393c92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120975 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-3/+3
| | | | | | | | | | Change-Id: Ia7ceb0278117df6e140c04232bcfd366fbba3dd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 763996f29aef31f95c438738d081d9b361db36e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120979 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-1/+1
| | | | | | | | | | Change-Id: Ib020053b30ee7d7c0e335afac68f3a39e891cf2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a620516fbdddc93b85430081e83fe6cecd9f8d12) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120973 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-2/+2
| | | | | | | | | | Change-Id: I768cec434ee20e6e46eb3993c873bed05b3c9cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a0e92a64a9a6069ee21336888f3781ffe144b2df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120974 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#135164 add unit testJustin Luth2021-08-255-0/+63
| | | | | | | | | | fixed by tdf#143605, but that was a bit different, so adding a specific docx unit test. Change-Id: I9f5a6b225277f1c1fdbfed7759919b3fd6e5dea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121010 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#137737 i18n search: don't expand start/end with regex ^ or $Justin Luth2021-08-253-2/+34
| | | | | | | | | | | | | | | | | | | | | | | If the regex starts with ^, that means that it matches only at the beginning of the content. So don't expand the beginning of the content or else it won't match anymore. Similarly, $ indicates matching at the end of the content. For the unit test I just randomly guessed at SearchItem.AlgorithmType, and it kinda worked. I love black boxes... I hope I remember what i learned about TransformParameters() which was parsed in sfx2/source/appl/appuno.cxx, splitting the "variable" into Item.PropName = PropValue. That is definite black magic. Change-Id: Ie1640821a7a430e78dbe72c57a92aeaa9b5272a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120410 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a511bffd67a9cebfdc878766581ac08c79d7ff51) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120981 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#143957 Qt5 always create an OpenGLContextJan-Marek Glogowski2021-08-252-1/+10
| | | | | | | | | | | | Nothing checks the result and a lot of code just uses it. Change-Id: I1a672e98d42673fd684538ead831622f6a14e9f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120761 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 0f7fed9249e988ca34c5401d746887822b4aa9ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120776 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* VCL allow plugins to declare OpenGL supportJan-Marek Glogowski2021-08-2517-139/+34
| | | | | | | | | | | | | | | | | | ... and get rid of the whole GetBackendCapabilities, which was just overkill. Maybe this should even be some bitmap + enum + set/get function, but I'm too lazy... In the end add a bool for the OpenGL support of the VCL plugin (or maybe sticking it into ImplSVData, which is already some catchall for common VCL data). Change-Id: I9f0ececac482d8e2a94ef6024628e9631b49e773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9ca30cd1d04cf39411c3ede687805c28ebe2a980) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120775 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-2/+5
| | | | | | | Change-Id: I15d68391e20fba3a8ba46621aac0c831cd0900b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-1/+1
| | | | | | | | | | Change-Id: I4e592de5ff830aa970b96993c79a5d957f57adfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fe90f7fc34f8a6e354abbb48c21556d018fa768d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120977 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-251-1/+1
| | | | | | | Change-Id: I8bac670cb289d7b8636535c1b1fb2f4fc9f03afe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120891 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#143979 Write and read empty text element in number formatsEike Rathke2021-08-254-4/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | ... as they may be significant as separators between keywords of same letters. Also strip trailing empty text as meaningless, except if the only element. >General;General< earlier both General were written as <number:number-style style:name="N111P0" style:volatile="true"> <number:number number:min-integer-digits="1"/> <number:text/> </number:number-style> for which now <number:text> is not. Change-Id: I4809b1c784667994303b49d8e4ab0e857367e2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120856 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit c6f15d228489ccfd0628ca80b45a5c2faaacc7d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120728 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#143990: writer: default value for SetIncludeUpperLevels is 1Vasily Melenchuk2021-08-251-1/+1
| | | | | | | | | | | | | | | Same as in e08fba90 for tdf#143858: zero for SetIncludeUpperLevels has no practical sense, since actually this value is amount of levels to display. Default and minimal value is 1 (current level), zero used only in cases when there should be no numbering. Change-Id: I303386339a9e13944e11d0287c933523c7410b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 1fd9116fbcd1a8d25f964087cd1d0eb15df8a2d1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120889 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-241-0/+3
| | | | | | | Change-Id: Iea17e1d593f0003de3733722f619b10fbd90a303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120876 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* rhbz#1996735 SwEditShell::GetCorrection can return nullCaolán McNamara2021-08-241-1/+3
| | | | | | | | | | | Though the exact steps to reproduce are unknown. From the text seen in the backtrace the language is possibly Finnish in which case voikko is probably the spellchecking backend in use. Change-Id: I9b3186e4699946235ccc161575bba7d4a3820565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120878 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#142351 chart ooxml import: fix category axis cross positionBalazs Varga2021-08-243-5/+16
| | | | | | | | | | | | | | | | Set PROP_CrossoverPosition value regardless of the mrModel.mbAuto value, which is a different thing. This element specifies that this axis is a date or text axis based on the data that is used for the axis labels, not a specific choice. Change-Id: Ifa291aac2f4bb3981d968de3489b23f1af485104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120592 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e701732725dd641741f39020d7dc965bc4db765d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120875 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* arm: fix bridgeCaolán McNamara2021-08-231-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | which went a little wrong in commit dd91d3389c26645459d3b80649941d65efa4f63f Date: Sat Jan 2 14:36:44 2021 +0100 Fix some warnings for Raspberry pi 4 (part3) Change-Id: Ief7e1146b7480a1c16ec0810f991296710214332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120830 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> and... arm: nStackBytes was already the right amount of bytes regression from... commit 6e3424ca1131fe371f63e456267de476b5eb0eae Date: Sat Jan 2 11:03:12 2021 +0100 Fix some warnings for Raspberry pi 4 (part2) which changed that Change-Id: I9a19d7d6bc1e4115ffffbe32d8d62be5d275d500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120747 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: René Engelhard <rene@debian.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120831 Tested-by: René Engelhard <rene@debian.org>
* tdf#144022: make sure to create missing columns if neededMike Kaganski2021-08-231-3/+3
| | | | | | | | | | Change-Id: I1a0771fbe8023859ab29d8114303b62f6a3d539c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 23c1ec0d498124fbe275145d236db455f83cd850) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120872 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#102846 CSV: Detect separator, limit preview line concatenationsEike Rathke2021-08-204-25/+85
| | | | | | | | | | | | | | | | | | | | | | | In CSV import preview, if a line starts with a quote character and none of the remembered last field separators used occur in data in conjunction with a closing quote, then reading data tried to concatenate line by line to form a data field to be presented in the preview, worst case the entire file.. For the preview, detect one possible not yet selected separator if used with a quoted field (similar to commit c807e7ea7a0725a4d8375eda07d6f70870e0d50a for tdf#56910 space separator) and limit the number of source lines that are tried to be concatenated if no separator was encountered after a possibly closing field quote. Change-Id: Iefd37a8301161e72cb607cea88d4faadad47b4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120690 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit ff62e0165a0add7c7e3cb606df5b24b20c822d8a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120717 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* tdf#143624 PPTX: slideshow setting “Manual forwarding” not exportedTibor Nagy2021-08-203-0/+18
| | | | | | | | | | | | | Follow-up to commit f8ddaaf0f5e1fb61e0d4404ea28757bc652ae4be (tdf#142915 PPTX import: support for presentation's timing attribute). Change-Id: I1b175d406d2cd0fc40ba7085517709fb477fed58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120529 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120751 Tested-by: Jenkins
* tdf#142648 PPTX: import long slide names to avoid broken link exportTibor Nagy2021-08-203-3/+27
| | | | | | | | | | | | | | | | | | | | | | | | PPTX import renames the slides using their short title text. Apply this for the titles with 64 or more characters, too, abbreviating the title text instead of using the default slide name "page1", "page2" etc., because the default slide names result broken hyperlinks during the PPTX export. To test the fix manually, create a new hyperlink using text selection and Insert Hyperlink (Ctrl-K), clicking on Target in Document button on the Document pane, and selecting a slide name. Note: the problem still exists for the duplicated or newly inserted slides, which get default slide names. Change-Id: Iec1fab5a2ee862353766ed7e13b1501b3a325d0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118548 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120750 Tested-by: Jenkins
* ScriptForge - (SF_String) FIX misplaced brackets in _Repr()Jean-Pierre Ledure2021-08-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Next Basic code: Sub ReprNotPrintable() Dim a,b GlobalScope.BasicLibraries.loadLibrary("ScriptForge") a = "abc" & Chr(31) & "def" b = SF_String.Represent(a) End Sub gives a Basic runtime error « Invalid procedure call » when error handling is disabled. Reason: misplaced brackets in SF_String._Repr() when the argument contains a non-printable character. ScriptForge additional info : Location : String.Represent/2113 Invalid procedure call. Should give : b = "abc\x1Fdef" Bug fixed on master in commit https://gerrit.libreoffice.org/c/core/+/119824 Change-Id: I9d180de99c803a49a56c4c1b22847cfc5a1f9608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120748 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
* tdf#134569 writerfilter: move tableParaProps on table endLevelJustin Luth2021-08-193-0/+12
| | | | | | | | | | | | | | | | | | | | | | | The end-level of a table only comes at the ::finishParagraph of the FOLLOWING paragraph. So for table-in-table, it is necessary to move the paragraph properties captured during the paragraph to the correct table level's collection. This fixes 7.0 regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c and depends on prior commit related tdf#134569 writerfilter: negative means table end Change-Id: I83183f38e1cf68b7db09813ca1b4a2491e7b54e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120526 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 28a7fec1f6465f8bfee417d447eb2e684ffe040b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120587 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#143353 defer tip of the day until impress template dialog is goneCaolán McNamara2021-08-193-20/+57
| | | | | | | | | wait until that dialog is dismissed before showing the tip dialog Change-Id: Id0e7e28f09c5a9727e10eda55e468adb56bfda70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120677 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#143858: sw: default value for nInclUpperLevels is 1Vasily Melenchuk2021-08-192-4/+4
| | | | | | | | | | | | | | | | | | SvxNumberFormat::nInclUpperLevels (matches text:display-levels in ODF) bit incorrect in its name: is counts total amount of levels to display, including current level. So value "0" seems have no sense: display 0 levels in total? In UI you can't select less than 1 level and ODF standard (19.797) using 1 as a default. This looks plausable. Change-Id: I596386c7b3cc4370910cd0ff6e927e501179fbdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120458 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 37dd6e18f5cf498d230ffe8a0a395cfdf9625e0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120645 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2024-06-27 02:57:21 +0000