summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* svl: fix crash if user cancels/closes master password dialoglibreoffice-7-2Michael Stahl2022-05-061-1/+3
| | | | | | | | | | | | | (regression from d7ba5614d90381d68f880ca7e7c5ef8bbb1b1c43) Change-Id: I8bb9a967aefa2e88f05c23456a0dd1a090e1a5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133932 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbb8617ece6d946957c2eb96287081029bce530f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133864 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* update creditsChristian Lohmaier2022-05-061-1962/+1989
| | | | | Change-Id: Ib5064763e88ca90d1ad52c71f4ac920de3ae0274 (cherry picked from commit 40462e3e78e7beb7cd22c8825f473126d1c89ef8)
* Update git submodulesChristian Lohmaier2022-05-061-0/+0
| | | | | | | | | | * Update translations from branch 'libreoffice-7-2' to 44bb18fe95687126a8ef3ebbd3a1963bad6dd91f - update translations for 7.2.7 rc2 and force-fix errors using pocheck Change-Id: I12c38fe9c492443c83279486d655e192b00482a6
* libxml2: upgrade to release 2.9.14Michael Stahl2022-05-051-2/+2
| | | | | | | | | | | | Fixes CVE-2022-29824. Change-Id: I31d6ec794b01dee0bb17022ef2e18d2acd8255df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133813 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit f670422a01e7336ba8a554331f3781ec7f5c4e8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133831 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* sw: avoid one more EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli2022-05-041-2/+7
| | | | | | | | | | | | | | Seen in https://crashreport.libreoffice.org/stats/signature/SwTextFrame::PaintExtraData(SwRect%20const%20&) Change-Id: Ie6924254dca73360d384987834460a6f813e0d69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133691 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fae937b6859517bd9fe8e400cad3c84561ff98ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133716 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#148683 sw: fix crash on deleting text with redlining enabled, but hiddenMiklos Vajna2022-05-034-1/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Regression from commit 32902f66e7749b2d06d13f50416be5323a0c0ea9 (sw_redlinehide: make layout based Show/Hide mode the default, 2018-11-30), deleting some text in the middle of the paragraph with the bugdoc results in an assertion failure in the SwDrawTextInfo ctor. Normally this doesn't happen on text deletion as we already have a mechanism for truncating no longer needed lines in SwTextFrame::Format_(), though that only checks the length of the current line. Fix the problem by extending this mechanism to also check the remaining lines: if change tracking is on and the total of all line lengths is more than the string length of the text frame, then time to re-calculate. It seems this is not needed in practice when redlining is disabled, though we might want to enable this for the non-redline case as well in the future. (cherry picked from commit 515bf5d4afa3a8ed413fd6f17f66fa98b6dbf29e) Change-Id: Iede03e11daceb3c2b614a301e21560b075a60c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133684 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133693
* sw: avoid EXCEPTION_INT_DIVIDE_BY_ZEROXisco Fauli2022-05-031-1/+1
| | | | | | | | | | | | | | | | Seen in https://crashreport.libreoffice.org/stats/signature/SwBookmarkPortion::DoPaint(SwTextPaintInfo%20const%20&,rtl::OUString%20&,SwFont%20&,int%20&) Introduced by 4ce8120f1e53f7b81e653b01d141643013bc69ab "tdf#45589 sw: create and paint text portions for bookmarks" Change-Id: I7d025878164e1f97b86f9d129af9ba93e93b6ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133562 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7c8b9fa98f4c5f7f5620e797dbbe24081e252548) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133602 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* fix regression in linked bitmap importNoel Grandin2022-04-301-1/+1
| | | | | | | | | | | | | | | | | from commit 0527778df5f1ace8731043d070cf54b7b8648545 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Aug 21 13:19:36 2020 +0200 use fastparser for fill styles spotted dodgy code while doing other work Change-Id: I339e8fbdb9df4d5f17ded76de199a3282f7c2d6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d606b6bb3e03467fb66a19f0acb85e46b0d4ff41) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133599
* update creditsChristian Lohmaier2022-04-271-2077/+2136
| | | | | Change-Id: I5d60bff321a20a0d8f8b05af7ea58c7ebbbba1b7 (cherry picked from commit fc12d6b962bf3b34501fe656e1cf9fefbd944332)
* tdf#148654 stop playing sound with presentation endsCaolán McNamara2022-04-261-0/+2
| | | | | | | | | | Change-Id: I74aa4cd966b6966f7826d241fcf9bb9d64955464 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133394 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 83bda568df0c6a65337922e20b6c7b74e20db415) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133406 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodesMichael Stahl2022-04-262-0/+56
| | | | | | | | | | | | | | | | ... in SwTextNode::JoinNext(). The 2nd node is deleted, so its frame is deleted, and if it is the start of a merged frame, fly frames on the node itself will be recreated already, but those on subseqent nodes need an extra call. Change-Id: I18999946334f5560b720d3d275610bc8b07973f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133335 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 98ae340307786c8fe18addc3714c9b859fdf12dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133293 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* tdf#148620 Crash in Draw using Format > Lists > Move DownNoel Grandin2022-04-2511-387/+428
| | | | | | | | | | | | | | | | | | This reverts commit 35f03f26799747894d1534796b6cb227bd4f233b speed up loading large ODS a little since ImpEditEngine::ImpMoveParagraphs wants to manipulate ParaPortion's and also identify them by pointer Also convert the OSL_ASSERT in this method to an assert to catch such problems earlier Change-Id: Id924d00c9524223db9a96e487b331ce60e3a4fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133300
* sw: layout: fix crash when deleting page with section being formattedMichael Stahl2022-04-213-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This crashes only when calling storeToURL() with writer_pdf_Export? There is a text frame 112, followed by section frame 126, which contains table frame 127. The section frame 126 is being formatted, which in SwFrame::PrepareMake() formats its prev, text frame 112. This does MoveBwd() and in SwContentFrame::MakeAll() formats its next, tab frame 127. This also does MoveBwd() and then there is this really odd condition in SwTabFrame::Paste() where it calls SwFrame::CheckPageDescs() if it *doesn't* have a RES_PAGEDESC item and the page has a non-default page style - this condition remains inexplicable since initial CVS import. Then CheckPageDesc() sees the (next) page is empty and deletes it. So check in sw::IsPageFrameEmpty() that there aren't any sections with IsDeleteForbidden() set. (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I3c64fe40fabffc255c4146a35c678ce6a1cc09c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133222 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 85aa57359befd7a21b3fdf36f2b362f50495f77c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133151 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* bump product version to 7.2.8.0.0+Christian Lohmaier2022-04-191-1/+1
| | | | Change-Id: I98a016d2477e18e4f5d02cc1e9c6db777de98871
* Update git submodulesChristian Lohmaier2022-04-191-0/+0
| | | | | | | | | | * Update translations from branch 'libreoffice-7-2' to f7d6d5069dfea2692c2a53f7b2fc0045b748a456 - update translations for 7.2.7 rc1 and force-fix errors using pocheck Change-Id: If9216a8bfc693e61595f984567a9dce55ce9dd6f
* tdf#142151: Red cast rendered in 16 bit TIFF imageJulien Nabet2022-04-181-2/+2
| | | | | | | | | | | | | | | I found this fix by testing "pure" red/green/blue files (see attachments in the bugtracker) where red 16 bits file was ok but not green and blue 16 bits ones. Change-Id: Ic700a0fa17c3056d1d4f1d1a7f16a799ff4c7378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133108 (cherry picked from commit 49ee1c889665c3539fa9a1c99a865a42fc08ee97) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133051 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit 1af0bf010b839b7b34e856dfc5a7385db45c9aa7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133053 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#143615 clamp relative times to 1.0Thorsten Behrens2022-04-151-3/+9
| | | | | | | | | | | | | | | User input permits zero-length animations, so whenever we calculate relative position within the animation time frame, the case mnMinSimpleDuration == 0.0 means: we're already at the end of the animation, i.e. set relative time to 1.0 Change-Id: I0e8c1e29f47bd9fa16f04115cf52d3a176e13fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133005 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit e1db8c27875eac73b1e619e4a23ecdb7a9924b61) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133039 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#148052 accept a ". Month " name for matching DMY formatEike Rathke2022-04-131-0/+23
| | | | | | | | | | | | | | | | ... even if the locale doesn't define such DM order or LongDateDaySeparator. Change-Id: I4bef720dff3582de9b60313824a84b570c153e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132741 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 7a16002ede5fd31ae8f3358136ad49de40465ac1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132703 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 29f7b81afcf2e21c88c38fbae31fb463b26040c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132859 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz#46352 assert on bad string offsetCaolán McNamara2022-04-131-1/+1
| | | | | | | Change-Id: I60123fd0460b8038f08582a0bcbf2307af321df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132862 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* an inconsistent SwTextFormatInfo index, len, text length caseCaolán McNamara2022-04-121-3/+11
| | | | | | | | | | | | | | | | | | | | | | seen on loading sw/qa/python/testdocuments/TESTMETA.odt maybe since: commit 2f3684b2289a8c46dc6144064a452cc529400f28 Date: Tue Jul 31 16:00:02 2018 +0200 [API CHANGE] add some more asserts to the string functions but probably an underlying issue since conversion from UniString to OUString Change-Id: If731163fbc5e05b813ccd21df65164fe476cba9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit eb7fbe1f3a37d89b97bd8976bdc006099578c204) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132860 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz: Use-of-uninitialized-valueCaolán McNamara2022-04-121-1/+1
| | | | | | | Change-Id: I87cfad2da9b90bc4487dc4deb2fda5bb31a6b763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132857 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* ofz#46526 AbrtCaolán McNamara2022-04-121-1/+1
| | | | | | | Change-Id: Iaec536b0989c4ec11b39b1534c7798e46715d7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132710 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* nss: depend on zlibMichael Stahl2022-04-081-0/+4
| | | | | | | | | | | | | Required on WNT since 1c748fefc3c5b42e3548a1a7f5017a579982005a, may be needed on other platforms if using --without-system-zlib. Change-Id: Ib8e544d81881f425d257514fc475e272ca2e53ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132648 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins (cherry picked from commit b11a5d3900e3c19e94833c1b1e5218288320c3e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132609 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#146174 allow shortcut key event handling before menubarVincent Reher2022-04-071-6/+14
| | | | | | | Change-Id: Ib0dadafcc66604baf53169cb222a059ee3f97362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132602 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* forcepoint#100 drop SwBorderAttrAccess to allow cache entry to be removedCaolán McNamara2022-04-041-16/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for SwBorderAttr which gets deleted during this call also includes... Related: forcepoint#100 we don't need pAttrs for the duration of the full scope similar to the case of commit 6b1eae0334ba8bad7656a859695551ce51b62f95 Date: Fri May 18 08:26:14 2001 +0000 Fix #87058#: Locked boraderattribut the SwCache object cannot be deleted if its locked, leading to a leak, we don't need pAttrs for the entire scope here so we can defer to the end of the scope the reacquire the lock to set pAttrs and also includes... Related: forcepoint#100 don't reacquire after every release instead release when we have to, and only reacquire if necessary before use of pAttrs Change-Id: Ie52aab7e5933d76b0c055389798104e4d93f39e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132462 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
* forcepoint#95 read past end of malformed documentCaolán McNamara2022-04-042-4/+20
| | | | | | | | | | Change-Id: I8b2c558c733af3d7662f668af47e962e252ee339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0b9892fee990b7f6d0457ab6191f87c3991580e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132414 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* forcepoint#87 Assertion 'mp_char <= mp_end' failedCaolán McNamara2022-04-042-0/+28
| | | | | | | | | | | Change-Id: I434928cb2425a2e8eb9440dff67f52cda241b2d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 32019baffa19a8f79cacf93d5dd5a95c7d416657) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132413 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#83 forcepoint#84 update to upstream fixCaolán McNamara2022-04-042-16/+16
| | | | | | | | | | Change-Id: I5add09b4379a1f86a720af75b758389424f4f50b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132055 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2323fa29617e4919226517d50abbb9ad33b320ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132412 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* add Initialization Vectors to password storageCaolán McNamara2022-04-023-47/+148
| | | | | | | | | | | | | old ones default to the current all zero case and continue to work as before Change-Id: I6fe3b02fafcce1b5e7133e77e76a5118177d77af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131974 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 192fa1e3bfc6269f2ebb91716471485a56074aea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132306 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* Accept macOS SDK 12.3Tor Lillqvist2022-04-011-3/+12
| | | | | | | | | | | Change-Id: Ice469236dd79675b6fad6f7c5a244888200fea8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131565 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131975 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132436
* zlib: upgrade to release 1.2.12Michael Stahl2022-04-013-17/+2
| | | | | | | | | | | | | | Fixes CVE-2018-25032 external/zlib/ubsan.patch: remove, fixed upstream Change-Id: I2aa9a9008b9cf7efd970c5fff0df7029204204f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132358 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bfb6c4c65781a610d21409d974227d73f264f41a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132192 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* nss: build with zlib module on WNTMichael Stahl2022-04-012-2/+7
| | | | | | | | | | Change-Id: Ie875b4a8df1697de83a8f22cb1170a49792c47e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132367 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 1c748fefc3c5b42e3548a1a7f5017a579982005a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132376 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#84 Invalid read of size 1Caolán McNamara2022-04-012-0/+44
| | | | | | | | | | Change-Id: I1d0d74940cfa78a3c88cee737c9535acf03e0f19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131991 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d6a02a99eaa3690c0aa5c33fea3a4c710813a0de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132315 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* add infobar to prompt to refresh to replace old formatCaolán McNamara2022-03-313-0/+41
| | | | | | | | | | | Change-Id: Id99cbf2b50a4ebf289dae6fc67e22e20afcda35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131976 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bbd196ff82bda9f66b4ba32a412f10cefe6da60e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132307 Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* forcepoint#82 back() called on empty vectorCaolán McNamara2022-03-292-0/+30
| | | | | | | Change-Id: I8017777a58f1fef41d1545899868e333c2184c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131867 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* forcepoint#83 Invalid read of size 1Caolán McNamara2022-03-292-0/+39
| | | | | | | Change-Id: I1576dfd8c9731d943107764aeb66bb1c2294ad5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131989 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* forcepoint#86 RES_TXTATR_UNKNOWN_CONTAINER item put at invalid indexCaolán McNamara2022-03-291-1/+1
| | | | | | | | | | RES_CHRATR_BEGIN is 1, presumably RES_TXTATR_UNKNOWN_CONTAINER should be stored in the last index Change-Id: Id37fff41cbbccbc26fe5ccce6027014af7362729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132040 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#147014 Image missing due to integer overflowAron Budea2022-03-283-5/+36
| | | | | | | | | | | | | | | | | | | | 32-bit awt::Point/Size/Rectangle cannot fit size of 1M rows with larger (eg. 5x the usual) height, and could overflow. This causes problems in 64-bit Linux builds and, since the following commit, in 64-bit Windows builds: 3d90997fb6f232d8008df4d166d7b97b869c200f For now, clamp possibly overflowing values to 32-bit. Change-Id: Ifda7265703388abdfb47f523da4f0c5822358404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129876 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132205
* forcepoint#85 Conditional jump or move depends on uninitialised valueCaolán McNamara2022-03-281-1/+2
| | | | | | | | | | | | | | | | ==398461== by 0xCDC7960: (anonymous namespace)::CopyUntil(char16_t*&, char16_t const*&, char16_t, bool) (strhelper.cxx:88) ==398461== by 0xCDC839F: psp::WhitespaceToSpace(rtl::OUString const&, bool) (strhelper.cxx:294) ==398461== by 0xCB54980: vcl::PDFWriterImpl::setOutlineItemText(int, rtl::OUString const&) (pdfwriter_impl.cxx:9875) ==398461== by 0xCB547FF: vcl::PDFWriterImpl::createOutlineItem(int, rtl::OUString const&, int) (pdfwriter_impl.cxx:9851) ==398461== by 0xCAF39B0: vcl::PDFWriter::CreateOutlineItem(int, rtl::OUString const&, int) (pdfwriter.cxx:383) ==398461== by 0xCABD7C8: vcl::GlobalSyncData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:250) ==398461== by 0xCAC0628: vcl::PDFExtOutDevData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:616) ==398461== by 0x3D06EA0F: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:1004) Change-Id: I6bc086997851ee06531a4a9ae263e2b26edfba84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132036 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz: ensure unsigned indexCaolán McNamara2022-03-281-6/+6
| | | | | | | Change-Id: I38d6238a6eede0188f942229b2fb931614e56309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132043 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* make hash encoding match decodingCaolán McNamara2022-03-254-3/+54
| | | | | | | | | | | | | | | Seeing as old versions of the hash may be in the users config, add a StorageVersion field to the office config Passwords section which defaults to 0 to indicate the old hash is in use. Try the old varient when StorageVersion is 0. When a new encoded master password it set write StorageVersion of 1 to indicate a new hash is in use and use the new style when StorageVersion is 1. Change-Id: I3174c37a5891bfc849984e0ec5c2c392b9c6e7b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132080 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* warn on too many rows/column when loading ODSLuboš Luňák2022-03-243-3/+20
| | | | | | | | | | | | There's a warning when loading XLSX, but not when loading ODS. Now that 7.4 is going to support 16k columns, that would be a useful warning, either if we raise the limits again, or backported to 7.2/7.3 . Change-Id: I204bca32e1ff37332b86361d3d81d3fee29c15ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131945 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
* tdf#147641 default font size for captions always resetNoel Grandin2022-03-241-3/+3
| | | | | | | | | | | | | | | | | regression from commit 65d2d2647ead42e5bbb7800f14c047f383fe450b Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Nov 8 16:10:51 2018 +0200 loplugin:singlevalfields in sw where I incorrectly reduced a boolean expression Change-Id: I7f3b4552dc27dcd5e118233b5c0ca75e4eb06fc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131980 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 323ff2749b6be5f6ef98c6250afce4fa89e3aa1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131995 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* update creditsChristian Lohmaier2022-03-231-1511/+1509
| | | | | Change-Id: Id548d2a8260dd8ab23b68781c99cca6b983d52c1 (cherry picked from commit 66dea2b9ba257c8e3e1baec9adbc37afd0eca910)
* update creditsChristian Lohmaier2022-03-231-1916/+1961
| | | | | Change-Id: Iae73e10952fcb87e9fe24a5d053bc3ab554b688e (cherry picked from commit 4ac4d643425c26870bd6e0bac26bb5896186875c)
* Call corresponding base class method in SpellDialog::DeactivateMichael Weghorn2022-03-211-1/+1
| | | | | | | | | | | | | | | | | | At a quick glance, the fact that `SpellDialog::Deactivate` previously did the same as `SpellDialog::Activate` looks like a copy-paste mistake; both were added in commit 5261417cbb3051b812164838d19c0f748573df45 Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog Change-Id: Ib06d19e46470141d5bfcfc7e790160c1879b6a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 5aa42d256fa5081d79da3eb21ddd8000d7b6cc1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131861
* Resolves: tdf#148054 Advance offset for all columns, tdf#104927 regressionEike Rathke2022-03-211-28/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | Regression from commit 621c189173b35ac7f5ce4c578f57045479c63ab6 CommitDate: Sat Jan 9 05:13:55 2021 +0100 tdf#104927 consider character width for CSV import that for fixed width introduced a visual count of character widths for CJK IVS characters but did not advance the character offset for skipped hidden columns. Instead of having to ask bDetermineRange three times in the loop, split off an extra loop for bDetermineRange, advancing the offset then is straight forward and just only non-skipped columns are extracted and written to document. Change-Id: Ib6ab6b68c5fc0f6ff854d629d75742c39ed6ddf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131722 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6b768542ddd52573bbdb0e7b5b85ce5a9dd4551d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131606 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#135220 sw: fix layout after SwUndoDeleteMichael Stahl2022-03-171-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The bugdoc is 398 pages after initial load and 397 pages after Undo. There is really only one problem, on page 6 the fly frame 7370 "Figure 3: Hay Rake in Weeds" anchored on SwTextFrame 5896 should be on page 7 and aligned to the top of its paragraph. First, 5986 moves forward from page 6 to 7, hitting the condition added in commit c799de145f7e289f31e3669646e5bd12814e6c5e debug:1170918:1170918: SwObjectFormatterTextFrame::CheckMovedFwdCondition(): o_rbPageHasFlysAnchoredBelowThis because next chain on same page Then 5986 moves back to page 6. When it is formatted there, the ConsiderObjWrapInfluenceOnObjPos() is true, preventing a formatting of the anchor frame - so it does not move forward. The flag SetTmpConsiderWrapInfluence(true) was set the first time (when it moved forward). Setting this flag for any anchor frame that moves forward was added in 2005 in commit 46297c0923c50a12510c7b15b725c8d2fd80f9c0 and apparently the only way the flag is cleared is when SwDoc's SetModified() is called (or the frame is in a table or column). So it is similar to the InsertMovedFwdFrame() case that was addressed by commit c799de145f7e289f31e3669646e5bd12814e6c5e in that the flag should not be set if bPageHasFlysAnchoredBelowThis is true. (reportedly regression from sw_redlinehide commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Change-Id: I27b2a1becf5f7a760e74e801e23472116d0a5ced Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131560 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit d9e38d5830ac278d7180b96fb6cefe3ee8ef6d76) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131591 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* hwpfilter: why isn't that path string null terminatedMichael Stahl2022-03-171-0/+1
| | | | | | | | | | Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4c86ed851bc1c0a2414e254082064760c99437f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131593 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* Related: tdf#128610 Avoid use-after-freeMike Kaganski2022-03-151-17/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Creating SvMemoryStream from string makes it non-owning, i.e. pointing to the string's memory. So the string must outlive the stream. Since commit 64bc8b45b5c23efc5fe57585a69aa4263aaf4e83 Date Wed Jul 08 12:31:43 2015 +0000 i#107734 Support for Math Input Panel in Windows 7 Was only working by chance, when destructor didn't clean the memory (e.g., in optimized release builds) and the released memory hasn't been reused yet. Change-Id: I2e0c195de7bd2aff2889a94ef0f2eb084411933f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131373 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit c964700d16d99d1569373a1eb9a1352fb3512915) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131474 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131541 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2024-04-18 21:06:40 +0000