summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* bump product version to 7.2.2.2.0+libreoffice-7-2-2Christian Lohmaier2021-10-061-1/+1
| | | | Change-Id: I685592214b8a1caf3730f417f09dd5202ab55b32
* update creditsChristian Lohmaier2021-10-061-2043/+2087
| | | | | | Change-Id: I434832c8b4395e8a8e0df44ad056e07cce6585d4 (cherry picked from commit 372005419f68eff13f526b3f1bf4a344370ef4c2) (cherry picked from commit f5e4dbfccdbc0d810cf82c52f14801dddf95631a)
* tdf#144122, tdf#144305 Revert "sw: allow the height of a line...Aron Budea2021-10-0622-137/+89
| | | | | | | | | | | | | | | ...to be larger than 65536 twips" Revert in libreoffice-7-2 due to hard to detect underflows introduced as a side-effect of the type changes. This reverts commit 301278b656e76b6f42af5cf8a6f5c6c02acfffeb. Change-Id: I0e10b4b56155c24314b84b34e8ce0bfa1999dd36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123095 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Revert "sw: eliminate recently added static_cast<SwTwips>() calls"Aron Budea2021-10-0611-26/+26
| | | | | | | | | | | | | Needed to revert 301278b656e76b6f42af5cf8a6f5c6c02acfffeb in libreoffice-7-2. This reverts commit 9e075acf2bf1ce6c43fdf5b601507ee0663bd691. Change-Id: I79460e19dadc5a9def5b0ee89cd1cbb5c3ad699c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123094 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Partially revert "sw: replace most static_cast<sal_uInt16>()...Aron Budea2021-10-0611-45/+45
| | | | | | | | | | | | | | | | ... calls with o3tl::narrowing()" Only the changes that enable 301278b656e76b6f42af5cf8a6f5c6c02acfffeb to be reverted easily in libreoffice-7-2. This reverts commit 2634bc59092b24217d984a5845365d703bdb08d2. Change-Id: Id43bcb8eb386d8aa49a6a0c3768abfc916cce717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123093 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Revert "sw: allow the width of a line portion to be larger...Aron Budea2021-10-069-65/+14
| | | | | | | | | | | | | | | ...than 65536 twips" The originating 301278b656e76b6f42af5cf8a6f5c6c02acfffeb will be reverted in libreoffice-7-2. This reverts commit 6fdd0a3f8b3448a9a246496191908c92156cc38b. Change-Id: Ia4f231af90d17eeaa0db4272c8a80e48181647dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122945 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Revert "tdf#144305 sw: fix rendering of ruby portions with...Aron Budea2021-10-065-74/+2
| | | | | | | | | | | | | | | ...non-default ruby alignment" Causing 301278b656e76b6f42af5cf8a6f5c6c02acfffeb will be reverted in libreoffice-7-2. This reverts commit 168065841250c190808261cf65afa00f9ecd52e7. Change-Id: I9b23c9a1980c4ed06cc0c53086ad24f00e75053a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122944 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Update git submodulesChristian Lohmaier2021-10-051-0/+0
| | | | | | | | | | | * Update translations from branch 'libreoffice-7-2-2' to cab374bf80b36168abbeb69d193df3dc0450a2d9 - update translations for 7.2.2 rc2 and force-fix errors using pocheck Change-Id: I5753b612a06c959fa5646398a70e5ce98c6b0da9 (cherry picked from commit 37818c93f0c285186fd747e703086eafe184e1c5)
* Resolves: tdf#140992 Paste/Cut should mark Edit as modifiedCaolán McNamara2021-10-011-2/+10
| | | | | | | | | | | | Change-Id: Id56b5bf2e922394da7e730f4bab652808253c54e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122857 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 236419fb117ce8cd96d181f0b1050d7bb6020a06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122871 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#144783 shift+RETURN not searching backwardsCaolán McNamara2021-09-302-5/+3
| | | | | | | | | | | | | | | | In gtk nothing is happening, in gen its searching forwards. Align backends so that Activate is emitted only on a bare return in both and then handle shift+RETURN explicitly for the search widget Change-Id: I142002bbaf6b3aca83800a442096a4b1024fe097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122748 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fdfa78e4c9f6087f38720c60373548f0a6481563) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122751 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#144139 checkboxs in print output shouldn't be themedCaolán McNamara2021-09-302-1/+97
| | | | | | | | | | | | Change-Id: Ibbde5d64595d2fec1fa63756d628cf295dcdbb78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122792 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 8230731a4201419f32e80b22a576e8b2e1350277) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122746 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#144184 sc: fix first page footer exportDaniel Arato (NISZ)2021-09-293-1/+37
| | | | | | | | | | | | | | | | | | | | | Due to a typical case of copy-paste oversight LO Calc used to lose the first page footer when exporting to ODS. With the typo fixed, the export now works again. Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388 "tdf#121715 XLSX: support custom first page header/footer". Change-Id: If8f5ab4ff9a9392768789b886218d1d9c56ddbae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122455 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122764 Tested-by: Jenkins (cherry picked from commit ccd1393611ff7ea71d2dc5d75b0c27a4794ebdbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122742 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* ofz#39304 short timestamp recordCaolán McNamara2021-09-291-5/+8
| | | | | | | | | Change-Id: I8f783473dd5d4679846c7c866cd1853ef7d919fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122645 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* ofz#39301 month has to be in range [1-12]Caolán McNamara2021-09-291-3/+6
| | | | | | | | | Change-Id: I5a4ca534b24098342d8f465a32bc1887f40f5b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122646 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Resolves: tdf#144740 Fix broken compareByValue() query, tdf#142910 tdf#144253Eike Rathke2021-09-294-41/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix regression of a series of commits that, intended for filter queries, unconditionally round numeric values as shown under ScTable::ValidQuery() and compareByValue() without having taken into account that the same query and compare functions are used by the interpreter for all functions that use query criteria, possibly delivering completely wrong results including in backports to 7.2.0.0 commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d CommitDate: Wed Jul 7 17:44:46 2021 +0200 tdf#142910 sc filter: fix "greater than" or "smaller than" etc commit 51375b48378915b6e95c1ac26b2ccf8e39880f7e CommitDate: Tue Sep 21 11:06:35 2021 +0200 tdf#144253 tdf#144324 sc filter: use formatted values in filters Several related and intertwined commits in filter context make assumptions about these queries always being executed rounded, so the only clean solution is to make that depend on the ScQueryEntry::Item being passed. Its mbRoundForFilter value is set to true for all items of all queries executed via ScTable::Query() and ScTable::GetFilteredFilterEntries(). It might be not all are necessary (or some even still harmful?) and unnecessarily obtaining number formats and calling RoundValueAsShown() is still a bottle neck for those, but that should be addressed and reworked independently. The important part is calculations work as before. Also, moved obtaining number formats for calling RoundValueAsShown() into logic that calls them only if necessary. Note the TODO in compareByValue() about suspicious rounding of rItem.mfVal in filter context that is to be addressed. Change-Id: Ieb178ad1ea15a635caeb1ba698c2f4b7ad676d57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122729 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b60b6bfaafa1315e07108dba50f016975b619c59) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122736 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#144729 create FrameSelectorImpl before setting size requestCaolán McNamara2021-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gtk wan't to update some a11y info when we set the new size request but we haven't created the requirements that a11y needs yet. Just move that creation to before the set_size_request #0 std::__cxx1998::vector<svx::FrameBorder*, std::allocator<svx::FrameBorder*> >::size() const (this=0x720) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_vector.h:919 #1 0x00007fbd40f3fcc2 in svx::FrameSelector::GetEnabledBorderCount() const (this=0x91bafd0) at svx/source/dialog/frmsel.cxx:858 #2 0x00007fbd40da76b8 in svx::a11y::AccFrameSelector::getAccessibleChildCount() (this=0x921b190) at svx/source/accessibility/AccessibleFrameSelector.cxx:63 #3 0x00007fbd3184930e in AtkListener::updateChildList(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&) (this=0x91e6200, pContext= uno::Reference to (svx::a11y::AccFrameSelector *) 0x921b1f0) at vcl/unx/gtk3/a11y/atklistener.cxx:149 #4 0x00007fbd31849096 in AtkListener::AtkListener(AtkObjectWrapper*) (this=0x91e6200, pWrapper=0x91e60a0) at vcl/unx/gtk3/a11y/atklistener.cxx:56 #5 0x00007fbd3186e9ab in atk_object_wrapper_new(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, AtkObject*, AtkObject*) (rxAccessible=uno::Reference to (svx::a11y::AccFrameSelector *) 0x921b230, parent=0x9299a40, orig=0x90bedd0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:875 #6 0x00007fbd318b3ded in (anonymous namespace)::GtkInstanceDrawingArea::GetAtkObject(_AtkObject*) (this=0x91e5060, pDefaultAccessible=0x90bedd0) at vcl/unx/gtk3/gtkinst.cxx:16918 #7 0x00007fbd318b3d21 in (anonymous namespace)::drawing_area_get_accessibity(_GtkWidget*) (pWidget=0x91206f0) at vcl/unx/gtk3/gtkinst.cxx:21555 #8 0x00007fbd30fb0bc2 in () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0 #9 0x00007fbd3764b65f in g_closure_invoke () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #10 0x00007fbd3765d99b in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #11 0x00007fbd37663c6f in g_signal_emit_valist () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #12 0x00007fbd376641df in g_signal_emit () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #13 0x00007fbd3764fcd4 in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #14 0x00007fbd3764f50e in () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #15 0x00007fbd37651d4b in g_object_thaw_notify () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #16 0x00007fbd318b86d5 in (anonymous namespace)::GtkInstanceWidget::set_size_request(int, int) (this=0x91e5060, nWidth=137, nHeight=146) at vcl/unx/gtk3/gtkinst.cxx:3475 #17 0x00007fbd40f3fa23 in svx::FrameSelector::SetDrawingArea(weld::DrawingArea*) (this=0x91bafd0, pDrawingArea=0x91e5328) at svx/source/dialog/frmsel.cxx:833 #18 0x00007fbd3d16d46a in weld::CustomWeld::CustomWeld(weld::Builder&, rtl::OString const&, weld::CustomWidgetController&) (this=0x90e9fd0, rBuilder=..., rDrawingId="framesel", rWidgetController=...) at vcl/source/app/customweld.cxx:28 #19 0x00007fbcf08f0c4e in SvxBorderTabPage::SvxBorderTabPage(weld::Container*, weld::DialogController*, SfxItemSet const&) (this=0x91baeb0, pPage=0x90fc550, pController=0x7a4d4b0, rCoreAttrs= SfxItemSet of pool 0x5aea070 with parent 0x5b25658 and Which ranges: [(1, 45), (63, 132), (153, 153), (1014, 1033), (10023, 10023), (10050, 10055), (10057, 10058), (10065, 10065), (10179, 10183), (10451, 10451), (10457, 10457), (10467, 10467), (10591, 10591), (10855, 10855), (11142, 11142), (12065, 12065), (21123, 21123), (21307, 21307), (22401, 22401)] = {...}) at cui/source/tabpages/border.cxx:291 #20 0x00007fbcf08fc77f in std::make_unique<SvxBorderTabPage, weld::Container*&, weld::DialogController*&, SfxItemSet const&>(weld::Container*&, weld::DialogController*&, SfxItemSet const&) (__args=@0x7ffdac0324e0: 0x90fc550, __args=@0x7ffdac0324d8: 0x7a4d4b0, __args=SfxItemSet of pool 0x5aea070 with parent 0x5b25658 and Which ranges: [(1, 45), (63, 132), (153, 153), (1014, 1033), (10023, 10023), (10050, 10055), (10057, 10058), (10065, 10065), (10179, 10183), (10451, 10451), (10457, 10457), (10467, 10467), (10591, 10591), (10855, 10855), (11142, 11142), (12065, 12065), (21123, 21123), (21307, 21307), (22401, 22401)] = {...}) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/unique_ptr.h:962 #21 0x00007fbcf08f514f in SvxBorderTabPage::Create(weld::Container*, weld::DialogController*, SfxItemSet const*) (pPage=0x90fc550, pController=0x7a4d4b0, rAttrSet=0x7dca0e0) at cui/source/tabpages/border.cxx:592 Change-Id: I7325970bf0137602007e453e8b7fc43f1e6f36c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122637 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 2b96bf1fd8f4287a06b79dbec14114ca6c035731) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122638 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#144585 Qt5 restore old VCL popup handlingJan-Marek Glogowski2021-09-264-34/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So while it works with X11, the Wayland situation seems much worse. Eventually we want to use Qt::Popup as a window type, because that implies special handling for Wayland, but the additional private Qt mechanisms this implies conflict with VCL handling, especially input + focus handling with ComboBox. I'll re-check (again) how Qt itself implements this and maybe that solution is adaptable to VCL. This re-introduces the problem, that "DropDown/PopUp stays open and in FG when changing app on Linux desktop (keyboard, ALT+TAB)", original reported as part of tdf#143114, which is some kind of kf5 catchall bug report. Just revert for 7-2. Hope we find a better solution on master, which can be backported later. This revert includes: - "tdf#144037 Qt5 just close popup with mouse outside" commit 7c1f4284562e905372b5c14b6017f1eb438f54b5 - "tdf#143580 Qt5 don't use Qt::Popup for FLOAT wins" commit ea2f19827db330a21c7962bdd13b1b838821bd4c - "Qt5 fix Qt::Popup window handling" commit 7e6fee830116823b9cd8e46d6962df4ea2bc1ea6 Change-Id: Ibf56187e00232f6c75cdbbc82ce915f80214a136 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122356 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit a928bab9fb68ff8fe45aca212b3c794799db31f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122449 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann2021-09-241-3/+3
| | | | | | | | | | | | | | | Change-Id: I3d97bbc023dee481420cc1fda8f36f4d3f6364fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122510 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ab6ea962bdf54d1ba7f9be368daf186f9c829ca3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122436 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit f371c5083883733024706417d131ecddb55d0bad) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122441 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
* bump product version to 7.2.2.1.0+Christian Lohmaier2021-09-211-1/+1
| | | | Change-Id: If6863006c57005b242454f8aa181b5fe9f3a2f56
* Branch libreoffice-7-2-2Christian Lohmaier2021-09-214-1/+1
| | | | | | | | | | This is 'libreoffice-7-2-2' - the stable branch for the 7.2.2 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.2.x release, please use the 'libreoffice-7-2' branch. If you want to build something cool, unstable, and risky, use master.
* Update git submodulesChristian Lohmaier2021-09-211-0/+0
| | | | | | | | | | * Update translations from branch 'libreoffice-7-2' to e6c8a0bddf2aa2983c8a75b48b9802319bd0c88f - update translations for 7.2.2 rc1 and force-fix errors using pocheck Change-Id: I64567c3dbe7e63de2550530fb5e0e0ba8e7f0525
* tdf#144253 tdf#144324 sc filter: use formatted values in filtersBalazs Varga2021-09-214-2/+27
| | | | | | | | | | | | | | | | if the results of formulas are values. Followed up of 40acda4e78127fa9f513646ef210b074d40cf307 (Related: tdf#140968 avoid duplicated filter values) Change-Id: Ib396d2b7cc08ba41b5936a53a28b5e38bf678b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121715 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 51375b48378915b6e95c1ac26b2ccf8e39880f7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#143591 DOCX import: handle anchored objects as at-charMiklos Vajna2021-09-213-13/+9
| | | | | | | | | | | | | | | | This partially reverts cc8f8ae55f681755f5da3bf64e4c30bb713f0383 (DOCX drawingML shape import: wp:anchor's behindDoc attribute, 2013-11-19), it seems to be more important to be consistent with the DOC import than with the VML import which is no longer used for DOCX shapes crated with Word >= 2010. Change-Id: I631da010bce1b4d3c392645e0ae3797a03665a42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122367 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 7246e57216bb20c15af0ecf6a0183f5ffa81e780) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122287 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#144564 don't query siblings and parent to determine typeCaolán McNamara2021-09-213-61/+12
| | | | | | | | | | | | because this is used during sorting of the tree elements so its position isn't necessarily meaningful during the sort. DBTreeListUserData is supposed to exist for elements not staged for removal and that already has the type as a member Change-Id: Ie1004dbcdca2fae8711941d98a084103a0b15815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122355 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
* tdf143726 DOCX: export default TOC Header style with correct nameGabor Kelemen2021-09-213-1/+10
| | | | | | | | | | | | | | | This seems to have been a typo since it was mapped to the default name of the Table of Authorities index's heading in Word which is not really supported anyways. Change-Id: I4cadce18c30c5497f27479fcc251fdf85d859145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120091 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 5440492ff9f949ee9ed9052e8bab6f5136d78b2a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122278 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* use clang-cl's -Zc:dllexportInlines- for Skia (tdf#144598)Luboš Luňák2021-09-214-2/+38
| | | | | | | | | | | | | | | | | | | | | | | This is clang-cl's equivalent of -fvisibility-inlines-hidden, and it seems to be also sort of the equivalent of MSVC's -Zc:inline. So it saves build time and disk space. As an additional effect, this disables emitting copies of inlines functions in every .o file where the function is called (even if inlined), which means that it hopefully avoids the problem of SkOpts_avx.cpp generating a copy of SkRect::round() which would include AVX code, and the linker might select this as the instance of SkRect::round() to keep, thus making SSE2 code call AVX code without checking for AVX availability first. Change-Id: I97541ae11d05f489894bc9233271eb21fd520f43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122335 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 36f76223193fb96df7b8cbc1a1ff30f739857189) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122284 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Revert "tdf#99492 sw layout: always paint merged cell grids"Justin Luth2021-09-211-0/+4
| | | | | | | | | | | | | | | | | | | | | | This reverts LO 7.1 commit c016fe2b5918d6e53113e100b1126076b6e1a6a3. This failed for two reasons. 1.) If it is not a solid color (like a graphic for example) then the graphic is going to be repeated in each cell. 2.) This is NOT actually repainting the visible cell's background. It is painting the hidden cell - which MIGHT be different from the visible cell (in the case of a solid color). Since this will require a completely different approach, I am just reverting this. Thanks Mike for finding an example document that shows the flaws. Change-Id: Icdc21e09118e7c33ac9f7ede23c913b95ad69c93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122366 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit eb830ad284f245165b6ab5e8647d48834622f2d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122281
* Resolves: tdf#144620 toolbar config item overwrites options dialog oneCaolán McNamara2021-09-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | There are two SwMailMergeConfigItem involved. One SwMailMergeConfigItem from the toolbar created and considered modified and with changes not commited to the config yet. Then the other SwMailMergeConfigItem is created by the options dialog and commited on ok, but after that commit at cui/source/options/treeopt.cxx at line 723 there is a utl::ConfigManager::storeConfigItems() to flush all outstanding config items, so the one belonging to the toolbar is now flushed after the options dialog one was written. The SwMailMergeConfigItem has a IsModified() of true right after ctor which doesn't seem intentional, there is no explicit set of Modified to true on setting the simple bool members, the Modified bit is toggled on when using the more complicated modifier methods during ctor so very much looks like an accidental side effect. Change-Id: If84a6f01c7bf92704dd1e175a2bd8e2ea59e157f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122280 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#143813 Outline folding: Make copy cut paste workJim Raykowski2021-09-201-2/+12
| | | | | | | | | | Change-Id: Ib8b491fdcce1cd059c8eaf80a9c3bb2590af7c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122212 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit f4f646eec90c44b6a7ffeaf5f6ce4c85af64eed0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122276 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* occasionally the bg color of the deck grip is wrongCaolán McNamara2021-09-171-0/+1
| | | | | | | Change-Id: I318e817a8e99b9f01aee90f042bfac39a1c4b5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122120 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#144427 tdf#144483 sw mailmerge: fix merge all documentBalazs Varga2021-09-173-22/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not all records were merged if we selected the “From 'X' To 'Y' of the “Save Merged Documents” or “Print Merged Documents” or "Send to Email" dialog windows and write some value into them and then we switched back on to Save/Print/Send All record (opened via the Mail merge toolbar). Regression from commit: ec44f87d5b99a3299322d0b79abc4c6808877865 (tdf#117212 sw mailmerge: merge only the selected range) (cherry picked from commit f3993912ec4b526aa57cb4bfb4745d7298a4da82) tdf#144483 sw mail merge: save ranges in a single document In the Save mail merged document dialog, it wasn't possible to save mail ranges in a single document, because of the bad UI of the dialog window: grouping range selector as a radio button with the single document/individual documents radio buttons. Moreover, commit f3993912ec4b526aa57cb4bfb4745d7298a4da82 "tdf#144427 sw mailmerge: fix merge all document" removed the hidden workaround: setting range at the third radio button, and selecting the first radio button. Using checkbox for the third option solved the problem as proposed. (cherry picked from commit 45c4caff685b15a0f1b87ef05436a7e6aca96851) Fix broken ui file ...after 45c4caff685b15a0f1b87ef05436a7e6aca96851 "tdf#144483 sw mail merge: save ranges in a single document", causing CppunitTest_sw_dialogs_test to fail with > warn:vcl.gtk:2759211:2759211:vcl/unx/gtk3/gtkinst.cxx:21611: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: ~/lo/core/instdir/share/config/soffice.cfg/modules/swriter/ui/mmresultsavedialog.ui:165:49 Invalid property: GtkCheckButton.group (cherry picked from commit 7b37af5af6afe75ad952538c145a4f4e61de9a96) Change-Id: I01fc664fe76f74cefe4faa81b324088ec37b9881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121982 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu> Tested-by: Jenkins
* Resolves tdf#144523 - Update Liberation fonts to 2.1.4 releaseHeiko Tietze2021-09-171-2/+2
| | | | | | | | | | Change-Id: I25aa71d214eec3a131a7b11dfe292764061a127c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122182 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 95406f2e172df13ae9c6536ca1378cd7fca3b2de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122129 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Revert "speedup rational_FromDouble"Noel Grandin2021-09-161-5/+5
| | | | | | | | | | | | | | This reverts commit 67d83e40e2c4f3862c50e6abeabfc24a75119fc8. because it causes less accuracy sometimes, eg. see https://gerrit.libreoffice.org/c/core/+/122186 Change-Id: I06eb4921359a8fe6689c6cfd3e2967e25b646fa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f2315daf701847a180a5759039b4951fb4da0653) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122126
* CppunitTest_sw_core_text needs some more RTTI now in UBSan buildsStephan Bergmann2021-09-162-2/+2
| | | | | | | | | | | | | | | | | | | | | ...presumably since 0c3e47cc2f0570a7cd8ff4889763991a86b29f26 "tdf#144305 sw: fix rendering of ruby portions with non-default ruby alignment", > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI13SwLinePortion" and > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI14SwMultiPortion" Change-Id: Iaebffc3c9c0245d6092ef1dfc58213fd2d38d303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122143 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 485add3cd6240a0faceb7a74784d44b1c0a6705e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122117 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* patch Skia to search only system32/ for librariesLuboš Luňák2021-09-162-0/+14
| | | | | | | | | | | | | | | LO on Windows defaults to Vulkan, and Skia tries to load the vulkan DLL, which may not be present on some systems. The library AFAICT should always be in a system directory, so restrict library searching to just there to avoid the possibility of DLL hijacking, just to be safe. Change-Id: I78ad3c7297e613c0316e82c5ff3c0110a02da337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121437 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122135 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* fix skia build with newer freetypesRene Engelhard2021-09-162-0/+23
| | | | | | | | | | | | | | | extracted (and adapted for 7.2.x) from masters catch-all-commit a0edcc68f94915a78fcc08e70d2cdd752abd9ebb: Additionally patch out Skia's use of TT_SUPPORT_COLRV1, which seems to be an unstable freetype API from the git version and it doesn't even compile with the latest stable 2.9.11 release Change-Id: Iba22fbc74dcd75bc6d1d91e2f537caf9d179e885 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122096 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* Resolves: tdf#144135 Rework Sort with area extrasEike Rathke2021-09-1518-281/+518
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since commit 774a61afa9fc281290e7bfad4e28c05978b82d73 CommitDate: Wed Apr 14 08:46:03 2021 +0200 tdf#126678 - Consider "Include formats" option during sort a sheet formatted with visible attributes like cell background colour up to the end if for Sort all columns and/or rows are selected lead to an excessive memory allocation and slow execution time if it didn't get killed by the operating system before due to memory exhaustion. The same could had happened already before if graphics or comments were to be included that could had resulted in a similar large range. However, cell formats across sheets are more likely. This changes the strategy how the to be sorted data range is determined (range only with data) and additional area extras ranges without data that are only to be rearranged. Those are then processed in chunks (limited to ~512MB per chunk). Cell formats that are identical within one column's rows range do not even need to be covered as they are not rearranged, in the best case leading to all trailing formats' ranges being excluded from the sort. Additionally optimize the cell gathering of formats, graphics and comments such that for the area extras they are only collected if actually requested. The overall performance gain is in an order of magnitudes even if some extras are to be collected. Change-Id: If3abbaeaa615aaff7d88a82a5b3fc7ac633d770d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122013 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0a9b68c9f9880655576e3220d8b70064b367dbee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121981 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update git submodulesOlivier Hallot2021-09-151-0/+0
| | | | | | | | | | | | | | * Update helpcontent2 from branch 'libreoffice-7-2' to f3bf3ced8ac07689e83c4f29226323313a23caed - tdf#133851 connect help page to certificate path dialog Change-Id: I5a96785f32b81c6a8dd347b5665e1f5d0c7b84b2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122152 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 323c851c00559631e9e2ee1098d9aed89ca1d2ff) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122118 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Adapt to Bison 3.8 internal yyn -> yyrule renameStephan Bergmann2021-09-151-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | see <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=f30067ed51f23802fc91761ede1506dfa72b2865> "glr2.cc: log the execution of deferred actions" including "Rename argument yyn as yyrule for clarity." YYBISON was defined as 1 rather than as a representation of the Bison version prior to <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=21c147b6e5372563b7c4741deadaddb9354f4b09> "yacc.c: provide the Bison version as an integral macro", which shouldn't be a problem here. And YYBISON is apparently completely undefined with /usr/bin/bison on macOS. (The preceding comment always mentioned "yyi" and "yyrmap" in apparent mismatch with the actually used "yyn" and "yyr1" ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it untouched.) Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 45227d9b79dc4f2a2aa6874cd4e3c02b7934b197) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122069 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#144305 sw: fix rendering of ruby portions with non-default ruby alignmentMiklos Vajna2021-09-145-2/+74
| | | | | | | | | | | | | | | | | | | | | | | | Regression from 301278b656e76b6f42af5cf8a6f5c6c02acfffeb (sw: allow the height of a line to be larger than 65536 twips, 2021-05-20), the problem was that changing from sal_uInt16 to sal_uInt32 broke SwRubyPortion::Adjust_(), which relied on integer promotion rules to have a negative diff. Old storage size was smaller than int, so got promoted to signed int, so the result could be a small negative number. New storage size is an unsigned int, so no promotion happens, so the new result was a large positive number. Fix this by casting to signed int explicitly. Change-Id: I8778c1bd0d62e27c99d4ceb1bb7bc6107a179803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122048 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 0c3e47cc2f0570a7cd8ff4889763991a86b29f26) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122066 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#142415 mouse events not propogated to table control event handlersCaolán McNamara2021-09-145-30/+103
| | | | | | | | | | handle this with explicit callbacks from the cell widget for those events Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#117842: use XUnoTunnel to get wrapped connection reliablyMike Kaganski2021-09-143-2/+24
| | | | | | | | | | | | | | XDataDefinitionSupplier::getDataDefinitionByConnection may take not only direct reference to expected connection type, but also connectivity::OConnectionWeakWrapper wrapping it. Change-Id: I88925f9403b51f0cf13f02b5f00d3765a242230e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121890 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ccc6c846eb7f6d334d0ab2e6b50c188c434caa19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121986 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#123642: keep last bookmark at the document endVasily Melenchuk2021-09-148-6/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | In some cases DomainMapper_Impl::RemoveLastParagraph() can also remove last bookmark from real last paragraph. This does never happens when we use xParagraph->dispose(), but pretty always during older way with xCursor->setString(OUString()). Unfortunately without deep refactoring of redlines, bookmarks, etc. I see no other way to avoid this removal except given hack which is trying to store last bookmark and if it did disappear restore it. Some existing unittests were adjusted: corresponding original DOCX files did contain final bookmarks not taken into account by the code. In some cases test code is modified, in some just removed final bookmark in DOCX: such multi-format tests as in ooxmlfieldexport.cxx will be more identical to RTF & DOC variants. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport17.cxx Change-Id: Ie9948b58cda705a0b85fa8e5e08b72fbb7d682b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121409 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122015
* tdf#144106 Don't proceed ptrim_i past ptrim_fStephan Bergmann2021-09-141-1/+1
| | | | | | | | | | | | | | | | | | | | ...which would cause p2 - p1 to be negative in lcl_appendLineData and thus construction of a std::u16string_view with a huge positive length of type size_t. In 64-bit builds where size_t is 64-bit, that would then cause termination due to an uncaught std::bad_alloc. But in (implicitly) --disable-assert-always-abort 32-bit builds where size_t is 32-bit, this would silently have worked before 1efec9ec21dba32335e311d367b636538e219621 "Tighten rtl_{string,uString}_newFromStr_WithLength implementation", when the huge positive size_t value was cast back to a negative sal_Int32 that was gracefully handled by rtl_uString_newFromStr_WithLength. Change-Id: I3b95a9fce62b99ffc150f76a1c6ccddcdacdae0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122038 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4a4be7a1edead11b48e1a8598e52a3246e6744bb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122064 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* do not intern a temporary cell error stringLuboš Luňák2021-09-131-2/+2
| | | | | | | | | | | | Interning is way more work than a simple text comparison done once. Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit d0316985db22efd6708dffa173eaabb430f6b9a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121985 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* exernal/firebird: extern/cloop: Missing dependencies of compilations on...Stephan Bergmann2021-09-133-5/+50
| | | | | | | | | | | ...output directories Change-Id: Iaa2b750a12e3df078b46e5bb4feeafc926e11165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121741 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122041 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Explicitly set cursor position for x11 'gen' backend, tdf#144457 follow-upEike Rathke2021-09-131-1/+7
| | | | | | | | | | | | ... (and other backends?) Change-Id: If45b83080aa2df50ef27ad282eb6fa1d4a022703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122037 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 37e2e99f7a3018dce0337b582b139d41e1e81a9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122059 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#116184 Check that there is no trailing number behind a matchEike Rathke2021-09-131-2/+3
| | | | | | | | | | | | | | ... without being separated by a blank so the match is rejected if it doesn't possibly form a date+time input and input can be accepted as decimal fraction. Change-Id: Iabd1d216366ecb8454c59822ce58f112bfa6091e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122024 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit eb0b4ab2d3b86d77ee0edb652d4486343e5b3b1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122054 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* cache FormulaError::NoRef error string (tdf#144249)Luboš Luňák2021-09-132-2/+5
| | | | | | | | | | | | | | | | Those COUNTIF() may call it a huge number of times, and the translation of the string each time then actually is a noticeable impact. And ScGlobal already does one-time intialization of objects based on the locale, so one-time initializing a string there should be fine too. Change-Id: I0daeb50ccb43f780d99cf3838cfd1bf790c5f6cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121856 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit b4c1bb2f91e9ae47820c289e2c08f640a958cf05) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121984 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#115547: Fix DB path handlingMike Kaganski2021-09-131-5/+7
| | | | | | | | | | | | | | | | | | | | | 1. The code used wrong procedure to convert file URLs to local paths. It assumed that it's enough to just strip the leading 'file://', which is only sometimes true on Unix-like systems; on Windows, this converts a valid 'file:///C:/path/file.ext' to '/C:/path/file.ext', where the leading slash is then treated as a network path, resulting in errors. 2. It is incorrect to assume the same length for UTF-16 and UTF-8 encoded URLs coming from untrusted source (like user file). It may contain non-ASCII characters (be an IRL), and then the assumption would fail. Change-Id: Ie2ea6c8cb9a690975db956fa025bf926a8010984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121885 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins (cherry picked from commit 51269c4d28c04ebd2c0047772b7373e0bebec219) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121983 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-04-24 20:18:31 +0000