| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I18bce66cc0068815a466291a1a72093704d9fdc7
|
|
|
|
|
|
|
|
|
| |
with the variadic variants.
Change-Id: Ib5335ab6e64ee407e3aa8f9558a24af40a308107
Reviewed-on: https://gerrit.libreoffice.org/17981
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
with the variadic variants.
Change-Id: If88e1d741075e86997c91dc2c59eeebe45f67c1f
Reviewed-on: https://gerrit.libreoffice.org/17980
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
| |
Change-Id: I21fbfe37f89fa404688cd1b287163801da9f7e0a
Reviewed-on: https://gerrit.libreoffice.org/17974
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
o3tl::typed_flags_set"
sberg did not like this macro, let's see if I can find a better
solution.
This reverts commit e51fa143587d018b75db08e60cf27ff932b1cf8d.
|
|
|
|
|
|
|
|
|
| |
(cherry picked from commit e3cd97ce0b2e153b8b6812cc66f2e7d33504a7da)
Conflicts:
vcl/opengl/program.cxx
Change-Id: I86ae50bd8d2148e86a6c8fc0821d3e2bc29a0cd4
|
|
|
|
|
|
|
|
| |
Change-Id: I3d5eae99427ca68a5121ad43e9f4e7df03ddc23e
Reviewed-on: https://gerrit.libreoffice.org/18005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
| |
Change-Id: Ia9ae1f8583948620b6f496afcadd292671cdc906
Reviewed-on: https://gerrit.libreoffice.org/18004
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
| |
Change-Id: Id407614c75eb04fb920fcf75d368b070323a0b79
Reviewed-on: https://gerrit.libreoffice.org/18003
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
|
|
| |
Any string in one of given matrices should result in IllegalParameter
error.
Change-Id: Ia08d879ec109e04021373c34e83f1873be6815c2
Reviewed-on: https://gerrit.libreoffice.org/18002
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
|
|
| |
Strings should be omitted by the algorithm, so such test cases are
important (were missed before).
Change-Id: I2e77b2087e398bf27ac71ba4da0b26c66cc08311
Reviewed-on: https://gerrit.libreoffice.org/18001
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
| |
Same as in ScStatisticsInputOutputDialog.
Change-Id: I0e3eb06bc86cf77c405c54f312340c7b2551c1ec
|
|
|
|
|
|
| |
Same as in ScSamplingDialog.
Change-Id: Iff709ec2284673efa8824a9b8cfc037e4d6d567a
|
|
|
|
|
|
| |
Same as in ScRandomNumberGeneratorDialog.
Change-Id: I1bc9296bfc8b1b2b8f3fc20183e2c626f94dee09
|
|
|
|
|
|
| |
... and disable/enable Apply/Ok buttons for in/valid ranges.
Change-Id: I52b5eae2f34e3fca7c0761b14124477a0d160b01
|
|
|
|
|
|
|
| |
The string support certainly isn't complete or correct
anyway. Partially revert c3383aafa18ef9d03b04b2a4719e71fdfabc14eb.
Change-Id: Ica86f39daf864a1a62d92f8d8300d75d020c0ee0
|
|
|
|
|
|
|
|
|
|
|
| |
If an OpenGL zone takes >2s to make progress, disable OpenGL.
If an OpenGL zone takes >5s to make progress, abort the app.
Change-Id: I776c06a3f8ba460ff9842a9130c21f9ee2147eee
Reviewed-on: https://gerrit.libreoffice.org/17986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
|
|
| |
Change-Id: I937ec900044bbc6027ff8d4ae37f2f275dde974f
|
|
|
|
|
|
| |
Instead of a bare NaN.
Change-Id: I170c540478315eedd23f5851d54c30175d21ef96
|
|
|
|
| |
This reverts commit af9751a760e9007d0450adf2753d8a65be5f536c.
|
|
|
|
|
|
| |
just shove the unneeded pam into dead space
Change-Id: Id0a3d550cd9d54394888e6b2d62e21eaded24a7c
|
|
|
|
|
|
| |
so do that in the ctor and drop the arg from a bunch of places
Change-Id: Iaad71e9854b38d8632df057dfe9c96468d1d0098
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The commit c3383aafa18ef9d03b04b2a4719e71fdfabc14eb was missing an !
operator in two places where it checks whether a cell is a numeric or
string one, resulting in it always using the string value, which for
NULL (the case I was looking at, only numeric cells in the array)
meant zero was returned.
As such I am not sure if it is entirely correct to do the check
whether a cell is a numeric or string value in the order the generated
OpenCL code does here (and all over the place perhaps). The
documentation in <formula/vectortoken.hxx> says:
* Single unit of vector reference consists of two physical arrays.
*
* If the whole data array consists of only numeric values, mpStringArray
* will be NULL, and NaN values in the numeric array represent empty
* cells.
*
* If the whole data array consists of only string values, mpNumericArray
* will be NULL, and NULL values in the string array represent empty
* cells.
*
* If the data array consists of numeric and string values, then both
* mpNumericArray and mpStringArray will be non-NULL, and a string cell will
* be represented by a non-NULL pointer value in the string array. If the
* string value is NULL, check the corresponding value in the numeric array.
* If the value in the numeric array is NaN, it's an empty cell, otherwise
* it's a numeric cell.
Note how that implies one should first check whether the value in the
string array is NULL or not, and only if it is NULL, look at the vale
in the numeric array. The code in the generated OpenCL VLOOKUP
implementation does it backwards. Scary. But probably equivalent for
the subset of cases we actually handle in OpenCL, which (I think) are
those where no string cells are involved.
More bug fixes for the OpenCL VLOOKUP will follow.
Change-Id: Id567c245a0700267584be6032320863a4a66df83
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Project: help fff841e50d4e1b36453820b66f150d708ebfff2b
TDF#80588 Help page for Basic IDE Options
Help page for Basic IDE Option in Tools - LibreOffice - Basic IDE Options
Before merging this patch it is necessary to verify correctness of the help page contents.
Change-Id: Ic80410910ed3eadb02c4fd49c02fc5f1dce053db
Reviewed-on: https://gerrit.libreoffice.org/17356
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
|
|
|
|
| |
Change-Id: Ifd4c6594d50ff63235e75049bc7ab8bc79606fc8
Reviewed-on: https://gerrit.libreoffice.org/17880
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Related to http://cgit.freedesktop.org/libreoffice/core/commit/?id=e38f63d861715fb56f41af82b897c2128ea20b38
Change-Id: I4ede777207fe42dede6e82c7399189354f182f6a
Reviewed-on: https://gerrit.libreoffice.org/17924
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
|
|
| |
Change-Id: Id5715f8753d17b3955ac87b9260318ac56e64a08
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the title was set during construction as e.g.
"Conditional Format: A2:B245"
However the selected range can be modified while the dialog is open,
hence we update it whenever the selected range is modified.
Change-Id: I63790108553102cedb51ca32d672a62477493660
Reviewed-on: https://gerrit.libreoffice.org/15711
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The lookup of getNumberFormatKeyByIndex() is sped up by storing the
addresses into the cached data array m_aDataArray.
The existing cache invalidating strategy should hold since the
cache was already storing information about hidden fields and
ranges, which is the information which affects the addresses.
Also: Change data type of m_aDataArray from std::list to std::vector to
allow index-based access.
Also: Change for-loops over m_aDataArray to range-based loops with auto
variables to make them more readable
Change-Id: I9a5038892a384e7d5e72556a52faaf98b475a839
Reviewed-on: https://gerrit.libreoffice.org/16485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
| |
Try to use some sane consistent formatting in this function. No semantic
change.
Change-Id: Ic9e4625c910f826246451e8ff9e18d6131c04a78
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, at least in the case of the "Test OpenCL" thing, we get here
an mpStringArray that is non-null but where all the elements (rtl_uString
pointers) in it are null. Treat that case as if the mpStringArray was null.
This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other
useful effects, too. (But for normal spreadsheet use, the mpStringArray that
gets handled here *is* null when all the cells used by a formula group are
numbers. At least it seemed so in a simple test.)
Also add more useful (?) SAL_INFO calls in the area.
Change-Id: I1388786a3a0765af6eb01a63da31e5b83c7a616d
|
|
|
|
| |
Change-Id: I53dc6d358952a046a4c1f03246441742dfa3d685
|
|
|
|
| |
Change-Id: I555d4b79a61b371a39ad0f0b76c2d34c22414962
|
|
|
|
| |
Change-Id: Icc3e913d4150e724c87e8293f7b641ee8ca19177
|
|
|
|
|
|
|
| |
Change-Id: I1bd1040cc80c0450a5e029c37f0737c0692c056a
Reviewed-on: https://gerrit.libreoffice.org/17952
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Replace bullet char before write out font description
since it may be altered if bullet font has been changed
(i.e. StarSymbol to WingDings ).
Change-Id: I0461cc0a5e4628b36177602bba7ed7f74a0751eb
Reviewed-on: https://gerrit.libreoffice.org/17376
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
|
|
|
| |
Change-Id: Id670e83db01efe6bcd5fb6bb374ab9cb92898f88
Reviewed-on: https://gerrit.libreoffice.org/17460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Indirect property values were ignored, now they are used.
2) Write endParaRPr so that PowerPoint display them.
3) Automatic colors are written as white or black based on
whether background is dark.
Change-Id: I255c16f35149b738be2daf2800b1c90389f2c7cf
Reviewed-on: https://gerrit.libreoffice.org/17472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Project: help 67285d99b8c9373ba3fa992679353ee1a5bc4da9
typo "Navigator displays" → "The Navigator displays"
via pootle-feedback
Change-Id: I25578b8a780e607ce553e17289d96cdc7185577e
|
|
|
|
| |
Change-Id: Icb96b45c936b974938c2dfae48960f727a1dc84d
|
|
|
|
|
|
|
| |
for the duration of inserting attributes, and excess
dos newline chars can be removed safely afterwards
Change-Id: If70e34fec1c0819f827f483d3d7ac4f19b3caef8
|
|
|
|
| |
Change-Id: Ia22866225b2a726ed69c9f18d02d1ebffdafde8f
|
|
|
|
|
|
|
| |
Change-Id: Icc5958d77277c6938b8a03ef44dfd71b9350e288
Reviewed-on: https://gerrit.libreoffice.org/17978
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
|
|
|
|
|
| |
...as found by UBSan in CppunitTest_filter_ppm_test on
filter/qa/cppunit/data/pbm/fail/crash-1.pbm
Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...as found by UBSan in CppunitTest_sw_filters_test (see below), and at the same
time limit reads within the pA array to its bounds.
> Testing file:///.../sw/qa/core/data/ww6/pass/crash-2.doc:
> sw/source/filter/ww8/ww8scan.cxx:6473:32: runtime error: upcast of misaligned address 0x6200000e70e7 for type 'WW8_FFN_Ver6', which requires 2 byte alignment
> 0x6200000e70e7: note: pointer points here
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0e 00 00 6a 00 00 00 00 0e 00 00 6a 00 00 00 6a
> ^
> WW8Fonts::WW8Fonts(SvStream&, WW8Fib&) sw/source/filter/ww8/ww8scan.cxx:6473:32
> SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:4961:20
> SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
> SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
> WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
> SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
> SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
> SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
> SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
> SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
> test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
> test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
> SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5
Change-Id: I31ac8dc11d985745785c9dda1cec8a11a41098bb
|
|
|
|
| |
Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254
|
|
|
|
| |
Change-Id: I6e43fd4a4b45f0217de8b6d93ef2403e46e39489
|
|
|
|
| |
Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f
|
|
|
|
|
|
| |
Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable.
Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609
|
|
|
|
| |
Change-Id: Ic48e22169dff2ed06b75af519ca39addef7d07de
|