summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* bump product version to 7.1.5.2.0+libreoffice-7-1-5Christian Lohmaier2021-07-161-1/+1
| | | | Change-Id: I7f5e8079684de14dbdc7bbb685d1efdc992d15cf
* update creditsChristian Lohmaier2021-07-161-2314/+2367
| | | | | | Change-Id: I1a09193e888318084a7d9b3c76c049e373db545b (cherry picked from commit 113d308155e4b6a67a8510098a7db5f4a6632bdc) (cherry picked from commit 8c52893341dbe84d0772f574c1fa9bf37b88a338)
* Update git submodulesChristian Lohmaier2021-07-161-0/+0
| | | | | | | | | | | * Update translations from branch 'libreoffice-7-1-5' to ce7b028c7a241f9fd73679dee6eacca571797830 - update translations for 7.1.5 rc2 and force-fix errors using pocheck Change-Id: I42501f3274956b38075932f254e33d4643a3040f (cherry picked from commit f631db10ea817a58295da01010d9f4c7b2aa58ae)
* crashreporting: Crash seen in CachePreview from Idle UpdateHdlCaolán McNamara2021-07-151-1/+4
| | | | | | | | | | | | | | | the intent here is regenerate the previews if font settings changed which should mean that we restart at index 0 and not continue from the old index https: //crashreport.libreoffice.org/stats/crash_details/a01c5fcd-983b-40ab-b90a-8ee90286e5b8 Change-Id: I9604ad96cf6cc757d2d33469827d1295d309454d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118924 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#143245 activate-on-single-click only if 'up' is at active entryCaolán McNamara2021-07-151-0/+9
| | | | | | | | | | | | | | which is typically selected by the 'down' Change-Id: I23382fb97146820da49e570280778729a3156f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118807 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit bfc49fc16c1cc9b9a5dee406fe7348c079c45ba6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118811 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#143291 the "none" item selected is distinct from nothing selectedCaolán McNamara2021-07-131-6/+10
| | | | | | | | | Change-Id: I2e012df85a5c28f462a6c643d7a9a88f8775e870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118730 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#140594 Create proper window peer for FORMATTEDFIELDMichael Weghorn2021-07-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 2a694f9e0e7789b4b3b792a9eedd29366fa10c1c Date: Wed May 6 14:08:07 2020 -0400 lok: fix the window type of the formatted field control had introduced the new 'WindowType::FORMATTEDFIELD' and set it for the 'FormattedField' control (instead of using the previous default value set in the 'SpinField' ctor, which is 'WindowType::SPINFIELD'). So far, this type was not explicitly handled when creating the XWindow peer. Handle it just the same as 'WindowType::SPINFIELD' and return a new 'VCLXNumericField', which e.g. makes sure that a "proper" accessible is created and thus alues of a spin field are announced by the NVDA screen reader (again). (See also commit 33cac418db78f64f7fa84b8e65c01c2b02cf17a7 Date: Fri May 29 16:53:59 2020 +0200 tdf#133498 Make native drawing of FormattedField work (again) which had fixed a similar regression elsewhere.) Change-Id: Ie8a4d279a12a1b83a9cf97f1304d84214b3a2a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit cdc752fd5e5b3bf97043b9542867d84827614f2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118503 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 1e7f4ecdfbb30cdf35501292ced01388b8d24647) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118507 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* SolarMutexGuard::clear called twice where the 2nd call site should undo the 1stCaolán McNamara2021-07-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | since commit 94f8a0e60b7bc5c1176eafe9a36c3f3466bd1408 Date: Thu Mar 20 09:08:10 2014 +0100 Use SolarMutexGuard directly Change-Id: I4b245dd68bf032a1d74fb16b910dc952fd761781 seen with compiler warning of: In member function ‘sal_uInt32 comphelper::SolarMutex::release(bool)’, inlined from ‘void osl::ClearableGuard<T>::clear() [with T = comphelper::SolarMutex]’ at include/osl/mutex.hxx:194:28, inlined from ‘void framework::ImageManagerImpl::reload()’ at framework/source/uiconfiguration/imagemanagerimpl.cxx:1071:25: include/comphelper/solarmutex.hxx:91:22: error: ‘this’ pointer is null [-Werror=nonnull] Change-Id: Ibd074794e4556a6ff34b0dc94099e81e1ae3b349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118623 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins (cherry picked from commit b39292ac6c89ee20db72e2dc33a59e8d49ca449c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118722 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#140506: fix repeated table header switchingBjoern Michaelsen2021-07-121-2/+2
| | | | | | | | | | | | | | | | | | this fixes regression from f899c28f210c6565b7227d7665d449f194d2af8e, which asssumed all frames to be listening to the Notifier of the format. That is not (yet) the case. Change-Id: Ib684842c571823eeb72824196ccfdb1df8179e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118370 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 25e09087d8e2c5cecca1d548c69a263c7bf8b7ca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118418 (cherry picked from commit dd4d221f77501eb36c816ade48869d385462f18c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118423 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#143153 null-deref on grouping fit-to-frame obj with anotherCaolán McNamara2021-07-121-1/+2
| | | | | | | | | | | | | Change-Id: I134d15ac980aa34ff274abd03966cd7948390542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118628 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit f2290187dcd59f159c560a47629b5d3897be1864) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118630 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#143146 copy functor and arg before calling function that can delete thisCaolán McNamara2021-07-121-2/+6
| | | | | | | | | | | | | Change-Id: I4e29fe6fa4119b709e31156afc5c2a5d08cdc072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118625 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 80f5f74b661b52717ec2848b98cad3be8192b330) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118629 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#143165 Date input must match separator, D,M,Y not part ofEike Rathke2021-07-061-2/+17
| | | | | | | | | | | | | Change-Id: Iae464fd0fc6c480b9a16ccb2f8eb635812c6eeff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118408 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 89a3caee73c476133af804d9a0a650e72e711d95) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118422 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#138432 Use locale's CharClass to parse numeric i18n contextEike Rathke2021-07-031-1/+5
| | | | | | | | | | | | | | | Change-Id: I1828f1b6f93228cd517a6a7bd9ae36584bd801a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d703131d063c41b8baca01830c4c9806f99ab7d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118190 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c7d6a4dcfa82387d4ea2445b7af109101f0c365b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118261 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* fix potential write-after-free in RecentDocsViewNoel Grandin2021-07-032-3/+9
| | | | | | | | | | | | | | | | | spotted while running a valgrind session Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2176084192dc46a1ef5d6dd79effa5cd5d1dcca2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118256 (cherry picked from commit 2b848d7dad2e7e1c8efce5b23eafedff387f00c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118266 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#143149 fix crash if app exits while print progress is runningCaolán McNamara2021-07-033-1/+15
| | | | | | | | | | | | | | | dismiss the dialog if its parent goes away, but leave the print job running Change-Id: Ic29ee0300a7d9476ad27a2594a555312e30c74f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118254 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit bc51aec4209729ea91a79a82506d18461183f570) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118267 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#140431 XLSX export: fix double file:// prefixTünde Tóth2021-07-033-2/+21
| | | | | | | | | | | | | | | | | | | | | | Regression from commit: fc58d7d65b9683db7b7632137126680b8483f6c5 (tdf#129969 XLSX export: file URLs need IURI encoding) Change-Id: I5bfb0ef9ba7fe82cd3f4d0e0b3fdcf8f705cba64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118090 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 67e2cc17bad3fd7aacb94da47f9024b731434a84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118293 Tested-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> (cherry picked from commit 5a47501ec5856f32d652d492e9e144e64642b452) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118299 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 26e447de1d6b940588ea3ae8f22e35a18aa60754) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118301 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* bump product version to 7.1.5.1.0+Christian Lohmaier2021-07-011-1/+1
| | | | Change-Id: I673c72f5d309ecc5c30cbd82d13dedf9ca4ed9b5
* Branch libreoffice-7-1-5Christian Lohmaier2021-07-014-1/+1
| | | | | | | | | | This is 'libreoffice-7-1-5' - the stable branch for the 7.1.5 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master.
* Update git submodulesChristian Lohmaier2021-07-011-0/+0
| | | | | | | | | | * Update translations from branch 'libreoffice-7-1' to ef50348279adbec84e7e6f800330901efebaeb31 - update translations for 7.1.5 rc1 and force-fix errors using pocheck Change-Id: I4232763382b588d86e2118fea9906f586e5eb19a
* tdf#143081: fix Basic Replace() function crashes LOJulien Nabet2021-07-011-5/+5
| | | | | | | | | | | | | | | | | | | | | | 0x00007f19c0aa6e57 in rtl::OUStringBuffer::append(char16_t const*, int) (this=0x7fff100d0748, str=0x6f6f46a u"晦饖香©", len=-1) at include/rtl/ustrbuf.hxx:659 0x00007f19c0c3c8a8 in SbRtl_Replace(StarBASIC*, SbxArray&, bool) (rPar=...) at basic/source/runtime/methods.cxx:1321 see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173298 Calling xCharClass->toUpper may change words, eg: "Straße" becomes "Strasse" so the length of the word increases. In brief, we want to use the length of aSrcStr not aExpStr Change-Id: Ia291d47a2021efc7dd9162ca5cc72b7940fdd71e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4a0b40f1be9f6773c8ebc5331c257911a76a5cee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118178 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118229
* sfx2: try to fix lifecycle of SfxOfficeDispatchMichael Stahl2021-07-014-1/+61
| | | | | | | | | | | | | | | | | | | | This can be created either from the global SfxApplication, or from a SfxViewFrame. Particularly in the latter case, the SfxDispatcher and SfxBindings members are owned by SfxViewFrame, so in case that is destroyed, the SfxOfficeDispatch must clear its pointers. It looks like the member pointers are checked before access already everywhere, so just listen at the SfxViewFrame. Change-Id: If08825734e94dd54e32cb77546684fd583c336ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7cbd6d768d282077053c354254315f3dc89bf254) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118195 Tested-by: Jenkins
* Related: tdf#143088 return early on notification from frozen editengineCaolán McNamara2021-07-011-0/+13
| | | | | | | | | | | | processing EE_NOTIFY_PROCESSNOTIFICATIONS from an EditEngine with an UpdateMode mode of false will just to on to cause AccessibleTextHelper_Impl::GetTextForwarder to throw an exception as a Frozen EditEngine is considered Invalid so return early instead Change-Id: I86f9647b7bf839cf3c7cf2f029be8c7c5aeef1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118071 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
* Related: tdf#143088 listen to DefaultWindow for Settings changedCaolán McNamara2021-07-011-6/+6
| | | | | | | | | | | having multiple Application::EventListener are expensive while a Window::EventListener is cheap and in this document there are thousands of comments so having thousands of EventListeners is problematic. Change-Id: I64fd12e4bcb8e4fd131effe94e6882e54cfcaf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118084 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#142061 Consider window scaling for XOR drawing on macOSThorsten Wagner2021-06-293-147/+299
| | | | | | | Change-Id: I4261334b6d2d2f34fe3452cc870aba6f88c4069e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118036 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#143047: When no properties for command, use those from item containerMike Kaganski2021-06-281-0/+2
| | | | | | | | | | | | | | | This allows to use the "Label" property defined by user for macro items, that indeed have no built-in command properties. Thus the resulting tooltip will be a concatenation of the label and mnemonic instead of only mnemonic as happened before. Change-Id: I79d933fecd09ca7d64b7a3e7db0ef194e42c1c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117787 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8383175bd3c714c163eac40a00b1e8277d4d5307) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117857 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* sw: layout: fix table split loop caused by RemoveFollowFlowLinePendingMichael Stahl2021-06-282-5/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In no_view.odt, the table 1340 does RemoveFollowFlowLine(), then splits again, and by the time Split() returns, its flag m_bRemoveFollowFlowLinePending is set and so in the next SwTabFrame::MakeAll() it will do the same thing again, until eventually it hits layact.cxx:544: LoopControl_1 in SwLayAction::InternalAction The flag is set during lcl_RecalcSplitLine(), in SwContentFrame::Cut(), which operates under the assumption that there are no other cells in the follow flow line that may contain content frames. This only happens if "Verdana" and "Arial" fonts are available and not substituted with "DejaVu Sans" etc. (regression from c4af8b0f106f31b6e79a145bc4ab83bb6a55c808) Unfortunately this uncovers another pagination bug in testTdf88496 which was hidden by this flag being set from text frames that shouldn't exist anyway. Change-Id: I3cc82c13bfc06960b827aefc64f5b5b12520955a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117851 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit a0cd270a99f43049fc099ddd463e57aa243d5b0e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117860 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* disable ligatures for monospace fontsCaolán McNamara2021-06-241-0/+6
| | | | | | | | | | | | we don't want e.g. a ffi ligature for Courier/Nimbus Mono PS Change-Id: I292c6e2ea217b511b4affcd8dab4a4bda85ab5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 744e964619b5c49870ceab7f59daf1272f24cf75) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117713 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#143008 Evaluate AM/PM for type date+time text-to-column and CSVEike Rathke2021-06-241-1/+31
| | | | | | | | | | Change-Id: Ib760b9a103ab4b8ce7f5a158b09fbe11c6617f2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117747 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d81775f5b12080676ebaf659c5a4c10d64a9074b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117720 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#142716 Update selection after any text is inserted.Gülşah Köse2021-06-233-7/+25
| | | | | | | | | | | | | | When we don't update the selection after insertion of new text SvxUnoTextBase::createEnumeration knows old selection and losts last part of the text. Change-Id: I20f6530f34097ff213ff00cff617139887fd287a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117409 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit e837f50313a703b6b26abb78f224472c1e4734ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117557 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#142932: fix crash when pasting cells with comments+"skip empty cells"Julien Nabet2021-06-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173011 4 0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43 5 0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...) at sc/source/core/data/table7.cxx:118 6 0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...) at sc/source/core/data/document10.cxx:75 7 0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*) (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0) at sc/source/core/data/document.cxx:2916 8 0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this= 0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true) at sc/source/ui/view/viewfun3.cxx:1312 Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a6d269ed9478b20f611912bf9711c2683e7bc924) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117632 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit bb59b4165456d13eda800098be8b875d93b093d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117637
* tdf#139447 crash on dragging query/table from explorer to calc sheetCaolán McNamara2021-06-223-4/+4
| | | | | | | Change-Id: Ic827cb967a9a9cb78f28a23707813aeec8381cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117019 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz#34297 Indirect-leakCaolán McNamara2021-06-221-2/+5
| | | | | | | | | | | | | | | | | | | | | this is similar to the memory leak fixed by commit d6e752d5ebfaf66d1c9b0694f9c8582311d6151a Author: Jian Fang Zhang <zhangjf@apache.org> Date: Mon Jun 18 12:26:30 2012 +0000 i#113608#, memory leak in animations: newly exposed crashed problem where the parent node holds a reference to its children and the child held a reference to its parent. Change RandomAnimationNode to use a WeakReference to its parent like the other AnimationNodes do Change-Id: I251a6127c301d1fb7e51397d8f05db4020bc612c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117115 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* sw: add BIRT layout test documentMichael Stahl2021-06-222-0/+6
| | | | | | | | | | | | | | | This nested table is an example that was broken by commit 91b2239783dc716bd71ce7962bfd7e341dfe4175 - if loaded with a wide window, it goes into layout loop; if loaded with a tall window size where page 2 is visible, strangely it doesn't loop. Change-Id: I5e73cfcd928ff1a321667c1a75b0ba7f348d4b77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117587 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit a41c71838d4662adf1ada9d46ec6e070cae7e695) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117603 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#116501 sw: layout: check for flys in SwTabFrame::ShouldBwdMoved()Michael Stahl2021-06-223-9/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On loading, this hits loop control warn:legacy.osl:580715:580715:sw/source/core/layout/layact.cxx:543: LoopControl_1 in SwLayAction::InternalAction This is because there's a fly frame 404 anchored at the last text frame 353 on page 2 inside the nested table 347. ShouldBwdMoved() sees that there is space on the bottom of page 2 and hence the follow flow row joined, but then it immediately splits again in the same way as before due to the fly with WrapTextMode_NONE. But then the outer table's cell 273 (upper of 347) is invalidated again, hence the loop. Try to check for overlapping flys in SwTabFrame::ShouldBwdMoved() by reusing CalcFlyOffsets(), which is ... not quite ideal, but perhaps better than copy-pasting half of it to a new function. This should have less side effects than the previous fix, but a problem remains that clicking on the shape on bottom of page 2 causes the layout to go wonky, but that was also the case with previous fix. Note there's a check of SwLayouter::DoesRowContainMovedFwdFrame() there already, but that doesn't help because it will only detect when the fly itself was moved forward, but in this case the fly remains on the page. Also likely it wouldn't be a good idea to move a text frame forward if the only thing of it that fits on a page is an anchored fly (i.e. its follow has mnOffset=0) because that can be intentional. Change-Id: I0376f7dcb784c006990336233c97f5093aaccb77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117473 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit f1439db62eb36ef5fbc9111b87dc4e0f24b3cb86) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117602 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Revert "tdf#116501 fix freezing at embedded text tables"Michael Stahl2021-06-224-38/+3
| | | | | | | | | | | | | | | | | | This reverts commit 91b2239783dc716bd71ce7962bfd7e341dfe4175. This breaks documents that have many nested tables. For example Eclipse BIRT generates reports with tables nested 8 levels deep, they run into the counter in no time and, ironically, one goes into a layout loop because of this counter. Change-Id: I7451d01787903bbc60b305da3dc72f8259175e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117472 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ee042a371e98cdcc59848f0b953f1ce545e18e31) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117601 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves tdf#140360 - Provide option to turn off sidebar's minimum widthHeiko Tietze2021-06-223-2/+11
| | | | | | | | | | | | | Boolean option Sidebar:General:MinimumWidth introduced defaulting to true; if false the sidebar width is under full user control Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit f43fdcad400b6ff51f0810d923fe75d5a2cfde0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117414 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#141311: Rotation spinbox in sidebar used to have 2 decimal placesKatarina Behrens2021-06-212-1/+2
| | | | | | | | | | | | | | | regression from weld-ing (c85fcc6e1994eb8e079aaca85066ab4d67149c15) Change-Id: Iad0725fd4542ecdddb65092846dbf9d103016d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117408 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 7a717c8b9319edcc12e50ab78554b8e0e7049cbf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117419 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 1bec8a3d3b16bb8881bd49f58d8786421ff5f839) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117554 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* ofz#34221 avoid OOMCaolán McNamara2021-06-211-15/+17
| | | | | | | Change-Id: I1987d39ea8ff195b397b0ee3fb0e45f9bfbfb572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117516 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#142873: Fix print preview zoom-out zoom-in buttonsJulien Nabet2021-06-212-4/+4
| | | | | | | | | | | | | .uno:ZoomOut has been renamed .uno:ZoomMinus .uno:ZoomIn has been renamed .uno:ZoomPlus Change-Id: I06e7e66550399e53032a0df39a98846982acba48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117279 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c21398066b6bf630070ed291456f2663e06d94b9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117427 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#142852 forward surrounding-text requests to an active drawing editengineCaolán McNamara2021-06-191-1/+12
| | | | | | | | | | | | | when present. As we do for related CommandEventId::[StartExtTextInput/EndExtTextInput] Change-Id: Ie5b57c8a8a1a258efc2be079a2674b1ca620dc9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117421 Tested-by: Jenkins Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* tdf#127028 "bpmn" template should have ext. otg instead of ottTomaž Vajngerl2021-06-182-7/+7
| | | | | | | | | | | | | | | | "bpmn" is an template for draw documents and not text documents (writer) so it should have the extension otg and not ott. This is also important for the template manager as it categorises the templates based on the extension, so the bpmn was not categorised correctly. Change-Id: I503b972711830dc3c5ab98d9c24f974862ffc540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116775 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e9a824dd6c1c33777461874d9892343d193c867d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116907 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update git submodulesOlivier Hallot2021-06-181-0/+0
| | | | | | | | | | | | | * Update helpcontent2 from branch 'libreoffice-7-1' to 0ef840bfd6928f312b3ece83c5a8bbd225767646 - Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117310 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 0849d16f3b86339a8906c496f89db64d2995fa6f) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117311
* Adapt to flatpak-builder 1.0.14 split "dest" + "dest-filename"Stephan Bergmann2021-06-151-88/+176
| | | | | | | | | | | see <https://github.com/flatpak/flatpak-builder/issues/399> "flatpak-builder 1.0.14 breaks build of org.libreoffice.LibreOffice, empty /run/build/libreoffice" Change-Id: Ia6383d8afb97396cb690a9859fc5d1c8f513970e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117263 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Resolves tdf#142513 fix zoom caller handlingJim Raykowski2021-06-158-21/+23
| | | | | | | | | | | | | | | | | | Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling. ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling. This patch changes ZoomPlus to do SID_ZOOM_IN case handling and ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate changes required by these name changes to provide expected zoom results in all module shells that have handling for these calls. Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit ec629c5ee22d02f99d66a5cf975ce239876b7f4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116702 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Resolves: tdf#142767 cannot use itemid of 0 in ValueSetsCaolán McNamara2021-06-151-3/+4
| | | | | | | Change-Id: I2c2b655b512e4e7869fe3784f1b073ecdbd0dac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117123 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Avoid Clang -Werror,-Wunused-command-line-argumentStephan Bergmann2021-06-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | > [CXX] bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx > clang-12: error: argument unused during compilation: '-fno-stack-clash-protection' [-Werror,-Wunused-command-line-argument] as seen e.g. on macOS 11.1 ARM64 when building against Clang 12 trunk. Clang supports -fstack-clash-protection on > $ clang --target=x86_64-unknown-linux-gnu -fstack-clash-protection -fsyntax-only -x c - </dev/null but not on e.g. > $ clang --target=aarch64-unknown-linux-gnu -fstack-clash-protection -fsyntax-only -x c - </dev/null > clang-12: warning: argument unused during compilation: '-fstack-clash-protection' [-Wunused-command-line-argument] or > $ clang --target=arm64-apple-macosx11.0.0 -fstack-clash-protection -fsyntax-only -x c - </dev/null > clang-12: warning: argument unused during compilation: '-fstack-clash-protection' [-Wunused-command-line-argument] Change-Id: I98625bb7ed37bf00e97634c1c8d1f87fe3263af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109719 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117134 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves: tdf#127013 differentiate non-/array separators and restrictEike Rathke2021-06-142-28/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a combination of 2 commits. Resolves: tdf#127013 differentiate non-/array separators and restrict Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117068 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit bb54d6d8241a06a6772052b77b67d6a4f686426c) Related: tdf#127013 Check loaded separators for validity ... not only if something is present at all. That way future restrictions can reset separators. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117072 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 381bc9d9acd461415cf81eef71ec3dd935a07b62) I738bcb9e052e8dbecb0a6cd07bbae8f4a8ea1c35 Change-Id: I9ff6b816b0c7af9081954fa407a4d516a576a338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117075 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* tdf#140623 Chart OOXML import: set text overlap to falseTünde Tóth2021-06-113-9/+17
| | | | | | | | | | | | | | | | of category axis label unless the rotation is 0 in xml. Regression from commit: 21620f9d2f50e66dffc45a5afb539edb8d54434c (tdf#138194 Chart OOXML import: set text break to true) Change-Id: I18db7483f49c84a83760200037f8858a3b471994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 6185d1ff0130b3d178d5e50eeb6944ab70db41f9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116905 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* EMF tdf#142745 Improve performance of FILLRGN, PAINTRGN, EXTSELECTCLIPRGNBartosz Kosiorek2021-06-111-13/+20
| | | | | | | | | | | | | | | | | | With previous implementation, during reading of rectangles the optimizations were made after reading every single rectangle. This was causing performance issues, with many rectangles (eg. 2500 rectangles). With this commit, the optimization is made after reading all rectangles. It is improving performance of FILLRGN, PAINTRGN and EXTSELECTCLIPRGN records. Change-Id: I1b8b844efddd08e9bf6f6726c3fdf213a629883f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116996 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117022
* tdf#142721 restore SwShellTableCursor if the orig selection was a single cellCaolán McNamara2021-06-111-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | where the previous attempt of commit 4d52d2bc81f9d27472fe368785912a530489d046 tdf#142165 restore a SwShellTableCursor if the orig selection described that so that we are operating on the same selection that existed when the dialog was originally launched wasn't sufficient to restore a single cell selection. we continue to need to avoid the assert of commit 6db71f70a3b200d4074f6cda8ce445e9861d3296 tdf#140977 drop possible table-cursor before setting the new one and support the multi-selection of commit e08b446e46f56e15af58fdd4396afba1a316f9e5 tdf#140257 duplicate entire PaM ring when making copy and support not scrolling to a different location on changing a table page break style of commit 9c61732677d038e32b73fc9fb883aced14c0febf tdf#135916 just set the target table as selection and keep making it possible to remove a page break on a table of commit 81f91196b98af38e29af451b86c26a893a109abc tdf#135636 the selection at dialog-launch time is lost by dialog-apply time all of which is necessitated by commit c3a085d22742f88e91ff92f319a26d6e8d1d9a98 lokdialog: Convert the Table -> Properties... to async exec. Though; since 4d52d2bc81f9d27472fe368785912a530489d046 where we started using rSh.GetTableCrs if IsTableMode() then in practice 6db71f70a3b200d4074f6cda8ce445e9861d3296 probably cannot arise. The scenario of rSh.IsTableMode() changing between launch of the dialog and applying the result of the dialog is presumably maybe theoretically possible in e.g. an online scenario, but not in the normal user case, but handled here anyway. Change-Id: I12f0b6bc7e0e2f5bad45a88007bf6fe2cd3d3b0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116896 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2024-04-24 06:32:03 +0000