summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* framework: MenuBarManager: fix WNT crash if queryDispatch() throwslibreoffice-24-2Michael Stahl13 hours1-1/+10
| | | | | | | | | | | | | | | | | | | a Java extension throws RuntimeException from queryDispatch(), which is translated to a C++ exception and thrown by the mscx_uno bridge, and this is apparently not handled anywhere (Visual Studio says "Unhandled Exception"), and what happens then apparently is the exception goes poof and vanishes, and normal return from the mscx_uno bridge code happens, but the out parameter used for the return value is never initialised, and then the uno::Reference move assignment operator crashes. Change-Id: I21535fcf0ab4ec30a712d01b5039b7e2fb7b09d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165081 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 447a15f4772bcbc9366cfa43b92c55ae644e9b03) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165113 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
* return early on empty ORelationTableConnectionData*Caolán McNamara16 hours1-1/+1
| | | | | | | | | | | | | we test for pData existing, but it it doesn't then we continue and will typically dereference it, so test looks inverted Change-Id: Iddcab25d5620942bb617bd1e9985322f5e497839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167331 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 0b97bfa88ffebf31778f0f68e883e046822cd264) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167313 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#159375: remove initialization on Tools>OptionsBayram Çiçek18 hours2-21/+5
| | | | | | | | | | | | | | | | | | | | | | | | - Initializing some dialogs at the startup of Options makes it opening very slow on some low-power systems. - This patch removes this initialization. This means, all dialogs will be initialized at the time of search. Therefore, we should wait a bit longer when typing on the search bar to get the results... - remove the default parameter "nNumberOfNode" from initializeFirstNDialog() - rename initializeFirstNDialog() to initializeAllDialogs() Change-Id: I4fd9c5673f7edecfe6a6621b6018d5d405f112a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167023 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Moritz Duge <moritz.duge@allotropia.de> (cherry picked from commit dd3953f705cc19aad4b0fcec7fd2961246b659e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167222 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* tdf#159683 sw content controls, plain text: fix crash with the clipboard docMiklos Vajna19 hours3-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Regression from commit c804c5354855188b5a37219cfe11dc079dc235f4 (sw content control: fix lost properties on copy&paste, 2023-03-10), select a plain text content control, copy it to the clipboard, quit: assertion fails during shutdown because the doc's "placeholder text" char style is still referenced by a client. What happens here is that the SwContentControl copy ctor copies the plain text flag, and that flag is only read in SwTextNode::InsertHint(), so that causes the problem. Note how that code is inconsistent: we avoid the creation of dummy characters in the copy case, but we still try to adjust the start/end of the content control attribute in the copy case, which makes not much sense. Fix the problem by not adjusting the content control attribute boundaries in the copy case, since the original intention was to do thees corrections only at a UI level, during interactive edit. It's not clear why this inconsistency had an influence on the clients of the char style, though. Change-Id: I86b0516464f24fc453dcd97588dafb8afd010a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166882 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 06aeb9c61d50bba7edafe17f9d3513af26b0782f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167311 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Related: tdf#160833 teach DOC export about DoNotMirrorRtlDrawObjsMiklos Vajna20 hours3-0/+30
| | | | | | | | | | | | | | | See <https://gerrit.libreoffice.org/c/core/+/167033/1#message-e1df9bf60b7b8b2acdf0c062484ddc572939a3d9>, no need to undo the import-time mapping in case we know that the mirroring is avoided at a layout level. Change-Id: Idbdc10ad327540dc5045e9b19dd42160b5139470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167049 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 9d95eb980ef12678f6fb978badcbe1cacbe0c4dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167084 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/Miklos Vajna20 hours3-6/+32
| | | | | | | | | | | | | | | | | | | The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the anchor paragraph is RTL, so swapped the "from left" label to a "from right" label. Don't do this when the compat option is enabled, so not only we render correctly but the UI now correctly explains why we came up with the correct position. Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167031 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 0f410680461d7ba5f70dd65b2a8263dec15ac357) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167083 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* fix linker error for PCH buildThorsten Behrens30 hours1-0/+1
| | | | | | | | | | | | | | | | | | | | | Error was: ld.lld: error: undefined symbol: LanguageTag::~LanguageTag() >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119) >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&)) >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119) >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&)) >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119) >>> core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<CharClass, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&>(CharClass*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&)) >>> referenced 5 more times Change-Id: Ie84d062d1815aa8e8118171862e0f8f64331d769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166346 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit b4be47efb848bd5209cb1f2d915c22814b516d32) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166896 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
* update creditsChristian Lohmaier34 hours1-1002/+1022
| | | | | Change-Id: Ibdf64d7605c81e9006c1637a85a4a539993dffa6 (cherry picked from commit 6b62ff0eaf499eb8c2ed4af3413757f38bc97dcb)
* tdf#160153 Restore Storage config itemSamuel Mehrbrodt35 hours1-0/+5
| | | | | | | | | | | | | | | | | Revert "[API CHANGE] Remove deprecated Storage config item" This reverts commit 3cee7edeb31ac64e078159c7a63ebf4f54793da7. As documented in the bug report, the config item is still used. Thus, remove the deprecation notice, too. Change-Id: Ia9beefe8e98bce8d70c546d27999d81c5cc9fd62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166904 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins (cherry picked from commit 80fcd2290dfc9748bb7f4e322b22b773b61daa67) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167219 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#160402 writerfilter: extend StyleMap with all Word stylesMichael Stahl42 hours2-54/+367
| | | | | | | | | | | | | | | | | There doesn't appear to be an accurate and complete documentation of all the Word built-in style names, but fortunately Word writes them all into styles.xml in a w:latentStyles element anyway. It turned out that a lot of the Writer built-in style names here were obsoleted by renaming and did not match any more. Change-Id: Ic69785a34524f667b83a06a267715b2c8b0165d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167242 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 72ea1005b987159a6a59f9379e63321e0b0dd44f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167261 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#40142 sw: only check level for table of contentsMichael Stahl43 hours1-1/+2
| | | | | | | | | | | | | | | | Only Table of Contents has level settings, the level is always 0 for the other ToX types, which erroneously excludes nodes (as can be seen with testFDO77715 failing with upcoming tdf#160402 bugfix). (regression from commit 5c04c4474236cc50009aea6d89f7c443c861af19) Change-Id: Iec1c2b8eaba0ad20b2ad7d8c6b20603315a7a83d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167096 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7178d6197b892e456a8db8a3d085a24bfd52cf32) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167212 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* android-viewer translated using WeblateWeblate43 hours4-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chinese (Traditional) currently translated at 100.0% (132 of 132 strings) Change-Id: Iadede33683d02d01c5c0781af18b41328fc2f01a android-viewer translated using Weblate Portuguese (Brazil) currently translated at 100.0% (132 of 132 strings) Change-Id: Ide5e2c3964faad4656cb8b7d5302604d87074ea5 android-viewer translated using Weblate Dutch currently translated at 100.0% (132 of 132 strings) Change-Id: Ia4659494c08701dd9939596321bcb5955bfe830f android-viewer translated using Weblate Czech currently translated at 100.0% (132 of 132 strings) Change-Id: If43f5f750e95e9eb93f9051e6370c9a0f27a7f06 Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org> Co-authored-by: Po-Yen Huang <jeff.huang@ossii.com.tw> Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com> Co-authored-by: kees538 <kees538@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/cs/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/nl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/pt_BR/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/zh_Hant/ Translation: android-viewer/android-strings-24-2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167251 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#160402 writerfilter,sw: STYLEREF field can refer to character styleMichael Stahl43 hours3-26/+58
| | | | | | | | | | | | | | | Adapt SwGetRefFieldType::FindAnchor() to search for SwTextCharFormat, and ApplyClonedTOCStylesToXText() to replace "CharStyleName". Works for the "Intensive Hervorhebung" field in bugdoc. Change-Id: Iee126eeb4cc2ff1c570941e3beefd93527c56fee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167098 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit d4fdafa103bfea94a279d7069ddc50ba92f67d01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167244 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#160402 filter,writerfilter: import locale-dependent STYLEREF namesMichael Stahl43 hours8-58/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Handle STYLEREF style the same way as TOC style on import. * Word 2013 does not uppercase the first letter ("Überschrift 1" -> "berschrift1") and there doesn't appear to be any justification why the code does that. * The style that's applied is actually the display style name so convert from source's m_sConvertedStyleName. * Change the logic in DomainMapper_Impl::ConvertTOCStyleName() to explicitly check and clone only known built-in Word styles, which are the ones that are translated. * This requires some refactoring, and to add the built-in styles in the bugdoc to the "StyleNameMap", which is probably still incomplete... * Exporting to DOCX appears to work without changes. * Somehow this causes the testFDO77715 to have an outlinelevel of 1 on the TOC paragraphs now, but that turns out to be a bugfix. Change-Id: I73bc1d1819e5cecbba2fef9cd6d290682a02a638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167097 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167243 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#160855 fix crash due to Skia's internal maximum pixel limitPatrick Luby45 hours1-2/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Somewhere in the tens of thousands of selected fill cells, the size of the VirtualDevice exceeds 1 GB of pixels. But Skia, at least on macOS, will fail to create a surface. Even if there is ample free memory, Skia/Raster will fail. The second problem is that even if you disable Skia, the crash is just delayed when a BitmapEx is created from the VirtualDevice and malloc() fails. Since this data flavor really triggers one or more system memory limits, lower the resolution of the bitmap by keeping the VirtualDevice pixel size within an arbitrary number of pixels. Note: the artibrary "maximum number of pixels" limit that that Skia can handle may need to be raised or lowered for platforms other than macOS. Change-Id: Ie087f2db152470aa70521fbe5fe6c7cedd8504af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167145 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 8d9f54165d28d83092667b7bfcd0ee48ade54c87) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167215
* svx: Avoid divide by 0Xisco Fauli2 days1-1/+1
| | | | | | | | | | | | | See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs() Change-Id: Ie08c54d1a1b40bcc42da9f81c893f496fff433a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166626 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 90548039f09d4bc773bf6879a62d544adfa175db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166674 Reviewed-by: Aron Budea <aron.budea@collabora.com>
* Update git submodulesXisco Fauli2 days1-0/+0
| | | | | | | | | | | | | | | | * Update dictionaries from branch 'libreoffice-24-2' to 43715e23e6ff1f153689950db0ea1273b6a7bf3f - upgrade Ukrainian dictionaries to 6.4.4 Change-Id: Idf246940bdf58844212420975ab52c19b08327ec Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Andriy Rysin <arysin@gmail.com> (cherry picked from commit 0ca7301c3c00d6e7936fd912ba775d0008f7fee4) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166906 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* wrong ScContentTree::SelectEntryByName early return conditionCaolán McNamara3 days1-1/+1
| | | | | | | | | | Change-Id: I974f5aea545a80b0e48b50e2a2eae0729ff59691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167174 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 18b70ec7d9c4a0288f206cb64708f87a83789c00) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167085 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#159661, tdf#160773: svgio: Add unittestXisco Fauli3 days2-0/+21
| | | | | | | | | Change-Id: I2d0b96f13e02ac81b97ea347889c76770c22a989 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166509 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167053
* tdf#152906: use correct Y offsetMike Kaganski3 days3-1/+101
| | | | | | | | | | | | | | GetEditCursor now returns the position relative to the line, not to the whole text. In ImpEditEngine::CreateLines, its use wasn't fixed, and so the Y position of all lines in the calculation was the same, thus adjusting to the same contour's horizontal stripe. Change-Id: I16362bab47f3064281eefb45a12834d836a8ada3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167042 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167188
* Related: tdf#160056 1 entry is more common than no entriesCaolán McNamara3 days1-9/+9
| | | | | | | | | | Change-Id: I78fe8969120f894cf5c0a71fb61611af2d203d18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 7f2283c2986ff94766cc1d2c076fb34a2c88a31a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166302 Reviewed-by: Eike Rathke <erack@redhat.com>
* Related: tdf#160056 don't call GetParamCount twiceCaolán McNamara3 days1-13/+18
| | | | | | | | | | | GetParamCount: 290ms -> 175ms Change-Id: Ic3a26b1e8035744dcab2da69a8ebd3b29dd2160a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 030b655963c182693c7b657dc6aa4d2fe85c17c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166301 Reviewed-by: Eike Rathke <erack@redhat.com>
* Related: tdf#160056 don't set nVal twiceCaolán McNamara3 days1-6/+12
| | | | | | | | | | Change-Id: I0da3e0c7f18271f6104d52b50d65e96564650b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 63b237e1e8147f54e6d4db4671f612a656200e2f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166300 Reviewed-by: Eike Rathke <erack@redhat.com>
* Related: tdf#160056 all maTokens are FormulaTypedDoubleToken*Caolán McNamara3 days1-2/+2
| | | | | | | | | | Change-Id: I6eacaf58c25ef9c5cb930a79177471c79a6a26c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit adbbe732e7ed7f3a749e04f1d9023989c972ec22) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166299 Reviewed-by: Eike Rathke <erack@redhat.com>
* Related: tdf#160056 various functions and objects that can be constCaolán McNamara3 days5-18/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this formatter can be const Change-Id: I2cd83140585e0b7027bb1c165a8d59e51cbbaad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164728 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> SvNumberformat::ImpGetFractionOfSecondString can be const Change-Id: If7a31f8b3667d9a6b8719553567211071bd2d631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164774 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> ImpIsEntry can be const Change-Id: Id229344a68925a1bde84f2b4aad46cfc5f01b797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> SvNumberformat::ImpGetLogicalOutput can be const Change-Id: I847e5de84f0636b5a169f383e319a6b8707cc31f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164773 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> SvNumberFormatter::GetUserDefColor can be const Change-Id: If499e28e5ac69018b35b475a73ecb2dc4b78dad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> These methods can be const too Change-Id: Iaef46216dac6584f57b7933d658384f54d0a4544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166125 Reviewed-by: Eike Rathke <erack@redhat.com>
* cid#1596833 Uninitialized pointer fieldCaolán McNamara3 days1-1/+2
| | | | | | | | | | Change-Id: I1f05ef494e7e28bd105b7658072c33b2d274a803 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167159 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 66916b20818e4fc4a25d711b3860b4096e575a5c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167080 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#160706 speed up loading conditional formatting rule in XLSNoel Grandin3 days1-1/+2
| | | | | | | | | | | | | we only need to finalizeImport on the last ExtDxf we loaded, otherwise we end up with an O(n^2) performance problem Change-Id: I566ef43189a1bb7ac7c55e1bccf9445c9cea19b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166179 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit dac30c44c606232ce23d52a423d0bf8010f25d4f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167077 Tested-by: Jenkins
* tdf#160833 DOCX import: use the DoNotMirrorRtlDrawObjs compat flagMiklos Vajna3 days5-0/+118
| | | | | | | | | | | | | | | | | The bugdoc has a shape which should be on the right page margin, but it was on the left page margin. Use the new compat flag to have a layout that matches Word. This way we don't need to unmap the tweaked position at export time (a limitation that the DOC filter has). Change-Id: I38dfae370f275d9f0897198e7b0569f2d91dd352 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166993 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167044
* tdf#160833 sw DoNotMirrorRtlDrawObjs: add layoutMiklos Vajna3 days2-1/+52
| | | | | | | | | | | | | In case this flag is active (intended for DOCX files), then don't automatically mirror the position of drawing objects, just because they are anchored in an RTL text node. Change-Id: Ie743d94ecb511d7de89e8e1e8303896370ce58c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166883 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167043
* tdf#160375 Base displays and gives the full name of the tablePierre3 days2-6/+9
| | | | | | | | Change-Id: Icc8c6d85cc5a88461b7bd02487513e0e864bacef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166093 Reviewed-by: Pierre Vacher <prrvchr@gmail.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#160924: SDK: typo SDK_HOME instead of OO_SDK_HOME for linuxJulien Nabet4 days1-1/+1
| | | | | | | | | | | Change-Id: I8ec2bc31b19cc6b724a6f7ea3238dda8cf60d4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167111 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 6aa2e8fe2b0b59e2fe20191decb9bd6202dabcc9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167073 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
* android-viewer translated using WeblateWeblate4 days10-1/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Polish currently translated at 100.0% (132 of 132 strings) Change-Id: I803a8b0f3608066df8864e44451eb3dfc9b06c32 android-viewer translated using Weblate Italian currently translated at 100.0% (132 of 132 strings) Change-Id: I52367b9e9d91c4e4bd50914861100cdf7f440e78 android-viewer translated using Weblate Armenian currently translated at 100.0% (132 of 132 strings) Change-Id: Ice049f5f95394783ba8b214c9bf069c67aff7317 android-viewer translated using Weblate Upper Sorbian currently translated at 100.0% (132 of 132 strings) Change-Id: If58610f0e164867babefb7c2eeaadeac0b87a5a6 android-viewer translated using Weblate French currently translated at 100.0% (132 of 132 strings) Change-Id: I460e0276b6c98ec33ceefde14d5878f51127ed93 android-viewer translated using Weblate Spanish currently translated at 100.0% (132 of 132 strings) Change-Id: I96ea9a573188a68937500563f0100e999554b1a0 android-viewer translated using Weblate Lower Sorbian currently translated at 100.0% (132 of 132 strings) Change-Id: I61a5e85484ee942c1ec49a4a98b302739a01e864 android-viewer translated using Weblate Catalan currently translated at 100.0% (132 of 132 strings) Change-Id: Iebb2ed1a53aef3bc46790bbaf43527837d77e1b6 android-viewer translated using Weblate Asturian currently translated at 99.2% (131 of 132 strings) Change-Id: I3a93bbccc61931662cbecb4466c49589e026b37a android-viewer translated using Weblate Turkish currently translated at 100.0% (132 of 132 strings) Change-Id: I3b39853d9be20c69c1b7a95a87dcdd204f7f58b0 Co-authored-by: Adam Rak <kitynska@gmail.com> Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Michael Wolf <milupo@sorbzilla.de> Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com> Co-authored-by: Valter Mura <valtermura@gmail.com> Co-authored-by: gokhan <ggurbet@gmail.com> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/ca/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/dsb/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/es/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/hsb/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/hy/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/pl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/tr/ Translation: android-viewer/android-strings-24-2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167133 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Fix a thinko in 8a97f1ba8d9ccb65b2c89106de20666311d90c30Mike Kaganski5 days1-1/+1
| | | | | | | | | Change-Id: I07bb67e9384470269d1fd3df087acee377cce729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166490 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167052
* tdf#160773: handle 0-size font heightMike Kaganski5 days1-2/+11
| | | | | | | | | | | | | Regression from commit cc3663bbaed4f65d64154e5f9abb51a5f622f710 (tdf#160702: improve text positioning, 2024-04-20), where I didn't know yet that this was possible :-) Change-Id: I1316db48b8acbacd077eeb4a8989c3dbf7e4a7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166425 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167051
* tdf#155651: Add support for "context-stroke"Xisco Fauli5 days5-4/+68
| | | | | | | Change-Id: Ib4f4a7b644d0d6c6b36e31b80fd7adc18999110d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166908 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
* tdf#157103: fix SVG whitespace handlingMike Kaganski6 days4-90/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previous code tried to hack some tricks to restore whitespaces after trimming them according to the xml:space attribute value. But it was wrong in multiple ways. 1. The collapsed space must stay in the block where its start was. When a block ended with a space, then trimming the space from it, and adding to a next block, can change the size of the space. 2. The shift of a line (e.g., specifying x and y values) doesn't end the logical line. A space before such a shift must be kept by the same rules, as if there weren't a shift. 3. A block with xml:space="preserve" is treated as if it consists of all non-whitespace characters, even if its leading or trailing characters are spaces. I.e., a trailing space in a block before, or a leading space in a block after, should be collapsed into a single space, not removed - even when the space-preserving block itself is made invisible. Change-Id: Ic778d1e9d6b9d0c342ea74ad78d44bb47bc8d708 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166239 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167050 Tested-by: Jenkins
* tdf#160916: typo "Checbox"Julien Nabet6 days1-1/+1
| | | | | | | | | | | | Change-Id: Ia06bc947cd1788850251b1386977ef0229dddd8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167030 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins (cherry picked from commit 68008d9f0176c43ecc768af8e3539227640d1519) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166905 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#160702: improve text positioningMike Kaganski6 days5-62/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Opening an SVG with text in different elements (e.g., tspans) in the same text element performs calculations to position the parts properly (i.e., the next part will start where the previous part ended, unless the position in overridden explicitly). These calculations require to know the text widths. The first problem leas here: the text width was calculated for a typically small text size (numerically equal to the pixel size defined in the SVG), but these calculations aren't truly linear, because font rendering may change depending on font height. Additionally, the rounding gives much higher error in smaller sizes than in larger. There was already a workaround for a similar problem in ViewRedirector::createRedirectedPrimitive2DSequence, where a large font (with 100 times greater height) was used to increase correctness. This was also used here, with the same large height (50000) used as a reference. Then, at the time of wrawing the text at different zoom levels, the code in VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D creates a font of a calculated size, and uses it to output the text. But the font is always created with an integral height, which means, that for a wanted height of 2.5 (in a zoomed out view), the really used height will be 3, which is 20% larger; or for wanted height of 2.4, the actual height will be 2 (20% smaller). This resulted in odd jumps of the text widths, when the text may overlap the following part, or conversely, create a big gap before the next gap. To try to mitigate that, the function now takes the difference between the wanted and the actual font size into account, and adjusts the MapMode accordingly. This doesn't fix the jumping completely (e.g., because of the mentioned special handling of small font sizes in the fonts thenselves, like hinting), but still makes the calculations much more stable, decreasing the amount of jumping. Similar changes are made in TextLayouterDevice. Use of the functions that return text size as a double, not rounded value, should additionally help improving stability. Change-Id: I455845d8ca43ee9c06a0fc980947f35d8a25797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166238 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166468
* tdf#160622: Let SalLayout::GetBoundRect return basegfx::B2DRectangleMike Kaganski6 days9-38/+87
| | | | | | | | | | | | | | | | This avoids premature rounding in TextLayouterDevice::getTextBoundRect. The box in D2DWriteTextOutRenderer::performRender needs to be expanded to allow room for the line width (which now will be guaranteed on all sides; previously, the rounding could happen to give no room on some side, even prior to commit 8962141a12c966b2d891829925e6203bf8d51852). Fixes some lines partially cut off in smaller text (or zoomed out). Change-Id: I07335136021f894cf045363b4d736bfab06c64d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167014
* tdf#160833 sw: add a DoNotMirrorRtlDrawObjs compat flagMiklos Vajna6 days7-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | The DOCX bugdoc has a circle shape anchored inside an RTL paragraph: this shows up on the right hand side in Word, but on the left hand side in Writer. What happens is that Writer implicitly mirrors draw objects anchored in RTL paragraphs, while Word doesn't do this. Start fixing the problem by adding a new layout compatibility flag that can be used by the DOCX import in the future, to leave the behavior unchanged for new & existing ODT documents. An alternative would be to do something similar to the DOC import's SwWW8ImplReader::MiserableRTLGraphicsHack(), but 1) we don't have the page margins by the time we import the shape and 2) as its name says, it doesn't feel like a clean solution, it's better to handle this difference at a layout level. Change-Id: I2ec067d86c7fbdbe57e4cd9547015fe25a9a56b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166820 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit c675eaf923cf579670b8ba2f7794b47be7fad39e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166845 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* android-viewer translated using WeblateWeblate6 days2-0/+26
| | | | | | | | | | | | | | | | | Turkish currently translated at 98.4% (130 of 132 strings) android-viewer translated using Weblate German currently translated at 100.0% (132 of 132 strings) Co-authored-by: Christian Lohmaier <cloph@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/de/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-24-2/tr/ Translation: android-viewer/android-strings-24-2 Change-Id: I211f181c9e02dbb9c0ba1347bf9f584470e58d1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167015 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* tdf#160329 update objects after row sort is finishedRegina Henschel6 days3-6/+109
| | | | | | | | | | | | | | | | | | | | | | The problem was that when the object position was updated to the anchor values by recalcPos() method, the document did not yet have the new state of the hidden rows. As a result, incorrect positions were calculated. Therefore, the update of the position is moved to a place after the update of the visibility of the rows. Sorting rows must not change the visibility of objects. However, updating the visibility of rows sets all objects to visible. Now the visibility state of an object is saved and restored later so that the recalcPos() method receives the correct state for the object. Change-Id: Ia32698c1d45cd81702e6d00c5dfc100f6f6f399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f0a2969d15e3101d7f96a7fe77bca06a5d70f57a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166903 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* tdf#160898: check for nullptrMike Kaganski6 days3-3/+52
| | | | | | | | | | | | | Regression after commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda (tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09) Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166997 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* seed 24-2 branch with android translationsChristian Lohmaier7 days34-66/+3141
| | | | Change-Id: Ib5f9e545d4dbef998ed8b7a3ffbea5e7e4c0a9d3
* always check return of SfxViewFrame::Current()Caolán McNamara7 days1-11/+13
| | | | | | | | | | Change-Id: If35fe03c775aec12ec534d02d58596aebcec764f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166985 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit caf719c59c6dc8db2b6a0eab8d47760277f112a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166902 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Only run solver uitest if either lpsolve or coinbase is inThorsten Behrens7 days1-1/+6
| | | | | | | | | | Change-Id: Ic03a6df33344b92dccc9bc393d718b4011aa1613 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162034 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 580b2ecf88f7418374dff2d937c9e18f93d50381) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166897 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Resolves tdf#141778 - Size issues on view options UIHeiko Tietze7 days1-2/+1
| | | | | | | Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166894 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Unchecked HeapAllocCaolán McNamara9 days2-17/+19
| | | | | | | | | | Change-Id: Icd49d0b5f996d57d8e9518cb08fd3c3fc54fa779 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166732 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit a70a8f55973ec3e71f65335be75699f1d2a73d62) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166833 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* qt: Guard clipboard mime data with SolarMutexMichael Weghorn9 days3-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of the access to the QtClipboardTransferable mime data happens exclusively on the main thread, with the solar mutex held. However, `mimeData()`, called from `QtClipboard::getContents` didn't ensure that yet, so as Michael Stahl pointed out in [1], commit 1db5b87fe69c2375f1d66974dafcd563303c76db Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Feb 13 13:23:17 2024 +0100 tdf#156562 qt: Sync with system clipboard content if necessary introduced a data race by allowing to set new mime data. Introduce a new `QtClipboardTransferable::hasMimeData(const QMimeData* pMimeData)` that guards access to the mime data with the solar mutext as well and use that instead, so all access to the `QtClipboardTransferable` mime data is now guarded by the solar mutex. Also add an explicit note for the mime data getter/setter in the `QtTransferable` base class that subclasses allowing to update mime data are responsible for preventing data races. [1] https://gerrit.libreoffice.org/c/core/+/166141/comment/fe75f418_40c1b622 Change-Id: I01dbbb0b37a4c6ad06b4d3001ecce8b0260eb32e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166750 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 621cfc0e4120ab2b381b54268fe39bd19257df9b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166892
* qt: Avoid race on QtTransferable memberMichael Weghorn9 days2-19/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As Michael Stahl pointed out in [1], there is a data race on `QtTransferable::m_bProvideUTF16FromOtherEncoding`. Adjust the code a bit to no longer make use of the member and drop it. The QtClipboard case was fine because both methods making use of the member always run in the main thread with the SolarMutex held. For anything else, the `m_pMimeData` doesn't change don't change, so access to that member doesn't need to be guarded by a mutex and thus dropping `QtTransferable::m_bProvideUTF16FromOtherEncoding` should be sufficient to address that race at least. (Another one will be addressed separately.) [1] https://gerrit.libreoffice.org/c/core/+/166140/comment/bc1c9f11_6ad630b7 Change-Id: Iaf2fb460b129493f5627c95b6968aa57da368b4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166749 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 8939999deef4f77f19d7b2d31df09260a34affe1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166891
generated by cgit (git 2.34.1) at 2024-05-09 03:32:16 +0000