summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* build fix: missing #include <ndgrf.hxx>feature/clipboardAndras Timar2019-07-191-0/+1
| | | | Change-Id: I72caa16d3c5b5698226cc7d3f07d3d32820032d8
* Fix build: unused argumentSzymon Kłos2019-07-191-1/+1
| | | | Change-Id: Id79d9c093da21b9f68bb38a51ac5f142a69364ed
* LOK: Support detecting complex selectionsAshod Nakashian2019-07-199-1/+125
| | | | | | | Includes unit-test, but is otherwise not complete implementation. Change-Id: I5fdcd543358caab1858f6351238c21312665839c
* lok: use utf-8 for text/plain always.Michael Meeks2019-07-191-2/+5
| | | | Change-Id: Ie91f89b3dc6ba3eddcf8383948dddc7878eae4d8
* Add more powerful selection fetch & clipboard set methods.Michael Meeks2019-07-195-48/+236
| | | | Change-Id: I6633356d13480377a83a006588ec69ebcb56a93f
* Avoid odd crash where OLE object can't generate an image preview.Michael Meeks2019-07-191-0/+6
| | | | Change-Id: Ib77eca6907aa09383a96f3c9de6f7a7c4799c3bc
* lok: disable calc char-set dialog for HTML when pasting.Michael Meeks2019-07-191-1/+2
| | | | Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab
* lok: don't be prejudiced against a single missing mime-type.Michael Meeks2019-07-191-0/+3
| | | | Change-Id: Ic5004c306cbd01071c397ed1a61ef094b439a48f
* simplify ImageListNoel Grandin2019-07-196-314/+101
| | | | | | | | | we don't need an Impl pattern here Change-Id: I93d0c5904a3aee8844987c7e36c19319d071d2f4 Reviewed-on: https://gerrit.libreoffice.org/75960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in embeddedobjNoel Grandin2019-07-198-110/+56
| | | | | | | Change-Id: I11a80e540b2a7da8d8037ba45e176d5c4d85374c Reviewed-on: https://gerrit.libreoffice.org/75951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#126471 Apply selected MM printer on dialog openMichael Weghorn2019-07-191-2/+1
| | | | | | | | | | | | | | | | | | | | | | Calling 'PrinterChangeHdl_Impl' in 'SwMMResultPrintDialog::FillInPrinterSettings' makes sure that a preselected printer is actually taken into account (i.e. 'm_pTempPrinter' set accordingly etc.) as soon as the dialog is created, not only when explicitly selecting another printer. Since 'PrinterChangeHdl_Impl' is now called initially and every time another printer is selected, there's no more need to do so in 'PrinterSetupHdl_Impl' any more. This fixes the issue that printout would always happen on default printer instead of the preselected one when SwMMResultPrintDialog was opened a second time. Change-Id: I5c930ed56d1025a7e94cc98fb70c01612bda0d22 Reviewed-on: https://gerrit.libreoffice.org/75933 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Mail merge: Preselect proper printerMichael Weghorn2019-07-191-2/+0
| | | | | | | | | | | | | | | | | | | | | The proper printer has already been set a few lines above depending on the value of 'bMergePrinterExists', so it shouldn't be unconditionally overwritten here with a potentially invalid printer (using the same statement as already used 7 lines above for the 'else' case). This e.g. makes sure that the default printer is selected when no printer has been set, e.g. just after running Mail Merge Wizard on a new Writer doc, in which case no printer was selected previously. Change-Id: I922b8234be9c80536b6b0a9ba0dd19bdc39246e8 Reviewed-on: https://gerrit.libreoffice.org/75932 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* tdf#123587 Beanshell editor: Show current file name as window titleAndreas Heinisch2019-07-192-1/+10
| | | | | | | Change-Id: I7a817d19cfadc46b1f35a4e42e5a6177c1910a4b Reviewed-on: https://gerrit.libreoffice.org/75869 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in extensionsNoel Grandin2019-07-1910-36/+29
| | | | | | | Change-Id: Ib03be019b2fedc67b3114c107162722eabce0218 Reviewed-on: https://gerrit.libreoffice.org/75955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in forms..fpickerNoel Grandin2019-07-1914-63/+44
| | | | | | | Change-Id: I0aa040b6d3264d2efde5797f79994d3d65ceaddf Reviewed-on: https://gerrit.libreoffice.org/75957 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in filterNoel Grandin2019-07-1912-41/+28
| | | | | | | Change-Id: Ia437fa8f18052afa2b70dfedc1b4badcfd165d6a Reviewed-on: https://gerrit.libreoffice.org/75956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2019-07-191-7/+7
| | | | | | | Change-Id: Ifdb5ca9a9f7b6ee2c1549675da28af35c695e354 Reviewed-on: https://gerrit.libreoffice.org/72574 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Fix typosAndrea Gelmini2019-07-1911-13/+13
| | | | | | | Change-Id: Ia7486fe6c110a4a7f53f1dac82dbff3a15405fd7 Reviewed-on: https://gerrit.libreoffice.org/75947 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
* Fix typosAndrea Gelmini2019-07-1910-11/+11
| | | | | | | Change-Id: I8222cf7aae977f0e26645dea6e4cfaee94446a2c Reviewed-on: https://gerrit.libreoffice.org/75946 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
* cid#1448460 Unchecked return valueCaolán McNamara2019-07-191-1/+1
| | | | | | | | Change-Id: I5984923062338b54e016e46a8f12be72deff6822 Reviewed-on: https://gerrit.libreoffice.org/75895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#125546 DOCX import: fix overgrowth of change tracking entriesLászló Németh2019-07-195-14/+39
| | | | | | | | | | | | The same text portion could get double redlines including ParagraphFormat. This broke redline compression, sometimes resulting huge amount of redundant change tracking entries based on rsId, or losing paragraph styles after deletion. Change-Id: I5930eab2ef0bc7eb9c93a10cdd30b96cd41c9098 Reviewed-on: https://gerrit.libreoffice.org/75926 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
* loplugin:referencecasting in desktopNoel Grandin2019-07-197-28/+19
| | | | | | | Change-Id: I9ba4243bc3d6b14e66694728deb270ed74a70d01 Reviewed-on: https://gerrit.libreoffice.org/75949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in editengNoel Grandin2019-07-196-22/+16
| | | | | | | Change-Id: I584266ba58e55e6435e76180227c0a5756aa0c23 Reviewed-on: https://gerrit.libreoffice.org/75950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Move static into the getter functionMike Kaganski2019-07-191-3/+1
| | | | | | | Change-Id: I6a4ed20cc8f208fa59f12d65d3ff8287726db594 Reviewed-on: https://gerrit.libreoffice.org/75939 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:referencecasting in comphelper..connectivityNoel Grandin2019-07-1914-42/+35
| | | | | | | Change-Id: I21896885c29e9ab58ebab17b59f1480c6a06fb38 Reviewed-on: https://gerrit.libreoffice.org/75936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:referencecasting in avmedia..basicNoel Grandin2019-07-1914-98/+62
| | | | | | | Change-Id: I6790b2e3902d64fb6f714f031affa221dbaba014 Reviewed-on: https://gerrit.libreoffice.org/75934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#126334 Fix number format array in init controls.Gülşah Köse2019-07-191-3/+2
| | | | | | | | | | | | Customization changings need only selected number format object but Position changings on bullet need all existing number format array. After merge the customization and position keeping all numbering format objects (10 item) make sense. Change-Id: Iade1e154243deaed43b9d243f2ebd0c5298b42a4 Reviewed-on: https://gerrit.libreoffice.org/75784 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
* missing LDAPCaolán McNamara2019-07-193-2/+6
| | | | | | | | | | | | | | since... Make LDAP support optional commit 6776c53b7ce2e431d8636f4e5a755f50f787ec8f Date: Tue Jan 8 04:53:51 2019 -0500 Change-Id: I4268169809b0dc68b347b28523500453394937de Reviewed-on: https://gerrit.libreoffice.org/75865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:referencecasting in dbaccessNoel Grandin2019-07-1926-54/+46
| | | | | | | Change-Id: If44176f85f460afca92cfa77b3cc1f7107a41690 Reviewed-on: https://gerrit.libreoffice.org/75938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Engine to add Extension inside extension tab in NotebookBarSumit Chauhan2019-07-1912-24/+261
| | | | | | | | | | | The patch provides backend for adding the extension.Schema for the adding extension in notebookbar can be seen here https://gerrit.libreoffice.org/#/c/75134/ Change-Id: I10f0e83d1aaec5330c80b3b53cf59a21b93be015 Reviewed-on: https://gerrit.libreoffice.org/75650 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* Addons(extension) support is extended for NotebookBarSumit Chauhan2019-07-193-1/+503
| | | | | | | | | | This patch adds the schema for the extensions to be available in Notebookbar. We will adding items in addons.xcs in future if needed. Change-Id: I0a3831983b9758fac0a6fa32213ad6da20d6a97f Reviewed-on: https://gerrit.libreoffice.org/75134 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* loplugin:referencecasting in cppcanvas..cuiNoel Grandin2019-07-1915-67/+43
| | | | | | | Change-Id: Ib8a513d88575cef9c1479b91adff98170c9323e8 Reviewed-on: https://gerrit.libreoffice.org/75937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cid#1448264 silence Out-of-bounds accessCaolán McNamara2019-07-192-2/+4
| | | | | | | | Change-Id: I12267e8709d8f36acbbd6c70bfdb80a2a500e5d3 Reviewed-on: https://gerrit.libreoffice.org/75910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:referencecasting in canvas..chart2Noel Grandin2019-07-1937-159/+132
| | | | | | | Change-Id: I3a3671b5c44d1a7e5ca320d3d76dd5d902382cbc Reviewed-on: https://gerrit.libreoffice.org/75935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cid#1448351 Use after freeCaolán McNamara2019-07-191-3/+3
| | | | | | | | Change-Id: I5591303096a495565e4e3638ca8db8196fa26092 Reviewed-on: https://gerrit.libreoffice.org/75913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448451 Use after freeCaolán McNamara2019-07-191-6/+5
| | | | | | | | Change-Id: I6df7a2d117be1c8f7a3e00387006c69857a98b1c Reviewed-on: https://gerrit.libreoffice.org/75914 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448547 Unchecked return valueCaolán McNamara2019-07-191-1/+1
| | | | | | | | Change-Id: If0b19a53bba10064a81a22856cd3796dcefd1f68 Reviewed-on: https://gerrit.libreoffice.org/75903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448217 Use after freeCaolán McNamara2019-07-193-6/+6
| | | | | | | | Change-Id: Icb7700c701dd8e9b23bfe29bbedf27ddd9c8f0a1 Reviewed-on: https://gerrit.libreoffice.org/75911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* sw: fix use after free on tdf117215-1.odtMichael Stahl2019-07-192-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move the fix from 6d0ea082889c89eb8b408779f2de08da7441ff54 to SwFlyFrame::DestroyImpl() so we unregister every SwFlyFrame. ==1550==ERROR: AddressSanitizer: heap-use-after-free on address 0x615000383f56 at pc 0x7efcd70d5ab9 bp 0x7ffeb7ac7c40 sp 0x7ffeb7ac7c38 WRITE of size 1 at 0x615000383f56 thread T0 0 SwAnchoredObject::SetTmpConsiderWrapInfluence(bool) sw/source/core/layout/anchoredobject.cxx:743:32 1 SwObjsMarkedAsTmpConsiderWrapInfluence::Clear() sw/source/core/layout/objstmpconsiderwrapinfl.cxx:53:23 2 SwLayouter::ClearObjsTmpConsiderWrapInfluence(SwDoc const&) sw/source/core/layout/layouter.cxx:387:84 3 sw::DocumentLayoutManager::ClearSwLayouterEntries() sw/source/core/doc/DocumentLayoutManager.cxx:497:5 4 sw::DocumentStateManager::SetModified() sw/source/core/doc/DocumentStateManager.cxx:45:39 5 sw::DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM&) sw/source/core/doc/DocumentContentOperationsManager.cxx:3942:36 0x615000383f56 is located 342 bytes inside of 504-byte region [0x615000383e00,0x615000383ff8) freed by thread T0 here: 1 SwFlyAtContentFrame::~SwFlyAtContentFrame() sw/source/core/inc/flyfrms.hxx:159:7 2 SwFrame::DestroyFrame(SwFrame*) sw/source/core/layout/ssfrm.cxx:389:9 3 SwFrameFormat::DelFrames() sw/source/core/layout/atrfrm.cxx:2624:17 4 SwUndoFlyBase::DelFly(SwDoc*) sw/source/core/undo/undobj1.cxx:161:19 5 SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*) sw/source/core/undo/undobj1.cxx:403:5 6 SwHistoryTextFlyCnt::SwHistoryTextFlyCnt(SwFrameFormat*) sw/source/core/undo/rolbck.cxx:538:20 7 SwHistory::Add(SwFlyFrameFormat&, unsigned short&) sw/source/core/undo/rolbck.cxx:1083:50 8 SwUndoSaveContent::DelContentIndex(SwPosition const&, SwPosition const&, DelContentType) sw/source/core/undo/undobj.cxx:1020:39 9 SwUndoDelete::SwUndoDelete(SwPaM&, bool, bool) sw/source/core/undo/undel.cxx:229:9 11 sw::DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM&) sw/source/core/doc/DocumentContentOperationsManager.cxx:3939:55 Change-Id: Ia0c28c9d5792615cbb566e502374efd0f4056daf Reviewed-on: https://gerrit.libreoffice.org/75857 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* Fix typosAndrea Gelmini2019-07-191-9/+9
| | | | | | | Change-Id: I1b566ef38eaef3d6b20555e20b8353976fbdca5d Reviewed-on: https://gerrit.libreoffice.org/75927 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-07-191-1/+1
| | | | | | | Change-Id: Id35aaf69535385f99513acd80a2a1e4a4cdae861 Reviewed-on: https://gerrit.libreoffice.org/75928 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-07-191-2/+2
| | | | | | | Change-Id: I542d694bbab6ce8d07bee9345db70a64a2fc0963 Reviewed-on: https://gerrit.libreoffice.org/75924 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-07-191-1/+1
| | | | | | | Change-Id: I9840c48adae1f01f08e3dedebf93444aa49f8a97 Reviewed-on: https://gerrit.libreoffice.org/75929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* cid#1448480 Uncaught exceptionCaolán McNamara2019-07-191-2/+2
| | | | | | | | Change-Id: Ied9ff9ea5d8b40c52e20c10f709836a193d5e940 Reviewed-on: https://gerrit.libreoffice.org/75896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448489 Uncaught exceptionCaolán McNamara2019-07-191-1/+1
| | | | | | | | Change-Id: Id0c55bdf3a51d21f4d0e9cc407dbff1db5eb55f4 Reviewed-on: https://gerrit.libreoffice.org/75899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448488 Unchecked return valueCaolán McNamara2019-07-191-2/+3
| | | | | | | | Change-Id: If42c4f2215057120774b4ad7e2755e4e861bd828 Reviewed-on: https://gerrit.libreoffice.org/75898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448256 Unchecked return valueCaolán McNamara2019-07-191-1/+1
| | | | | | | | Change-Id: I13c95bdbfc3161cca3b136266c5fd2e57b34a093 Reviewed-on: https://gerrit.libreoffice.org/75870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448455 Unchecked return valueCaolán McNamara2019-07-191-2/+2
| | | | | | | | Change-Id: I4526fbd939934fc4233279d9839f72c781a588b5 Reviewed-on: https://gerrit.libreoffice.org/75894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448495 Unchecked return valueCaolán McNamara2019-07-191-1/+1
| | | | | | | | Change-Id: I8a7f347d8f3ff6195b10e5559ff0682734c54eaf Reviewed-on: https://gerrit.libreoffice.org/75900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448527 Unchecked return valueCaolán McNamara2019-07-191-1/+3
| | | | | | | | Change-Id: I024b2cc088027cfb74dc009220e75e24b7228ea2 Reviewed-on: https://gerrit.libreoffice.org/75902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>