summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* reset submodules to their corresponding branchChristian Lohmaier2018-07-042-0/+0
| | | | | | was broken after gerrit update Change-Id: I56cc1ab0e9d5bb4acb54d5ca5538fefae290253c
* Update git submodulesChristian Lohmaier2018-07-041-0/+0
| | | | | | | | | | | | | * Update translations from branch 'master' - update translations for 6.1.0 rc1 and also test the auto-update of the core module Change-Id: Id4556effa916c1d274f818bb5a5b700617fa6436 - update translations for 6.1.0 rc1 Change-Id: Ibff5b92a1b44ed2546d3ad25312e272ada2fa350
* move helpfiles pattern rule above the plaing get_target oneChristian Lohmaier2018-07-041-6/+6
| | | | | | | | | | as mac's make might pick the one without the dependency on the direcotry when trying to "make" that <module>.helpfiles target Change-Id: I60a55be118bc9a41352dad94326247b02aef1dd6 Reviewed-on: https://gerrit.libreoffice.org/56960 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* tdf#118506: Disable orientation page in read onlyXisco Fauli2018-07-041-1/+1
| | | | | | | Change-Id: I30994b95e65ddd70df7872f5cc41c339bf906f19 Reviewed-on: https://gerrit.libreoffice.org/56875 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* NB writer: add printpreview to all NB implementationsandreas kainz2018-07-044-784/+2624
| | | | | | | Change-Id: I763811ba4f0a5a9096be0b5d7f139a3acdb0086a Reviewed-on: https://gerrit.libreoffice.org/56955 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* cppcheck: variableScopeJochen Nitschke2018-07-041-4/+8
| | | | | | | Change-Id: I9a01758812e5611c313a41225ec8e04b86e3bdf3 Reviewed-on: https://gerrit.libreoffice.org/56769 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* m_nHeaderLength is always 0Jochen Nitschke2018-07-041-20/+5
| | | | | | | | | | | | | | | | | | ever since commit 3716b144265dda695d7dd447dbe692a3f84c588e Date: Mon Aug 8 15:38:59 2016 +0200 loplugin:constantparam and because (m_nPosition < m_nHeaderLength) is always false, m_pBMPHeader is unused too. Change-Id: I481e37ba75dfe4523ea49d10f94a35b045334a8d Reviewed-on: https://gerrit.libreoffice.org/56897 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* sw HTML export: use PNG fallback + RTF native data for all images for ReqIFMiklos Vajna2018-07-047-23/+147
| | | | | | | | | | | | | | | | | | | ReqIF says the image should be either PNG or has a PNG fallback and then it can be something else. We used to convert images to PNG to avoid writing any native data, but results in data loss. So instead: 1) Write the original image as an RTF fragment, so it's not lost. 2) Some ReqIF parsers expect an RTF fragment even for PNG, so make sure we always write the RTF fragment, even if that means a small duplication. Change-Id: Ida0fcaa58d56b9e11f81992307505599807353b5 Reviewed-on: https://gerrit.libreoffice.org/55430 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
* -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann2018-07-041-0/+6
| | | | | | | Change-Id: I12d5cfafab17e02dc041eff8af207ba36df9bb5a Reviewed-on: https://gerrit.libreoffice.org/56938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#82175 writerfilter: honor basedOn -none- for built-in stylesJustin Luth2018-07-043-1/+11
| | | | | | | | | | | | | | | | | | | | | This section of code was introduced when LO 5.3 commit b79b5e0d for tdf#53856 reset built-in inheritance to Standard. (Not sure why I didn't try "none" at that time.) This commit prevents settings specifically applied to LO's "Default" paragraph style from affecting built-in styles that have been re-defined by the document settings to not have any parent. I don't know why this commit would cause regressions, but it probably will so committing early in 6.2 development. Since both "Standard" and every other built-in style has had LO-specific settings cleared by SetPropertiesToDefault(), they ought to be identical, so dependence on "Standard" should be irrelevant for default values. Change-Id: Ie306d036f8667ef9ae1d51678f4e8e108d754641 Reviewed-on: https://gerrit.libreoffice.org/56919 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Check for HasAttrFlags::Protected instead ATTR_PROTECTION, tdf#68290 follow-upEike Rathke2018-07-041-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | ATTR_PROTECTION at ScAttrArray is not sufficient as also conditional formatting may apply protection to otherwise unprotected cells. This now actually enables travelling Enter->Right in the sample document of tdf#68290 to advance to the next row / first col if at the end of a row for such protected cells. This matches what the ScTabView::MoveCursorRel() call then does via ScTabView::SkipCursorHorizontal() and ScTabView::SkipCursorVertical() (additionally checking protection options for selectable cells which should be done in ScTable::GetNextPos() as well). Actually when getting things straight the call to MoveCursorRel() may not be needed anymore and MoveCursorAbs() could be sufficient, but *only* if we can differentiate between viewshell cursor travel and UNO gotoNext()/gotoPrevious() calls. Change-Id: I0fcb0ecd748bbde982b260db4f4696166cfc5e78 Reviewed-on: https://gerrit.libreoffice.org/56947 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
* enable html-help for Linux, Windows and Mac distro-configsChristian Lohmaier2018-07-044-4/+4
| | | | Change-Id: I731e9bcae221d72286f13d5ab8a117e1f1f92052
* Add font mapping test for Linux Libertine GJan-Marek Glogowski2018-07-041-9/+21
| | | | | | | | | | | | The vcl_fontfeature test needs a valid "Linux Libertine G" font, not a fallback font like DejaVuSans.ttf. Also fixes the test to work with spaces in font names. Change-Id: I6acad55c912c2ecab4b17ac7ab31021ad22d0cbc Reviewed-on: https://gerrit.libreoffice.org/56928 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* Avoid failing assert in SwDBManager::MergeMailFilesMike Kaganski2018-07-041-4/+7
| | | | | | | | | | | | | | | | | | The failing assert reproducing scenario is the steps in https://bugs.documentfoundation.org/show_bug.cgi?id=116543#c0 rMergeDescriptor.nMergeType == DBMGR_MERGE_PRINTER; rMergeDescriptor.bPrefixIsFilename is true; rMergeDescriptor.sPrefix is empty. The failing assert is unrelated to the crash in tdf#116543. It looks like the assertion was incorrect; assert on empty prefix instead. Change-Id: Ibeedb90a9fac810124283fc06aa756777fa04720 Reviewed-on: https://gerrit.libreoffice.org/56863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* add --enable-gdb-index for --gdb-index from gold/lldLuboš Luňák2018-07-043-0/+37
| | | | | | | | | https://lists.freedesktop.org/archives/libreoffice/2018-June/080437.html Change-Id: I66904333bf329e804025d4b229a0db573e21c3af Reviewed-on: https://gerrit.libreoffice.org/56566 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* add configure option --enable-ld to use GNU gold or LLVM lldLuboš Luňák2018-07-043-0/+33
| | | | | | | | | https://lists.freedesktop.org/archives/libreoffice/2018-June/080437.html Change-Id: I06214459fcebe5cc58fd7979f3cbe5ac3d97db7d Reviewed-on: https://gerrit.libreoffice.org/56417 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* add --enable-split-debug for -gsplit-dwarfLuboš Luňák2018-07-045-0/+45
| | | | | | | | | | https://lists.freedesktop.org/archives/libreoffice/2018-June/080437.html Change-Id: I2a02e23e46d7a54083249408f09fba87932b1d44 Reviewed-on: https://gerrit.libreoffice.org/56416 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
* simplify ScChartListenerCollection listener managementNoel Grandin2018-07-041-67/+19
| | | | | | | Change-Id: I95961bc77b5f07c9eb57675ce2cada79fec4a2e2 Reviewed-on: https://gerrit.libreoffice.org/56942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop usage of --dynamic-list-cpp-new/typeinfoLuboš Luňák2018-07-044-13/+4
| | | | | | | | | | | | | | | | | | | | | First of all, lld doesn't have these options, but there doesn't seem to be any point in using them anyway. They are supposed to block the effect of -Bsymbolic-functions, but: - --dynamic-list-cpp-new matters only if we'd create our own global operator new/delete, which we don't - --dynamic-list-cpp-typeinfo affects only the typeinfo (_ZTI*) and typeinfo name (_ZTS*) symbols, which are not functions, and so -Bsymbolic-functions shouldn't do anything with them. According to https://sourceware.org/bugzilla/show_bug.cgi?id=3831 my understanding is that --dynamic-list-cpp-typeinfo actually predates -Bsymbolic-functions and it was an attempt to do the same from the other direction ('bind locally everything except for this' instead of 'bind locally only functions'). Change-Id: Iadad2d78f32a2adfb9c2100fb4eb5abe75725545 Reviewed-on: https://gerrit.libreoffice.org/56739 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
* loplugin:useuniqueptr in ScDPDataDimensionNoel Grandin2018-07-042-16/+15
| | | | | | | Change-Id: I74d6fd6a291d518c26180836706e4195f1144c8f Reviewed-on: https://gerrit.libreoffice.org/56944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove now moot OSL_ENSUREEike Rathke2018-07-041-3/+0
| | | | Change-Id: Ifaf18cfa74a57898f4762a284ec088ece8b8270e
* -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann2018-07-043-0/+4
| | | | | | | | | | | (BroadcasterMixin apparently needs a one-off user-provided copy assignment op due to SvtBroadcaster's odd design of having a user-provided copy ctor and an explicitly deleted copy assignment op.) Change-Id: I8fcb5a40f82031f94c37a65e9bd54657dfd07b7e Reviewed-on: https://gerrit.libreoffice.org/56876 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann2018-07-041-0/+2
| | | | | | | | | | | | | It is apparently by "design" that SwCursor has a deleted copy ctor and non- deleted copy assignment op, see bdf3c9bff607e3977c8455927b21ba292530d25a 'sw: replace SwPaM's so-called "copy constructor'" and c23dd470d49d722197c148f4ef64a6a3350af88d "sw: same treatment for SwCursor's fake 'copy constructor'" Change-Id: I7c44dcf022fa3edbd371d5a19c547f6ebdc13204 Reviewed-on: https://gerrit.libreoffice.org/56934 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Resolves: tdf#117458 let Enter move left/right again, tdf#68290 follow-upEike Rathke2018-07-043-12/+17
| | | | | | | | | | | | | | | | | | | | Regression from commit b0a391d62c1df7525069a02913a52af940d92ecc CommitDate: Tue Jan 30 23:12:04 2018 +0100 Circular movement of cursor in a table with hidden columns/rows, tdf#68290 related where for nMoveX case nNewX - nCurX and nNewY - nCurY were both 0. Also don't abuse the bMarked flag for GetNextPos() as bUnprotected if nothing is marked, in which case also bKeepSel doesn't make sense. Change-Id: I59af09f1cfa397e68ce16d151ba7eee6e6598a75 Reviewed-on: https://gerrit.libreoffice.org/56935 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
* Notebookbar:Context for printpreview is now workingKshitij Pathania2018-07-045-4/+34
| | | | | | | | | | Also the context stuff is now working well even after print preview is set Change-Id: Ia43f512394cf4d162b4019257c039aecb664df22 Reviewed-on: https://gerrit.libreoffice.org/56740 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* tdf#118199 avoid double dispose actionsArmin Le Grand2018-07-041-2/+7
| | | | | | | | | | | Cell::dispose may be (and gets in this case) called multiple times. Do not double-cleanup stuff. Change-Id: Icb907968e8211eb4ba0bbb1c4d060eb8be9a874a Reviewed-on: https://gerrit.libreoffice.org/56924 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
* tdf#118369 Add Ellipsis to "Insert Image"Abhyudaya Sharma2018-07-041-1/+1
| | | | | | | | | Adds ellipsis to "Insert Image" in Impress Slide properties sidebar. Change-Id: I8f93d35e7fbb217cd10e9a549397d816a3e164f6 Reviewed-on: https://gerrit.libreoffice.org/56929 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* tdf#118533 RTF/DOCX import: fix beforeAutospacing for first paragraphLászló Németh2018-07-046-3/+30
| | | | | | | | | | | | | | | | | of a text frame (first bug of tdf#104354), a table cell or a document by setting zero top margin here. This bug could result non visible paragraph content in narrow frames, as in the test document of the commit. See also commit f737c9386a605cb7d8c9dbc210c557f98f6cdc19 for a similar fix for first paragraph of a shape. Fix top margins of the first paragraphs of the affected tdf#82006 and tdf#107480, adding also new paragraphs to their RTF tests cases to keep the original tests, too. Change-Id: Iea3c735eeb262233b82090fb9491991ed2df2b4e Reviewed-on: https://gerrit.libreoffice.org/56737 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
* loplugin:useuniqueptr in ScChart2DataSequenceNoel Grandin2018-07-042-5/+5
| | | | | | | Change-Id: I340d9fbde1aa53097c162b61505593ee6d9fde35 Reviewed-on: https://gerrit.libreoffice.org/56902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScTabViewNoel Grandin2018-07-047-59/+51
| | | | | | | | | and remove pDrawOld, was not being used for anything useful. Change-Id: I65ded5758ca5f7636bf7188012707410f59fb81d Reviewed-on: https://gerrit.libreoffice.org/56910 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "loplugin:useuniqueptr in SwWrongList"Stephan Bergmann2018-07-045-56/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 09d9419bf2072fdab2d7c1d1c6a8dee70b9f0f8a, which breaks tests like JunitTest_forms_unoapi_3, see valgrind log: [...] > ***** State for forms.OHiddenModel ****** > Whole component: COMPLETED(with known issues).OK > ***************************************** > Creating: forms.OImageButtonControl > LOG> Log started 04.06.2018 - 10:45:27 > LOG> creating a textdocument > ==30352== Thread 37 cppu_threadpool: > ==30352== Invalid read of size 8 > ==30352== at 0xEE952773: std::__cxx1998::vector<SwWrongArea, std::allocator<SwWrongArea> >::size() const (/usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_vector.h:806) > ==30352== by 0xEE951E8C: SwWrongList::Count() const (/sw/source/core/inc/wrong.hxx:304) > ==30352== by 0xEF389F31: SwWrongList::GetWrongPos(int) const (/sw/source/core/text/wrong.cxx:200) > ==30352== by 0xEF38A5A1: SwWrongList::Move(int, int) (/sw/source/core/text/wrong.cxx:282) > ==30352== by 0xEF285AAC: SwGrammarMarkUp::MoveGrammar(int, int) (/sw/source/core/text/SwGrammarMarkUp.cxx:40) > ==30352== by 0xEF36C41F: lcl_SetWrong(SwTextFrame&, SwTextNode const&, int, int, bool) (/sw/source/core/text/txtfrm.cxx:1462) > ==30352== by 0xEF36A12C: SwTextFrame::SwClientNotify(SwModify const&, SfxHint const&) (/sw/source/core/text/txtfrm.cxx:1676) > ==30352== by 0xEE95E937: SwModify::CallSwClientNotify(SfxHint const&) const (/sw/inc/calbck.hxx:444) > ==30352== by 0xEE95DC0D: SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) (/sw/inc/calbck.hxx:201) > ==30352== by 0xEE95B910: SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) (/sw/source/core/attr/calbck.cxx:199) > ==30352== by 0xEF41DA5E: SwTextNode::InsertText(rtl::OUString const&, SwIndex const&, SwInsertFlags) (/sw/source/core/txtnode/ndtxt.cxx:1997) > ==30352== by 0xEF4450CE: SwTextNode::InsertHint(SwTextAttr*, SetAttrMode) (/sw/source/core/txtnode/thints.cxx:1301) > ==30352== by 0xEF444C71: SwTextNode::InsertItem(SfxPoolItem&, int, int, SetAttrMode) (/sw/source/core/txtnode/thints.cxx:1247) > ==30352== by 0xEEC9DB1C: sw::DocumentContentOperationsManager::InsertDrawObj(SwPaM const&, SdrObject&, SfxItemSet const&) (/sw/source/core/doc/DocumentContentOperationsManager.cxx:2791) > ==30352== by 0xEF5997B7: SwXDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) (/sw/source/core/unocore/unodraw.cxx:727) > ==30352== by 0x3039EE14: gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77) > ==30352== by 0x3039D892: cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233) > ==30352== by 0x3039D01E: unoInterfaceProxyDispatch (/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420) > ==30352== by 0x34E513E1: binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const (/binaryurp/source/incomingrequest.cxx:236) > ==30352== by 0x34E4FA2C: binaryurp::IncomingRequest::execute() const (/binaryurp/source/incomingrequest.cxx:79) > ==30352== by 0x34E7DCAC: request (/binaryurp/source/reader.cxx:85) > ==30352== by 0x8A67426: cppu_threadpool::JobQueue::enter(long, bool) (/cppu/source/threadpool/jobqueue.cxx:107) > ==30352== by 0x8A6ED71: cppu_threadpool::ORequestThread::run() (/cppu/source/threadpool/thread.cxx:165) > ==30352== by 0x8A7187D: threadFunc (/include/osl/thread.hxx:185) > ==30352== by 0x4EC8969: osl_thread_start_Impl(void*) (/sal/osl/unx/thread.cxx:234) > ==30352== by 0x5906593: start_thread (/usr/src/debug/glibc-2.27-63-g80c83e9114/nptl/pthread_create.c:463) > ==30352== by 0x563A02E: clone (/usr/src/debug/glibc-2.27-63-g80c83e9114/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95) > ==30352== Address 0x35687808 is 40 bytes inside a block of size 136 free'd > ==30352== at 0x4C3029C: operator delete(void*) (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576) > ==30352== by 0xEF285968: SwGrammarMarkUp::~SwGrammarMarkUp() (/sw/source/core/text/SwGrammarMarkUp.cxx:24) > ==30352== by 0xEF287E1E: std::default_delete<SwGrammarMarkUp>::operator()(SwGrammarMarkUp*) const (/usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/unique_ptr.h:81) > ==30352== by 0xEF3B83B2: std::unique_ptr<SwGrammarMarkUp, std::default_delete<SwGrammarMarkUp> >::reset(SwGrammarMarkUp*) (/usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/unique_ptr.h:382) > ==30352== by 0xEF3B8306: std::unique_ptr<SwGrammarMarkUp, std::default_delete<SwGrammarMarkUp> >::operator=(decltype(nullptr)) (/usr/lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/unique_ptr.h:318) > ==30352== by 0xEF3B7BA7: SwGrammarContact::TimerRepaint(Timer*) (/sw/source/core/txtnode/SwGrammarContact.cxx:77) > ==30352== by 0xEF3B7B17: SwGrammarContact::LinkStubTimerRepaint(void*, Timer*) (/sw/source/core/txtnode/SwGrammarContact.cxx:69) > ==30352== by 0x1118CFC7: Link<Timer*, void>::Call(Timer*) const (/include/tools/link.hxx:84) > ==30352== by 0x1118CE26: Timer::Invoke() (/vcl/source/app/timer.cxx:76) > ==30352== by 0x11141A61: Scheduler::ProcessTaskScheduling() (/vcl/source/app/scheduler.cxx:448) > ==30352== by 0x11140C7C: Scheduler::CallbackTaskScheduling() (/vcl/source/app/scheduler.cxx:270) > ==30352== by 0x11368EC5: SalTimer::CallCallback() (/vcl/inc/saltimer.hxx:55) > ==30352== by 0x11367333: SvpSalInstance::CheckTimeout(bool) (/vcl/headless/svpinst.cxx:205) > ==30352== by 0x1136826A: SvpSalInstance::DoYield(bool, bool) (/vcl/headless/svpinst.cxx:417) > ==30352== by 0x111782D9: ImplYield(bool, bool) (/vcl/source/app/svapp.cxx:470) > ==30352== by 0x11172F13: Application::Yield() (/vcl/source/app/svapp.cxx:535) > ==30352== by 0x11172E9D: Application::Execute() (/vcl/source/app/svapp.cxx:450) > ==30352== by 0x514B874: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1634) > ==30352== by 0x11188B94: ImplSVMain() (/vcl/source/app/svmain.cxx:200) > ==30352== by 0x1118A7E7: SVMain() (/vcl/source/app/svmain.cxx:238) > ==30352== by 0x51C07D7: soffice_main (/desktop/source/app/sofficemain.cxx:169) > ==30352== by 0x40087C: sal_main (/desktop/source/app/main.c:48) > ==30352== by 0x400856: main (/desktop/source/app/main.c:47) > ==30352== Block was alloc'd at > ==30352== at 0x4C2F226: operator new(unsigned long) (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:334) > ==30352== by 0xEF3B7E11: SwGrammarContact::getGrammarCheck(SwTextNode&, bool) (/sw/source/core/txtnode/SwGrammarContact.cxx:123) > ==30352== by 0xEF8450B1: SwXTextMarkup::commitMultiTextMarkup(com::sun::star::uno::Sequence<com::sun::star::text::TextMarkupDescriptor> const&) (/sw/source/core/unocore/unotextmarkup.cxx:432) > ==30352== by 0x17BAD989: GrammarCheckingIterator::ProcessResult(com::sun::star::linguistic2::ProofreadingResult const&, com::sun::star::uno::Reference<com::sun::star::text::XFlatParagraphIterator> const&, bool) (/linguistic/source/gciterator.cxx:456) > ==30352== by 0x17BAB9CB: GrammarCheckingIterator::DequeueAndCheck() (/linguistic/source/gciterator.cxx:657) > ==30352== by 0x17BAB070: lcl_workerfunc (/linguistic/source/gciterator.cxx:224) > ==30352== by 0x4EC8969: osl_thread_start_Impl(void*) (/sal/osl/unx/thread.cxx:234) > ==30352== by 0x5906593: start_thread (/usr/src/debug/glibc-2.27-63-g80c83e9114/nptl/pthread_create.c:463) > ==30352== by 0x563A02E: clone (/usr/src/debug/glibc-2.27-63-g80c83e9114/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95) > ==30352== [...]
* tdf#86612 - Keep zoom visible in Writerheiko tietze2018-07-041-9/+9
| | | | | | | | | | Mandatory flags added to the statusbar Change-Id: I2605c76d579aa50efb953a475aacbc5e3a6e3abb Reviewed-on: https://gerrit.libreoffice.org/56859 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:useuniqueptr in ScCellTextDataNoel Grandin2018-07-043-15/+15
| | | | | | | Change-Id: I60a0ffe27b2bbd7d2661fc0fa288730cb71be0b2 Reviewed-on: https://gerrit.libreoffice.org/56904 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* lok: sc: ctrl-clicking links doesn't workMarco Cecchetti2018-07-044-77/+96
| | | | | | | | | | | | | | | | | | | | | I think there is no reason for not execuring the code below if ((bDouble || bIsTiledRendering) && .... ) { ... } for both desktop and online. So since the code for open the clicked URL is below such if clause, I changed the code so that we return only when it's really a double click event. Moreover I reverted back the code for executing the list validation pop-up to its original place, since there is no more the need to have it executed in two places. Change-Id: Idbec2e6e45cd7ee8282005169e1132a11d4cac33 Reviewed-on: https://gerrit.libreoffice.org/54151 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Removed duplicated includesAndrea Gelmini2018-07-042-2/+0
| | | | | | | Change-Id: Ie6e6574b031c68c0d4c9079abbe3317fab2a6123 Reviewed-on: https://gerrit.libreoffice.org/56834 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* tdf#106854 svl windows: enable CNG by defaultMiklos Vajna2018-07-041-2/+2
| | | | | | | | | | But keep the environment variable to disable it for testing purposes. This means that signing with ECDSA keys works out of the box on Windows. Change-Id: I2820deb45377c54b59cdbd27a490af9beaf62851 Reviewed-on: https://gerrit.libreoffice.org/56901 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* There should be no need for a private SwSubFont copy assignment opStephan Bergmann2018-07-042-4/+0
| | | | | | | | | | | | | | ...given that its (implicitly defined) copy ctor is public. Before ad355e2b2449421786c0abe8f9ee740e9153eae3 "New: Proportional font width" the class's members were all private, and then were gradually changed to public, that's probably the reason why the copy assignment op still is. Making it public and implicitly declared avoids -Werror=deprecated-copy with GCC trunk towards GCC 9. Change-Id: I940c04041b0447f2129aaaa48f19fec40352311e Reviewed-on: https://gerrit.libreoffice.org/56920 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typoAndrea Gelmini2018-07-041-1/+1
| | | | | | | Change-Id: I851237e46ddf83035453ae4f6c43a53e74b3aca7 Reviewed-on: https://gerrit.libreoffice.org/56882 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* loplugin:useuniqueptr in ScCellsEnumerationNoel Grandin2018-07-042-6/+5
| | | | | | | Change-Id: I2ab494c977e6c877064ba6561d850b62bef2b438 Reviewed-on: https://gerrit.libreoffice.org/56911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScCellRangesBaseNoel Grandin2018-07-042-19/+18
| | | | | | | Change-Id: I4416b012f20c71885211350e605e7ad856642fea Reviewed-on: https://gerrit.libreoffice.org/56909 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScOutputDataNoel Grandin2018-07-042-9/+6
| | | | | | | Change-Id: Ic3b8802262910502cc2f7b638e41e0e865c03f6c Reviewed-on: https://gerrit.libreoffice.org/56908 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScPreviewNoel Grandin2018-07-042-15/+11
| | | | | | | Change-Id: I081066d34ed6b134b5354f8df7f9801356ef181c Reviewed-on: https://gerrit.libreoffice.org/56907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScDrawViewNoel Grandin2018-07-042-7/+3
| | | | | | | Change-Id: Idbc47bdb3ff16d29a93365654b36b047c564de70 Reviewed-on: https://gerrit.libreoffice.org/56906 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScNoteMarkerNoel Grandin2018-07-042-3/+3
| | | | | | | Change-Id: I4880f23a6c5879807430b60e812c6c697cf69268 Reviewed-on: https://gerrit.libreoffice.org/56905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ScSimpleEditSourceHelperNoel Grandin2018-07-043-11/+14
| | | | | | | Change-Id: Iebe62753d9e6f83f985e4c55fb938d5861613898 Reviewed-on: https://gerrit.libreoffice.org/56903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make ThreadPool::pushTask take param by std::unique_ptrNoel Grandin2018-07-0414-35/+39
| | | | | | | | | | And fix leak in XclExpRowBuffer::Finalize, was not freeing the synchronous task it creates Change-Id: Id1e9ddb5d968e6b95d9d2b5ca0c9e50774580182 Reviewed-on: https://gerrit.libreoffice.org/56874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* solenv/bin/pack_images.py no longer needs executable bitStephan Bergmann2018-07-041-0/+0
| | | | | | | | | | ...after 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute pack_images.py with the right Python interpreter" removed its shebang line Change-Id: I39dfa9c57699594caad85e183d3ef90b9ecaa59b Reviewed-on: https://gerrit.libreoffice.org/56872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Menubar Calc: move document compare features to track changes groupandreas kainz2018-07-041-2/+3
| | | | | | | | | same layout than in writer Change-Id: I9fd0e745b6376c3047c4fa8408543fe11a4852ce Reviewed-on: https://gerrit.libreoffice.org/56899 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* Calc Menubar: add icons to some menubar entriesandreas kainz2018-07-043-1/+30
| | | | | | | Change-Id: Iad8334c3e0f27c39cdab54a06ca8e54de263d26b Reviewed-on: https://gerrit.libreoffice.org/56885 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* Fix typoAndrea Gelmini2018-07-041-1/+1
| | | | | | | Change-Id: I28a12befa0df6dcfcec7bad39c8691425b5b5d9d Reviewed-on: https://gerrit.libreoffice.org/56852 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins