summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Bump version to 22.05.17.1cp-22.05.17-1Aron Budea2023-07-121-1/+1
| | | | Change-Id: I3e7103abfd2f54bc6be120d64a37e521fa876f39
* lok: copy simple selection even when filteredSzymon Kłos2023-07-101-1/+2
| | | | | | | | | | | | | when selected cells contain data filtered with autofilter and regular cells after that - we get different type of selection called SC_MARK_SIMPLE_FILTERED allow copying that too Change-Id: I69f91a674f427a7b956fd87b8dc56937b3b55e86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154250 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
* Update pdfium to 5778Miklos Vajna2023-07-106-136/+89
| | | | | | | | | | | | | | | | | | | | | - external/pdfium/abseil-trivial.patch is no longer needed, upstream does what we did previously - external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git diff' - external/pdfium/include.patch is no longer needed, upstream does what we did previously Change-Id: I39a6f721e436aa53914bbf43b78ac7d86e5eac59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152244 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit dc69e7c52f12f57197f26b56c968139186d4ed5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153653 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154143 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Update pdfium to 5636Miklos Vajna2023-07-102-2/+4
| | | | | | | | | | | | | | | Some changes in the bundled libtiff, but it seems that would be for XFA which we disable, so it doesn't affect us. Change-Id: Ibadeecf20daec342fbfef6d1e89bd17f5f0095e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148652 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 47afcad0d599009c38b4597c27558ec2af58b7f8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153651 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154142 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Update pdfium to 5522Miklos Vajna2023-07-101-2/+2
| | | | | | | | | | | | | | | The internal libpng 1.6 is now dropped, but that doesn't really affect us. Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 04fd7d0f53faa08c608034707ca4a459a162712d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153650 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154141 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Update pdfium to 5408Miklos Vajna2023-07-1014-215/+42
| | | | | | | | | | | | | | | | | | | | | - drop cg-instead-of-carbon.patch.1, no longer needed after https://pdfium-review.googlesource.com/c/pdfium/+/99753 - drop AndroidNDK19.patch.1, no longer needed after https://pdfium-review.googlesource.com/c/pdfium/+/96530 - drop gcc-c++20-comparison.patch, no longer needed after <https://pdfium.googlesource.com/pdfium/+/065698acf82962a3168a0d56bb1d5964bc593d00> "Fix interaction between RetainPtr<T> and transparent comparisons" since chromium/5321 Change-Id: I1f861dd8a3d490400bb39c108bd4e767a2f45d30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 5a69fd3052bb638857f30a4cfd5913634275d23d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154140 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* sfx2: disable setting password on text documentsAshod Nakashian2023-07-071-0/+10
| | | | | | | | | | | | Since we can't preserve the password in a plain-text file, we should disable the ability to set/change it. Otherwise, it's misleading to users. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I3176243ddd2826eb07def1ff5ab251e33cb7125e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153918 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-3/+0
| | | | | | | | | | ...since 376cc3ea0fc2e0f209763a2a27c5852136332c86 "dbaccess: delete old paste autoincrement logic" Change-Id: I4ffa3ffbcc1b80091a4a3449362766334b31c5af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-2/+0
| | | | | | | | | ...since 0b6d0ac41afc72a0043e6ccdc6cdfd8648a5efdc "m_pRowMarker is unused" Change-Id: I68d23a11e4be814a23e8ede87723b9aba208b774 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-2/+0
| | | | | | | | | | ...since 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox: replace PUT_PROP macro with comphelper::makePropertyValue() calls" Change-Id: Ic90e6e579e0d546454d2acd8c3fb5b5ac50f9f5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-2/+2
| | | | | | | | | | ...since its uses got commented out with a9cc0100645deea53f27e35c7e754c9f062680d8 "chart2: Weld ChartTypePanel" Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-5/+0
| | | | | | | | | | ...ever since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter" Change-Id: Ia01b618c57318657976372257ea37ed2b1b354b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132212 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-2/+0
| | | | | | | | | ...since 35dce7a06088386f13636bc355bc35e93be6ba5d "INTEGRATION: CWS warnings01" Change-Id: Iaae91d7792348d0bf61173c5839295c8aa1b938f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-2/+0
| | | | | | | | | | ...since 8e73111faeb9620117801fee89a838a407f0b7e5 "CWS-TOOLING: integrate CWS ab72" Change-Id: Ib2fdccc36090d366ca2288b31bd1948832366c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wunused-but-set-variableStephan Bergmann2023-07-071-4/+0
| | | | | | | | | | ...since fb6c99f21e03afb85d00459ca1e1abb07e71d126 "loplugin:unuseddefaultparam in svtools" Change-Id: I08da150389bfe8dad09ca293a8f445020c3a51ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#155796 sc: fix select with merged cellsJaume Pujantell2023-07-072-157/+247
| | | | | | | | | | | | | When selecting multiple cells or modifying a selection with shift+arrow make sure that a merge group is never partially selected. This also fixes tdf#128678 Change-Id: Ida00939cec11240c0d06375feb21afa82a6876da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154048 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
* external/libnumbertext: Silence -Werror,-Wdeprecated-declarationsStephan Bergmann2023-07-042-0/+50
| | | | | | | | | | | | | | | | ...as seen now with LLVM 15 trunk libc++, which marks the std::codecvt_utf8 and std::wstring_convert functionality, deprecated since C++17, as such (<https://github.com/llvm/llvm-project/commit/3ee9a50a146c585fc92f79e742c538261f98bd4e> "[libc++] Implement P0618R0 (Deprecating <codecvt>)") Change-Id: Id34e3fea540b76591ead8ba3df4c31a71d7b4aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136776 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e37e1a7d2007bd6896027b69271774da2568e6f8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153935 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* Fix buildAron Budea2023-07-041-6/+0
| | | | | | | | | | | | | | | | | sc/source/ui/app/inputwin.cxx: In member function ‘virtual bool ScTextWnd::Command(const CommandEvent&)’: sc/source/ui/app/inputwin.cxx:1739:22: error: unused variable ‘pParaPoint’ [-Werror=unused-variable] 1739 | const Point* pParaPoint = static_cast<const Point*>(rCEvt.GetEventData()); | ^~~~~~~~~~ sc/source/ui/app/inputwin.cxx:1740:15: error: unused variable ‘aSelectionStartEnd’ [-Werror=unused-variable] 1740 | Point aSelectionStartEnd = rCEvt.GetMousePosPixel(); | ^~~~~~~~~~~~~~~~~~ After ea846af14bffc9f48862c39e6232f188df4bbe62. Change-Id: Ica1a1a8985a3fdfc2fbd38652f687bf0d8c5fc36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153934 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* lok: formulabar: use IME also on desktopSzymon Kłos2023-07-031-17/+4
| | | | | | | | | | | this makes selection always on the end of content so we can remove not matching last X chars and append new content easily Change-Id: I75cbf59f2a536f0e7969409325ac6d549046ef06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153718 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* -Werror=dangling-referenceStephan Bergmann2023-06-304-8/+9
| | | | | | | | | | | | | | | | | | | | In <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d2249cd9adf5ae638577139177a50f7e62d8abd9> "c++: Implement -Wdangling-reference [PR106393]" grew a new warning, included in -Wall, and based on some more-or-less shaky heuristics, that warns about "possibly dangling reference to a temporary". It produces quite a number of false positives, but for these uses of SfxItemSet::Get it does look plausible that the returned item references could, at least in theory, point at data that is destroyed along with the temporary SfxItemSet. Change-Id: I11afc4512db488f73170c6cfa706e9e094209550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e0121b2478526d803681d57d59af0cbf9cf602b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* sc: filter: oox: fix crash delete ScDatabarFormatDataHenry Castro2023-06-293-1/+8
| | | | | | | | | | | | | | | | | | | Unfortunately, the instance of "ScDatabarFormatData" is deleted before finalizeImport is called. The "maEntries" is not usable, the global format buffer is required to hold the reference. #1 0x7f2ef19081c0 in oox::xls::CondFormatBuffer::finalizeImport() co-23.05-asan/sc/source/filter/oox/condformatbuffer.cxx:1322:23 #2 0x7f2ef1b9999a in oox::xls::WorksheetGlobals::finalizeWorksheetImport() co-23.05-asan/sc/source/filter/oox/worksheethelper.cxx:942:22 #3 0x7f2ef58d030e in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) co-23.05-asan/sax/source/fastparser/fastparser.cxx:910:36 #4 0x7f2ef23f0e46 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) co-23.05-asan/oox/source/core/fastparser.cxx:121:15 #5 0x7f2ef23f1544 in Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ieb3840cc10372867d5462a19d9efa9771f633437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153622 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* Bump version to 22.05.16.1cp-22.05.16-1Aron Budea2023-06-281-1/+1
| | | | Change-Id: Ib1b7b82830a8d99056c6044557555c306976aeb4
* avoid some UNO queryingNoel Grandin2023-06-281-8/+7
| | | | | | | | | | Change-Id: I5fa793ab979221252f66bdd38e6950c06a66b00a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153587 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sort row-range-stylesNoel Grandin2023-06-281-1/+8
| | | | | | | | | | | | | | which reduces the amount of data-movement we do in the following loop when inserting into the sorted_vector. Shaves 2% off the load time of a large document with lots of styles. Change-Id: I8df4cc35edcc212613068af108b136c2d5acd219 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* remove unnecessary ScPatternAttr copyNoel Grandin2023-06-281-2/+1
| | | | | | | | | | | | | | | slightly speeds up loading document with large number of patterns Change-Id: I1b82145fb0f8a62da0d5a46a43594f7085ce2c22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c01fa7ff3bcd3447ea190bcc1833beb7c48a8803) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152535 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153585 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* ofz#49713 Heap-use-after-freeCaolán McNamara2023-06-282-2/+16
| | | | | | | | | | | | | | | | | | | | | | | the dtor of ScAttrArray where the std::vector<ScAttrEntry> ends up will call ScDocumentPool::Remove on each entries pPattern, assuming that a matching ScDocumentPool::Put was called on each, something that is elided if we just do a simply copy here. probably a problem since: commit dddee125cc32f1ad5228e598a7de04e9654e65c1 Date: Thu Mar 10 15:03:25 2022 +0100 load ods/xlsx with full row attributes without allocating all columns Change-Id: I3a5e2e3fa4d40343f30f9eefbabd1579d8a97e02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6c81a09e3ef239a2d7a991d00fe3620a67298b99) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153584 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sc: perf: speedup sheets with lots of repetitive...Dennis Francis2023-06-286-9/+124
| | | | | | | | | | | | row styles using a small cache of already allocated patterns that are tied to extended format id and number format id. Change-Id: I3136aef9a034635924f7b7b6d2432f9ae5c2bd15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152692 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153588 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* tdf#153466 PPTX import: fix "Custom position/size" background imageTibor Nagy2023-06-286-16/+110
| | | | | | | | | | | | | | | | | | | Custom sized background with the value "tile" was imported as "stretched", losing the preset size. Restore also the exported preset positions, and map the other values to the preset positions supported by OpenDocument/Impress. Follow-up to commit 11451781d4c562f506a3aae3732e35b92387b4db (tdf#153105 PPTX export: fix "Custom position/size" background image) Change-Id: Ibf9b487ecd31b3ad7b06bda668c51e6b7a98c4af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148482 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153581 Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
* speed up tab-switching in a calc document with a lot of graphic objectsNoel Grandin2023-06-281-3/+7
| | | | | | | | | | | | | if we are in the destructor, and we have never painted the object in question, then we don't need to do an expensive object-range calculation and invalidation Change-Id: I857c3d927142f4e90d54f79fa6c293731382f0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152434 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153582 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* Resolves: tdf#153767 Try harder to import OOXML bool shared formula resultEike Rathke2023-06-246-16/+46
| | | | | | | | | | | | | | | | | | | ... by setting the result value or if necessary recalculating even if AutoCalc is turned off for the document. Similar for other implicitly recalculating formula types. Also set a boolean number format if none. Change-Id: I2f75735707180eccf4b2c525738ac0b763901230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147425 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 05ac57f85eb622b798719db03bbdd07b79e1703a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147444 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 816b0e97f32df82a1ffc23950d5bf21760a4cd39) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153546 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* lok: use correct shell when doing undoSzymon Kłos2023-06-241-2/+5
| | | | | | | | | | | | | | | | | | | When doing undo we save EditShell reference in the context object. Later it is used to get cursor we want to move to the place where modification was done (in sw/source/core/undo/unins.cxx:281). In LOK case when 2 different sessions were used and undo was done by user A - then user's B cursor was moved. This fixes that issue. We use current shell instead of getting it indirectly through SwDoc::GetEditShell() Change-Id: I7a10ea98587f48818e8d0aaa9ad739d4eed514f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153461 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sc: prefix m_* ScViewFunctionSet class membersHenry Castro2023-06-232-138/+138
| | | | | | | | | | .. Change-Id: Ic16ae0fc6580e350444576a087c333d52296ec5e Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153405 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sc: filter: oox: fix setting value to color scaleHenry Castro2023-06-201-8/+9
| | | | | | | | | | The COLORSCALE_VALUE setValue method reset the mpCell that contains formula. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Idbbfcdc5bce78542ce671753d9a70dcd375e7966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153293 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* lok: on switching from tabbed to compact ui 2 buttons were disabledMarco Cecchetti2023-06-201-0/+2
| | | | | | | | | | | | | Number Format Increase Decimals, Number Format Decrease Decimals were not enabled on switching ui. Change-Id: Ia81a43ef40168dcbf071d071231b795f9bf8659e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153050 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit cd4ad81ca334a3d2bc90bab81502ae5350bac84d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153210 Reviewed-by: Aron Budea <aron.budea@collabora.com>
* Fix compilation with latest Xcode with iOS SDK 16.4Tor Lillqvist2023-06-201-0/+2
| | | | | | | | | | | | | | | | | | | | | Alternatively we could just remove lots of stuff that we apparently don't actually need from this file, including the problematic typedef and its uses. _Unwind_Exception_Class now gets typedeffed in <unwind_itanium.h> as uint64_t which effectively is the same as the unsigned __attribute__((__mode__(__DI__))) that is used here. Change-Id: Id96d43eb481ee4ae97dd315aa2fd741e5f627916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150702 Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150711 (cherry picked from commit c3f181fd2ff02bd4aeabd151e2fd79e38fa81331) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153305 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* Accept iOS SDK 16.5Aron Budea2023-06-201-2/+2
| | | | | | | Change-Id: Idf53c90cc3ef5c59cc9ad6151c13cc2125daf546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153304 Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* fix crash on LOKIT spelling dialogJaume Pujantell Traserra2023-06-191-0/+1
| | | | | | | | | Update active view before trying to access it's selection. Change-Id: Ic83d335216304f7122005e447f5bd1c1484d0eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153137 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* accept Apple's patch utility - pickier than GNU patch, but should be OKChristian Lohmaier2023-06-192-3/+8
| | | | | | | | | | | | | | | | macOS Ventura replaced the patch utility by Apple's version: patch 2.0-12u11-Apple (as of macOS 13.0.1) It is picker/less robust when it comes to locating matches, and absolutely refuses to apply when the hunks are out of order. Only one patch needed rework in the current codebase (master an 7-4 branch), and being more correct about the locations in the files to be patched is not a bad thing either, so accept Apple's version of patch (with a warning for now) Change-Id: I707d00958b814307b13caf9923f1de7f3919442c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143461 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Resolves: tdf#155791 export of default impress slide master to svg failedCaolán McNamara2023-06-181-2/+2
| | | | | | | | | | | Change-Id: Ie4ec64fef6d8c2c2844a01d06109ad9022714c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152913 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 366a9cdd1a0b03c1abe7ffc7515a34a8abd27754) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153149 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* cid#1532384 Out-of-bounds readCaolán McNamara2023-06-151-1/+1
| | | | | | | | | sizeof returns num of bytes, not num of elements Change-Id: I9dea109e5f322d93ee10680f120b15554efa92e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
* backport CVE-2023-1999 libwebp fixCaolán McNamara2023-06-142-0/+53
| | | | | | | Change-Id: Idce341a78e44af9940d287d2a08b02d2ee9a6dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153024 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* cid#1532366 Uninitialized scalar variableCaolán McNamara2023-06-141-1/+1
| | | | | | | | | | | Change-Id: Iea2b38149815c7025f1df0739731142f892ba016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152876 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 86b8e5563cb2d2c054befb89f7a90d6676a8ae64) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153023 Reviewed-by: Andras Timar <andras.timar@collabora.com>
* pdfium: better suport for annotations and some fixesJaume Pujantell2023-06-089-22/+133
| | | | | | | | | | | Added suport to import FreeText annotations. Added some suport to export graphical annotations. Fixed some color issues to be more inline with the pdfium library. Change-Id: I7371595ebb95594ee765ae532ca7c7d4f0499592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152548 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* lok: vcl: fix "ImplConvertToAbsPos" functionHenry Castro2023-06-071-1/+1
| | | | | | | | | | | The conversion to absolute position is ignored for mirrored graphics, otherwise, the popup window will be closed after the mouse up event. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I2cb101b07f1aa79ab8aa605637b276ad3a56ce88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152681 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sc: fix crash with document properties dialogTomaž Vajngerl2023-06-062-2/+13
| | | | | | | | | | | | | | | "ImagePreferredDPI" property was added for impress and writer, but it was not handled in calc, so it document properties dialog crashed (exception because of a non existent property). Change-Id: I9eb3f6aa7cf6d8ab48930b3071b993e073117688 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 88d8c9af7140ec25dfbcd9323b870a2da7b6f7e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152558 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
* tdf#155611: SwFrame::FindNext sometimes returns a sub-frame of this frameMike Kaganski2023-06-043-1/+76
| | | | | | | | | | | | | | | | | | | | This resulted in wrong split of the section frame, when the table frame was the last in the section, the split needed to happen after that table (i.e., at the very end of the section), and passing the table frame as pFrameStartAfter gave its last cell's subtable as pSav (i.e., the frame to move after the split). The first frame of the last cell (the one prior to pSav) got lost from the layout, and wasn't destroyed when SwRootFrame was destroyed, and then it crashed referencing destroyed root frame and view shell. Change-Id: I1a539818aa890f65e961f4185ce50916ce7e4e4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152454 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152465 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152484 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
* lok: sfx2: fix change state "SheetRightToLeft"Henry Castro2023-06-021-2/+8
| | | | | | | | | | The UNO command "SheetRightToLeft" can be disabled Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I54742c9d52eb52e36154e0aac2cdf440771eb177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152502 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* sw: fix wrong downcast in UndoManager::IsViewUndoActionIndependent()Miklos Vajna2023-05-262-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | In case a user types in one view, an other user types in an other view, finally the first user deletes, then getting the undo state resulted in a memory corruption. This went wrong in commit 2875c65946e59f5dd7968155463bf00bd71d440b (sw, out of order undo: allow a subset of a non-empty redo list, 2021-11-11), the intention was to check if we have a redo item and it has the expected type, but we checked the type of an earlier undo action that belongs to the view. Fix the problem by checking the type of the correct undo action, this was probably a copy&paste error of mine. Resolves <https://github.com/CollaboraOnline/online/issues/6412>. (cherry picked from commit f0a9d4d4eea6562e98fd92a2797d16504e1d4db5) Change-Id: I6cb2a081067695a045d86b4ef427cc5a76c0f9c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152269 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* tdf#155350 Do AutoCorrect of Input Method textCaolán McNamara2023-05-261-1/+2
| | | | | | | | | | | | | | for all of SvxAutoCorrect::IsAutoCorrectChar() chars not just quotes Change-Id: I368836ea3c2dcdcc7fbe6906d7ae886f312d73d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152107 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 1e206d5b53ed1e11f2bab2437dd6fccdab4586ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152225 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* Bump version to 22.05.15.2cp-22.05.15-2Andras Timar2023-05-241-1/+1
| | | | Change-Id: I89ba521234c721e2278b32dafc5899afa4c32ecf