summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert RULER_BORDER to scoped enumNoel Grandin2016-05-113-34/+39
| | | | | | | Change-Id: Ia8dcffe817e6f7a5f8470ce08c25103c527d221d Reviewed-on: https://gerrit.libreoffice.org/24854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert RULER_DRAGSIZE to scoped enumNoel Grandin2016-05-113-38/+40
| | | | | | | Change-Id: Iddf7562273072eb4d5d60efc730d5c40bfc79f46 Reviewed-on: https://gerrit.libreoffice.org/24852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert RULER_INDENT to scoped enumNoel Grandin2016-05-113-42/+32
| | | | | | | | | | | | Also separate out the INVISIBLE flag into it's own bit, because the constant is shared with other fields. Also fix some dubious code in SVX that was setting stuff on the field that meant nothing. Change-Id: If460be575eee38b8e9f01af4d73f93f6426c604f Reviewed-on: https://gerrit.libreoffice.org/24853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert MappingType to scoped enumNoel Grandin2016-05-116-54/+64
| | | | | | | Change-Id: I1f00e1fbdb9213d0c2f30da116684b77842282f5 Reviewed-on: https://gerrit.libreoffice.org/24851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin2016-05-1146-215/+186
| | | | | | | Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert FONT_FAMILY to scoped enumNoel Grandin2016-05-113-30/+36
| | | | | | | Change-Id: Id7cc5c76ba45cdd6a06a981ad14e83713cfe5c1a Reviewed-on: https://gerrit.libreoffice.org/24840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert BORDERWINDOW_DRAW to scoped enumNoel Grandin2016-05-112-41/+37
| | | | | | | Change-Id: I25d8c8921445749be05974af5c00e9fde82382a3 Reviewed-on: https://gerrit.libreoffice.org/24837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert BORDERWINDOW_TITLE to scoped enumNoel Grandin2016-05-113-28/+34
| | | | | | | Change-Id: I9e3088c4ba51010a013f5bbaa2bb545ffa11409b Reviewed-on: https://gerrit.libreoffice.org/24836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove unused return type from SalGraphics::SetFontNoel Grandin2016-05-1119-54/+34
| | | | | | | Change-Id: I0ca41130f5e1028a70f1242f7af3366b7c57c572 Reviewed-on: https://gerrit.libreoffice.org/24833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Change code related to setting diacritic and cluster property of a characterAkash Jain2016-05-111-17/+41
| | | | | | | | | | | To determine whether a character is a diacritic check the characters unicode combining class if the font has no GDEF table. Also change the way to determine whether a character is in a cluster or not. Change-Id: I1ef45d5ffe610216d492ce4a1caacf2c01bfde78 Reviewed-on: https://gerrit.libreoffice.org/24844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
* starmath: Drop unused non-const variant of GetLeftMostTakeshi Abe2016-05-112-17/+10
| | | | | | | | | ... resulting in one less const_cast. Change-Id: I3dad339f25524fc22e7a02b08ee7ec01b341e991 Reviewed-on: https://gerrit.libreoffice.org/24810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#99588: Fix radio button groups (and thus up/down key cycle)Katarina Behrens2016-05-101-15/+7
| | | | | | | | | | | Fix both Operations group (orig. report) as well as the other group (Shift cells) which was broken too, but since the buttons happened to be in alphabetical order, the bug didn't show Change-Id: Ib4d3dca29b286efe58f066dd20c4d4a9d6bf07dd Reviewed-on: https://gerrit.libreoffice.org/24857 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
* Assign 0 explicitly, avoiding intermediate downcastsMatteo Casalin2016-05-101-1/+1
| | | | Change-Id: I43a9adeaf7078551a3447032fbf65affab817b15
* Constify some temporariesMatteo Casalin2016-05-101-40/+37
| | | | Change-Id: I4d88975c4c4639ff933dc155bd258f1617c2198f
* This temporary Size is not really neededMatteo Casalin2016-05-101-8/+4
| | | | Change-Id: Ieb20b30bb017118acc6fcc00d175cab9b47732c2
* Use member initialization listMatteo Casalin2016-05-101-26/+26
| | | | Change-Id: I98486822d1cac8fd16c8d916011c3d99baf1f1ae
* Reorder class fieldMatteo Casalin2016-05-101-1/+1
| | | | Change-Id: I7e4c7704cba8d1e2528b966267a350bdd7394e24
* Fix code format and remove some unneeded parenthesesMatteo Casalin2016-05-101-36/+34
| | | | Change-Id: I7ffd93c98736f1904cef5c5bfcfa18dbf365cd6d
* Avoid some temporaries, constifyMatteo Casalin2016-05-101-22/+19
| | | | Change-Id: I5a9a02b5dae88679d7f39a85b26796a161688815
* Avoid some OUString temporariesMatteo Casalin2016-05-101-9/+4
| | | | Change-Id: Icd7a63ac144c9ef365e64ab09d611cdfe3edf739
* Avoid some OUString temporaries and constifyMatteo Casalin2016-05-101-16/+9
| | | | Change-Id: I4789e9c0a4c2978e703ad4f8a088c8d267cd0972
* Avoid some temporaries and constifyMatteo Casalin2016-05-101-14/+6
| | | | Change-Id: Ie9ae7edb78e3c5768e4d253ab43a1dcdcf44078c
* tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas2016-05-10144-44/+311
| | | | | | | | | ...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Fix typosAndrea Gelmini2016-05-1018-29/+29
| | | | | | | Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Presumably missing break in switchStephan Bergmann2016-05-101-0/+1
| | | | | | | | | | | | | | | | | The code was like this ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", but it looks more like the break was always missing than that it was an intended fallthrough. Note how the symmetric FIRSTRIGHT case does end in a break. Also note that in the original code, the fallthrough case RIGHT guarded its modifications with if (bTbx || n <= nPos) aInnerRect.Right() -= pCli->aSize.Width(); break; (where the surrounding if got since removed), so it was presumably less likely that an erroneous fallthrough actually caused any modifications. Change-Id: Idf7ee117f1e22dee19343684a2f56fbf464bdb7f
* Presumably missing break in switchStephan Bergmann2016-05-101-0/+1
| | | | | | | | | | | | In fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import" the case SDRDRAG_CROOK fell through to the default branch, but which was irrelevant, as the default branch's if-branch would only hit if bCroner || bVertex, in which case the SDRDRAG_CROOK's if-branch would already have hit and returned. Then dc1fddc142ab438775e2c1bae4a0e148d263ce0d "INTEGRATION: CWS cropmaster2000_DEV300: #i83933# added interactive graphic cropping" moved the case SDRDRAG_CROP in between. Change-Id: I66939fc62416e0a442b02e674d90812ce76f3b2b
* Presumably missing break in switchStephan Bergmann2016-05-101-0/+2
| | | | | | | | | | Was like that at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but as clarified on IRC: <vmiklos> sberg: doesn't look intended, i think ESCHER_Prop_lineDashing and ESCHER_Prop_fNoLineDrawDash are supposed to be mutually exclusive. Change-Id: I5ea92e6bdc9800c4511ca041c0572d1f9ffca49c
* Missing break in switchStephan Bergmann2016-05-101-0/+1
| | | | | | | | | | | First 749a0845500d69f99bf1901bab82361f67b5e4f6 "don't show area and line panel in pie chart Chart selection, tdf#94320" added the case OBJECTTYPE_DIAGRAM falling through to the default break case. Then 14237c1678167da725fee079532c4669264d697f "use trendline context for trendlines, tdf#94931, tdf#94934" added the case OBJECTTYPE_DATA_CURVE, OBJECTTYPE_DATA_AVERAGE_LINE block in between. Change-Id: I9d06b5054128c4a31381e33620f4a2b898e0e969
* -Werror=empty-bodyStephan Bergmann2016-05-101-1/+1
| | | | | | ("suggest braces around empty body in an ‘else’ statement") Change-Id: I7c6de1ed2cc1c2cc39e2c8f530866c31ab038907
* tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav2016-05-102-2/+6
| | | | | | | | | | | replaced tolower with to AsciiLowerCase() in lingucomponent/source/languageguessing/altstrfunc.cxx l10ntools/source/gL10nMem.cxx Change-Id: I1340da18b263a4a921e2e8d96c0f133fe300086e Reviewed-on: https://gerrit.libreoffice.org/24682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-104-0/+5
| | | | Change-Id: I0dd8f3c1d9330bc58cf52212c9752adf51444d3d
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-104-0/+34
| | | | Change-Id: I1f147c4a0ebc6895435722d8385131917f88ecb5
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+2
| | | | Change-Id: Id0470b3e60a455bc3807f4fa5da98cf5f1877d00
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-1012-0/+14
| | | | Change-Id: Id6e230d026184ab243e994a17515f2e5539d3646
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+1
| | | | Change-Id: Ief09facecb6243815309a59e23a5673db5e1d94d
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+1
| | | | Change-Id: I49c216ed6e1e401fcc2029c047d7a7feeb767b36
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-103-0/+37
| | | | Change-Id: I6df171debbf4940bf27898c3ff5d8597f437897f
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+2
| | | | Change-Id: Iba1556d1918a336e376c0fda5e7e14b3e890d267
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-104-0/+8
| | | | Change-Id: I8fcd7bf2583c935e060a29e43c88614681d81d13
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-104-0/+16
| | | | Change-Id: I8a42f027d4970fe31c0e713d1402668499c8dda7
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-105-0/+15
| | | | Change-Id: I796ec3b79d7c26d9efe275b4232ae85cac80b578
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-104-0/+10
| | | | Change-Id: I646abf83b4dce8c92a3ba1c136d968bb9291dd83
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-102-2/+3
| | | | Change-Id: I005943a7c7bc4f8bfc647b2cf44f143a66a7e997
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-102-0/+2
| | | | Change-Id: Ieee43fce49b7f07d6b356e8c2e34e9e92b605957
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-1/+1
| | | | Change-Id: Ib0cb61ce63b065f6e2845ef7e8da0827556110ba
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+2
| | | | Change-Id: I0dccdf984f4b171feab20e8400376cf8846ffe2e
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+1
| | | | Change-Id: I07f247f003a5522e7d655f30f7c68d1b8f7225f2
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+1
| | | | Change-Id: I041971ad00b6b2e41509fa6b877c0563748f1336
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-1/+1
| | | | Change-Id: I41dec58c163bdd33b71b3519fa0fd6eca72faae6
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-103-0/+16
| | | | Change-Id: Ib67f7cb71255a32810f09a6b7e528f024bbef9df