summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update git submodulesOlivier Hallot2018-08-021-0/+0
| | | | | | | | | | | | | | | | | | * Update helpcontent2 from branch 'master' - New 6.1 video for module's help entry pages Must be cherry-picked to 6.1 branch Added localize=false to prevent translation. Translation will be displayed in captions. Note: videos and collateral files are available in help online ONLY Change-Id: If57a384783a2e31c90b069c1f0b33746d569f800 Reviewed-on: https://gerrit.libreoffice.org/58433 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Use memcpy for string ImplNewCopy functionsNoel Grandin2018-08-021-8/+3
| | | | | | | Change-Id: If0072a2fd7d3111b48413143610025124f365207 Reviewed-on: https://gerrit.libreoffice.org/58275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* forcepoint#67 null derefCaolán McNamara2018-08-021-2/+4
| | | | | | | | Change-Id: I666c6b1795e037d3bb74d4ccc33be0e161bfb157 Reviewed-on: https://gerrit.libreoffice.org/58444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#66 make sure we don't get stuck endlessly reparsingCaolán McNamara2018-08-021-3/+8
| | | | | | | | Change-Id: Ie2733e8d7f73e5f6a072604c477e949cd944189a Reviewed-on: https://gerrit.libreoffice.org/58441 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:stringloop in variousNoel Grandin2018-08-024-58/+181
| | | | | | | Change-Id: Ia400e67108e622ae63a8d59667eae96c858f22dc Reviewed-on: https://gerrit.libreoffice.org/58463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1438196 deliberate 'Constant' variable guards dead codeCaolán McNamara2018-08-021-2/+2
| | | | Change-Id: I8b4cec8c82a5d1eb57d96908b784bbc2704ac8fa
* coverity#1438197 deliberate 'Constant' variable guards dead codeCaolán McNamara2018-08-021-1/+1
| | | | Change-Id: I4fb8a0bcfb3785fbd144ab25adbe6505684dc8c4
* forcepoint#67 detect cairo surface creation failureCaolán McNamara2018-08-021-0/+10
| | | | | | | | | | if e.g. too large Change-Id: I7de8748a5ed695c1b3ddc8c1358414f3acd68c94 Reviewed-on: https://gerrit.libreoffice.org/58453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* libxmlsec windows: no longer build the mscrypto backendMiklos Vajna2018-08-022-2/+1
| | | | | | | | | Only the mscng one is used. Change-Id: Ic8716cd465b2631da56f47d36811731be205fc3e Reviewed-on: https://gerrit.libreoffice.org/58446 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Revert rtl_alloc_preInit back to boolean argumentStephan Bergmann2018-08-024-59/+25
| | | | | | | | | | | | | | | This effectively reverts 271a663d2f098f3f665cab6da2e13b265a7eab93 "rtl: support start/stop threads around pre-init" again, now that df6ba650469a6f2fda06ef1c2e107ccdd3570505 "Remove 'officially dead now' rtl_cache slab allocator mechanism" removed the wsupdate thread. (rtl_alloc_preInit is an internal-use-only C function, so changing its arguments doesn't affect URE compatibility.) Change-Id: Ie9bce86377f9520e2600e4111ac525dddace10f8 Reviewed-on: https://gerrit.libreoffice.org/58443 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:returnconstant in cui,desktopNoel Grandin2018-08-027-30/+12
| | | | | | | Change-Id: Ieec9e3d9e2e18add9a1bc7e0e15bb8435ea51954 Reviewed-on: https://gerrit.libreoffice.org/58428 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#119029: also export rotation for data seriesMike Kaganski2018-08-024-8/+36
| | | | | | | Change-Id: I6a9895145e0c54d35bf404f209721a0c718e4446 Reviewed-on: https://gerrit.libreoffice.org/58401 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#119042: Also check if SfxViewFrame::Current() is nullptrMike Kaganski2018-08-011-2/+3
| | | | | | | Change-Id: I5ac43ff626bfb4e2e754cacead5bf87115f3ce4b Reviewed-on: https://gerrit.libreoffice.org/58447 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins
* NB calc: add tabbed compact layout to calcandreas kainz2018-08-011-0/+9629
| | | | | | | | | similar to writer Change-Id: Id8e6e2f658228a86a8460e879f1e2942a8209664 Reviewed-on: https://gerrit.libreoffice.org/58284 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* forcepoint#66 protect against infinite parse recurseCaolán McNamara2018-08-012-13/+24
| | | | | | | | Change-Id: I0313cc141469a00b7d6a5bd15400e9d5a8f686cf Reviewed-on: https://gerrit.libreoffice.org/58440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:returnconstant in chart2Noel Grandin2018-08-0117-37/+24
| | | | | | | Change-Id: If44096ccf8d176023a1b7b8ae722e04417e4c131 Reviewed-on: https://gerrit.libreoffice.org/58425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:returnconstant in connectivityNoel Grandin2018-08-0112-60/+32
| | | | | | | Change-Id: I291bebbd644095d6632841abe56c4f28b84e228d Reviewed-on: https://gerrit.libreoffice.org/58427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringloop in scNoel Grandin2018-08-0128-206/+194
| | | | | | | Change-Id: I12c020d5dd75d9c8ffcb7a2e8d6ff310628fa04d Reviewed-on: https://gerrit.libreoffice.org/58432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add operator+=(OUStringBuffer) method to OUStringNoel Grandin2018-08-0117-47/+106
| | | | | | | | | | | | | to reduce needless object creation and copying some more And fix what looks like a bug in CSS hex color parsing at line 609 in sw/../parcss1.cxx that has been there since commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import" Change-Id: Ibad42b23721a56493bd1edcd7165e6104494a5c3 Reviewed-on: https://gerrit.libreoffice.org/58357 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#118949 don't set zero auto top margin in every first paragraphLászló Németh2018-08-013-7/+8
| | | | | | | | | | | of sections, only in table cells. Partially revert of the commit 0307a62790b33ee0c02c2323a8f759e53e2035a4. Change-Id: I1daf1bc49ce1acf42a55857c1b6b92c7cbcb8e00 Reviewed-on: https://gerrit.libreoffice.org/58431 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
* Tidy up used librariesMike Kaganski2018-08-011-2/+1
| | | | | | | Change-Id: Iffe7f5075ee11585fa945363c132d7f3ff8d6f1c Reviewed-on: https://gerrit.libreoffice.org/58436 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update git submodulesMike Kaganski2018-08-011-0/+0
| | | | | | | | | | | | | | * Update helpcontent2 from branch 'master' - Revert "tdf#118187 Text for INDIRECT() in wrong place" ... and clarify the context in the example instead. This reverts commit 184324625ea1e803007b9c41ce625ae6014573f1. Change-Id: Ie51c3b960a2262e5751bdecf86ba4e174f369fff Reviewed-on: https://gerrit.libreoffice.org/57899 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Remove obsolete (cargo-cult copied) dependenciesJens Carl2018-08-011-35/+6
| | | | | | | Change-Id: I9edc18f94a33587bbb0a3bd11b4df66b7844a028 Reviewed-on: https://gerrit.libreoffice.org/58379 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
* forcepoint#60 FPECaolán McNamara2018-08-011-0/+2
| | | | | | | | Change-Id: I7de20dce834d4c41531487d79071db47e9260e73 Reviewed-on: https://gerrit.libreoffice.org/58403 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Replace rtl_cache_alloc/free with rtl_allocate/freeMemoryStephan Bergmann2018-08-012-127/+12
| | | | | | | | | | | | | | | ...as with the combination of old ce906b8096081dee15dc8cc96e570d5b0b587955 "skip tricky allocators on G_SLICE=always-malloc" and recent bc6a5d8e79e7d0e7d75ac107aa8e6aa275e434e9 "Disable custom allocator", rtl_cache unconditionally just uses malloc/free now (see also db354dfad541fe2edd64a618a2d7cc83a6be2b9e "the custom SAL allocator is no longer used" and df6ba650469a6f2fda06ef1c2e107ccdd3570505 "Remove 'officially dead now' rtl_cache slab allocator mechanism"). So simplify the code. Change-Id: Ia665fd381ee4757e2c8b3d0460363bd34efd373a Reviewed-on: https://gerrit.libreoffice.org/58424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* fix up non standard indent and stray ;Caolán McNamara2018-08-011-30/+30
| | | | | | | | Change-Id: Ica713270278046ec8f64531eb67be17787fbedf7 Reviewed-on: https://gerrit.libreoffice.org/58413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#65 pdf page visiting revisits itselfCaolán McNamara2018-08-012-4/+20
| | | | | | | | Change-Id: I6d9eb75f0850a94814fb4d69ea1442b826674496 Reviewed-on: https://gerrit.libreoffice.org/58416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#64 null derefCaolán McNamara2018-08-011-1/+1
| | | | | | | | Change-Id: I4acf03a7911aa203fc4ef10b6a96b0135d6adbbc Reviewed-on: https://gerrit.libreoffice.org/58414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#63 null derefCaolán McNamara2018-08-011-1/+1
| | | | | | | | Change-Id: Ib22ff870cd0d8cdd2350b2aa8698f5a2e3866bdc Reviewed-on: https://gerrit.libreoffice.org/58410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Dead assignmentStephan Bergmann2018-08-011-1/+1
| | | | | | | Change-Id: Ia9459d29ebe823a8e08eed0a7418e89b05ed360b Reviewed-on: https://gerrit.libreoffice.org/58412 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* forcepoint#62 null derefCaolán McNamara2018-08-011-2/+2
| | | | | | | | Change-Id: I255aeb96c3763aa106128d3463e4fd55395ef8b8 Reviewed-on: https://gerrit.libreoffice.org/58408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Use temporaries for dummy argumentsMike Kaganski2018-08-011-3/+3
| | | | | | | Change-Id: Idd91a4dedc3a37aac572343580da9587d58b0810 Reviewed-on: https://gerrit.libreoffice.org/58405 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* forcepoint#55 invalid iterator incrementCaolán McNamara2018-08-011-0/+2
| | | | | | | | Change-Id: I151602f645a48404d93e0ae64a9e1d2a6ba2bc4b Reviewed-on: https://gerrit.libreoffice.org/58384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#61 null derefCaolán McNamara2018-08-011-2/+4
| | | | | | | | Change-Id: Ia22f1df0ce3a49a8cb9b11e35895f9d1e13a2e05 Reviewed-on: https://gerrit.libreoffice.org/58406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#59 the "matrix" is always one row in heightCaolán McNamara2018-08-011-22/+16
| | | | | | | | | | | | so it can be a vector instead, and by using vector::at() instead of matrix::at() vector bounds checking is performed, unlike matrix::at() which does no checking Change-Id: Ic767c2dd884bffbf1cdff65c0980b21170612f4d Reviewed-on: https://gerrit.libreoffice.org/58396 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#57 sanity check stream signature sizeCaolán McNamara2018-08-011-0/+5
| | | | | | | | Change-Id: I5ae459e159a64f32c62278a87e37deb08ab9d6ac Reviewed-on: https://gerrit.libreoffice.org/58389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* flatten conditionalsCaolán McNamara2018-08-011-15/+14
| | | | | | | | Change-Id: I3b3e45a20c41e538849b7b0b4cdf112d8fac8fe7 Reviewed-on: https://gerrit.libreoffice.org/58388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#56 null derefCaolán McNamara2018-08-011-6/+8
| | | | | | | | Change-Id: Iaa9c4d6901a340145412fa46eaf5c292c3fb62e8 Reviewed-on: https://gerrit.libreoffice.org/58385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Update git submodulesOlivier Hallot2018-08-011-0/+0
| | | | | | | | | | | | * Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are'nt working 15 module sw a- to b- Change-Id: Ife8de2a83b4e99a2762a452c06045e1892b090b6 Reviewed-on: https://gerrit.libreoffice.org/58402 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Add missing sal/log.hxx headersGabor Kelemen2018-08-01141-1/+147
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directory sc Change-Id: I988d7d3abaedfb32516a9db88815663bf54da46e Reviewed-on: https://gerrit.libreoffice.org/58266 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* forcepoint#58 null derefCaolán McNamara2018-08-011-0/+2
| | | | | | | | Change-Id: I826890ec85a16bc05fc1e4cd068079b0f8734d07 Reviewed-on: https://gerrit.libreoffice.org/58393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#37223 insert OLE tables in text tables as native text tablesLászló Németh2018-08-011-3/+28
| | | | | | | | | | | | | | | | | | | | | | | | | to solve the long-standing problem of Calc/Writer integration, ie. now Calc table data are inserted cell by cell in Writer text tables instead of putting an unwanted second table over the original, as an OLE object. First insert the OLE table as a nested native table using paste special as RTF, and cut and paste that to get a native table insertion, removing also the temporary nested table. This fix has got correct undo, but unfortunately, also a small flash during insertion by the temporary nested table. I've tried to fix that by LockView and LockModify, but it seems, they don't help. Note: the planned solution mentioned in the original OOo issue (reported in 2004) suggested to use a hidden temporary document, but that has got poblems with clipboard usage. Change-Id: I49253239f1878bce5fc4c93494f997ed37101a1c Reviewed-on: https://gerrit.libreoffice.org/58346 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
* Access2Base - Firebird 3.0 field equivalencesJean-Pierre Ledure2018-08-011-2/+2
| | | | Review in LoadMetadata the field types array for Firebird
* Resolves: rhbz#1610692 rectangles ctor takes topleft, bottomright pointsCaolán McNamara2018-08-011-4/+4
| | | | | | | | | | | | so pass arguments in the topleft, bottomright order to avoid eventual... Gtk-CRITICAL **: 09:43:33.896: gtk_widget_queue_draw_area: assertion 'height >= 0' failed Change-Id: I2396f49470274331c49275a5e6d707f59277be4a Reviewed-on: https://gerrit.libreoffice.org/58391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* forcepoint#54 null derefCaolán McNamara2018-08-011-0/+2
| | | | | | | | Change-Id: I9ca04647b16f90bb2d2d4aa0d25b08a09c408fe0 Reviewed-on: https://gerrit.libreoffice.org/58382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Update git submodulesOlivier Hallot2018-08-011-0/+0
| | | | | | | | | | | | * Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are'nt working 14 module sw, c- to e- Change-Id: Ie5f2575114177fe7ca7b060a82fbd9b992c3bda1 Reviewed-on: https://gerrit.libreoffice.org/58377 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update git submodulesOlivier Hallot2018-08-011-0/+0
| | | | | | | | | | | | * Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are'nt working 13 Module sw, f- h- Change-Id: I40bd97eb8d48951c087548f8a1f4aeeefb745f66 Reviewed-on: https://gerrit.libreoffice.org/58376 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* tdf#118521 writerfilter: ContextMargin grouped with Top/BottomJustin Luth2018-08-013-19/+45
| | | | | | | | | | | | | | | | | | | | fixes tdf#104348, but tagging with the bug# of the initial fixes. Internally, EditEng holds Top/Bottom/Context settings in one object, so if only one piece is set, the cloned object starts with docDefaults, so the un-initialized parts also need to be specified with the values they inherit from their style. So this patch makes two corrections. The first is grouping ContextMargin with top/bottom. The second correction is to check the entire style-chain instead of only the direct style for the inherited property. Change-Id: Ie1d4c9538aefece4ff8b7287242c7f4d33319b3b Reviewed-on: https://gerrit.libreoffice.org/57914 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
* Add missing sal/log.hxx headersGabor Kelemen2018-08-01126-1/+126
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from dbaccess to extensions Change-Id: I4d15aa35e11664ef78c836ffc2937c7e0bb6ea59 Reviewed-on: https://gerrit.libreoffice.org/58165 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* pdfium: replace FPDFTextObj_GetColor() patch with backportMiklos Vajna2018-08-0110-196/+167
| | | | | | | | | | | Upstream already got FPDFPageObj_GetFillColor() and FPDFPageObj_GetStrokeColor(), so what was necessary is just a FPDFText_GetTextRenderMode() to find out which one to use. Change-Id: I2f31fcadee8a4377b890e01ea62ed96bce275f2b Reviewed-on: https://gerrit.libreoffice.org/58381 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins