summaryrefslogtreecommitdiffstats
path: root/writerfilter
diff options
context:
space:
mode:
authorJustin Luth <justin_luth@sil.org>2017-08-15 12:05:21 -0400
committerJustin Luth <justin_luth@sil.org>2017-08-15 21:16:56 +0200
commitddb8f498a336cb6a76a06bb65406579e50447d39 (patch)
tree9ddf380d75d3d12763c9b90b5ea342795d0fda5c /writerfilter
parenttdf#111337 - Introduce alternative workflows at the special characters dialog (diff)
downloadcore-ddb8f498a336cb6a76a06bb65406579e50447d39.tar.gz
core-ddb8f498a336cb6a76a06bb65406579e50447d39.zip
tdf#109318 writerfilter: don't increment DropCap lines
I have no idea why the original implementation used ++nLines when setting aDrop.Lines. Unchanged since mass import from OOo in 2008 commit 614f53dda31f14fe89303dc1809fc29350c1ba29. Change-Id: If427dcea815e91d2cccb2c11044cdb393bff09e3 Reviewed-on: https://gerrit.libreoffice.org/41184 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'writerfilter')
-rw-r--r--writerfilter/source/dmapper/DomainMapper_Impl.cxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index f94d3687e149..2c282ecc394a 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1122,7 +1122,7 @@ void DomainMapper_Impl::finishParagraph( const PropertyMapPtr& pPropertyMap )
//handles (4) and part of (5)
//create a DropCap property, add it to the property sequence of finishParagraph
sal_Int32 nLines = rAppendContext.pLastParagraphProperties->GetLines();
- aDrop.Lines = nLines > 0 && nLines < 254 ? (sal_Int8)++nLines : 2;
+ aDrop.Lines = nLines > 0 && nLines < SAL_MAX_INT8 ? (sal_Int8)nLines : 2;
aDrop.Count = rAppendContext.pLastParagraphProperties->GetDropCapLength();
aDrop.Distance = 0; //TODO: find distance value
//completes (5)