summaryrefslogtreecommitdiffstats
path: root/vcl/source
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2012-08-27 20:36:23 +0100
committerCaolán McNamara <caolanm@redhat.com>2012-08-27 20:36:23 +0100
commit34091bc0e33a0aa6e839f5474e53d22a79960e68 (patch)
treebb6d7fb71f5d4c2b1481c7a1a0b3722ec419bdee /vcl/source
parentRemove ineffective password erasing security in PDF Import (diff)
downloadcore-34091bc0e33a0aa6e839f5474e53d22a79960e68.tar.gz
core-34091bc0e33a0aa6e839f5474e53d22a79960e68.zip
drop these memory trashers
some are the wrong length anyway, and anyway the copies remain untrashed, and munging immutable strings is dubious Change-Id: Ic7ac3bea35e57ed015092b3b255d48819195490d
Diffstat (limited to 'vcl/source')
-rw-r--r--vcl/source/gdi/pdfwriter_impl2.cxx3
1 files changed, 0 insertions, 3 deletions
diff --git a/vcl/source/gdi/pdfwriter_impl2.cxx b/vcl/source/gdi/pdfwriter_impl2.cxx
index 16f806bf6c7b..1855d43a7505 100644
--- a/vcl/source/gdi/pdfwriter_impl2.cxx
+++ b/vcl/source/gdi/pdfwriter_impl2.cxx
@@ -1315,9 +1315,6 @@ void PDFWriterImpl::padPassword( const rtl::OUString& i_rPassword, sal_uInt8* o_
sal_Int32 i,y;
for( i = nCurrentChar, y = 0 ; i < ENCRYPTED_PWD_SIZE; i++, y++ )
o_pPaddedPW[i] = s_nPadString[y];
-
- // trash memory of temporary clear text password
- memset( (sal_Char*)aString.getStr(), 0, aString.getLength() );
}
/**********************************