diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-12-16 15:58:31 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-12-17 00:01:39 +0100 |
| commit | e75b67c68ace40cc25ef525003d334fc56de6423 (patch) | |
| tree | 4cc1f5c280f2b9a84eebe5cabe069ab640acc182 /sw/qa/extras/tiledrendering | |
| parent | coverity#1426167 refactor to be less obscure (diff) | |
| download | core-e75b67c68ace40cc25ef525003d334fc56de6423.tar.gz core-e75b67c68ace40cc25ef525003d334fc56de6423.zip | |
coverity#1426171 Unchecked dynamic_cast
and
coverity#1426170 Unchecked dynamic_cast
coverity#1426164 Unchecked dynamic_cast
coverity#1426165 Unchecked dynamic_cast
and duplicated lines look like cnp gone wrong
Change-Id: I195204e9d0a4d591fbe210241203a17b22b25ec1
Reviewed-on: https://gerrit.libreoffice.org/46603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sw/qa/extras/tiledrendering')
| -rw-r--r-- | sw/qa/extras/tiledrendering/tiledrendering.cxx | 41 |
1 files changed, 23 insertions, 18 deletions
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index 01a5e10eecbd..4bed2db8ed28 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -1907,14 +1907,16 @@ void SwTiledRenderingTest::testDocumentRepair() int nView2 = SfxLokHelper::getView(); CPPUNIT_ASSERT(pView1 != pView2); { - std::unique_ptr<SfxPoolItem> pItem1; - std::unique_ptr<SfxPoolItem> pItem2; - pView1->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, pItem1); - pView2->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, pItem2); - CPPUNIT_ASSERT(dynamic_cast< const SfxBoolItem* >(pItem1.get())); - CPPUNIT_ASSERT(dynamic_cast< const SfxBoolItem* >(pItem2.get())); - CPPUNIT_ASSERT_EQUAL(false, dynamic_cast< const SfxBoolItem* >(pItem1.get())->GetValue()); - CPPUNIT_ASSERT_EQUAL(false, dynamic_cast< const SfxBoolItem* >(pItem2.get())->GetValue()); + std::unique_ptr<SfxPoolItem> xItem1; + std::unique_ptr<SfxPoolItem> xItem2; + pView1->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, xItem1); + pView2->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, xItem2); + const SfxBoolItem* pItem1 = dynamic_cast<const SfxBoolItem*>(xItem1.get()); + const SfxBoolItem* pItem2 = dynamic_cast<const SfxBoolItem*>(xItem2.get()); + CPPUNIT_ASSERT(pItem1); + CPPUNIT_ASSERT(pItem2); + CPPUNIT_ASSERT_EQUAL(false, pItem1->GetValue()); + CPPUNIT_ASSERT_EQUAL(false, pItem2->GetValue()); } // Insert a character in the second view. @@ -1923,14 +1925,16 @@ void SwTiledRenderingTest::testDocumentRepair() pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 'u', 0); Scheduler::ProcessEventsToIdle(); { - std::unique_ptr<SfxPoolItem> pItem1; - std::unique_ptr<SfxPoolItem> pItem2; - pView1->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, pItem1); - pView2->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, pItem2); - CPPUNIT_ASSERT(dynamic_cast< const SfxBoolItem* >(pItem1.get())); - CPPUNIT_ASSERT(dynamic_cast< const SfxBoolItem* >(pItem2.get())); - CPPUNIT_ASSERT_EQUAL(true, dynamic_cast< const SfxBoolItem* >(pItem1.get())->GetValue()); - CPPUNIT_ASSERT_EQUAL(true, dynamic_cast< const SfxBoolItem* >(pItem2.get())->GetValue()); + std::unique_ptr<SfxPoolItem> xItem1; + std::unique_ptr<SfxPoolItem> xItem2; + pView1->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, xItem1); + pView2->GetViewFrame()->GetBindings().QueryState(SID_DOC_REPAIR, xItem2); + const SfxBoolItem* pItem1 = dynamic_cast<const SfxBoolItem*>(xItem1.get()); + const SfxBoolItem* pItem2 = dynamic_cast<const SfxBoolItem*>(xItem2.get()); + CPPUNIT_ASSERT(pItem1); + CPPUNIT_ASSERT(pItem2); + CPPUNIT_ASSERT_EQUAL(true, pItem1->GetValue()); + CPPUNIT_ASSERT_EQUAL(true, pItem2->GetValue()); } comphelper::LibreOfficeKit::setActive(false); @@ -1942,8 +1946,9 @@ void checkPageHeaderOrFooter(const SfxViewShell* pViewShell, sal_uInt16 nWhich, { const SfxPoolItem* pState = nullptr; pViewShell->GetDispatcher()->QueryState(nWhich, pState); - CPPUNIT_ASSERT(dynamic_cast< const SfxBoolItem * >(pState)); - CPPUNIT_ASSERT_EQUAL(bValue, dynamic_cast< const SfxBoolItem * >(pState)->GetValue()); + const SfxBoolItem* pBoolItem = dynamic_cast<const SfxBoolItem*>(pState); + CPPUNIT_ASSERT(pBoolItem); + CPPUNIT_ASSERT_EQUAL(bValue, pBoolItem->GetValue()); }; } |