diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-10-26 10:27:48 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-10-26 10:27:48 +0200 |
commit | 084f454e8caa2d9e43f7bdea098538bfb87423d8 (patch) | |
tree | 46c900bd78b03d20886dadad92adb17cf3045d4b /sw/qa/extras/ooxmlexport/ooxmlexport7.cxx | |
parent | drop old SetBufferSize stuff (diff) | |
download | core-084f454e8caa2d9e43f7bdea098538bfb87423d8.tar.gz core-084f454e8caa2d9e43f7bdea098538bfb87423d8.zip |
More loplugin:unnecessaryparen
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when
compiling as C++17, so the ParenExpr is no longer hidden behind
ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me
the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in
loplugin:unnecessaryparen. However, that would still not look through implicit
CXXConstructExpr, so would still not have found the occurrences in
81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode.
Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not
entirely sure in which situations non-implicit CXXConstructExpr---that should
thus not be ignored---would occur, but assume they would be underneath something
like a CXXFunctionalCastExpr, which is not ignored.)
Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
Diffstat (limited to 'sw/qa/extras/ooxmlexport/ooxmlexport7.cxx')
-rw-r--r-- | sw/qa/extras/ooxmlexport/ooxmlexport7.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx index 8607ff84fca5..41cd6ac8b676 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx @@ -38,7 +38,7 @@ protected: */ bool mustTestImportOf(const char* filename) const override { // If the testcase is stored in some other format, it's pointless to test. - return (OString(filename).endsWith(".docx")); + return OString(filename).endsWith(".docx"); } }; |