diff options
author | Chris Sherlock <chris.sherlock79@gmail.com> | 2016-03-03 21:52:49 +1100 |
---|---|---|
committer | Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> | 2016-03-15 23:40:04 +0000 |
commit | a05f5238fc3811cf2c56f343a3015d5a58180677 (patch) | |
tree | 11f532053249e327398d56942c8e926b689fd32a /sw/CppunitTest_sw_filters_test.mk | |
parent | fix windows build (diff) | |
download | core-a05f5238fc3811cf2c56f343a3015d5a58180677.tar.gz core-a05f5238fc3811cf2c56f343a3015d5a58180677.zip |
tdf#79679 vcl: dashed lines show as solid lines when importing EMF files
Backported to 5.1
Issue is a regression in commit 09c722873b2d378d2d155f5f1dd7d8f3fb2012e9.
(EMF/WMF: fix rendering of pen styles (dash, dot, dashdot, dashdotdot).
I've looked at how the latest version of Word on the Mac works, and it
turns out that the spacings for the PenStyle enumerations in the LogPen
objects for all the create pen EMF records are as follows:
* PS_DOT - ■ □ ■ □ ■ □ ■ □ ■ □ ■
* PS_DASHDOT - ■ ■ ■ □ ■ □ ■ ■ ■ □ ■
* PS_DASHDOTDOT - ■ ■ ■ □ ■ □ ■ □ ■ ■ ■
(where ■ is the actual filled in area, and □ is the space between the
filled in areas)
In other words, each dash fills in the space of three dots, and there
is the one dot worth of empty space between the dashes and dots. Each
"dot" has a width and height equal to the width specified in the pen.
So basically, we seem to be arbitrarily setting the dot, dash and
distance lengths arbitrarily, which were reasonable guesses but tended
to produce very odd lines at different zoom levels.
Change-Id: Ie8b5fa396e4fb0f480cb3594c8129a59f472c1b8
Reviewed-on: https://gerrit.libreoffice.org/22886
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/22923
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Diffstat (limited to 'sw/CppunitTest_sw_filters_test.mk')
0 files changed, 0 insertions, 0 deletions