loplugin:constparams in svx

and fix a bug in the plugin itself when calling operator's like the one
on std::function<>

Change-Id: I1617607107eeff06785c1841f69e13ad2926218e
Reviewed-on: https://gerrit.libreoffice.org/40446
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 13 insertions, 13 deletions

diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index bd3f6aa62f4d..697b85222265 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -825,10 +825,10 @@ void Cell::AddUndo()
 }
 
 
-sdr::properties::TextProperties* Cell::CloneProperties( sdr::properties::TextProperties* pProperties, SdrObject& rNewObj, Cell& rNewCell )
+sdr::properties::TextProperties* Cell::CloneProperties( sdr::properties::TextProperties const * pProperties, SdrObject& rNewObj, Cell& rNewCell )
 {
     if( pProperties )
-        return new sdr::properties::CellProperties( *static_cast<sdr::properties::CellProperties*>(pProperties), rNewObj, &rNewCell );
+        return new sdr::properties::CellProperties( *static_cast<sdr::properties::CellProperties const *>(pProperties), rNewObj, &rNewCell );
     else
         return nullptr;
 }
@@ -987,7 +987,7 @@ sal_Int32 SAL_CALL Cell::getError(  )
 // XPropertySet
 
 
-Any Cell::GetAnyForItem( SfxItemSet& aSet, const SfxItemPropertySimpleEntry* pMap )
+Any Cell::GetAnyForItem( SfxItemSet const & aSet, const SfxItemPropertySimpleEntry* pMap )
 {
     Any aAny( SvxItemPropertySet_getPropertyValue( pMap, aSet ) );
 
diff --git a/svx/source/table/cell.hxx b/svx/source/table/cell.hxx
index 0d599784335a..1bd063dac3f6 100644
--- a/svx/source/table/cell.hxx
+++ b/svx/source/table/cell.hxx
@@ -67,7 +67,7 @@ public:
 
     SVX_DLLPRIVATE void cloneFrom( const CellRef& rCell );
 
-    SVX_DLLPRIVATE void setCellRect( ::tools::Rectangle& rCellRect ) { maCellRect = rCellRect; }
+    SVX_DLLPRIVATE void setCellRect( ::tools::Rectangle const & rCellRect ) { maCellRect = rCellRect; }
     SVX_DLLPRIVATE const ::tools::Rectangle& getCellRect() const { return maCellRect; }
     SVX_DLLPRIVATE ::tools::Rectangle& getCellRect() { return maCellRect; }
 
@@ -179,7 +179,7 @@ public:
 
     SVX_DLLPRIVATE sdr::properties::TextProperties* CloneProperties( SdrObject& rNewObj, Cell& rNewCell );
 
-    SVX_DLLPRIVATE static sdr::properties::TextProperties* CloneProperties( sdr::properties::TextProperties* pProperties, SdrObject& rNewObj, Cell& rNewCell );
+    SVX_DLLPRIVATE static sdr::properties::TextProperties* CloneProperties( sdr::properties::TextProperties const * pProperties, SdrObject& rNewObj, Cell& rNewCell );
 
     SVX_DLLPRIVATE void notifyModified();
 
@@ -189,7 +189,7 @@ protected:
     SVX_DLLPRIVATE virtual const SfxItemSet& GetObjectItemSet() override;
     SVX_DLLPRIVATE virtual void SetObjectItem(const SfxPoolItem& rItem) override;
 
-    SVX_DLLPRIVATE static css::uno::Any GetAnyForItem( SfxItemSet& aSet, const SfxItemPropertySimpleEntry* pMap );
+    SVX_DLLPRIVATE static css::uno::Any GetAnyForItem( SfxItemSet const & aSet, const SfxItemPropertySimpleEntry* pMap );
 
 private:
     /// @throws css::uno::RuntimeException
diff --git a/svx/source/table/tablecontroller.cxx b/svx/source/table/tablecontroller.cxx
index e3dae07e78bf..514cd49d593e 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -244,7 +244,7 @@ bool SvxTableController::onKeyInput(const KeyEvent& rKEvt, vcl::Window* pWindow
 
 namespace {
 
-Point pixelToLogic(const Point& rPoint, vcl::Window* pWindow)
+Point pixelToLogic(const Point& rPoint, vcl::Window const * pWindow)
 {
     if (!pWindow)
         return rPoint;
@@ -891,7 +891,7 @@ namespace
     }
 }
 
-void SvxTableController::onFormatTable( SfxRequest& rReq )
+void SvxTableController::onFormatTable( SfxRequest const & rReq )
 {
     sdr::table::SdrTableObj* pTableObj = dynamic_cast< sdr::table::SdrTableObj* >( mxTableObj.get() );
     if( !pTableObj )
@@ -2596,7 +2596,7 @@ bool SvxTableController::PasteObjModel( const SdrModel& rModel )
 }
 
 
-bool SvxTableController::PasteObject( SdrTableObj* pPasteTableObj )
+bool SvxTableController::PasteObject( SdrTableObj const * pPasteTableObj )
 {
     if( !pPasteTableObj )
         return false;
diff --git a/svx/source/table/tablerow.cxx b/svx/source/table/tablerow.cxx
index ceda77a7fb41..2f0df692c9bf 100644
--- a/svx/source/table/tablerow.cxx
+++ b/svx/source/table/tablerow.cxx
@@ -101,7 +101,7 @@ TableRow& TableRow::operator=( const TableRow& r )
 }
 
 
-void TableRow::insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator* pIter /* = 0 */  )
+void TableRow::insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator const * pIter /* = 0 */  )
 {
     throwIfDisposed();
     if( nCount )
diff --git a/svx/source/table/tablerow.hxx b/svx/source/table/tablerow.hxx
index 7242ae138751..57c836d64548 100644
--- a/svx/source/table/tablerow.hxx
+++ b/svx/source/table/tablerow.hxx
@@ -46,7 +46,7 @@ public:
 
     TableRow& operator=( const TableRow& );
 
-    void insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator* pIter );
+    void insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator const * pIter );
     void removeColumns( sal_Int32 nIndex, sal_Int32 nCount );
     /// Reference to the table model containing this row.
     const TableModelRef& getModel() const;
diff --git a/svx/source/table/tablertfimporter.cxx b/svx/source/table/tablertfimporter.cxx
index d1800721fdf4..61aa8c405bc9 100644
--- a/svx/source/table/tablertfimporter.cxx
+++ b/svx/source/table/tablertfimporter.cxx
@@ -91,7 +91,7 @@ public:
     void NextColumn();
     void NewCellRow();
 
-    void InsertCell( RtfImportInfo* pInfo );
+    void InsertCell( RtfImportInfo const * pInfo );
     void InsertColumnEdge( sal_Int32 nEdge );
 
     void FillTable();
@@ -212,7 +212,7 @@ void SdrTableRTFParser::NextRow()
     ++mnRowCnt;
 }
 
-void SdrTableRTFParser::InsertCell( RtfImportInfo* pInfo )
+void SdrTableRTFParser::InsertCell( RtfImportInfo const * pInfo )
 {
 
     RTFCellInfoPtr xCellInfo( new RTFCellInfo(mrItemPool) );