diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2019-03-07 14:31:17 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2019-03-12 12:36:57 +0100 |
| commit | adb08e892b37ea9e155abbdee4e0c9951a1d163b (patch) | |
| tree | 065683917390d6aca4ff6d22e2f945e48718352e /solenv/clang-format | |
| parent | weld SvxGeneralTabPage (diff) | |
| download | core-adb08e892b37ea9e155abbdee4e0c9951a1d163b.tar.gz core-adb08e892b37ea9e155abbdee4e0c9951a1d163b.zip | |
make (some) clang plugins share the same RecursiveASTVisitor
Each plugin currently uses its own recursive AST run, which adds up.
This patch adds another shared plugin which internally contains all
(suitable) plugins and dispatches to them from the same one recursive
run. This patch converts ~25 plugins and for starmath's accessibility.cxx
reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any
plugins). As there are almost 50 more plugins to go, this can theoretically
result in 4.56s final time, although probably not all plugins can be
that easily converted, if at all.
This mostly requires very little change in many plugins (see e.g.
BadStatics), some even work without any functionality change (e.g.
CharRightShift). Traverse* calls require some changes but are often
not that difficult. WalkUp* probably can't be supported, although some
plugins can(?) possibly be adjusted to not rely on them. And of course
some plugins can be left as they are, using their own recursive run.
See description at the top of generator.cxx for description of how to
convert a plugin.
The sharedvisitor.cxx source is generated based on scanning relevant
plugin sources using a clang-based scanner/generator. The generated
source is intentionally included instead of getting always generated,
as the generating currently takes some time, so it should get updated
in git whenever a change in a plugin triggers a source change in it.
Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01
Reviewed-on: https://gerrit.libreoffice.org/68026
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'solenv/clang-format')
| -rw-r--r-- | solenv/clang-format/blacklist | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist index 66bfbb85d581..6b3f4aecd914 100644 --- a/solenv/clang-format/blacklist +++ b/solenv/clang-format/blacklist @@ -1753,6 +1753,8 @@ compilerplugins/clang/sallogareas.cxx compilerplugins/clang/sallogareas.hxx compilerplugins/clang/salunicodeliteral.cxx compilerplugins/clang/sfxpoolitem.cxx +compilerplugins/clang/sharedvisitor/generator.cxx +compilerplugins/clang/sharedvisitor/sharedvisitor.cxx compilerplugins/clang/simplifybool.cxx compilerplugins/clang/singlevalfields.cxx compilerplugins/clang/staticaccess.cxx |