diff options
| author | Noel Grandin <noel@peralex.com> | 2016-04-12 12:08:00 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-14 11:37:19 +0000 |
| commit | 62633dfe026bc3badf7066e5fb454036bae9cfdc (patch) | |
| tree | b1a30ddd709ba80b8629d916d54c03d733651d12 /slideshow | |
| parent | don't export the same lib multiple times (diff) | |
| download | core-62633dfe026bc3badf7066e5fb454036bae9cfdc.tar.gz core-62633dfe026bc3badf7066e5fb454036bae9cfdc.zip | |
clang-tidy performance-unnecessary-value-param in various
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'slideshow')
4 files changed, 5 insertions, 5 deletions
diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx index d70d9a7b2e70..f6292581d2a2 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionImpl.cxx @@ -1597,7 +1597,7 @@ GLuint VortexTransition::makeShader() const return OpenGLHelper::LoadShaders( "vortexVertexShader", "vortexFragmentShader", "vortexGeometryShader" ); } -glm::mat4 lookAt(glm::vec3 eye, glm::vec3 center, glm::vec3 up) { +glm::mat4 lookAt(const glm::vec3& eye, const glm::vec3& center, const glm::vec3& up) { glm::vec3 f = glm::normalize(center - eye); glm::vec3 u = glm::normalize(up); glm::vec3 s = glm::normalize(glm::cross(f, u)); diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx index c864f87d6d8f..7ed3b028d2d7 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx @@ -175,7 +175,7 @@ public: OGLTransitionerImpl(); OGLTransitionerImpl(const OGLTransitionerImpl&) = delete; OGLTransitionerImpl& operator=(const OGLTransitionerImpl&) = delete; - bool setTransition( std::shared_ptr<OGLTransitionImpl> pOGLTransition ); + bool setTransition( const std::shared_ptr<OGLTransitionImpl>& pOGLTransition ); bool initialize( const Reference< presentation::XSlideShowView >& xView, const Reference< rendering::XBitmap >& xLeavingSlide, const Reference< rendering::XBitmap >& xEnteringSlide ); @@ -546,7 +546,7 @@ void OGLTransitionerImpl::impl_finishTransition() mpTransition->finish(); } -bool OGLTransitionerImpl::setTransition( std::shared_ptr<OGLTransitionImpl> pTransition ) +bool OGLTransitionerImpl::setTransition( const std::shared_ptr<OGLTransitionImpl>& pTransition ) { if ( mpTransition ) // already initialized return true; diff --git a/slideshow/source/engine/slide/layermanager.cxx b/slideshow/source/engine/slide/layermanager.cxx index 34603d8a9528..865e6424cb8c 100644 --- a/slideshow/source/engine/slide/layermanager.cxx +++ b/slideshow/source/engine/slide/layermanager.cxx @@ -655,7 +655,7 @@ namespace slideshow void LayerManager::commitLayerChanges( std::size_t nCurrLayerIndex, LayerShapeMap::const_iterator aFirstLayerShape, - LayerShapeMap::const_iterator aEndLayerShapes ) + const LayerShapeMap::const_iterator& aEndLayerShapes ) { const bool bLayerExists( maLayers.size() > nCurrLayerIndex ); if( bLayerExists ) diff --git a/slideshow/source/engine/slide/layermanager.hxx b/slideshow/source/engine/slide/layermanager.hxx index 61ccedeb73c3..859de3743f50 100644 --- a/slideshow/source/engine/slide/layermanager.hxx +++ b/slideshow/source/engine/slide/layermanager.hxx @@ -270,7 +270,7 @@ namespace slideshow */ void commitLayerChanges( std::size_t nCurrLayerIndex, LayerShapeMap::const_iterator aFirstLayerShape, - LayerShapeMap::const_iterator aEndLayerShapes ); + const LayerShapeMap::const_iterator& aEndLayerShapes ); /** Init Shape layers with background layer. */ |