loplugin:constantparam

Change-Id: Ia11bf93768d5f722b7fe62df15f24809cb7e7f04
Reviewed-on: https://gerrit.libreoffice.org/60280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 9 insertions, 21 deletions

diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 0598fe22e37a..3bb367c4bbd0 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -615,7 +615,7 @@ SdDrawDocument* SdDrawDocument::AllocSdDrawDocument() const
                 SfxObjectCreateMode::EMBEDDED, true, meDocType ) );
         else
             mpCreatingTransferable->SetDocShell( new ::sd::GraphicDocShell(
-                SfxObjectCreateMode::EMBEDDED, true, meDocType ) );
+                SfxObjectCreateMode::EMBEDDED ) );
 
         pNewDocSh = static_cast< ::sd::DrawDocShell*>( pObj = mpCreatingTransferable->GetDocShell().get() );
         pNewDocSh->DoInitNew();
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index 056fb2953f49..557e836bf39c 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -220,7 +220,7 @@ SdDrawDocument* SdDrawDocument::OpenBookmarkDoc(SfxMedium* pMedium)
             // If that wasn't the case, we could load the model directly.
             if ( bCreateGraphicShell )
                 // Draw
-                mxBookmarkDocShRef = new ::sd::GraphicDocShell(SfxObjectCreateMode::STANDARD, true, DocumentType::Draw);
+                mxBookmarkDocShRef = new ::sd::GraphicDocShell(SfxObjectCreateMode::STANDARD);
             else
                 // Impress
                 mxBookmarkDocShRef = new ::sd::DrawDocShell(SfxObjectCreateMode::STANDARD, true, DocumentType::Impress);
diff --git a/sd/source/ui/docshell/grdocsh.cxx b/sd/source/ui/docshell/grdocsh.cxx
index e6d400f86e3d..67948cce3cb7 100644
--- a/sd/source/ui/docshell/grdocsh.cxx
+++ b/sd/source/ui/docshell/grdocsh.cxx
@@ -48,18 +48,14 @@ void GraphicDocShell::InitInterface_Impl()
 
 SFX_IMPL_OBJECTFACTORY( GraphicDocShell, SvGlobalName(SO3_SDRAW_CLASSID_60), SfxObjectShellFlags::STD_NORMAL, "sdraw" )
 
-GraphicDocShell::GraphicDocShell(SfxObjectCreateMode eMode,
-                                     bool bDataObject,
-                                     DocumentType eDocType) :
-    DrawDocShell(eMode, bDataObject, eDocType)
+GraphicDocShell::GraphicDocShell(SfxObjectCreateMode eMode) :
+    DrawDocShell(eMode, /*bDataObject*/true, DocumentType::Draw)
 {
     SetStyleFamily( SfxStyleFamily::Para );
 }
 
-GraphicDocShell::GraphicDocShell(SfxModelFlags nModelCreationFlags,
-                                     bool bDataObject,
-                                     DocumentType eDocType) :
-    DrawDocShell(nModelCreationFlags, bDataObject, eDocType)
+GraphicDocShell::GraphicDocShell(SfxModelFlags nModelCreationFlags) :
+    DrawDocShell(nModelCreationFlags, /*bDataObject*/false, DocumentType::Draw)
 {
     SetStyleFamily( SfxStyleFamily::Para );
 }
diff --git a/sd/source/ui/inc/GraphicDocShell.hxx b/sd/source/ui/inc/GraphicDocShell.hxx
index 9406a127a262..0ef7738addfc 100644
--- a/sd/source/ui/inc/GraphicDocShell.hxx
+++ b/sd/source/ui/inc/GraphicDocShell.hxx
@@ -44,15 +44,9 @@ private:
 public:
     SFX_DECL_OBJECTFACTORY();
 
-    GraphicDocShell (
-        SfxObjectCreateMode eMode,
-        bool bSdDataObj,
-        DocumentType);
+    GraphicDocShell(SfxObjectCreateMode eMode);
 
-    GraphicDocShell (
-        SfxModelFlags nModelCreationFlags,
-        bool bSdDataObj,
-        DocumentType);
+    GraphicDocShell(SfxModelFlags nModelCreationFlags);
 
     virtual ~GraphicDocShell() override;
 };
diff --git a/sd/source/ui/unoidl/unodoc.cxx b/sd/source/ui/unoidl/unodoc.cxx
index 554be509cc18..263d24b1dd31 100644
--- a/sd/source/ui/unoidl/unodoc.cxx
+++ b/sd/source/ui/unoidl/unodoc.cxx
@@ -53,9 +53,7 @@ uno::Reference< uno::XInterface > SdDrawingDocument_createInstance(
 
     SdDLL::Init();
 
-    SfxObjectShell* pShell =
-        new ::sd::GraphicDocShell(
-            _nCreationFlags, false, DocumentType::Draw );
+    SfxObjectShell* pShell = new ::sd::GraphicDocShell( _nCreationFlags );
     return uno::Reference< uno::XInterface >( pShell->GetModel() );
 }