diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-29 15:38:29 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-02 08:47:58 +0200 |
| commit | 50c63e5c2f7962e8893e2d04b0e958209432f4c9 (patch) | |
| tree | 308893225e96328c5ff5fd071a97c2110e61577b /sd/inc | |
| parent | loplugin:unusedfields improve checking for write-only fields (diff) | |
| download | core-50c63e5c2f7962e8893e2d04b0e958209432f4c9.tar.gz core-50c63e5c2f7962e8893e2d04b0e958209432f4c9.zip | |
pass OutlinerParaObject around by std::unique_ptr
SdrText::SetOutlinerParaObject was modified to not check for
self-assign, and instead assert because
the existing check was no longer possible.
Fix bug in SdrUndoObjSetText::Undo(), where it was calling
SdrText::SetOutlinerParaObject unnecessarily,
because NbcSetOutlinerParaObjectForText already does that.
Optimise Outliner::GetEmptyParaObject by creating a new constructor for
OutlinerParaObject,
so we don't need to copy the new object we get back from
GetEmptyTextObject, unnecessarily.
Change-Id: I57c475583d6c31658c154e24992b3d587bad9841
Reviewed-on: https://gerrit.libreoffice.org/56730
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd/inc')
| -rw-r--r-- | sd/inc/textapi.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/inc/textapi.hxx b/sd/inc/textapi.hxx index d81ecf4b4ce2..00a60d13791d 100644 --- a/sd/inc/textapi.hxx +++ b/sd/inc/textapi.hxx @@ -40,7 +40,7 @@ public: /// @throws css::uno::RuntimeException void dispose(); - OutlinerParaObject* CreateText(); + std::unique_ptr<OutlinerParaObject> CreateText(); void SetText( OutlinerParaObject const & rText ); OUString GetText(); |