diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-04 14:20:26 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-05 07:32:46 +0100 |
commit | 9a06b99d2f53bd8d0a9ab0936efed9924a2abb88 (patch) | |
tree | 544f3e51a3978bd234a1c9fcdbf12d9b84352da4 /sc | |
parent | loplugin:countusersofdefaultparams in editeng..package (diff) | |
download | core-9a06b99d2f53bd8d0a9ab0936efed9924a2abb88.tar.gz core-9a06b99d2f53bd8d0a9ab0936efed9924a2abb88.zip |
loplugin:salcall fix non-virtual methods
first, since those are safer to change than virtual methods
Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
-rw-r--r-- | sc/source/ui/Accessibility/AccessibleCellBase.cxx | 8 | ||||
-rw-r--r-- | sc/source/ui/Accessibility/AccessibleContextBase.cxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/AccessibleCellBase.hxx | 8 | ||||
-rw-r--r-- | sc/source/ui/inc/AccessibleContextBase.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/vba/vbacomment.cxx | 8 | ||||
-rw-r--r-- | sc/source/ui/vba/vbacomment.hxx | 8 | ||||
-rw-r--r-- | sc/source/ui/vba/vbaglobals.hxx | 2 |
7 files changed, 19 insertions, 19 deletions
diff --git a/sc/source/ui/Accessibility/AccessibleCellBase.cxx b/sc/source/ui/Accessibility/AccessibleCellBase.cxx index b96effe84d87..a7a5ac2d76f9 100644 --- a/sc/source/ui/Accessibility/AccessibleCellBase.cxx +++ b/sc/source/ui/Accessibility/AccessibleCellBase.cxx @@ -300,7 +300,7 @@ bool ScAccessibleCellBase::IsEditable( return bEditable; } -OUString SAL_CALL ScAccessibleCellBase::GetNote() +OUString ScAccessibleCellBase::GetNote() { SolarMutexGuard aGuard; IsObjectValid(); @@ -346,7 +346,7 @@ OUString SAL_CALL ScAccessibleCellBase::GetNote() return sNote; } -OUString SAL_CALL ScAccessibleCellBase::getShadowAttrs() +OUString ScAccessibleCellBase::getShadowAttrs() { SolarMutexGuard aGuard; IsObjectValid(); @@ -426,7 +426,7 @@ OUString SAL_CALL ScAccessibleCellBase::getShadowAttrs() return sShadowAttrs; } -OUString SAL_CALL ScAccessibleCellBase::getBorderAttrs() +OUString ScAccessibleCellBase::getBorderAttrs() { SolarMutexGuard aGuard; IsObjectValid(); @@ -575,7 +575,7 @@ OUString SAL_CALL ScAccessibleCellBase::getBorderAttrs() } //end of cell attributes -OUString SAL_CALL ScAccessibleCellBase::GetAllDisplayNote() +OUString ScAccessibleCellBase::GetAllDisplayNote() { OUString strNote; OUString strTrackText; diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx b/sc/source/ui/Accessibility/AccessibleContextBase.cxx index c2d9d31c09f1..a8057a10be71 100644 --- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx +++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx @@ -183,7 +183,7 @@ awt::Size SAL_CALL ScAccessibleContextBase::getSize( ) return AWTSize(GetBoundingBox().GetSize()); } -bool SAL_CALL ScAccessibleContextBase::isShowing( ) +bool ScAccessibleContextBase::isShowing( ) { SolarMutexGuard aGuard; IsObjectValid(); diff --git a/sc/source/ui/inc/AccessibleCellBase.hxx b/sc/source/ui/inc/AccessibleCellBase.hxx index d9dde2fb2b08..45c074797c9a 100644 --- a/sc/source/ui/inc/AccessibleCellBase.hxx +++ b/sc/source/ui/inc/AccessibleCellBase.hxx @@ -121,14 +121,14 @@ private: const css::uno::Reference<css::accessibility::XAccessibleStateSet>& rxParentStates); protected: /// @throw css::uno::RuntimeException - OUString SAL_CALL GetNote(); + OUString GetNote(); /// @throw css::uno::RuntimeException - OUString SAL_CALL GetAllDisplayNote(); + OUString GetAllDisplayNote(); /// @throw css::uno::RuntimeException - OUString SAL_CALL getShadowAttrs(); + OUString getShadowAttrs(); /// @throw css::uno::RuntimeException - OUString SAL_CALL getBorderAttrs(); + OUString getBorderAttrs(); public: const ScAddress& GetCellAddress() const { return maCellAddress; } }; diff --git a/sc/source/ui/inc/AccessibleContextBase.hxx b/sc/source/ui/inc/AccessibleContextBase.hxx index 10970150bf91..f6c832e98d08 100644 --- a/sc/source/ui/inc/AccessibleContextBase.hxx +++ b/sc/source/ui/inc/AccessibleContextBase.hxx @@ -78,7 +78,7 @@ protected: public: /// @throws css::uno::RuntimeException - bool SAL_CALL isShowing( ); + bool isShowing( ); /// @throws css::uno::RuntimeException virtual bool SAL_CALL isVisible(); diff --git a/sc/source/ui/vba/vbacomment.cxx b/sc/source/ui/vba/vbacomment.cxx index bc39a9c6b2dd..b27e73a34733 100644 --- a/sc/source/ui/vba/vbacomment.cxx +++ b/sc/source/ui/vba/vbacomment.cxx @@ -54,7 +54,7 @@ ScVbaComment::ScVbaComment( // private helper functions -uno::Reference< sheet::XSheetAnnotation > SAL_CALL +uno::Reference< sheet::XSheetAnnotation > ScVbaComment::getAnnotation() { uno::Reference< table::XCell > xCell( mxRange->getCellByPosition(0, 0), uno::UNO_QUERY_THROW ); @@ -62,7 +62,7 @@ ScVbaComment::getAnnotation() return uno::Reference< sheet::XSheetAnnotation > ( xAnnoAnchor->getAnnotation(), uno::UNO_QUERY_THROW ); } -uno::Reference< sheet::XSheetAnnotations > SAL_CALL +uno::Reference< sheet::XSheetAnnotations > ScVbaComment::getAnnotations() { uno::Reference< sheet::XSheetCellRange > xSheetCellRange(mxRange, ::uno::UNO_QUERY_THROW ); @@ -72,7 +72,7 @@ ScVbaComment::getAnnotations() return uno::Reference< sheet::XSheetAnnotations > ( xAnnosSupp->getAnnotations(), uno::UNO_QUERY_THROW ); } -sal_Int32 SAL_CALL +sal_Int32 ScVbaComment::getAnnotationIndex() { uno::Reference< sheet::XSheetAnnotations > xAnnos = getAnnotations(); @@ -97,7 +97,7 @@ ScVbaComment::getAnnotationIndex() return aIndex; } -uno::Reference< excel::XComment > SAL_CALL +uno::Reference< excel::XComment > ScVbaComment::getCommentByIndex( sal_Int32 Index ) { uno::Reference< container::XIndexAccess > xIndexAccess( getAnnotations(), uno::UNO_QUERY_THROW ); diff --git a/sc/source/ui/vba/vbacomment.hxx b/sc/source/ui/vba/vbacomment.hxx index 3ee4d4550e27..b430d962ecdf 100644 --- a/sc/source/ui/vba/vbacomment.hxx +++ b/sc/source/ui/vba/vbacomment.hxx @@ -38,13 +38,13 @@ class ScVbaComment : public ScVbaComment_BASE private: /// @throws css::uno::RuntimeException - css::uno::Reference< css::sheet::XSheetAnnotation > SAL_CALL getAnnotation(); + css::uno::Reference< css::sheet::XSheetAnnotation > getAnnotation(); /// @throws css::uno::RuntimeException - css::uno::Reference< css::sheet::XSheetAnnotations > SAL_CALL getAnnotations(); + css::uno::Reference< css::sheet::XSheetAnnotations > getAnnotations(); /// @throws css::uno::RuntimeException - sal_Int32 SAL_CALL getAnnotationIndex(); + sal_Int32 getAnnotationIndex(); /// @throws css::uno::RuntimeException - css::uno::Reference< ov::excel::XComment > SAL_CALL getCommentByIndex( sal_Int32 Index ); + css::uno::Reference< ov::excel::XComment > getCommentByIndex( sal_Int32 Index ); public: /// @throws css::lang::IllegalArgumentException /// @throws css::uno::RuntimeException diff --git a/sc/source/ui/vba/vbaglobals.hxx b/sc/source/ui/vba/vbaglobals.hxx index da401f40d5f2..700338be7282 100644 --- a/sc/source/ui/vba/vbaglobals.hxx +++ b/sc/source/ui/vba/vbaglobals.hxx @@ -38,7 +38,7 @@ class ScVbaGlobals : public ScVbaGlobals_BASE { css::uno::Reference< ov::excel::XApplication > mxApplication; /// @throws css::uno::RuntimeException - css::uno::Reference< ov::excel::XApplication > const & SAL_CALL getApplication(); + css::uno::Reference< ov::excel::XApplication > const & getApplication(); public: ScVbaGlobals( css::uno::Sequence< css::uno::Any > const& aArgs, |