diff options
| author | Laurent Godard <lgodard.libre@laposte.net> | 2011-12-01 10:17:05 +0100 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2011-12-01 11:43:55 +0100 |
| commit | eec4e1202d5f2f39ad881ce4afd94b8384c8b3c2 (patch) | |
| tree | b4438f3ba8a1a356ecf9962cfea328b5a6937327 /sc | |
| parent | Remove uses of charAt (diff) | |
| download | core-eec4e1202d5f2f39ad881ce4afd94b8384c8b3c2.tar.gz core-eec4e1202d5f2f39ad881ce4afd94b8384c8b3c2.zip | |
avoid Tabs size calculation in loops
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/core/data/documen3.cxx | 9 | ||||
| -rw-r--r-- | sc/source/core/data/documen5.cxx | 6 |
2 files changed, 10 insertions, 5 deletions
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx index 545e7f4c8a93..63d926ad94f1 100644 --- a/sc/source/core/data/documen3.cxx +++ b/sc/source/core/data/documen3.cxx @@ -656,7 +656,8 @@ bool ScDocument::HasSheetEventScript( SCTAB nTab, sal_Int32 nEvent, bool bWithVb bool ScDocument::HasAnySheetEventScript( sal_Int32 nEvent, bool bWithVbaEvents ) const { - for (SCTAB nTab = 0; nTab < static_cast<SCTAB>(maTabs.size()); nTab++) + SCTAB nSize = static_cast<SCTAB>(maTabs.size()); + for (SCTAB nTab = 0; nTab < nSize; nTab++) if (HasSheetEventScript( nTab, nEvent, bWithVbaEvents )) return true; return false; @@ -664,7 +665,8 @@ bool ScDocument::HasAnySheetEventScript( sal_Int32 nEvent, bool bWithVbaEvents ) bool ScDocument::HasAnyCalcNotification() const { - for (SCTAB nTab = 0; nTab < static_cast<SCTAB>(maTabs.size()); nTab++) + SCTAB nSize = static_cast<SCTAB>(maTabs.size()); + for (SCTAB nTab = 0; nTab < nSize; nTab++) if (maTabs[nTab] && maTabs[nTab]->GetCalcNotification()) return true; return false; @@ -686,7 +688,8 @@ void ScDocument::SetCalcNotification( SCTAB nTab ) void ScDocument::ResetCalcNotifications() { - for (SCTAB nTab = 0; nTab < static_cast<SCTAB>(maTabs.size()); nTab++) + SCTAB nSize = static_cast<SCTAB>(maTabs.size()); + for (SCTAB nTab = 0; nTab < nSize; nTab++) if (maTabs[nTab] && maTabs[nTab]->GetCalcNotification()) maTabs[nTab]->SetCalcNotification(false); } diff --git a/sc/source/core/data/documen5.cxx b/sc/source/core/data/documen5.cxx index 9540c9f16801..4a1c2b45825e 100644 --- a/sc/source/core/data/documen5.cxx +++ b/sc/source/core/data/documen5.cxx @@ -133,7 +133,8 @@ void ScDocument::UpdateAllCharts() size_t nDataCount = pChartCollection->size(); - for (SCTAB nTab=0; nTab< static_cast<SCTAB>(maTabs.size()); nTab++) + SCTAB nSize = static_cast<SCTAB>(maTabs.size()); + for (SCTAB nTab=0; nTab< nSize; nTab++) { if (maTabs[nTab]) { @@ -247,7 +248,8 @@ uno::Reference< chart2::XChartDocument > ScDocument::GetChartByName( const rtl:: if (pDrawLayer) { sal_uInt16 nCount = pDrawLayer->GetPageCount(); - for (sal_uInt16 nTab=0; nTab<nCount&& nTab < static_cast<SCTAB>(maTabs.size()); nTab++) + SCTAB nSize = static_cast<SCTAB>(maTabs.size()); + for (sal_uInt16 nTab=0; nTab<nCount && nTab < nSize; nTab++) { SdrPage* pPage = pDrawLayer->GetPage(nTab); OSL_ENSURE(pPage,"Page ?"); |