diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2018-07-26 13:47:59 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2018-07-27 08:20:20 +0200 |
commit | f1a10d4f14e86a2a2a632ff4a091690c2f31f255 (patch) | |
tree | 739f86a047016f2ac99c9dca142d666253173c80 /sc/source/filter/inc/xichart.hxx | |
parent | unotools: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9) (diff) | |
download | core-f1a10d4f14e86a2a2a632ff4a091690c2f31f255.tar.gz core-f1a10d4f14e86a2a2a632ff4a091690c2f31f255.zip |
sc: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)
...by explicitly defaulting the copy/move functions (and, where needed in turn,
also a default ctor) for classes that have a user-declared dtor that does
nothing other than an implicitly-defined one would do, but needs to be user-
declared because it is virtual and potentially serves as a key function to
emit the vtable, or is non-public, etc.; and by removing explicitly user-
provided functions that do the same as their implicitly-defined counterparts,
but may prevent implicitly declared copy functions from being defined as non-
deleted in the future. (Even if such a user-provided function was declared
non-inline in an include file, the apparently-used implicitly-defined copy
functions are already include, so why bother with non-inline functions.)
Change-Id: I4efe3eb088e5f9096be87dd8240504768755112b
Reviewed-on: https://gerrit.libreoffice.org/58096
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sc/source/filter/inc/xichart.hxx')
-rw-r--r-- | sc/source/filter/inc/xichart.hxx | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/sc/source/filter/inc/xichart.hxx b/sc/source/filter/inc/xichart.hxx index d1e3f4efcde8..f02ec52ca42b 100644 --- a/sc/source/filter/inc/xichart.hxx +++ b/sc/source/filter/inc/xichart.hxx @@ -86,6 +86,11 @@ public: explicit XclImpChRoot( const XclImpRoot& rRoot, XclImpChChart& rChartData ); virtual ~XclImpChRoot() override; + XclImpChRoot(XclImpChRoot const &) = default; + XclImpChRoot(XclImpChRoot &&) = default; + XclImpChRoot & operator =(XclImpChRoot const &) = default; + XclImpChRoot & operator =(XclImpChRoot &&) = default; + /** Returns this root instance - for code readability in derived classes. */ const XclImpChRoot& GetChRoot() const { return *this; } /** Returns a reference to the parent chart data object. */ @@ -177,6 +182,12 @@ private: class XclImpChGroupBase { public: + XclImpChGroupBase() = default; + XclImpChGroupBase(XclImpChGroupBase const &) = default; + XclImpChGroupBase(XclImpChGroupBase &&) = default; + XclImpChGroupBase & operator =(XclImpChGroupBase const &) = default; + XclImpChGroupBase & operator =(XclImpChGroupBase &&) = default; + virtual ~XclImpChGroupBase(); /** Reads the entire record group. @@ -428,6 +439,12 @@ typedef std::shared_ptr< XclImpChSourceLink > XclImpChSourceLinkRef; class XclImpChFontBase { public: + XclImpChFontBase() = default; + XclImpChFontBase(XclImpChFontBase const &) = default; + XclImpChFontBase(XclImpChFontBase &&) = default; + XclImpChFontBase & operator =(XclImpChFontBase const &) = default; + XclImpChFontBase & operator =(XclImpChFontBase &&) = default; + virtual ~XclImpChFontBase(); /** Derived classes return the leading font index for the text object. */ |