diff options
author | Julien Nabet <serval2412@yahoo.fr> | 2013-08-23 07:54:04 +0200 |
---|---|---|
committer | Julien Nabet <serval2412@yahoo.fr> | 2013-08-23 07:54:04 +0200 |
commit | c958c4ed117a46889afc59ae52502b7262c9ea5c (patch) | |
tree | 37ed9c04f5ce8501a5ef850e8acbae3e3f60d421 /sax | |
parent | cppcheck: reduce scope + remove commented lines (diff) | |
download | core-c958c4ed117a46889afc59ae52502b7262c9ea5c.tar.gz core-c958c4ed117a46889afc59ae52502b7262c9ea5c.zip |
cppcheck: fix duplicate if/else
I don't know if it's possible to parse EBCDIC knowing that there are several implementations
So I commented the block and added a TODO.
=> no time wasted for this block (ok "micro waste")+ 1 less cppcheck report
Change-Id: I72b72b68295eab7be5332166b955adaddf6ee5c3
Diffstat (limited to 'sax')
-rw-r--r-- | sax/source/expatwrap/xml2utf.cxx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sax/source/expatwrap/xml2utf.cxx b/sax/source/expatwrap/xml2utf.cxx index 76713d99ef84..34440bfa534c 100644 --- a/sax/source/expatwrap/xml2utf.cxx +++ b/sax/source/expatwrap/xml2utf.cxx @@ -314,12 +314,14 @@ sal_Bool XMLFile2UTFConverter::scanForEncoding( Sequence< sal_Int8 > &seq ) // UCS-4 little endian m_sEncoding = "ucs-4"; } +/* TODO: no need to test for the moment since we return sal_False like default case anyway else if( 0x4c == pSource[0] && 0x6f == pSource[1] && 0xa7 == static_cast<unsigned char> (pSource[2]) && 0x94 == static_cast<unsigned char> (pSource[3]) ) { // EBCDIC bReturn = sal_False; // must be extended } +*/ else { // other // UTF8 is directly recognized by the parser. |