diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 15:41:53 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 17:22:05 +0200 |
| commit | 928b1b04adc1cd49cc5d00069084e03675a320f3 (patch) | |
| tree | 8710687a4a66a628bd12c5482d7d93cc27f8996a /sal/qa | |
| parent | -Werror,-Wunused-variable (clang-cl) (diff) | |
| download | core-928b1b04adc1cd49cc5d00069084e03675a320f3.tar.gz core-928b1b04adc1cd49cc5d00069084e03675a320f3.zip | |
loplugin:external (clang-cl)
Including:
* expanding STDAPI to its definition (as per
<https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add
__declspec(dllexport) into its middle, in
extensions/source/activex/so_activex.cxx; as discussed in the comments at
<https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in
setup_native, use __declspec(dllexport)", having a function both listed in a
.def file EXPORTS and marking it dllexport is OK, and the latter helps the
heuristics of loplugin:external; however, the relevant functions in
extensions/source/activex/so_activex.cxx probably don't even need to be
exported in the first place?
* follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx
Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191
Reviewed-on: https://gerrit.libreoffice.org/60938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sal/qa')
| -rw-r--r-- | sal/qa/osl/process/osl_process_child.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sal/qa/osl/process/osl_process_child.cxx b/sal/qa/osl/process/osl_process_child.cxx index 22c5df241c21..17f749bc270c 100644 --- a/sal/qa/osl/process/osl_process_child.cxx +++ b/sal/qa/osl/process/osl_process_child.cxx @@ -52,12 +52,12 @@ static void wait_for_seconds(char* time) #ifdef _WIN32 -void w_to_a(LPCWSTR strW, LPSTR strA, DWORD size) +static void w_to_a(LPCWSTR strW, LPSTR strA, DWORD size) { WideCharToMultiByte(CP_ACP, 0, strW, -1, strA, size, nullptr, nullptr); } - void dump_env(char* file_path) + static void dump_env(char* file_path) { LPWSTR env = GetEnvironmentStringsW(); LPWSTR p = env; |