No need to keep these whitelisted functions decorated with SAL_CALL

The only effect SAL_CALL effectively has on LO-internal code is to change non-
static member functions from __thiscall to __cdecl in MSVC (where all other
functions are __cdecl by default, anyway).  (For 3rd-party code, it could be
argued that SAL_CALL is useful on function declarations in the URE stable
interface other than non-static member functions, too, in case 3rd-party code
uses a compiler switch to change the default calling convention to something
other than __cdecl.  But loplugin:salcall exempts the URE stable interface,
anyway.)

One could argue that SAL_CALL, even if today it effectively only affects non-
static member functions in MSVC, could be extended in the future to affect more
functions on more platforms.  However, the current code would already not
support that.  For example, 3af500580b1c82eabd60335c9ebc458a3f68850c
"loplugin:salcall fix functions" changed FrameControl_createInstance in
UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even
though its address (in ctl_component_getFacrory, in the same file) is passed to
cppuhelper::createSingleFactory as an argument of type
cppu::ComponentInstantiation, which is a pointer to SAL_CALL function.

Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6
Reviewed-on: https://gerrit.libreoffice.org/46436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

8 files changed, 17 insertions, 17 deletions

diff --git a/reportdesign/source/filter/xml/dbloader2.cxx b/reportdesign/source/filter/xml/dbloader2.cxx
index 0ffc8ecd7a43..d723d5809b07 100644
--- a/reportdesign/source/filter/xml/dbloader2.cxx
+++ b/reportdesign/source/filter/xml/dbloader2.cxx
@@ -76,7 +76,7 @@ OUString SAL_CALL ORptTypeDetection::detect( Sequence< css::beans::PropertyValue
     return OUString();
 }
 
-Reference< XInterface > SAL_CALL
+Reference< XInterface >
         ORptTypeDetection::create(Reference< XComponentContext > const & xContext)
 {
     return *(new ORptTypeDetection(xContext));
diff --git a/reportdesign/source/filter/xml/dbloader2.hxx b/reportdesign/source/filter/xml/dbloader2.hxx
index cd53be77a13d..3cf929369ada 100644
--- a/reportdesign/source/filter/xml/dbloader2.hxx
+++ b/reportdesign/source/filter/xml/dbloader2.hxx
@@ -78,7 +78,7 @@ public:
     }
     /// @throws css::uno::RuntimeException
     static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 
     virtual OUString SAL_CALL detect( css::uno::Sequence< css::beans::PropertyValue >& Descriptor ) override;
diff --git a/reportdesign/source/filter/xml/xmlExport.hxx b/reportdesign/source/filter/xml/xmlExport.hxx
index 102af7a03cf1..d082c7d9bf6f 100644
--- a/reportdesign/source/filter/xml/xmlExport.hxx
+++ b/reportdesign/source/filter/xml/xmlExport.hxx
@@ -159,7 +159,7 @@ public:
     static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
     /// @throws css::uno::RuntimeException
     static OUString getImplementationName_Static();
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 
     // XExporter
@@ -181,7 +181,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -196,7 +196,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -211,7 +211,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -226,7 +226,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 /** Exports all
@@ -240,7 +240,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
         create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
diff --git a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
index f68dc4d9e554..cee792543ef1 100644
--- a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
@@ -120,7 +120,7 @@ uno::Sequence< OUString > ExportDocumentHandler::getSupportedServiceNames_static
 }
 
 
-uno::Reference< uno::XInterface > SAL_CALL ExportDocumentHandler::create( const uno::Reference< uno::XComponentContext >& _rxContext )
+uno::Reference< uno::XInterface > ExportDocumentHandler::create( const uno::Reference< uno::XComponentContext >& _rxContext )
 {
     return *(new ExportDocumentHandler( _rxContext ));
 }
diff --git a/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx b/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
index b411b475fcdd..2c6a3c9524f6 100644
--- a/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
+++ b/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
@@ -48,7 +48,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static css::uno::Sequence< OUString > getSupportedServiceNames_static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
                     create(const css::uno::Reference< css::uno::XComponentContext >&);
 public:
     explicit ExportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
index 315883a300a6..af3b1787360f 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
@@ -94,7 +94,7 @@ uno::Sequence< OUString > ImportDocumentHandler::getSupportedServiceNames_static
 }
 
 
-uno::Reference< uno::XInterface > SAL_CALL ImportDocumentHandler::create( const uno::Reference< uno::XComponentContext >& _rxContext )
+uno::Reference< uno::XInterface > ImportDocumentHandler::create( const uno::Reference< uno::XComponentContext >& _rxContext )
 {
     return *(new ImportDocumentHandler( _rxContext ));
 }
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx b/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
index 9bc49ea247f8..64b4b9f23c3d 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
@@ -46,7 +46,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static css::uno::Sequence< OUString > getSupportedServiceNames_static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
                     create(const css::uno::Reference< css::uno::XComponentContext >&);
 public:
     explicit ImportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
diff --git a/reportdesign/source/filter/xml/xmlfilter.hxx b/reportdesign/source/filter/xml/xmlfilter.hxx
index 1f6531a9b795..eacb74e83969 100644
--- a/reportdesign/source/filter/xml/xmlfilter.hxx
+++ b/reportdesign/source/filter/xml/xmlfilter.hxx
@@ -122,7 +122,7 @@ public:
     static css::uno::Sequence< OUString > getSupportedServiceNames_Static();
     /// @throws css::uno::RuntimeException
     static OUString getImplementationName_Static();
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 
     const Reference<XReportDefinition>& getReportDefinition() const {
@@ -182,7 +182,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -197,7 +197,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -212,7 +212,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };
 
@@ -227,7 +227,7 @@ public:
     static OUString getImplementationName_Static(  );
     /// @throws css::uno::RuntimeException
     static Sequence< OUString > getSupportedServiceNames_Static(  );
-    static css::uno::Reference< css::uno::XInterface > SAL_CALL
+    static css::uno::Reference< css::uno::XInterface >
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 };