diff options
| author | Luboš Luňák <l.lunak@suse.cz> | 2011-03-25 17:27:08 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@suse.cz> | 2011-03-25 17:27:08 +0100 |
| commit | 4afa430c30483767440f61d11e9012e694019157 (patch) | |
| tree | 38eb33a7b545935d35a8ee0dcaab88a6d4239d28 /reportdesign/inc | |
| parent | set build depencencies against the new "translations" module (diff) | |
| download | core-4afa430c30483767440f61d11e9012e694019157.tar.gz core-4afa430c30483767440f61d11e9012e694019157.zip | |
more sensible SdrObject::Clone() and SdrObject::operator=()
Virtual operator=() is IMO pointless, and especially in a class hierarchy
like SdrObject it's pretty unlikely one could reasonably assign any
SdrObject-based object to any other one. Moreover, it was actually
only used in Clone(), which was almost never reimplemented, so the
more sensible choice is to have non-virtual operator= and virtual
Clone() always being reimplemented and using that.
This commit also fixes various smaller or bigger, er, interesting
details in the various operator= implementations.
Diffstat (limited to 'reportdesign/inc')
| -rw-r--r-- | reportdesign/inc/RptObject.hxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx index 44fa0a49c169..056a06c4a522 100644 --- a/reportdesign/inc/RptObject.hxx +++ b/reportdesign/inc/RptObject.hxx @@ -221,7 +221,7 @@ public: virtual sal_uInt16 GetObjIdentifier() const; virtual sal_uInt32 GetObjInventor() const; // Clone() soll eine komplette Kopie des Objektes erzeugen. - virtual SdrObject* Clone() const; + virtual OOle2Obj* Clone() const; virtual void initializeOle(); void initializeChart( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XModel>& _xModel); @@ -273,7 +273,7 @@ public: virtual ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > getUnoShape(); virtual sal_uInt16 GetObjIdentifier() const; virtual sal_uInt32 GetObjInventor() const; - virtual SdrObject* Clone() const; + virtual OUnoObject* Clone() const; private: void impl_setReportComponent_nothrow(); |