diff options
author | Noel Grandin <noel@peralex.com> | 2014-12-10 15:36:24 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2014-12-11 06:09:03 +0000 |
commit | 7557f23b31dcfb4d86c122bb34d9675c0db9a694 (patch) | |
tree | 5feb7be2b0841d8ee60d935cf2e29e9a01a31a27 /qadevOOo/runner/lib | |
parent | Deteremine the script type of source cell during paste replication. (diff) | |
download | core-7557f23b31dcfb4d86c122bb34d9675c0db9a694.tar.gz core-7557f23b31dcfb4d86c122bb34d9675c0db9a694.zip |
java: reduce visibility of fields and methods
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'qadevOOo/runner/lib')
-rw-r--r-- | qadevOOo/runner/lib/MultiMethodTest.java | 10 | ||||
-rw-r--r-- | qadevOOo/runner/lib/TestParameters.java | 2 | ||||
-rw-r--r-- | qadevOOo/runner/lib/TestResult.java | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/qadevOOo/runner/lib/MultiMethodTest.java b/qadevOOo/runner/lib/MultiMethodTest.java index c1f0b308f07b..aabd919054e3 100644 --- a/qadevOOo/runner/lib/MultiMethodTest.java +++ b/qadevOOo/runner/lib/MultiMethodTest.java @@ -290,7 +290,7 @@ public class MultiMethodTest * @param methName the method name to set status * @param methStatus the status to set to the method */ - protected void setStatus(String methName, Status methStatus) + private void setStatus(String methName, Status methStatus) { tRes.tested(methName, methStatus); } @@ -298,7 +298,7 @@ public class MultiMethodTest /** * sets the substates */ - protected void setSubStates(String msg) + private void setSubStates(String msg) { for (int k = 0; k < entry.SubEntryCount; k++) { @@ -332,7 +332,7 @@ public class MultiMethodTest /** * Checks if the <code>method</code> test has been already called. */ - protected boolean isCalled(String method) + private boolean isCalled(String method) { return methCalled.contains(method); } @@ -373,7 +373,7 @@ public class MultiMethodTest /** * Just calls the <code>method</code> test. */ - protected void callMethod(String method) + private void callMethod(String method) { methCalled.add(method); invokeTestMethod(getMethodFor(method), method); @@ -440,7 +440,7 @@ public class MultiMethodTest * * @return the testing method, if found, <tt>null</tt> otherwise */ - protected Method getMethodFor(String method) + private Method getMethodFor(String method) { String mName = "_" + method; diff --git a/qadevOOo/runner/lib/TestParameters.java b/qadevOOo/runner/lib/TestParameters.java index 1ca6a5c5b638..57501c140c06 100644 --- a/qadevOOo/runner/lib/TestParameters.java +++ b/qadevOOo/runner/lib/TestParameters.java @@ -199,7 +199,7 @@ public class TestParameters extends HashMap<String,Object> { * to OOo rules. * @return A valid OS name, or "" if the name is not known. */ - String getSOCompatibleOSName() { + private String getSOCompatibleOSName() { String osname = System.getProperty ("os.name").toLowerCase (); String osarch = System.getProperty ("os.arch"); String operatingSystem = ""; diff --git a/qadevOOo/runner/lib/TestResult.java b/qadevOOo/runner/lib/TestResult.java index a6c964f258ee..eb7a469cdc99 100644 --- a/qadevOOo/runner/lib/TestResult.java +++ b/qadevOOo/runner/lib/TestResult.java @@ -27,7 +27,7 @@ public class TestResult { /** * Contains methods having been tested and their results. */ - protected HashMap<String, Status> testedMethods = new HashMap<String, Status>(); + private HashMap<String, Status> testedMethods = new HashMap<String, Status>(); /** * The method makes method tested with the result, i.e. it adds to its |