new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

1 files changed, 11 insertions, 11 deletions

diff --git a/lotuswordpro/source/filter/lwpfoundry.hxx b/lotuswordpro/source/filter/lwpfoundry.hxx
index ae0834b020f8..51fbf50e1aea 100644
--- a/lotuswordpro/source/filter/lwpfoundry.hxx
+++ b/lotuswordpro/source/filter/lwpfoundry.hxx
@@ -121,7 +121,7 @@ private:
     LwpObjectID m_Head;
 public:
     void Read(LwpObjectStream *pStrm);
-    LwpObjectID* GetHeadID() { return &m_Head;}
+    LwpObjectID& GetHeadID() { return m_Head;}
 };
 
 class LwpContent;
@@ -141,8 +141,8 @@ private:
     LwpObjectID m_OleHead;
     LwpObjectID m_OleTail;
 public:
-    inline LwpObjectID* GetContentList() { return &m_ContentList; }
-    inline LwpObjectID* GetGraphicListHead() { return &m_GrapHead; }
+    inline LwpObjectID& GetContentList() { return m_ContentList; }
+    inline LwpObjectID& GetGraphicListHead() { return m_GrapHead; }
     LwpContent* EnumContents(LwpContent* pContent);
 
 public:
@@ -195,7 +195,7 @@ protected:
     LwpObjectID m_Head;
 public:
     void Read(LwpObjectStream *pStrm);
-    LwpObjectID* GetHeadID() { return &m_Head;}
+    LwpObjectID& GetHeadID() { return m_Head;}
     LwpOrderedObject* Enumerate(LwpOrderedObject* pLast);
 protected:
     LwpListList* GetNextActiveListList(LwpListList* pLast);
@@ -262,14 +262,14 @@ private: //file members
 private:
     void ReadStyles(LwpObjectStream *pStrm);
 public:
-    inline LwpContentManager* GetContentManager() { return &m_ContentMgr; }
-    inline LwpObjectID* GetGraphicListHead() { return m_ContentMgr.GetGraphicListHead(); }
-    inline LwpFontManager* GetFontManger() { return &m_FontMgr;}
-    inline LwpObjectID* GetTextStyleHead()  { return &m_TextStyle;}
-    inline LwpObjectID* GetLayout() {return &m_Layout;}
-    inline LwpObjectID* GetBulletManagerID() { return m_BulMgr.GetHeadID();}
+    inline LwpContentManager& GetContentManager() { return m_ContentMgr; }
+    inline LwpObjectID& GetGraphicListHead() { return m_ContentMgr.GetGraphicListHead(); }
+    inline LwpFontManager& GetFontManger() { return m_FontMgr;}
+    inline LwpObjectID& GetTextStyleHead()  { return m_TextStyle;}
+    inline LwpObjectID& GetLayout() {return m_Layout;}
+    inline LwpObjectID& GetBulletManagerID() { return m_BulMgr.GetHeadID();}
     inline LwpDocument* GetDocument(){ return m_pDoc;}
-    inline LwpNumberManager* GetNumberManager() { return &m_NumMgr;}
+    inline LwpNumberManager& GetNumberManager() { return m_NumMgr;}
     LwpObjectID * GetDefaultTextStyle() ;
 private:
     LwpStyleManager* m_pStyleMgr;