diff options
| author | Tor Lillqvist <tml@collabora.com> | 2020-06-04 15:06:24 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2020-06-04 14:13:46 +0200 |
| commit | 79c933916861d085ab844c50d7f07ba9c2d5e570 (patch) | |
| tree | a8253612a25b533ba9f597becbd0c7758a8d2f14 /libreofficekit | |
| parent | Upcoming loplugin:elidestringvar: javaunohelper (diff) | |
| download | core-79c933916861d085ab844c50d7f07ba9c2d5e570.tar.gz core-79c933916861d085ab844c50d7f07ba9c2d5e570.zip | |
tdf#128502: Add a FIXME comment
The view id concept is badly broken. Way too many wild assumptions
that the "current" view is the one we expect here and there. For
instance here.
Change-Id: Icf36808b2c09f0b3fd8070deecf175ba7f52b5f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95508
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'libreofficekit')
| -rw-r--r-- | libreofficekit/source/gtk/lokdocview.cxx | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx index 75deee7a38a0..ac5edc633ee0 100644 --- a/libreofficekit/source/gtk/lokdocview.cxx +++ b/libreofficekit/source/gtk/lokdocview.cxx @@ -1,4 +1,4 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ /* * This file is part of the LibreOffice project. * @@ -891,6 +891,8 @@ static gboolean postDocumentLoad(gpointer pData) std::unique_lock<std::mutex> aGuard(g_aLOKMutex); priv->m_pDocument->pClass->initializeForRendering(priv->m_pDocument, priv->m_aRenderingArguments.c_str()); + // FIXME: This returns the view id of the "current" view, but sadly if you load multiple + // documents that is apparently not a view showing the most recently loaded document. priv->m_nViewId = priv->m_pDocument->pClass->getView(priv->m_pDocument); g_aAuthorViews[getAuthorRenderingArgument(priv)] = priv->m_nViewId; priv->m_pDocument->pClass->registerCallback(priv->m_pDocument, callbackWorker, pLOKDocView); |