diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-22 09:00:52 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-23 09:58:23 +0200 |
| commit | 26fbf6eef19e2746c28d2f1584505d5e10a295cc (patch) | |
| tree | db5b1e8040e57f6125b5fed6532623c2e50b549d /include | |
| parent | Pump XInputStream into an SvMemoryStream rather than an OStringBuffer (diff) | |
| download | core-26fbf6eef19e2746c28d2f1584505d5e10a295cc.tar.gz core-26fbf6eef19e2746c28d2f1584505d5e10a295cc.zip | |
clang-tidy modernize-pass-by-value in formula
Change-Id: I275f96bb8b24838538ac88532508ad7dbd127eae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136271
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/formula/token.hxx | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/include/formula/token.hxx b/include/formula/token.hxx index ebb08e6d7c17..f534b2c5c801 100644 --- a/include/formula/token.hxx +++ b/include/formula/token.hxx @@ -24,6 +24,7 @@ #include <cstring> #include <memory> +#include <utility> #include <vector> #include <formula/formuladllapi.h> @@ -336,7 +337,7 @@ class FORMULA_DLLPUBLIC FormulaStringToken final : public FormulaToken { svl::SharedString maString; public: - FormulaStringToken( const svl::SharedString& r ); + FormulaStringToken( svl::SharedString r ); FormulaStringToken( const FormulaStringToken& r ); virtual FormulaToken* Clone() const override; @@ -352,7 +353,7 @@ class FORMULA_DLLPUBLIC FormulaStringOpToken final : public FormulaByteToken { svl::SharedString maString; public: - FormulaStringOpToken( OpCode e, const svl::SharedString& r ); + FormulaStringOpToken( OpCode e, svl::SharedString r ); FormulaStringOpToken( const FormulaStringOpToken& r ); virtual FormulaToken* Clone() const override; @@ -386,12 +387,12 @@ class FORMULA_DLLPUBLIC FormulaExternalToken final : public FormulaByteToken private: OUString aExternal; public: - FormulaExternalToken( OpCode e, sal_uInt8 n, const OUString& r ) : + FormulaExternalToken( OpCode e, sal_uInt8 n, OUString r ) : FormulaByteToken( e, n, svExternal, ParamClass::Unknown ), - aExternal( r ) {} - FormulaExternalToken( OpCode e, const OUString& r ) : + aExternal(std::move( r )) {} + FormulaExternalToken( OpCode e, OUString r ) : FormulaByteToken( e, 0, svExternal, ParamClass::Unknown ), - aExternal( r ) {} + aExternal(std::move( r )) {} FormulaExternalToken( const FormulaExternalToken& r ) : FormulaByteToken( r ), aExternal( r.aExternal ) {} |