loplugin:unused-returns in basegfx..cppcanvas

Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2
Reviewed-on: https://gerrit.libreoffice.org/48428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

8 files changed, 18 insertions, 27 deletions

diff --git a/include/basegfx/matrix/b3dhommatrix.hxx b/include/basegfx/matrix/b3dhommatrix.hxx
index 20f02f00c295..09d700547363 100644
--- a/include/basegfx/matrix/b3dhommatrix.hxx
+++ b/include/basegfx/matrix/b3dhommatrix.hxx
@@ -57,7 +57,7 @@ namespace basegfx
         void identity();
 
         /// Invert the matrix (if possible)
-        bool invert();
+        void invert();
 
         /// Calc the matrix determinant
         double determinant() const;
@@ -111,7 +111,7 @@ namespace basegfx
         B3DHomMatrix& operator=(B3DHomMatrix&& rMat);
 
         // decomposition
-        bool decompose(B3DTuple& rScale, B3DTuple& rTranslate, B3DTuple& rRotate, B3DTuple& rShear) const;
+        void decompose(B3DTuple& rScale, B3DTuple& rTranslate, B3DTuple& rRotate, B3DTuple& rShear) const;
     };
 
     inline B3DHomMatrix operator*(const B3DHomMatrix& rMatA, const B3DHomMatrix& rMatB)
diff --git a/include/comphelper/backupfilehelper.hxx b/include/comphelper/backupfilehelper.hxx
index 6f3445870625..4ff60102ad17 100644
--- a/include/comphelper/backupfilehelper.hxx
+++ b/include/comphelper/backupfilehelper.hxx
@@ -121,13 +121,10 @@ namespace comphelper
          *  Also may cleanup older backups when NumBackups given in the
          *  constructor has changed.
          *
-         *  @return bool
-         *          returns true if a new backup was actually created
-         *
          * tryPushExtensionInfo is the specialized version for ExtensionInfo
          */
-        bool tryPush();
-        bool tryPushExtensionInfo();
+        void tryPush();
+        void tryPushExtensionInfo();
 
         /** finds out if a restore is possible
          *
@@ -144,13 +141,10 @@ namespace comphelper
          *  Also may cleanup older backups when NumBackups given in the
          *  constructor has changed.
          *
-         *  @return bool
-         *          returns true if a restore was actually created
-         *
          * tryPopExtensionInfo is the specialized version for ExtensionInfo
          */
-        bool tryPop();
-        bool tryPopExtensionInfo();
+        void tryPop();
+        void tryPopExtensionInfo();
 
         /** tries to iterate the extensions and to disable all of them
         */
diff --git a/include/comphelper/embeddedobjectcontainer.hxx b/include/comphelper/embeddedobjectcontainer.hxx
index d838af94a3c1..8abea504d7bd 100644
--- a/include/comphelper/embeddedobjectcontainer.hxx
+++ b/include/comphelper/embeddedobjectcontainer.hxx
@@ -130,15 +130,15 @@ public:
         const OUString& rSrcShellID, const OUString& rDestShellID );
 
     // move an embedded object from one container to another one
-    bool MoveEmbeddedObject( EmbeddedObjectContainer& rSrc, const css::uno::Reference < css::embed::XEmbeddedObject >&, OUString& );
+    void MoveEmbeddedObject( EmbeddedObjectContainer& rSrc, const css::uno::Reference < css::embed::XEmbeddedObject >&, OUString& );
 
     // remove an embedded object from the container and from the storage; if object can't be closed
     // #i119941, bKeepToTempStorage: use to specify whether store the removed object to temporary storage+
-    bool            RemoveEmbeddedObject( const OUString& rName, bool bKeepToTempStorage = true);
+    void            RemoveEmbeddedObject( const OUString& rName, bool bKeepToTempStorage = true);
     bool            RemoveEmbeddedObject( const css::uno::Reference < css::embed::XEmbeddedObject >&, bool bKeepToTempStorage = true);
 
     // close and remove an embedded object from the container without removing it from the storage
-    bool            CloseEmbeddedObject( const css::uno::Reference < css::embed::XEmbeddedObject >& );
+    void            CloseEmbeddedObject( const css::uno::Reference < css::embed::XEmbeddedObject >& );
 
     // move an embedded object to another container (keep the persistent name)
     bool            MoveEmbeddedObject( const OUString& rName, EmbeddedObjectContainer& );
@@ -156,7 +156,7 @@ public:
     bool            InsertGraphicStreamDirectly( const css::uno::Reference < css::io::XInputStream >& rStream, const OUString& rObjectName, const OUString& rMediaType );
 
     // remove a graphical representation for an object
-    bool            RemoveGraphicStream( const OUString& rObjectName );
+    void            RemoveGraphicStream( const OUString& rObjectName );
 
     // copy the graphical representation from different container
     bool            TryToCopyGraphReplacement( EmbeddedObjectContainer& rSrc,
diff --git a/include/comphelper/listenernotification.hxx b/include/comphelper/listenernotification.hxx
index c61237adad1e..610ac31cb6ce 100644
--- a/include/comphelper/listenernotification.hxx
+++ b/include/comphelper/listenernotification.hxx
@@ -186,7 +186,7 @@ namespace comphelper
         using OListenerContainer::createIterator;
 
         /// typed notification
-        inline bool    notify( const EventClass& _rEvent, NotificationMethod _pNotify );
+        inline void    notify( const EventClass& _rEvent, NotificationMethod _pNotify );
 
     protected:
         virtual bool    implNotify(
@@ -203,12 +203,11 @@ namespace comphelper
 
 
     template< class LISTENER, class EVENT >
-    inline bool OSimpleListenerContainer< LISTENER, EVENT >::notify( const EventClass& _rEvent, NotificationMethod _pNotify )
+    inline void OSimpleListenerContainer< LISTENER, EVENT >::notify( const EventClass& _rEvent, NotificationMethod _pNotify )
     {
         m_pNotificationMethod = _pNotify;
-        bool bRet = OListenerContainer::impl_notify( _rEvent );
+        OListenerContainer::impl_notify( _rEvent );
         m_pNotificationMethod = nullptr;
-        return bRet;
     }
 
     //= OListenerContainerBase
diff --git a/include/comphelper/namedvaluecollection.hxx b/include/comphelper/namedvaluecollection.hxx
index 9b19bf2e3dda..7ae79b448914 100644
--- a/include/comphelper/namedvaluecollection.hxx
+++ b/include/comphelper/namedvaluecollection.hxx
@@ -152,9 +152,9 @@ namespace comphelper
         }
 
         template < typename VALUE_TYPE >
-        bool    get_ensureType( const OUString& _rValueName, VALUE_TYPE& _out_rValue ) const
+        void    get_ensureType( const OUString& _rValueName, VALUE_TYPE& _out_rValue ) const
         {
-            return get_ensureType( _rValueName, &_out_rValue, ::cppu::UnoType< VALUE_TYPE >::get() );
+            get_ensureType( _rValueName, &_out_rValue, ::cppu::UnoType< VALUE_TYPE >::get() );
         }
 
         /** retrieves a value with a given name, or defaults it to a given value, if it's not present
diff --git a/include/comphelper/propertycontainerhelper.hxx b/include/comphelper/propertycontainerhelper.hxx
index 2e60c97c4ea9..4f37a1018e66 100644
--- a/include/comphelper/propertycontainerhelper.hxx
+++ b/include/comphelper/propertycontainerhelper.hxx
@@ -149,7 +149,7 @@ protected:
                     const css::uno::Any& rValue
                 );
 
-    bool        setFastPropertyValue(
+    void        setFastPropertyValue(
                         sal_Int32 nHandle,
                         const css::uno::Any& rValue
                     );
diff --git a/include/connectivity/parameters.hxx b/include/connectivity/parameters.hxx
index 3f0491963dc0..80efce8689e7 100644
--- a/include/connectivity/parameters.hxx
+++ b/include/connectivity/parameters.hxx
@@ -387,7 +387,7 @@ namespace dbtools
 
         /** retrieves the active connection of the database component
         */
-        bool    getConnection(
+        void    getConnection(
                     css::uno::Reference< css::sdbc::XConnection >& /* [out] */ _rxConnection
                 );
 
diff --git a/include/cppcanvas/bitmap.hxx b/include/cppcanvas/bitmap.hxx
index 1e257d4dfb27..0dd3f69f3a84 100644
--- a/include/cppcanvas/bitmap.hxx
+++ b/include/cppcanvas/bitmap.hxx
@@ -54,10 +54,8 @@ namespace cppcanvas
             multiplied. For a normal, opaque bitmap, this will make
             the bitmap appear transparent with the given alpha value
             (value must be in the range [0,1]).
-
-            @return whether the rendering finished successfully.
          */
-        virtual bool                        drawAlphaModulated( double nAlphaModulation ) const = 0;
+        virtual void                        drawAlphaModulated( double nAlphaModulation ) const = 0;
 
         virtual BitmapCanvasSharedPtr       getBitmapCanvas() const = 0;