diff options
author | Noel Grandin <noel@peralex.com> | 2014-03-13 15:04:48 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-03-13 15:05:31 +0200 |
commit | fddde2b74a24b1e88e33940ee98f7fa2887dc58c (patch) | |
tree | 4cae7cb69b60c2c4628195caf36b7ec56e573c66 /include/vbahelper | |
parent | forward*PropertyValue functions need not be SAL_CALL (diff) | |
download | core-fddde2b74a24b1e88e33940ee98f7fa2887dc58c.tar.gz core-fddde2b74a24b1e88e33940ee98f7fa2887dc58c.zip |
xmloff,vbahelper: prefer passing OUString and OString by reference
Change-Id: I8b7e4284c122549c03edaa7f3963cbfb2024b3fc
Diffstat (limited to 'include/vbahelper')
-rw-r--r-- | include/vbahelper/vbahelper.hxx | 2 | ||||
-rw-r--r-- | include/vbahelper/vbashapes.hxx | 6 | ||||
-rw-r--r-- | include/vbahelper/vbatextframe.hxx | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/include/vbahelper/vbahelper.hxx b/include/vbahelper/vbahelper.hxx index 236beae7c4e6..6b3c2c29822c 100644 --- a/include/vbahelper/vbahelper.hxx +++ b/include/vbahelper/vbahelper.hxx @@ -230,7 +230,7 @@ class VBAHELPER_DLLPUBLIC ContainerUtilities public: static OUString getUniqueName( const css::uno::Sequence< OUString >& _slist, const OUString& _sElementName, const OUString& _sSuffixSeparator); - static OUString getUniqueName( const css::uno::Sequence< OUString >& _slist, const OUString _sElementName, const OUString& _sSuffixSeparator, sal_Int32 _nStartSuffix ); + static OUString getUniqueName( const css::uno::Sequence< OUString >& _slist, const OUString& _sElementName, const OUString& _sSuffixSeparator, sal_Int32 _nStartSuffix ); static sal_Int32 FieldInList( const css::uno::Sequence< OUString >& SearchList, const OUString& SearchString ); }; diff --git a/include/vbahelper/vbashapes.hxx b/include/vbahelper/vbashapes.hxx index 65905dd6884a..2e8e979d5405 100644 --- a/include/vbahelper/vbashapes.hxx +++ b/include/vbahelper/vbashapes.hxx @@ -42,18 +42,18 @@ protected: virtual OUString getServiceImplName(); virtual css::uno::Sequence<OUString> getServiceNames(); virtual css::uno::Reference< css::container::XIndexAccess > getShapesByArrayIndices( const css::uno::Any& Index ) throw (css::uno::RuntimeException); - css::uno::Reference< css::drawing::XShape > createShape( OUString service ) throw (css::uno::RuntimeException); + css::uno::Reference< css::drawing::XShape > createShape( const OUString& service ) throw (css::uno::RuntimeException); css::uno::Any AddRectangle( sal_Int32 startX, sal_Int32 startY, sal_Int32 nLineWidth, sal_Int32 nLineHeight, css::uno::Any aRange ) throw (css::uno::RuntimeException); css::uno::Any AddEllipse( sal_Int32 startX, sal_Int32 startY, sal_Int32 nLineWidth, sal_Int32 nLineHeight, css::uno::Any aRange ) throw (css::uno::RuntimeException); css::uno::Any AddTextboxInWriter( sal_Int32 _nOrientation, sal_Int32 _nLeft, sal_Int32 _nTop, sal_Int32 _nWidth, sal_Int32 _nHeight ) throw (css::uno::RuntimeException); - OUString createName( OUString sName ); + OUString createName( const OUString& sName ); //TODO helperapi using a writer document //css::awt::Point calculateTopLeftMargin( css::uno::Reference< ov::XHelperInterface > xDocument ); public: ScVbaShapes( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::container::XIndexAccess > xShapes, const css::uno::Reference< css::frame::XModel >& xModel ); static void setDefaultShapeProperties( css::uno::Reference< css::drawing::XShape > xShape ) throw (css::uno::RuntimeException); - static void setShape_NameProperty( css::uno::Reference< css::drawing::XShape > xShape, OUString sName ); + static void setShape_NameProperty( css::uno::Reference< css::drawing::XShape > xShape, const OUString& sName ); //XEnumerationAccess virtual css::uno::Type SAL_CALL getElementType() throw (css::uno::RuntimeException); virtual css::uno::Reference< css::container::XEnumeration > SAL_CALL createEnumeration() throw (css::uno::RuntimeException); diff --git a/include/vbahelper/vbatextframe.hxx b/include/vbahelper/vbatextframe.hxx index a93001d0a389..a5714e2d82a9 100644 --- a/include/vbahelper/vbatextframe.hxx +++ b/include/vbahelper/vbatextframe.hxx @@ -34,8 +34,8 @@ protected: virtual OUString getServiceImplName(); virtual css::uno::Sequence<OUString> getServiceNames(); virtual void setAsMSObehavior(); - sal_Int32 getMargin( OUString sMarginType ); - void setMargin( OUString sMarginType, float fMargin ); + sal_Int32 getMargin( const OUString& sMarginType ); + void setMargin( const OUString& sMarginType, float fMargin ); public: VbaTextFrame( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext , css::uno::Reference< css::drawing::XShape > xShape); virtual ~VbaTextFrame() {} |