new loplugin overrideparam

verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

1 files changed, 15 insertions, 1 deletions

diff --git a/include/tools/stream.hxx b/include/tools/stream.hxx
index 1bae0a89458c..447543367f96 100644
--- a/include/tools/stream.hxx
+++ b/include/tools/stream.hxx
@@ -669,7 +669,21 @@ public:
     SvScriptStream(const OUString& rUrl);
     virtual ~SvScriptStream();
 
-    virtual bool ReadLine(OString &rStr, sal_Int32) override;
+    /** Read a line of bytes.
+
+        @param nMaxBytesToRead
+                   Maximum of bytes to read, if line is longer it will be
+                   truncated.
+
+        @note NOTE that the default is one character less than STRING_MAXLEN to
+              prevent problems after conversion to String that may be lurking
+              in various places doing something like
+              @code
+                for (sal_uInt16 i=0; i < aString.Len(); ++i)
+              @endcode
+              causing endless loops ...
+    */
+    virtual bool ReadLine(OString& rStr, sal_Int32 nMaxBytesToRead = 0xFFFE ) override;
     virtual bool good() const override;
 };