diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-08-25 11:09:38 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-10-21 10:36:39 +0200 |
| commit | e26f8d2592a3d7cc5b43b3246b364397dd704f0d (patch) | |
| tree | 8677f333ba26a23f2999ab3a083696a8d2e29b74 /include/svtools | |
| parent | Replace lists by vectors in gtkgdi (vcl) (diff) | |
| download | core-e26f8d2592a3d7cc5b43b3246b364397dd704f0d.tar.gz core-e26f8d2592a3d7cc5b43b3246b364397dd704f0d.zip | |
coverity#1401307 document checked 'Uncaught exception'
markup std::unique_ptr where coverity warns a dtor might throw exceptions which
won't throw in practice, or where std::terminate is an acceptable response if
they do
Change-Id: Icc99cdecf8d8b011e599574f0a05b59efd1c65c2
Reviewed-on: https://gerrit.libreoffice.org/41561
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'include/svtools')
| -rw-r--r-- | include/svtools/ivctrl.hxx | 3 | ||||
| -rw-r--r-- | include/svtools/templatefoldercache.hxx | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/include/svtools/ivctrl.hxx b/include/svtools/ivctrl.hxx index 3cb0171f35cf..3d7a4842ca91 100644 --- a/include/svtools/ivctrl.hxx +++ b/include/svtools/ivctrl.hxx @@ -27,6 +27,7 @@ #include <tools/contnr.hxx> #include <vcl/image.hxx> #include <vcl/seleng.hxx> +#include <o3tl/deleter.hxx> #include <o3tl/typed_flags_set.hxx> class Point; @@ -189,7 +190,7 @@ class SVT_DLLPUBLIC SvtIconChoiceCtrl : public Control friend class SvxIconChoiceCtrl_Impl; Link<SvtIconChoiceCtrl*,void> _aClickIconHdl; - std::unique_ptr<SvxIconChoiceCtrl_Impl> _pImpl; + std::unique_ptr<SvxIconChoiceCtrl_Impl, o3tl::default_delete<SvxIconChoiceCtrl_Impl>> _pImpl; protected: diff --git a/include/svtools/templatefoldercache.hxx b/include/svtools/templatefoldercache.hxx index 842f19111b99..cee6bcbecc1b 100644 --- a/include/svtools/templatefoldercache.hxx +++ b/include/svtools/templatefoldercache.hxx @@ -22,9 +22,9 @@ #include <svtools/svtdllapi.h> #include <sal/types.h> +#include <o3tl/deleter.hxx> #include <memory> - namespace svt { @@ -60,7 +60,7 @@ namespace svt class SVT_DLLPUBLIC TemplateFolderCache { private: - std::unique_ptr<TemplateFolderCacheImpl> m_pImpl; + std::unique_ptr<TemplateFolderCacheImpl, o3tl::default_delete<TemplateFolderCacheImpl>> m_pImpl; public: /** ctor. |