loplugin:finalclasses

improve the plugin to detect more cases.

I only apply the new final changes to classes in /include here.

Which reveals that
RoadmapWizard::getPageController( TabPage* _pCurrentPage )
will always return nullptr

Also needed to sprinkle some
SAL_DLLPUBLIC_TEMPLATE
around to workaround Visual Studio linking problems.

Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 7 insertions, 5 deletions

diff --git a/include/registry/registry.hxx b/include/registry/registry.hxx
index 3c81c41e077f..3190b13ca66c 100644
--- a/include/registry/registry.hxx
+++ b/include/registry/registry.hxx
@@ -208,7 +208,8 @@ public:
     inline sal_uInt32 getLength() const;
 
     friend class RegistryKey;
-protected:
+
+private:
     /** sets the data of the key array.
 
         @param registry specifies the registry files where the keys are located.
@@ -216,7 +217,7 @@ protected:
         @param length specifies the length of the array specified by phKeys.
      */
     inline void setKeyHandles(Registry const & registry, RegKeyHandle* phKeys, sal_uInt32 length);
-private:
+
     /// stores the number of open subkeys, the number of elements.
     sal_uInt32      m_length;
     /// stores an array of open subkeys.
@@ -246,7 +247,8 @@ public:
     inline sal_uInt32 getLength() const;
 
     friend class RegistryKey;
-protected:
+
+private:
     /** sets the data of the array.
 
         @param registry specifies the registry files where the keys are located.
@@ -254,7 +256,7 @@ protected:
         @param length specifies the length of the array specified by pKeyNames.
      */
     inline void setKeyNames(Registry const & registry, rtl_uString** pKeyNames, sal_uInt32 length);
-private:
+
     /// stores the number of key names, the number of elements.
     sal_uInt32      m_length;
     /// stores an array of key names.
@@ -557,7 +559,7 @@ public:
     inline RegistryKey(Registry const & registry,
                        RegKeyHandle hKey);
 
-protected:
+private:
     /** sets the internal registry on which this key should work.
      */
     inline void setRegistry(Registry const & registry);