diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2018-07-26 16:42:16 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2018-07-27 08:29:44 +0200 |
commit | 727878a7d8ae25342db75173cc314fa330ccc077 (patch) | |
tree | b70827c83be87059fe553d68ac32c56438af297d /include/editeng/writingmodeitem.hxx | |
parent | svx: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9) (diff) | |
download | core-727878a7d8ae25342db75173cc314fa330ccc077.tar.gz core-727878a7d8ae25342db75173cc314fa330ccc077.zip |
Remove unused copy assignment ops of SfxPoolItem-derived classes
SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy
assignment op. Many derived classes then provide a non-deleted assignment op,
apparently more or less on an as-needed basis. But some of those user-provided
assignment ops are actually unused (and their presence causes
-Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly-
defined---copy ctor of the derived class is used), so remove them. In some
cases that would still cause -Werror=deprected-copy because of a user-declared
dtor, so in those cases explicitly default all the copy/move functions (some of
which will then be implicitly defined as deleted).
Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307
Reviewed-on: https://gerrit.libreoffice.org/58133
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/editeng/writingmodeitem.hxx')
-rw-r--r-- | include/editeng/writingmodeitem.hxx | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/editeng/writingmodeitem.hxx b/include/editeng/writingmodeitem.hxx index c7a823d8c6bd..737de29f3269 100644 --- a/include/editeng/writingmodeitem.hxx +++ b/include/editeng/writingmodeitem.hxx @@ -32,7 +32,10 @@ public: sal_uInt16 nWhich /*= SDRATTR_TEXTDIRECTION*/ ); virtual ~SvxWritingModeItem() override; - SvxWritingModeItem& operator=( const SvxWritingModeItem& rItem ); + SvxWritingModeItem(SvxWritingModeItem const &) = default; + SvxWritingModeItem(SvxWritingModeItem &&) = default; + SvxWritingModeItem & operator =(SvxWritingModeItem const &) = default; + SvxWritingModeItem & operator =(SvxWritingModeItem &&) = default; virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; virtual sal_uInt16 GetVersion( sal_uInt16 nFileVersion ) const override; |