diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2020-09-26 14:41:02 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-09-26 17:39:33 +0200 |
| commit | 5cb62b13ca8fec43fffe3f2000f61c1be7c5616c (patch) | |
| tree | 80a23ff0f16c91e9aa0e0bfb98b66d96527c25a4 /include/basegfx | |
| parent | tdf#112279 Change the error message to more clear (diff) | |
| download | core-5cb62b13ca8fec43fffe3f2000f61c1be7c5616c.tar.gz core-5cb62b13ca8fec43fffe3f2000f61c1be7c5616c.zip | |
revert recent Polygon commits
This reverts
commit 0cabffc05f3b40f5ee897df73475e09a3c05fc7
tools::PolyPolygon -> basegfx in canvas
and
commit 2c5d5a6d55a1ebd153f05523972a2c625484bde2
tools::PolyPolygon -> basegfx in filter
Comment from quikee:
The interpretation of integer polygons and floating point polygons
(or any other float vs. int drawing primitives) are different,
so you have to be really careful when changing, that the result
after the change is still the same. A big problem is that we still
have the metafile in OutputDevice, which is completely integer based
- so there will be conversions that go from int representation to
float representation to int again and to float (because backend is
in floating point) and I really fear that because of this there will
be regressions and even if not, it could make changing later more
painful. This is the reason I wouldn't change these things without
having tests that would show when there is a difference in rendering.
Change-Id: I54addca4e5a72196b5f77f6c7689eb716451c1dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103483
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/basegfx')
| -rw-r--r-- | include/basegfx/polygon/b2dpolygon.hxx | 1 | ||||
| -rw-r--r-- | include/basegfx/polygon/b2dpolypolygon.hxx | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/include/basegfx/polygon/b2dpolygon.hxx b/include/basegfx/polygon/b2dpolygon.hxx index 346b4c587693..e74b458ec3af 100644 --- a/include/basegfx/polygon/b2dpolygon.hxx +++ b/include/basegfx/polygon/b2dpolygon.hxx @@ -78,7 +78,6 @@ namespace basegfx /// Coordinate interface basegfx::B2DPoint const & getB2DPoint(sal_uInt32 nIndex) const; void setB2DPoint(sal_uInt32 nIndex, const basegfx::B2DPoint& rValue); - basegfx::B2DPoint const & operator[](sal_uInt32 nIndex) const { return getB2DPoint(nIndex); } /// Coordinate insert/append void insert(sal_uInt32 nIndex, const basegfx::B2DPoint& rPoint, sal_uInt32 nCount = 1); diff --git a/include/basegfx/polygon/b2dpolypolygon.hxx b/include/basegfx/polygon/b2dpolypolygon.hxx index ee8372d0aeb5..010815c8784e 100644 --- a/include/basegfx/polygon/b2dpolypolygon.hxx +++ b/include/basegfx/polygon/b2dpolypolygon.hxx @@ -68,7 +68,6 @@ namespace basegfx B2DPolygon const & getB2DPolygon(sal_uInt32 nIndex) const; void setB2DPolygon(sal_uInt32 nIndex, const B2DPolygon& rPolygon); - B2DPolygon const & operator[](sal_uInt32 nIndex) const { return getB2DPolygon(nIndex); } // test for curve bool areControlPointsUsed() const; |