diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-06 20:01:50 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 11:58:37 +0100 |
| commit | 93c64a61f2c84e684050294a1391cd32425b7837 (patch) | |
| tree | 00aad2cb8f3ee29ba4ac99e159e26fb8d71d2f33 /i18nlangtag | |
| parent | make sure mpAlphaVDev is drawn when drawing lines (tdf#137974) (diff) | |
| download | core-93c64a61f2c84e684050294a1391cd32425b7837.tar.gz core-93c64a61f2c84e684050294a1391cd32425b7837.zip | |
loplugin:stringview
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'i18nlangtag')
| -rw-r--r-- | i18nlangtag/source/languagetag/languagetag.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx b/i18nlangtag/source/languagetag/languagetag.cxx index 0c52a2b3cf45..ab9e33019428 100644 --- a/i18nlangtag/source/languagetag/languagetag.cxx +++ b/i18nlangtag/source/languagetag/languagetag.cxx @@ -1957,7 +1957,7 @@ OUString LanguageTag::getGlibcLocaleString( const OUString & rEncoding ) const aRet = getImpl()->getGlibcLocaleString(); sal_Int32 nAt = aRet.indexOf('@'); if (nAt != -1) - aRet = aRet.copy(0, nAt) + rEncoding + aRet.copy(nAt); + aRet = aRet.subView(0, nAt) + rEncoding + aRet.subView(nAt); else aRet += rEncoding; } |