diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-11 13:52:39 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-13 08:34:21 +0200 |
commit | ff4d6a7e5b166bb98bbe8d0f59cc4db36e7002aa (patch) | |
tree | 47215924da6d8605d1790ca90b57b141b4cf3776 /fpicker/source/office | |
parent | fix build (missing #include <sal/log.hxx>'s) (diff) | |
download | core-ff4d6a7e5b166bb98bbe8d0f59cc4db36e7002aa.tar.gz core-ff4d6a7e5b166bb98bbe8d0f59cc4db36e7002aa.zip |
loplugin:returnconstant in forms..fpicker
Change-Id: I3f0bead636632682488cbe677fd7fee60350f04d
Reviewed-on: https://gerrit.libreoffice.org/58876
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'fpicker/source/office')
-rw-r--r-- | fpicker/source/office/RemoteFilesDialog.cxx | 6 | ||||
-rw-r--r-- | fpicker/source/office/RemoteFilesDialog.hxx | 2 |
2 files changed, 3 insertions, 5 deletions
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index 7825064c3d25..55026fb228cb 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -561,7 +561,7 @@ void RemoteFilesDialog::AddFilter( const OUString& rFilter, const OUString& rTyp } -FileViewResult RemoteFilesDialog::OpenURL( OUString const & sURL ) +void RemoteFilesDialog::OpenURL( OUString const & sURL ) { if( m_pFileView ) { @@ -604,14 +604,12 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const & sURL ) ErrorHandler::HandleError( ERRCODE_IO_NOTEXISTS ); EnableControls(); - return eFailure; + return; } SetPointer( PointerStyle::Arrow ); EnableChildPointerOverwrite( false ); } - - return eFailure; } void RemoteFilesDialog::AddFileExtension() diff --git a/fpicker/source/office/RemoteFilesDialog.hxx b/fpicker/source/office/RemoteFilesDialog.hxx index c53f660e46f6..61d4575fd23a 100644 --- a/fpicker/source/office/RemoteFilesDialog.hxx +++ b/fpicker/source/office/RemoteFilesDialog.hxx @@ -166,7 +166,7 @@ private: /* If failure returns < 0 */ int GetSelectedServicePos(); - FileViewResult OpenURL( OUString const & sURL ); + void OpenURL( OUString const & sURL ); void AddFileExtension(); |