summaryrefslogtreecommitdiffstats
path: root/forms
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-02-25 10:24:55 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-02-27 07:34:52 +0100
commit19240f625f8bd7b772481abc8e678d7b0fadd921 (patch)
treedf98eb1d1d2bf11179aea13de58aa38548458b9d /forms
parentFix typo (diff)
downloadcore-19240f625f8bd7b772481abc8e678d7b0fadd921.tar.gz
core-19240f625f8bd7b772481abc8e678d7b0fadd921.zip
loplugin:unusedfields look for classes where we can make all the..
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'forms')
-rw-r--r--forms/source/component/Columns.hxx1
-rw-r--r--forms/source/inc/FormComponent.hxx1
-rw-r--r--forms/source/xforms/NameContainer.hxx2
-rw-r--r--forms/source/xforms/datatypes.hxx2
-rw-r--r--forms/source/xforms/xformsevent.hxx2
5 files changed, 2 insertions, 6 deletions
diff --git a/forms/source/component/Columns.hxx b/forms/source/component/Columns.hxx
index e3b4111da6cb..d98fdbd02e0e 100644
--- a/forms/source/component/Columns.hxx
+++ b/forms/source/component/Columns.hxx
@@ -49,7 +49,6 @@ class OGridColumn :public ::cppu::BaseMutex
,public OPropertySetAggregationHelper
,public OCloneableAggregation
{
-protected:
// [properties]
css::uno::Any m_aWidth; // column width
css::uno::Any m_aAlign; // column alignment
diff --git a/forms/source/inc/FormComponent.hxx b/forms/source/inc/FormComponent.hxx
index 38ed4a08f3a7..fa19c000e6fb 100644
--- a/forms/source/inc/FormComponent.hxx
+++ b/forms/source/inc/FormComponent.hxx
@@ -260,7 +260,6 @@ typedef ::cppu::ImplHelper1 < css::form::XBoundControl
class OBoundControl :public OControl
,public OBoundControl_BASE
{
-protected:
bool m_bLocked : 1;
public:
diff --git a/forms/source/xforms/NameContainer.hxx b/forms/source/xforms/NameContainer.hxx
index 07656745f006..8a7a89e445c1 100644
--- a/forms/source/xforms/NameContainer.hxx
+++ b/forms/source/xforms/NameContainer.hxx
@@ -40,10 +40,10 @@ typedef cppu::WeakImplHelper<
template<class T>
class NameContainer : public NameContainer_t
{
-protected:
typedef std::map<OUString,T> map_t;
map_t maItems;
+protected:
typename map_t::const_iterator findItem( const OUString& rName )
{
return maItems.find( rName );
diff --git a/forms/source/xforms/datatypes.hxx b/forms/source/xforms/datatypes.hxx
index fe1db2618442..894b8dc5bd0b 100644
--- a/forms/source/xforms/datatypes.hxx
+++ b/forms/source/xforms/datatypes.hxx
@@ -257,7 +257,6 @@ namespace xforms
typedef ODerivedDataType< OStringType > OStringType_Base;
class OStringType :public OStringType_Base
{
- protected:
// <properties>
css::uno::Any m_aLength;
css::uno::Any m_aMinLength;
@@ -282,7 +281,6 @@ namespace xforms
typedef ODerivedDataType< ODecimalType, OValueLimitedType< double > > ODecimalType_Base;
class ODecimalType : public ODecimalType_Base
{
- protected:
css::uno::Any m_aTotalDigits;
css::uno::Any m_aFractionDigits;
diff --git a/forms/source/xforms/xformsevent.hxx b/forms/source/xforms/xformsevent.hxx
index d9d03d385a8a..df4f5bcd20da 100644
--- a/forms/source/xforms/xformsevent.hxx
+++ b/forms/source/xforms/xformsevent.hxx
@@ -60,7 +60,7 @@ class XFormsEventConcrete : public cppu::WeakImplHelper< XFormsEvent > {
sal_Bool canBubbleArg,
sal_Bool cancelableArg) override;
- protected:
+ private:
OUString m_eventType;
bool m_bubbles;