loplugin:passstuffbyref in various

Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022

6 files changed, 9 insertions, 9 deletions

diff --git a/forms/source/component/GroupManager.hxx b/forms/source/component/GroupManager.hxx
index 2ea5ff51ea22..8567ebb1e02d 100644
--- a/forms/source/component/GroupManager.hxx
+++ b/forms/source/component/GroupManager.hxx
@@ -145,7 +145,7 @@ public:
     explicit OGroup(const OUString& rGroupName);
     virtual ~OGroup();
 
-    OUString GetGroupName() const { return m_aGroupName; }
+    const OUString& GetGroupName() const { return m_aGroupName; }
     css::uno::Sequence< css::uno::Reference< css::awt::XControlModel>  > GetControlModels() const;
 
     void InsertComponent( const css::uno::Reference< css::beans::XPropertySet>& rxElement );
diff --git a/forms/source/inc/limitedformats.hxx b/forms/source/inc/limitedformats.hxx
index e1c922a15293..5922fd6db8f1 100644
--- a/forms/source/inc/limitedformats.hxx
+++ b/forms/source/inc/limitedformats.hxx
@@ -77,7 +77,7 @@ namespace frm
         void        setFormatKeyPropertyValue( const css::uno::Any& _rNewValue );
         // setFormatKeyPropertyValue should only be called with a value got from convertFormatKeyPropertyValue!
 
-        css::uno::Reference< css::util::XNumberFormatsSupplier >
+        const css::uno::Reference< css::util::XNumberFormatsSupplier >&
                     getFormatsSupplier() const { return s_xStandardFormats; }
 
     private:
diff --git a/forms/source/xforms/computedexpression.hxx b/forms/source/xforms/computedexpression.hxx
index 169cd6606077..30b9581c5f4b 100644
--- a/forms/source/xforms/computedexpression.hxx
+++ b/forms/source/xforms/computedexpression.hxx
@@ -66,7 +66,7 @@ protected:
 
     /// allow manipulation of the expression before it is evaluated
     // the default implementation is to do nothing...
-    const OUString _getExpressionForEvaluation() const { return msExpression; }
+    const OUString& _getExpressionForEvaluation() const { return msExpression; }
 
     /// obtain a (suitable) XPathAPI implementation
     static css::uno::Reference<css::xml::xpath::XXPathAPI> _getXPathAPI(const xforms::EvaluationContext& aContext);
@@ -82,7 +82,7 @@ public:
 
 
     /// get the expression string
-    OUString getExpression() const { return msExpression;}
+    const OUString& getExpression() const { return msExpression;}
 
     /// set a new expression string
     void setExpression( const OUString& rExpression );
diff --git a/forms/source/xforms/mip.hxx b/forms/source/xforms/mip.hxx
index cd0a5f919d17..5db986d9cf55 100644
--- a/forms/source/xforms/mip.hxx
+++ b/forms/source/xforms/mip.hxx
@@ -64,7 +64,7 @@ public:
     // - type (static; default: xsd:string)
     //        (currently default implemented as empty string)
     bool hasTypeName() const { return mbHasTypeName; }
-    OUString getTypeName() const { return msTypeName; }
+    const OUString& getTypeName() const { return msTypeName; }
     void setTypeName( const OUString& );
     void resetTypeName();
 
@@ -94,7 +94,7 @@ public:
 
     // explain _why_ a constraint failed
     void setConstraintExplanation( const OUString& );
-    OUString getConstraintExplanation() const { return msConstraintExplanation; }
+    const OUString& getConstraintExplanation() const { return msConstraintExplanation; }
 
     // - calculate (computed XPath; default: has none (false))
     //   (for calculate, we only store whether a calculate MIP is present;
diff --git a/forms/source/xforms/pathexpression.hxx b/forms/source/xforms/pathexpression.hxx
index 220800e86228..4204bfe5223b 100644
--- a/forms/source/xforms/pathexpression.hxx
+++ b/forms/source/xforms/pathexpression.hxx
@@ -69,7 +69,7 @@ public:
 
     // get the result of this expression as node/node list/...
     css::uno::Reference<css::xml::dom::XNode> getNode() const;
-    const NodeVector_t getNodeList() const { return maNodes;}
+    const NodeVector_t& getNodeList() const { return maNodes;}
     css::uno::Reference<css::xml::dom::XNodeList> getXNodeList() const;
 
 };
diff --git a/forms/source/xforms/xpathlib/extension.hxx b/forms/source/xforms/xpathlib/extension.hxx
index a25f60837256..b364a9be1f5b 100644
--- a/forms/source/xforms/xpathlib/extension.hxx
+++ b/forms/source/xforms/xpathlib/extension.hxx
@@ -46,8 +46,8 @@ private:
 public:
     CLibxml2XFormsExtension() {}
 
-    css::uno::Reference< css::xforms::XModel > getModel() { return m_aModel;}
-    css::uno::Reference< css::xml::dom::XNode > getContextNode() { return m_aContextNode;}
+    const css::uno::Reference< css::xforms::XModel >& getModel() { return m_aModel;}
+    const css::uno::Reference< css::xml::dom::XNode >& getContextNode() { return m_aContextNode;}
 
     virtual css::xml::xpath::Libxml2ExtensionHandle SAL_CALL getLibxml2ExtensionHandle() throw (css::uno::RuntimeException, std::exception) override;
     virtual void SAL_CALL initialize(const css::uno::Sequence< css::uno::Any >& aSequence) throw (css::uno::RuntimeException, std::exception) override;