diff options
| author | Matteo Casalin <matteo.casalin@yahoo.com> | 2019-03-13 23:52:32 +0100 |
|---|---|---|
| committer | Matteo Casalin <matteo.casalin@yahoo.com> | 2019-03-20 07:48:21 +0100 |
| commit | 1d86bad16d8d517845828932115f75dd13c24940 (patch) | |
| tree | c552a4b190fea11f1968a86c1a1d8da19a75ea82 /filter | |
| parent | Further reducion of OString copying by in-string comparison (diff) | |
| download | core-1d86bad16d8d517845828932115f75dd13c24940.tar.gz core-1d86bad16d8d517845828932115f75dd13c24940.zip | |
Simplify by using indexed getToken()
Change-Id: Ie3c890be9ec3ec01bb72977ab2934bda62b2edea
Reviewed-on: https://gerrit.libreoffice.org/69248
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
Diffstat (limited to 'filter')
| -rw-r--r-- | filter/source/config/cache/querytokenizer.cxx | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/filter/source/config/cache/querytokenizer.cxx b/filter/source/config/cache/querytokenizer.cxx index a7f5b3e8be1d..6d6e9d5e504a 100644 --- a/filter/source/config/cache/querytokenizer.cxx +++ b/filter/source/config/cache/querytokenizer.cxx @@ -35,22 +35,14 @@ QueryTokenizer::QueryTokenizer(const OUString& sQuery) OUString sToken = sQuery.getToken(0, ':', token); if (!sToken.isEmpty()) { - sal_Int32 equal = sToken.indexOf('='); + sal_Int32 nIdx{ 0 }; + const OUString sKey{ sToken.getToken(0, '=', nIdx) }; + const OUString sVal{ sToken.getToken(0, ':', nIdx) }; - if (equal == 0) + if (sKey.isEmpty()) m_bValid = false; OSL_ENSURE(m_bValid, "QueryTokenizer::QueryTokenizer() Found non boolean query parameter ... but its key is empty. Will be ignored!"); - OUString sKey; - OUString sVal; - - sKey = sToken; - if (equal > 0) - { - sKey = sToken.copy(0 , equal ); - sVal = sToken.copy(equal+1); - } - if (find(sKey) != end()) m_bValid = false; OSL_ENSURE(m_bValid, "QueryTokenizer::QueryTokenizer() Query contains same param more than once. Last one wins :-)"); |